linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Kent Overstreet <kent.overstreet@linux.dev>
To: David Wang <00107082@163.com>
Cc: Suren Baghdasaryan <surenb@google.com>,
	akpm@linux-foundation.org,  linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Add accumulated call counter for memory allocation profiling
Date: Mon, 1 Jul 2024 17:58:50 -0400	[thread overview]
Message-ID: <koa5yyc2opu23giistqjaw3eo47gjcxpx56ekrbsbhltk74wzz@pvym4ollouzu> (raw)
In-Reply-To: <13c19bd1.2c49.1906c1ac5bf.Coremail.00107082@163.com>

On Mon, Jul 01, 2024 at 10:23:32AM GMT, David Wang wrote:
> HI Suren, 
> 
> At 2024-07-01 03:33:14, "Suren Baghdasaryan" <surenb@google.com> wrote:
> >On Mon, Jun 17, 2024 at 8:33 AM David Wang <00107082@163.com> wrote:
> >>
> >> Accumulated call counter can be used to evaluate rate
> >> of memory allocation via delta(counters)/delta(time).
> >> This metrics can help analysis performance behaviours,
> >> e.g. tuning cache size, etc.
> >
> >Sorry for the delay, David.
> >IIUC with this counter you can identify the number of allocations ever
> >made from a specific code location. Could you please clarify the usage
> >a bit more? Is the goal to see which locations are the most active and
> >the rate at which allocations are made there? How will that
> >information be used?
>  
> Cumulative counters can be sampled with timestamp,  say at T1, a monitoring tool got a sample value V1,
> then after sampling interval, at T2,  got a sample value V2. Then the average rate of allocation can be evaluated
> via (V2-V1)/(T2-T1). (The accuracy depends on sampling interval)
> 
> This information "may" help identify where the memory allocation is unnecessary frequent,  
> and  gain some  better performance by making less memory allocation .
> The performance "gain" is just a guess, I do not have a valid example.

Easier to just run perf...


  reply	other threads:[~2024-07-01 21:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-17 15:32 David Wang
2024-06-30 19:33 ` Suren Baghdasaryan
2024-06-30 19:52   ` Kent Overstreet
2024-07-01  2:23   ` David Wang
2024-07-01 21:58     ` Kent Overstreet [this message]
2024-09-12  2:27       ` David Wang
2024-09-12 16:12         ` Suren Baghdasaryan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=koa5yyc2opu23giistqjaw3eo47gjcxpx56ekrbsbhltk74wzz@pvym4ollouzu \
    --to=kent.overstreet@linux.dev \
    --cc=00107082@163.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=surenb@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox