From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 051B2C52D7C for ; Mon, 12 Aug 2024 16:58:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8EB426B008A; Mon, 12 Aug 2024 12:58:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8A41E6B008C; Mon, 12 Aug 2024 12:58:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6C5E46B0095; Mon, 12 Aug 2024 12:58:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 45C076B008A for ; Mon, 12 Aug 2024 12:58:16 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id E44A41402CD for ; Mon, 12 Aug 2024 16:58:15 +0000 (UTC) X-FDA: 82444201350.07.9FF957B Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf11.hostedemail.com (Postfix) with ESMTP id 6436440013 for ; Mon, 12 Aug 2024 16:58:12 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=W1twcv31; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=TDlqrTNR; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf11.hostedemail.com: domain of liam.howlett@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=liam.howlett@oracle.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1723481841; a=rsa-sha256; cv=pass; b=MGSpy1LksMd1Rv80Xp32Ga8CW4Xp3v+nJf1XLWvVrZ1HTbIuq1U+E4GosbwNKh79Y5BTrj bPhwerWHCKjYBrWowHjHspfSEakcdffOsGVLXIz5PU74biMCSlDxUWeY5hJWkGgUAepAN3 FqwSIPwIRHJWAtP9Y8K63SHfdEGwjJo= ARC-Authentication-Results: i=2; imf11.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=W1twcv31; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=TDlqrTNR; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf11.hostedemail.com: domain of liam.howlett@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=liam.howlett@oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723481841; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rfq5VDjD41u6mE3M/nOwp2ZWin/2HbR/A4oxxjbs5iw=; b=CVxcp9Rz0zN4uuPO9XP4eVFWB17arpo/v0QIvu6Klv6pAgFOpRtaefbDKNY8eXyawClhcQ 73Cji8iNRoMl16q/um/tAt+MjBryLBny3DO9A6iHJXYBkqTScuHtUHJ79Dv/gYsHdCYVW4 ytdwaxN23dGGlKiGA4gbpFx3QKLqlPw= Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 47CGXY8X015466; Mon, 12 Aug 2024 16:58:04 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h= date:from:to:cc:subject:message-id:references:content-type :content-transfer-encoding:in-reply-to:mime-version; s= corp-2023-11-20; bh=rfq5VDjD41u6mE3M/nOwp2ZWin/2HbR/A4oxxjbs5iw=; b= W1twcv31URDanDhU8+DCs0ttN8G557fa8kda08eG27ptNCD2+QKd8vnJf/PrHEix gzAXIKLqEB1GXKt+5j6Xa8328YpDKkOtIaANEayTWshMKsXqt0mhptDFePfA4BKv w9b+VE4faq3J3/GCVLOIlmVHTR8mg//UmlkvHhZoLf5Vm/z3dyoJ/JymvEDHOL1d aFqcAedVPvOT1Z4v+TFpYxjGGvxkj2R61Wd+cJ1NObx3mhvlrZpHzo5EINbF17Ft d993FaaJb+snAwY4hw4ZIyGqVNtceD+VUZeYaLiRF/qt7DhUaAiTjmT54/eVLu9k S5yLPWt/cz4ZQvTzHDTFtw== Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 40x03933a5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 12 Aug 2024 16:58:04 +0000 (GMT) Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 47CFOjNk003825; Mon, 12 Aug 2024 16:58:02 GMT Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2169.outbound.protection.outlook.com [104.47.57.169]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 40wxn8d7un-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 12 Aug 2024 16:58:02 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=cOGmmNFu+jTFEdBNdLu2zgRDwtW56siJqEAp1F2/LEA0KmA9Qgr+qFnVLZiAJwHqI4i19NH8vuAjMUgc+1U9Ml1I9NNJVhSjP5krcnW1yWc+12oJzSyEcilJ7v4XZ7rElctyl/2GzDmPmGR/w1RFhZ4U1c8QPS8pNaUQgHzjHkXaNwQviYHzlaWEDRNaFFXz7dXAebiIAf9FNfk8HgQv5ImYWFDJ7sXxDbETIxWnL9g380EiXq1+XRXlMruktwN4wvgFPfObAv7nLAMQrMrJmng3/XLI4OcBa+BWoeidsP5d+p0G601MoY/JJJYZd7ZHkd2YvmhTnoKR28Hx3w0y5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rfq5VDjD41u6mE3M/nOwp2ZWin/2HbR/A4oxxjbs5iw=; b=QytJ0u2SLoBj+O3LICNrzYsQFoXDMUyWi/tSEhLTaouW0V+c/LqcV7kDC9L7W6JTkLIbBY3b+Jb4f/FiAjq72rx7MFgDc7dLaN3ir1ofLBRyF2PE0B6vUMqfqukT+CkAd+gPVOvjENeBh+7id+bzouT1hAF8cQ6e6Jo+WeE3/kJ+eSEDie6ZKgd/w6KV8oVxgoZCfZ4F8gsLZGQAFagNrghy0OnVI4QmHu67QjDK+Wfpm/ok5ABqijYV2Q7LNFK28Rzm8qSAHx27FHQZ3ht+RgtmuAA9l1Th958IXLTPiOzCSw9QPdwC7zOk1gyNwVqx9rToOJ6TPGpLhvRlZJJaIg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rfq5VDjD41u6mE3M/nOwp2ZWin/2HbR/A4oxxjbs5iw=; b=TDlqrTNRwl53FeB79+19kWz27e/DienxX9BPtH8wuSyV+cTNCp5LV4J8khW+UE/gm+TAoAsQWF1jL5eVUZbvfGIs7Gex+fU0MengaYH1GVNuOTABGO13JxExdYct1fRpEwkru+qsX+UeWYxmrIdm7uqgNdg/SPiwQBQspD0QKLU= Received: from DS0PR10MB7933.namprd10.prod.outlook.com (2603:10b6:8:1b8::15) by CYYPR10MB7567.namprd10.prod.outlook.com (2603:10b6:930:be::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7875.15; Mon, 12 Aug 2024 16:58:00 +0000 Received: from DS0PR10MB7933.namprd10.prod.outlook.com ([fe80::2561:85b0:ae8f:9490]) by DS0PR10MB7933.namprd10.prod.outlook.com ([fe80::2561:85b0:ae8f:9490%3]) with mapi id 15.20.7875.012; Mon, 12 Aug 2024 16:58:00 +0000 Date: Mon, 12 Aug 2024 12:57:58 -0400 From: "Liam R. Howlett" To: Jeff Xu Cc: Pedro Falcato , Andrew Morton , Vlastimil Babka , Lorenzo Stoakes , linux-mm@kvack.org, linux-kernel@vger.kernel.org, oliver.sang@intel.com, torvalds@linux-foundation.org, Michael Ellerman , Kees Cook Subject: Re: [PATCH v2 2/6] mm/munmap: Replace can_modify_mm with can_modify_vma Message-ID: Mail-Followup-To: "Liam R. Howlett" , Jeff Xu , Pedro Falcato , Andrew Morton , Vlastimil Babka , Lorenzo Stoakes , linux-mm@kvack.org, linux-kernel@vger.kernel.org, oliver.sang@intel.com, torvalds@linux-foundation.org, Michael Ellerman , Kees Cook References: <20240807211309.2729719-1-pedro.falcato@gmail.com> <20240807211309.2729719-3-pedro.falcato@gmail.com> <3hzwtm7jw25ng5gemkp42k5ypkfky25fxeevccnk2d6gcpft32@qwkwofgauqna> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: User-Agent: NeoMutt/20240425 X-ClientProxiedBy: YT4P288CA0089.CANP288.PROD.OUTLOOK.COM (2603:10b6:b01:d0::26) To DS0PR10MB7933.namprd10.prod.outlook.com (2603:10b6:8:1b8::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR10MB7933:EE_|CYYPR10MB7567:EE_ X-MS-Office365-Filtering-Correlation-Id: a432181d-842c-4058-e109-08dcbaefec2a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014|7416014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?VktDVFptRUovblFncFhEUjFYU1Q2eU5pcXRrQmVYZFZuaGdibUYzM0gydkl2?= =?utf-8?B?a1J3N0p3dnpEamVLYitLdmUrNXNGdFdZNHNtYk14Ujdqdzc3eER5dno5bS9Q?= =?utf-8?B?Y1BvMEtEQitVY0xXZTJtVkhXMTBYMTZJdUJlblFycFB2Y0FPTlNXTEhsbmxX?= =?utf-8?B?bXNKQ2VsaG1zWkFVRVZaeFBsYzlVQjZLakJhaGx6dkhBeitWaDNHYlg2bkxD?= =?utf-8?B?YzhnQks5OWE3Ym9LN2JTeGhWaEFLcWJDcWFFUjByUCt4VGU3UGVPVWM2ZTF0?= =?utf-8?B?UzhwV2FVelRpQmJ0SkhEOW8zcDRKdFNudHRqbFJxUHFRVHVqbWNZb2Y5MGJF?= =?utf-8?B?U1F4STJnWFlxaC9kWWtoMlNmRnlKRjNQSmNnSzZzTnBwZUMxdG96T2FtUWVI?= =?utf-8?B?czU2akJYVmlRaTkxL3ZNQ3lZd3IzbU9HVzEraTJxOTVGSGtUN0o1c1F6WXVx?= =?utf-8?B?U1VBQXBCSUN6SFc1K2dOb2xkNURPZHAvTmZGM0IxRFFnYVhmbnFER002NnRh?= =?utf-8?B?MDR3SW5tOHh3bVRXNWU2YjVRUThDeUJycnJvb0o3NXlhK09yWGw1bU1VZXNw?= =?utf-8?B?UnNHbnBPUmJrY20zL1l0dWRqN0dJMkp6SkZRcjlWYlE1Ulh3NDFxUnlnOGJo?= =?utf-8?B?M0R2OXJBK3d0WWFMSzVBdlBNNC9EdGRta2xrc05qU2tlWTM2NFRFSDJQdzhO?= =?utf-8?B?d0xOT2ZPOHZjYVMraVlJMkdESzZvcld0clMzM2hvQUc0U2pxWnZ4TXJ0YlIy?= =?utf-8?B?VmhBMEdzOU41a1RSWnBmM1ptcmp0UFZtMDZ1REJ0N2NxdDhYb1FDUnhlVy9r?= =?utf-8?B?aEM3RWZqYU5UT0k5TEpBN2RPTVhFNHhyaVVFM1luRWV2c2YyVkpsbzZmbDFj?= =?utf-8?B?blFpaHdiSkJtaWJRL0dmK20xTFpmb0Jodnl4YmlqRENTNHVkdWJPVHFCZjdG?= =?utf-8?B?d29YckNjdFdhemNMM2lxR3BLaEJTWUVnbFBFSmFVYzhLc1VKMDVvKzlWbTVS?= =?utf-8?B?MjhXYXF5bGdKY0MwbDkvdjRKTElMZDZxMEdjUTZkenhWUnpQelVWTlpTdU5B?= =?utf-8?B?VEN4RkZKd3RQNVNEVkpHcU12eUYwQXhMV0RKV0ZjcTFoSzNzQm9STTMwWGlS?= =?utf-8?B?MmJmRndaNjFFUUxxNGJraENwdEQrV3poNUxheXp3OFNkUUJsMmJEaXZCeWVD?= =?utf-8?B?ODB0Sm1tRVJud0FuNGVYRk5OTU9jcFlrL1NOLzlCMG9TZTU5U2RYTWVjbUN3?= =?utf-8?B?WnMvUyt5azZMMWJreW9iS1dYcFhuM3dvRWZOUTB5QXdMM1B4cGRrQmZGUWFL?= =?utf-8?B?R1N5Zk1zNWRlbWpUYWc4aCtvOU1ZTFlTaDJkcnRtSzRPQjBrYWhoQ3E1a2Ix?= =?utf-8?B?SVI5SWlLeFUxY09NYkNUTStxejRxWTdscGtra0NwTW0xaS9Mdy8raHFaaWhY?= =?utf-8?B?TENxckUwckpKeVN3M28zQXlJWE5XMDF3bFQzRVBGTlN3NUkrelFqbG4xTVVa?= =?utf-8?B?YU9jcWN5TkV0Mkc0eEs3Vkg4ckJaV2hXM2lqOUJ3RUJLenl3dE9DdE9oM05m?= =?utf-8?B?M2Yrd3ZaZHFRNFVJdWk4SGdXenNQM2ZNZGhJYmgzY2ZqbkZ3amUxT29xS1g1?= =?utf-8?B?L1JjRkhiOHBnbkJiWm00ekxjTnp1QUF3cmhKWEM5bWlPb2x4N3lJVnRtdmZU?= =?utf-8?B?YUFqVjZYT0VRRTZuN09GeXZETU5NZlhzRGtPb1VxY0k2TkkrUHdwRU5XYkV3?= =?utf-8?B?N083eEVLSWtrRW8wMll1d0UzQkZ5U2F6elpHOHVDd3E5Y1RIOEtaRURHaUsz?= =?utf-8?B?YWpBbTVGWGI3OHNHaW1oUT09?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR10MB7933.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014)(7416014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aHBEUStwdUE0ajFQNVJwV09nZXIzMWw2VWdLQnk4TlZ2d0hUakZxd2NGU1ZL?= =?utf-8?B?eHpXT2lQTmhuU2JxcGxjcDBwbjlMQ21YMWViazFSb1ZaVEkwL1lUMVJxVkVP?= =?utf-8?B?UjVPTXZxZGwwZ0JVOG0rY1ZiZlE1SENrenZCWVBGbmU4b2Z3NmYyZ2JybGJ2?= =?utf-8?B?bkY3eFpZbzBEejBLNkhoMGtXWnJuZUt6MVd2YVlJMEpMWHU5aHRURkltQ2xE?= =?utf-8?B?TUhsYkpicDQwNE5wak9VM1cwSGJIbDJOcUdpRHJvcFZNWjhuWWltd2lJYkVX?= =?utf-8?B?MzRqVGlEczArNGJ6TVZEaTk1TTNoRFo3SndHR0ZrbTlQY0JlV01vd0RmUUtZ?= =?utf-8?B?YkdKRnUyRU5IaHNaNFlSaTJ0ZGRONG1PSG13R0l3UThnNmdhTzcxNjJmN0Fk?= =?utf-8?B?eVozcllac3NaSnRuNkd1enNrc294dXQvVHk5aFdhRkFCSTZZSXRGN1hxbjh3?= =?utf-8?B?Rm81L1BFUzFhdEVoVjJQMnVPYm94eHNzSi9BOWVhdUhWQU80cVdVV0QrMXdG?= =?utf-8?B?NnZjNmZLUFR5YXFhbEh3TGZmUW9WaGRibFoxSVB6VTJwNUtWQ0hRbitNaHkz?= =?utf-8?B?MDJtS2hleG9rRG5VMDVKRWNaTlkxRHRiRkgrc0dubmJQRjRtTDJEMnhHbEEz?= =?utf-8?B?VXFxSEVad0Q4YVBPK2tKQ2hHeExsZkZvK2FKbWJ5MFhiOUg0TkRxL3JEU1dT?= =?utf-8?B?LzJad0FjeExqTE14TW4wRVpsMzBzOXlSQUQxV1IwWGkrTEpweThBVFp6ZmxV?= =?utf-8?B?anUydytnZXFrcmdVTGlkSThIcXhmNkNmYkxKcEVFdlRORm9qc05PMHkyTDRE?= =?utf-8?B?Sm9zRnROejRFQzRLQW5KVXpPOGVIV3o0cDZISld5Z3JidmdvUmFvcXM4cVZK?= =?utf-8?B?YTYyQXN2bEhZbzNpYm16aTQvUWk1WkkrdmxEaXY2WnhGZUpvNmZoSWNtTk05?= =?utf-8?B?YUtkaUFibEVycm5aS2M5V3RxM2lzOHFsbEF5NTh3cHp6dEpFanpCZUtQbXU1?= =?utf-8?B?b1hQK0FLZ1Z3SjhVNzAzYVhhaVdsQXZ3WXMvQ0FuN0NOTHFtNGZ3RlpBSEt4?= =?utf-8?B?R2llamVsZk1md1FhbDFrYUdYTG5EbDZpSkxCSU9xbGF3bmhkMWZVVDZzeitL?= =?utf-8?B?YitrMitON3JhdXgybkIrQjQ5cTlOS3Q3anhpT2x0Z2J4Y2gvcG1paUxKNTla?= =?utf-8?B?SWZHZHVJeXp0MkpxTGN0UVc5MkprbWJFTkRPaWUwaERTOU1rN1ArMjVyMDA2?= =?utf-8?B?TWkxZHFuNlFqL1l6cWRvdXp1Rmh1dWlUSG93NjdTOE1BREtuU1hTaTNTTzA0?= =?utf-8?B?OFZVTDN6ZmhrUjNJVS8wUjYya25UK2l5Ryt1RGg1OWh1dHRBSWp6Y1JUNFBa?= =?utf-8?B?ZFo2YU1lNEI2bE1wSEFEbm91NUFiL0pxTHZOODVubXNLQ1VzVUxaM3RySmpW?= =?utf-8?B?QXpYelg2NDZLWXVHSktQOVk3K3ZPYXBmVEZmV2lFRVJ6K0ZLMVYvTzNSYjh1?= =?utf-8?B?VExZNE00di8xYVdsYmZtZSs1eXhDbGVwOGw1ZmxPUWgxbGVIbTNkb1RvN2FE?= =?utf-8?B?TjB6bWZMbG5EblZhcDhDTlZEWUYwb2lYV2hkRW90ZGdTVGZQQXJ1b0NHMWVZ?= =?utf-8?B?NjQrd3M1bXFHOFliNWVBZkltN1kxWThqSlM2N24rMXRhUzFuSGRoT1RudGR2?= =?utf-8?B?Smp5K014K3Q2Y3ZNeGs3Rmx0VGRQRnRVK2E4b3d0b095NUZJaXEwSXFubis3?= =?utf-8?B?eTFOUDdmT0NDMFR1RW5wZU5VWUI4dDJFcEdPclRZQ3NZcmMyQlE5VXdHMWsr?= =?utf-8?B?YTh0Qm5rVjQwOGNCZU4xRG1kc3plcnRzdzR1REtmSWRyVkZBZkhLcHRxSnJs?= =?utf-8?B?QzZkMVJxRHZSYXFiZktCK3ZEcTNoZXRPWmdjaGFJQnptQndVRzlaM1pITy9Q?= =?utf-8?B?ZTE5TFp3K1VPOVRJQ2N5SnNvbzZVY2diQUtBNEtrQ2JmallBQkxxUHplL05R?= =?utf-8?B?RG1jUWM3QnBZK056WndYNXB4VllUaUhzMzRwUmhseG1NMmZDQkM5aGRuV2lZ?= =?utf-8?B?NWRVY2hQOVVOYnRjNDFWY3FJcTcxUWxUM3dxWVV0K2ZJb1pjcnV3VDlhTmF2?= =?utf-8?Q?tqpac6VZ+oavG2Aq/sAXVOdDD?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: QWJzz6w2oIWR5CjJXB1sJ+MLgKamyuPUEyIeyGOGyTxrdv6aD7NajdtK5LXfPHIjJXhSqqBpm2Iyap+PFL7WiXMOlbCLPZpNLUiGKNxJsq7XimOuRP1r3kJmd0tUFGt1SLg4hglKOsdB2UCT61YvXpevbD94Dktx4YlLbz4Ym2QCFIke2+/S2IFGl0Zdv6HHMc8JA+wtbM1kcF/OHVpjwpJ9VTa8hqyx9S0X9IRR8Uum2B4uBCQYcsJYYpJ/yY89i+JHysaneTW/nEilSaY8ICdlEn4Yo0vcxu9q3bJqJNYMdskNWHrrt57GHRnbQJcAA1tV1TWTSrx8siri+azvnnbYc+r8Z0TP7vZJUNJgORmBUPmie7r1kQtqujz3PX/Jh7FBXczqTVCfIFYTnA7CF2Q8e0D3aSFrMyJHwyPZpSHdvsOvpAQJ4J0jiOxvsYpGtWb2XvhHg6QH4sgMkRA3Uhhb770AvtI13hMk81SaWBCiH8L8WXkQQSnElTh5qIVpZJx+Sm1W08dvgJw/3R8GVSLxx7ZEqOx5N4AhGv89O9lcFr1AoZRskn06OORz3zDLUmkSp8bl2jas1ld7tD8dbfzGMsASwuyj9GJXXIKa1ns= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: a432181d-842c-4058-e109-08dcbaefec2a X-MS-Exchange-CrossTenant-AuthSource: DS0PR10MB7933.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Aug 2024 16:58:00.3525 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XXUhIwScOJmpH1eFMU5kQMswWThnt9KXaXFp88BOKvRCF+oNkQGOrzbyJO2U51yPSivy3iOVwEnKX/uwKfcfjw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYYPR10MB7567 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-08-12_10,2024-08-12_02,2024-05-17_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxscore=0 adultscore=0 suspectscore=0 mlxlogscore=999 phishscore=0 spamscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2407110000 definitions=main-2408120125 X-Proofpoint-ORIG-GUID: TQsIWo8wdcQ0dxsP1ZSSXQ4B9afZVhFS X-Proofpoint-GUID: TQsIWo8wdcQ0dxsP1ZSSXQ4B9afZVhFS X-Rspamd-Queue-Id: 6436440013 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: kwxp46opdp59naojykau5gjfthrmu9ba X-HE-Tag: 1723481892-499777 X-HE-Meta: U2FsdGVkX197jZ2yhykaySCi3Z4xh58UAmR/voQ0pat8Bmg4J0BVh+KGN7vjwFZOONaNbyTDp8guxumrTdQZdZh/E/1j5CVUFaY+0WmGl3afGlyUgOL6bn8Osv6H1/OxUg+gfzaHAli61aEQ63fKxqGHGIXL1JWc2wHUfot0VyhSOg9gDbEfF0n1clWTxNwAr9Y/ODBwENBRN4dAvNwhDVoixVSrIxFvv3D/P0VySyvHEc+4DMZbmbNcDLlqn2Ja3GK24bJvIckaD+bROHJUmIdnZQJTD0BPBHUC3tz0DjbHALJGHT3bzbQMSyR9tli1+tH4jeAKdqrZ8nV0UwvwiOympa8be/kMDFbnnM66rIe+WEuOv+zV8Jmkdj9NOB+bZyFR0SYdzdB6Uwv6gwjdopmrQVEoDoBq7ua5mSeUet2gaUFpnCkMNYnsQKnmNeP+62NAo8SOynRqo1p81D4wu0pjfq+acfBSQ3oqbZm+j5ovzAbcv3U7JDiSaXM/30Ct37FMWr+rP4RD1Fmq2oFTKT/jpDXe/Ge3CYNEXv2gY8U37ZW4/IDkwuU76T6/bzaZhOoQ3THRQfi0XV4jyww5hX9YwhXS/Ar8ap/MhyoPO1WTZwuj7Kd8zvkB5rQDQrhTNHrhttea7mmwr2SkADy9B5WsmnrEoO2ydT2WOx/viURHzelJp/ym98rlWoEGZNK7tlFFNueN/KV2MKa9XNNXRkDpQWZxxYinxfHrZYd6BemtTEeZq1pDL5dAcusCFU7lWh3MmepcWgAgfIm250RiGKdwRsowtUsrKXh6p2RGf7nnAoKHd3smd4UPfxZZ7Q5x7oH3oMf+qRdUDLsZTsdt2AmPqVznn9n+y6r9YrFxPNUnS5kpWi1PesGjJ2zZ7c7PzsiiWnHoz6bbOrDB3WUOMweX+4TPX8m5Scv6yKAvOJw/WGoaUx+SFlsSZ23XZWox7lhVTxyfOvtAzqKHGZS 8vG1U6hG JWarjy1iYc1SQuDe1G6SEQPWFcY1w4w4BVOJBUP6ADFTauVJWPzcBjWEiK7mCCI2xBvqG1+kwLMd5Uh0KPizHswsApBnl/CfjqdYXNHXqCnh0B1Wu2NOYO7ZG/i1g7ZZbNHSCbhF/U4e2V9xa1qGxbsChBQobJSNScKz80Zag2+cCbSP52r/mnTbCh1jt2xOM4Oplhatj5XIHyGjo++zGXueZHp3E38mz7P51Y63mKGrsU3coD+s3UMzryI/5izgYYGKvhaF3XW15x/drktFooKdjbhc1i+pVK/Ey6aX+p3PLilrfkc/Q2gp1BTvYDEw0uHbWKGfp74lBbu6NW34GfMVRbYDjXveDCSRsI/NvRKIP3wbdeaZIn677V9XCEVcbv5Bdr3XjL/NzJRtGR0ga29JkMUvkmH4k3rVbQUPQsnlsqpxgZcfwyMgxOFi/QY9SsqYuwff2PG2GN+8gwCjsl2pqOttwHD6NoSxR5q+71TONX5uhfyWeBTP3KBP+hsYw5Kn7/Pk2noI/aUZ75znmI0YFErx0R4zrXmm20o06Um70CKEKKQyaRIzyLabuv0g3k6DrEdmJ9oMDTp1eo+RptsfuXCEcPzl38B/a55fIRszjKYyGmXKODqEnxdkYpcfLWz9dEppGah/AvEg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: * Jeff Xu [240812 10:30]: > + Kees who commented on mseal() series before. Please keep Kees in the > cc for future response to this series. >=20 > On Fri, Aug 9, 2024 at 12:25=E2=80=AFPM Liam R. Howlett wrote: > > > > * Pedro Falcato [240809 14:53]: > > > On Fri, Aug 9, 2024 at 5:48=E2=80=AFPM Liam R. Howlett wrote: > > > > > > > > * Liam R. Howlett [240809 12:15]: > > > > > * Pedro Falcato [240807 17:13]: > > > > > > We were doing an extra mmap tree traversal just to check if the= entire > > > > > > range is modifiable. This can be done when we iterate through t= he VMAs > > > > > > instead. > > > > > > > > > > > > Signed-off-by: Pedro Falcato > > > > > > --- > > > > > > mm/mmap.c | 13 +------------ > > > > > > mm/vma.c | 23 ++++++++++++----------- > > > > > > 2 files changed, 13 insertions(+), 23 deletions(-) > > > > > > > > > > > > diff --git a/mm/mmap.c b/mm/mmap.c > > > > > > index 4a9c2329b09..c1c7a7d00f5 100644 > > > > > > --- a/mm/mmap.c > > > > > > +++ b/mm/mmap.c > > > > > > @@ -1740,18 +1740,7 @@ int do_vma_munmap(struct vma_iterator *v= mi, struct vm_area_struct *vma, > > > > > > unsigned long start, unsigned long end, struct list= _head *uf, > > > > > > bool unlock) > > > > > > { > > > > > > - struct mm_struct *mm =3D vma->vm_mm; > > > > > > - > > > > > > - /* > > > > > > - * Check if memory is sealed before arch_unmap. > > > > > > - * Prevent unmapping a sealed VMA. > > > > > > - * can_modify_mm assumes we have acquired the lock on MM. > > > > > > - */ > > > > > > - if (unlikely(!can_modify_mm(mm, start, end))) > > > > > > - return -EPERM; > > > > > > - > > > > > > - arch_unmap(mm, start, end); > > > > > > - return do_vmi_align_munmap(vmi, vma, mm, start, end, uf, un= lock); > > > > > > + return do_vmi_align_munmap(vmi, vma, vma->vm_mm, start, end= , uf, unlock); > > > > > > } > > > > > > > > > > > > /* > > > > > > diff --git a/mm/vma.c b/mm/vma.c > > > > > > index bf0546fe6ea..7a121bcc907 100644 > > > > > > --- a/mm/vma.c > > > > > > +++ b/mm/vma.c > > > > > > @@ -712,6 +712,12 @@ do_vmi_align_munmap(struct vma_iterator *v= mi, struct vm_area_struct *vma, > > > > > > if (end < vma->vm_end && mm->map_count >=3D sysctl_= max_map_count) > > > > > > goto map_count_exceeded; > > > > > > > > > > > > + /* Don't bother splitting the VMA if we can't unmap= it anyway */ > > > > > > + if (!can_modify_vma(vma)) { > > > > > > + error =3D -EPERM; > > > > > > + goto start_split_failed; > > > > > > + } > > > > > > + > > > > > > > > > > Would this check be better placed in __split_vma()? It could rep= lace > > > > > both this and the next chunk of code. > > > > > > > > not quite. > > > > > > Yeah, I was going to say that splitting a sealed VMA is okay (and we > > > allow it on mlock and madvise). > > > > splitting a sealed vma wasn't supposed to be okay.. but it is Jeff's > > feature. Jeff? > > > Splitting a sealed VMA is wrong. > Whoever wants to split a sealed VMA should answer this question > first: what is the use case for splitting a sealed VMA? If we lower the checks to __split_vma() and anywhere that does entire vma modifications, then we would avoid modifications of the vma. This particular loop breaks on the final vma, if it needs splitting, so we'd still need the check in the main loop to ensure the full vma isn't mseal()'ed. Splitting the start/end could be covered by the __split_vma() function. >=20 > The V2 series doesn't have selftest change which indicates lack of > testing. The out-of-loop check is positioned nearer to the API entry > point and separated from internal business logic, thereby minimizing > the testing requirements. However, as we move the sealing check > further inward and intertwine it with business logic, greater test > coverage becomes necessary to ensure the correctness of sealing > is preserved. I would have expected more complete test coverage and not limited to what is expected to happen with an up front test. Changes may happen that you aren't Cc'ed on (or when you are away, etc) that could cause a silent failure which could go undetected for a prolonged period of time. If splitting a vma isn't okay, then it would be safer to test at least in some scenarios in the upstream tests. Ideally, all tests are upstream so everyone can run the testing. Thanks, Liam