From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CA33C83F34 for ; Fri, 18 Jul 2025 00:17:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 077C08D0002; Thu, 17 Jul 2025 20:17:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 04EC78D0001; Thu, 17 Jul 2025 20:17:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EB0FC8D0002; Thu, 17 Jul 2025 20:17:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D74D38D0001 for ; Thu, 17 Jul 2025 20:17:22 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id A2DBC1A026E for ; Fri, 18 Jul 2025 00:17:22 +0000 (UTC) X-FDA: 83675471124.26.2BDE2AC Received: from out-172.mta1.migadu.com (out-172.mta1.migadu.com [95.215.58.172]) by imf12.hostedemail.com (Postfix) with ESMTP id E562E40003 for ; Fri, 18 Jul 2025 00:17:20 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=D1ljpPBF; spf=pass (imf12.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.172 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752797841; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HPThvsGTU9AmYUXc5iZse47Q32vjXDXF/k19b8GxfmQ=; b=t2JLw2AE7Tu0VcmdCOxwqr4g37MuYqUnI7qhalQWT3usb9V2NN+P0Ar6zToFleY6ipE9hm GSzJPK0VkZdzwAmUgCaFsMsOGAej/bVXgKPCet5qPFZSoh7Iu2GqMU8nZpOLz71vaHj5x9 7IxE6NIoQlTNL/BEy9fMdG3gXuuQxlQ= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=D1ljpPBF; spf=pass (imf12.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.172 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752797841; a=rsa-sha256; cv=none; b=UAEoi7yVRfbDZ4g/hXTsOAaHjbjEMrayLXdkkggu96+Z+Ex5dk3O03RMkh23u10szMmFY2 eEF10seN9tgqg3XQxCmyMu/PHmsNxBVXMKwkqk4rQyJND96w4LhU3hp47U4AYVXW6bcCuz Kuh90bKIr6xdGDz2+cQvN7WJpVMtwWI= Date: Thu, 17 Jul 2025 17:17:11 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1752797838; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HPThvsGTU9AmYUXc5iZse47Q32vjXDXF/k19b8GxfmQ=; b=D1ljpPBFzcIGTjSTyt78lBLe1cFIZB5a1PZkFZRbxnIm0M4yAK1vRgGaZxZaCOy2N1AvOt ML+DGmr6+9XCZR3IMaPtO/DmSACXf76xsBXvxAM4lxGe148xSysG9iLtEaqc2L+YSFmHxO ARz7pho++7j0USrX5UupFOMTG41s8+g= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Davidlohr Bueso Cc: Andrew Morton , mhocko@kernel.org, hannes@cmpxchg.org, roman.gushchin@linux.dev, yosryahmed@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/4] mm/memcg: make memory.reclaim interface generic Message-ID: References: <20250623185851.830632-1-dave@stgolabs.net> <20250623185851.830632-3-dave@stgolabs.net> <20250717155246.1f2a90c76d71b401255f11b9@linux-foundation.org> <20250717235604.2atyx2aobwowpge3@offworld> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250717235604.2atyx2aobwowpge3@offworld> X-Migadu-Flow: FLOW_OUT X-Stat-Signature: rh77o3bhf7gz6mg7pkb3uhj7pgnkhemr X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: E562E40003 X-Rspam-User: X-HE-Tag: 1752797840-51469 X-HE-Meta: U2FsdGVkX197fVP0sgoGNst7DNFinxcDjcApRdyZVDBea348AcSTjDvhvMVFFiVO7nrAT7afrWDNltKkF6kXTd18k4EsTa6/L1tj9bwzYrof6pEs8qIyL2oblf9VlN97yZFAVUjL/yi2EO5Lm8PECaUqNTzA0Od/r1P5zSaGzYuTpkSVjgyVGX+WF2aYF0n4OvioeIoWrQGl52X+Fq1DqA6RnbNsAu7IMm3fyscgXpkaSjZnIVR7Jm5ka8HKksvM9wu7gyP3pPiGZA0kfdUMkdAiMJrZeTr1pBSiGssy5rcREC9P96G1ov3yhaIkGCJE7R0Hoj45hcvM8K4yp3wtxYClnJ2eqUGNyE3HvlEyUita01sn67AkcnaaBRPUcWOvOrhIMvX/DofKoD7kvNeXwEZ4W6gApWeBN1dPixitk9gJfq3oYFcr7dY/tEJlH51vBV97/I1j8PAZsh+J26eJNr3yhxg/QOonx52LMGhz9xkq4hzm5Q0dMZVT3U26xfVQHOE61jsyB89jwuL6ljzmLbdktACJSUvHNvjREtDWEtPpvGy8KaPwUT+LGHYt9p9oMYgMrSKO217abuPmq5Uo7hXkWlVUynk4MMjpKS0aBbJ4yRyIg9FtIUJhy5oEeC/H/C5///YYtS8yZmXuCcrOu1z9T2+dp4js9AL2ac0llUNAcuUOSEKuL2JYct5BAd4JwUNm5bqEhU/EU+eYF0jZGXijCmAFJZ7133LbdkbBSEn22+7RwB6PNzzTWH7v/uKAWDpNVlRLwkAPTL3HpWPAa/8wNeG2hpOtZv0tfPjT8zQGFciaUrvKbje6jDOUy9gxkPVMBec8DHingvjl8WAye/gCb3cXVUp8W2x8iSfV5bFeXoO8VqndToSmUfOLW4n687doUDI73O5fgAvTi5q6PJLck8qmyNQrTme/G0WMKtbHSeG0zD16YCtSAwqR6Hlu1hC+LispLpJw/75UfKF cYEX+7Fw knTyFsWR7ZK1P5n0maP+lRa75EcGYgWSQblAdraSKjvNSmWtt1hcc3rvy2D+A1OylHjd+ab+lGxmGaeinR/V5MeTraU6mgj9vHXfmphwXU0pzeE4a2YmMubecnMr4lOmYVKRTGyNr2KOt2UPdIExtF1LWS62TQLIH45GZV8jjrlXKJvmNKIxQ46YWPyinoEt3ZvEVuI9ZN7Fp0/6NlnyMVQUkoy4O4LRy8dyd+qh6g7AXGk33oUVYUzMLqrIW7MxbCzD5yr8wc12rZ5ZOCO/1j2yEqQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jul 17, 2025 at 04:56:04PM -0700, Davidlohr Bueso wrote: > On Thu, 17 Jul 2025, Andrew Morton wrote: > > > On Thu, 17 Jul 2025 15:17:09 -0700 Shakeel Butt wrote: > > > > > On Mon, Jun 23, 2025 at 11:58:49AM -0700, Davidlohr Bueso wrote: > > > > + > > > > +int user_proactive_reclaim(char *buf, struct mem_cgroup *memcg, pg_data_t *pgdat) > > > > +{ > > > > + unsigned int nr_retries = MAX_RECLAIM_RETRIES; > > > > + unsigned long nr_to_reclaim, nr_reclaimed = 0; > > > > + int swappiness = -1; > > > > + char *old_buf, *start; > > > > + substring_t args[MAX_OPT_ARGS]; > > > > + > > > > + if (!buf || (!memcg && !pgdat)) > > > > > > I don't think this series is adding a use-case where both memcg and > > > pgdat are non-NULL, so let's error out on that as well. > > > > As a followup, please. This has been in -next for four weeks and I'd > > prefer not to have to route around it (again). > > > > From: Davidlohr Bueso > Date: Thu, 17 Jul 2025 16:53:24 -0700 > Subject: [PATCH] mm-introduce-per-node-proactive-reclaim-interface-fix > > Both memcg and node is also a bogus case, per Shakeel. > > Signed-off-by: Davidlohr Bueso With this, I think we are good. We can always refactor and move code around to our taste but interface and functionality wise this is fine. Acked-by: Shakeel Butt