From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0327C54E5D for ; Tue, 12 Mar 2024 20:08:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6B0E28E0016; Tue, 12 Mar 2024 16:08:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 686B18E0011; Tue, 12 Mar 2024 16:08:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 575B78E0016; Tue, 12 Mar 2024 16:08:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 480868E0011 for ; Tue, 12 Mar 2024 16:08:15 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 1B6D6C0BD1 for ; Tue, 12 Mar 2024 20:08:15 +0000 (UTC) X-FDA: 81889473750.19.9A50BD8 Received: from out-179.mta0.migadu.com (out-179.mta0.migadu.com [91.218.175.179]) by imf21.hostedemail.com (Postfix) with ESMTP id 27F741C0013 for ; Tue, 12 Mar 2024 20:08:12 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=fGa0rx+R; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf21.hostedemail.com: domain of kent.overstreet@linux.dev designates 91.218.175.179 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710274093; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yVCYd35eicxoyDwHWZ5Xnl3STwUduIDprFGFDUbtbK8=; b=yfgbdgkQe02q5BwGBLxV/hM7/abhM6eT8rWTNLv6vZrH4Zo9PexKpoYgH/ycoAzZNcSMbt s+RXJw506OIUYUFyaSC5hAfBQP4e3SoN38UmMEBhjUIR31QZE0QFUuIXgtNh2qxAGzxRH0 PPrKQ8HY480hEVcPgvUG/GL2DulhYrU= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=fGa0rx+R; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf21.hostedemail.com: domain of kent.overstreet@linux.dev designates 91.218.175.179 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710274093; a=rsa-sha256; cv=none; b=Oi56+zF/O4SlE2IRUd9+/THCE59aS4AedHpb0JI4cXIlpDeKYqkHufmeWhQHsmhr185mXD IIQFRbCHvHhT9gHC2a/XrLyaBmF3W7tJylek90nLqmIpUgez+lTjaTO+1FMzRNz9lCN+AE 66BSYoIF2YixtSfOIwHqE6dzzZboPsY= Date: Tue, 12 Mar 2024 16:07:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1710274089; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=yVCYd35eicxoyDwHWZ5Xnl3STwUduIDprFGFDUbtbK8=; b=fGa0rx+RU9H7yzOC8eKrKFu17a+94OmM+4cytPi0Sy37phzuaEQ+GhJUBfxmO2TO/xIFcf bikGmTAjXGkm74EXvCd4e8T8K55apzctaN+Uuym6RjHufYvesaQ3hOpfnYjJpKv9uZ5LaK qVqU7WfUOZtpXPBVr1A9ajf9sgP3KCk= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Luis Chamberlain Cc: Vlastimil Babka , Suren Baghdasaryan , akpm@linux-foundation.org, mhocko@suse.com, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, penguin-kernel@i-love.sakura.ne.jp, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org Subject: Re: [PATCH v4 13/36] lib: prevent module unloading if memory is not freed Message-ID: References: <20240221194052.927623-1-surenb@google.com> <20240221194052.927623-14-surenb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: 27F741C0013 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: yni4ukpasyaqopqtgmh4m74gehnc71gn X-HE-Tag: 1710274092-78051 X-HE-Meta: U2FsdGVkX1/dO7txyLm6AxsphXJW7ozGXQfaWX/PL7BHZnKf+h+XGUQui6hbRfgmI2L8tn8Ufp/Q/pwteWYU4NEZtsSR88ac2FqgIqRqW9BC/EADj+BTPqq3mXBsW2kzEZwN9GazpxYPCiUZrHiBqA2qxDBV5ew5x3lIZ95iUYoEtVmKQUuS2AAQYodnZC11fYYO3OtyABHENQzCS3AMHv0jNaYol+igmLmf3+SLI4VLIhu/+I/14onIGq1SZpZ92CCxhKN2kjGqBJOKWRS/ATKg7U2VIKgg13EON6Pk8z11lrYrHGq8WK2dNpUBbHBvMCdeRD+El/1PKuL2F23WLmJJnokPe2lJn5cRX4YmlGCBF2vGhnfRa9AT9k0FENwk0t3aXrBlxBl6aV5bB1hVdn2Bs49hAOktccGO5GDbFCQAqKxwMad0EmpjU75ZPLlDAN0Zh5DX1IpYFAa5rdkZDLHcX6m78T6NonfAMyrw5Qbk9qif0UiKBmYGUTAKkqhmwKbniJSPiLEl3gf37SVx7IPlzeV72HF2Nx51Hp+wo2fIag75Fv5c3QjH/XddC8IDmtcHWMqkhd95MPZCtCCGaBgbEXgXakpI7PhAaDSJ0RWh3UQLY6bA6urpxTvADKtVrftbPA0WfT3JioZsyrIjzXgt+rs/pZuKFB9waRp38kdUMHRTsAIuUEKOql0R+vQ2woUW7RWy5h192YjY88VhUd9lMI9fSr/juB5XTDPKoqbx6q4Ia1d0CpFBh6nw+nLDtiFUmR+yFea/4QrQ+PF3uysM03sNLCMsMfEKmYV0WsqQ8xMlOL6Z7tHHlqQ3+k2bMf4T9cvgD6htzAYQvzqX5hdwDE0qs7vYf5SRpvrgSGkdviqC9hH2gJUi0bogS6qQoy5kx3Xht7z5KBdFrq8sPBoyZMdQokI1cimiRKdH+eF67xwRUuzFIfsa6yKxLIyASOggjrhEi8fRGzo1gVW bPCmvt1D XHidyXpZn0IuR/wlA4hz/mgpQ1+NMYeIpHYTQXhoDK4ERYgc3ptAGcuTyo9LAqE9TeIOlNpSG0Nhp4ruYSpZ80Wb/exu9nLretG4yXDX2IRhQ2IgJ0Uj5dYRpr5QQxIZRHeKR5o3YD10ZBAxgS1Vz0MDzbjrnSwjs3WKVmUd2MtkdeauGR/1R1+JqLZAGTjv4UREkHSkBzj1dqUM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Mar 12, 2024 at 11:23:45AM -0700, Luis Chamberlain wrote: > On Mon, Feb 26, 2024 at 05:58:40PM +0100, Vlastimil Babka wrote: > > On 2/21/24 20:40, Suren Baghdasaryan wrote: > > > Skip freeing module's data section if there are non-zero allocation tags > > > because otherwise, once these allocations are freed, the access to their > > > code tag would cause UAF. > > > > > > Signed-off-by: Suren Baghdasaryan > > > > I know that module unloading was never considered really supported etc. > > If its not supported then we should not have it on modules. Module > loading and unloading should just work, otherwise then this should not > work with modules and leave them in a zombie state. Not have memory allocation profiling on modules?