From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E079CCD11DF for ; Thu, 28 Mar 2024 19:15:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 698FA6B009A; Thu, 28 Mar 2024 15:15:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6490C6B009B; Thu, 28 Mar 2024 15:15:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 510996B009C; Thu, 28 Mar 2024 15:15:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 323F26B009A for ; Thu, 28 Mar 2024 15:15:23 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id EAE8B80381 for ; Thu, 28 Mar 2024 19:15:22 +0000 (UTC) X-FDA: 81947401284.03.5677C77 Received: from out-176.mta0.migadu.com (out-176.mta0.migadu.com [91.218.175.176]) by imf26.hostedemail.com (Postfix) with ESMTP id 3E6AB140020 for ; Thu, 28 Mar 2024 19:15:13 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=KvJB7SoZ; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf26.hostedemail.com: domain of kent.overstreet@linux.dev designates 91.218.175.176 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711653316; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UiiYaB+fnO7Vb9P9+KhFx8SmJF7I5vpoUotl6zT2/zs=; b=WMd7VhiI7jsGhRZiGU9sLd7jjj8P+Fr1xtlXqhaWsqlT0WDMRlOSYcWIhnfzj6ie0nx5Gd aytffywIn94nbPN6tb8vQV8fN6tjjXtMU6AKR2C789Rpo9kFAzIwDhs7+3c+Wisn7Otp+M iXIgjfCpa0XiWA2xKaYBK9ztVj74rPs= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=KvJB7SoZ; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf26.hostedemail.com: domain of kent.overstreet@linux.dev designates 91.218.175.176 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711653316; a=rsa-sha256; cv=none; b=IwWr3Bz6eUl4H+BePkdJA8GrqVLdog8f1dPxMzrLfq9CZrQJ8SacPo7H+e+EHWOf3sXaqG ufVl8PRVtNDti8EcQ8yUwz8rlGxevXYlkoXGSra/e/Iqapfl0AWQNGNsueHtfGZJttRBa2 QFOoXsL26UbDgPDS+pof+AaaOkSvaqc= Date: Thu, 28 Mar 2024 15:15:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1711653308; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UiiYaB+fnO7Vb9P9+KhFx8SmJF7I5vpoUotl6zT2/zs=; b=KvJB7SoZJKVuzlqFVWM0vRr2iWIHkYGpJutBec/Y0CDeoRB3ZqbEZnoiYkOlkksKTFjkgc ZCl0V6MkQaKz+XlvCm77TLAL4XRYFaNjdlbdfH1ZqLGFKR/WklakWlabZ6DvLfZlpu8cMo T9CtcB9YVXDlDIj6D7xWNsnofVKorJA= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Andrew Morton Cc: Kemeng Shi , willy@infradead.org, jack@suse.cz, bfoster@redhat.com, tj@kernel.org, dsterba@suse.com, mjguzik@gmail.com, dhowells@redhat.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v2 0/6] Improve visibility of writeback Message-ID: References: <20240327155751.3536-1-shikemeng@huaweicloud.com> <20240327104010.73d1180fbabe586f9e3f7bd2@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240327104010.73d1180fbabe586f9e3f7bd2@linux-foundation.org> X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 3E6AB140020 X-Stat-Signature: 1s6k4dh9us4a6b9wijcabzxxyhb6ui63 X-Rspam-User: X-HE-Tag: 1711653313-123131 X-HE-Meta: U2FsdGVkX1/xVdesGX1WpJIsLzAlBhDHpgnd+59e6pzQIxGD7OxLb8GwYbOwHcvYW3yDkNQzXPttPVxoRGKGpZpJLUV6zgZDShpdfmftZYQH7uaMehw/LLkbCsXyVc5OAeYjQbe5Mi5DALEE43LmnuHuMXa5o/x4VJuhIbYQXKqBrbRailTgs0X6wnN1OazgQuTi2SgCrQ361J77qkHW1wwSQs4wjhKXF9G/dCuiBiP2fUO1TaRcKuEAouDFzv7hPgRaajbuYF3oytfnHii5aHGtTGF6ifP5GXLxkUDkZZlf/Yf+0jQQs9X+d0G6oLwUYE8BXkJBkJa+qV+fjCCKi405TVBvZ5BsLzHG7eLhDkGqmM18hA1AdytzQoPozEVks9ePXH/Ve22PbxDf7aczzP1UeK72IxQJCjTIsTutB8/8CM3x6CWHbJ++WRkydNvCeIXbBWDH5Y0jD8nzahBKUssCa7n7vsbSXmx2QwTZReAl76c+Z3YGW9gJONf33fsTcZPg7mQyTlyDNYQ0BbicpK8H3QyL8bKslO/frJna7eamGm5D+/03+RMOpZwC4bOKJmJKR+n4gfZzEQCt6nA/rjCM5gu69zpE6mwAK6K/rn9D+iEioOV3Y8RKaQr9HUFVLJzi911eZZl9lDTsdgcKK1iGqhXgPXBQ5+UYggAS5Wl1IKI8Z5QZAhGXRT2XriimITv4Z9LLzYBcAU9lztoTEC2mVSxJcQzovJCF6MpHJ+g9GIZaESz6dSBtm1NE9u+DTqJME03UuGvTuTprwXflQR2r36XMVLqJuWjK+UEhZs21W/gY4MSvZCpC5i3kHiX3Ggn5906nHT86UEW1TMMqnB6sqt6G+zNwPXUrZz78llAAr+D/kC2VIieaYgDHAdoNBEK0QUUjXsbY4NBVM40cmF3NW/Er2fq8bwlp/j+OjXywEQuPmJvkMe4OQoLNOdELkwWBgDDcV1pTXmnPc3i AL5oTrMm wI1aDWu82AFW1v7TzHai09ZrrCND3i2v3QxSx5q7tG69nwkv5ybF7q/ny4EenjwwMtBgRnGD/SxJiDqROsJVzJsLUOD3/Eq/b+MXfJVZL6nJCkFOplsvEAMheFHRhliMrvPw685KRW6Ro6NlT06YIkHx3jQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Mar 27, 2024 at 10:40:10AM -0700, Andrew Morton wrote: > On Wed, 27 Mar 2024 23:57:45 +0800 Kemeng Shi wrote: > > > This series tries to improve visilibity of writeback. > > Well... why? Is anyone usefully using the existing instrumentation? > What is to be gained by expanding it further? What is the case for > adding this code? > > I don't recall hearing of anyone using the existing debug > instrumentation so perhaps we should remove it! Remove debug instrumentation!? Surely you just? I generally don't hear from users of my code when things are working, I only expect to hear from people when it's not.