From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F230C4829B for ; Mon, 12 Feb 2024 15:00:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 83E076B0071; Mon, 12 Feb 2024 10:00:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7EE656B0072; Mon, 12 Feb 2024 10:00:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6B5CB6B0074; Mon, 12 Feb 2024 10:00:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 570006B0071 for ; Mon, 12 Feb 2024 10:00:43 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 1898FA1405 for ; Mon, 12 Feb 2024 15:00:43 +0000 (UTC) X-FDA: 81783463566.27.47B3FB7 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf07.hostedemail.com (Postfix) with ESMTP id 237FB4000D for ; Mon, 12 Feb 2024 15:00:38 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=MvvqIR95; dkim=pass header.d=suse.com header.s=susede1 header.b=MvvqIR95; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf07.hostedemail.com: domain of mkoutny@suse.com designates 195.135.223.130 as permitted sender) smtp.mailfrom=mkoutny@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707750039; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zCA6YMIgfL2kSQYWwcG3dnu2KR4ZdNffoBP3LtJDiiQ=; b=yptYE7wqul5conYQfZCTIg/hjbct9JX7n0sj0p915OmZi2qoxv0LGQdrcfOyhlq8lAbIsP gx8+Us0fq9d89JTSmidNcQ0tXG8Nvdf1mtDFbEiBUyvalBVNWEm227G3ZLV90uQ5h/Raq0 61+jbMd63G9flEDJ5SATbAW0up478SQ= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=MvvqIR95; dkim=pass header.d=suse.com header.s=susede1 header.b=MvvqIR95; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf07.hostedemail.com: domain of mkoutny@suse.com designates 195.135.223.130 as permitted sender) smtp.mailfrom=mkoutny@suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707750039; a=rsa-sha256; cv=none; b=1KO8HVYnHESRyCAnDhzbKSyzvu5eGJ4JN/7J0IxGgqnKVCPZ1GLQbywR8F3v0oA/5FxosG oYSrcw8L2vM4okQsLPu0iEs40cTG7n2nKU3yt/Zdbaepp1Xgu992eqPnmqrrWMf1Hxd0Is NgMDlhPTimeYS5J9Uk9xXQ1UtBQrqoQ= Received: from blackpad (unknown [10.100.12.75]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 2643721BDD; Mon, 12 Feb 2024 15:00:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1707750037; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zCA6YMIgfL2kSQYWwcG3dnu2KR4ZdNffoBP3LtJDiiQ=; b=MvvqIR95yBP75tWFFy1E1AQN+7JSPPgRSEt6Mv39rfeUc6lnAA1+ajIgsxDBV2O3pfCrMf hunvnm68UfdHJTa/XZ5WtpnzS3ACHsonwVULiwzLCTQxVvSOJL1ERy4mupMUaSdc+QnZHG nKfmBE0Wg2ucd43Je97aRJ2o/WOC9pA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1707750037; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zCA6YMIgfL2kSQYWwcG3dnu2KR4ZdNffoBP3LtJDiiQ=; b=MvvqIR95yBP75tWFFy1E1AQN+7JSPPgRSEt6Mv39rfeUc6lnAA1+ajIgsxDBV2O3pfCrMf hunvnm68UfdHJTa/XZ5WtpnzS3ACHsonwVULiwzLCTQxVvSOJL1ERy4mupMUaSdc+QnZHG nKfmBE0Wg2ucd43Je97aRJ2o/WOC9pA= Date: Mon, 12 Feb 2024 16:00:36 +0100 From: Michal =?utf-8?Q?Koutn=C3=BD?= To: "Jan Kratochvil (Azul)" Cc: cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, containers@lists.osdl.org, Waiman Long Subject: Re: [PATCH v2] Port hierarchical_{memory,swap}_limit cgroup1->cgroup2 Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="udftjw4lcp7jj2yb" Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 237FB4000D X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 8po5e8hwtiyydsngkcyhe7it5tkoketf X-HE-Tag: 1707750038-816865 X-HE-Meta: U2FsdGVkX19ZvrZ1esJPzrZ1sINYT9yt1MIgWx9eVm4+tSM0kgHTguHks0YR7cdLRW8BrZXLUMejcR7UwBA1v8BGMlHFtnwH2tWfmpSn/ySOmWJPEzhCCpSEkUpZJl2RkY7etBvlFHWk8K8ml526kZNk0Tm5u/yKI5NTdfy9SuY2JOAB/z9egbhOtmxldfoyn4yjO0I987kAPnjWOi3gFOLDWRphmDXO+6LxN47+8KibTBcu8rINemaJXWM6oI91VQcOOeBk3RpxKMv9z+yLZwkwERbuLqO9CQLlN01IQJyrQz90F9ep3fRXRhGPtgkd/y2jVs/UamxihBZ1CbenUT7F6en4AZJREDAIIAE9LjffGGfSUMNuymaycDLXj6ijnsDv23/E2UzA/C8Hz1vlgtZTol0hU0ghXPl865FqPwPZB6Hd9TKlTtOlvfksH8JRYZjxXcGdRxvmIH4nCVn4o27DAeVFMwjf2nIY3Wa8Rjn5Q8eJhg2KYecTKbMd7iFcY1s4dx7mUtRx/717BvCvfRnYv5qYXzO5lazQwfJoBDbjsq6QvSHi3XXLpuOzBDTSgZqSPx2vdb6RnzJrDOkYeg2DOthnn+X6jwRO1Al79Y4JYCKQtDsmw6sgx12RU3MOugEym6vQV48nKrQRHUH5yLUrtuYpduDzxpDzmSAeFpwDwn38SBtgLeWtQQOq/P7dZyE0d9Az3rGH7Cm+6IX0wWmDcrpS1rimdOxC93pYYjUdOYgoFSsgPYg/a4hAC1YkP1TSfViTWN0prDPIgWPKVyyNBRfXr6R3uD2ZgrYCA9ULCAIH3ulMGYGDRSI5CJEp37nrIcXdCGVMjP05a6MnfeUkn9TsX0fqI8YFpzlYeQpTjvoJaDvXk/SOiO6r4QUfeazpAr+UEPGYtSgAq05Z39n1GuNvXYYY03cnGjO9cV9Wa6ADbb2kuVbs3u9ju72gPywdw+q66T4WLt8g4qu xrMZlbcP WainnWifwoxBXIr7eXK81KA/KZ0BfbCaI1iwUDPPzHbKzizaCzKSmx3S5Tbqs0c6IYXyoiocp1OPn5uQ57wizxqD0C2feOgXddcKT+d6dfnwm9VxZKFmF8IsEqKC+rYzDyaKubpZS7jHoO0JKujI1p1sgWSAiTs4lsEXrAuECT/dyzj9sJ+DKY9TC3dr7xSYEgz271mfk51jHvNkpPgTUKm3lU1u0zBFet+7gtMmpZvxgIb2D6NCnFuclnpDgNE/Ei8DsPQBjXAlFqhZYPbzHwMF1lYNssdthqp8zw/bkdHvcGuRubhlZPpud2/UXEKog+wESy8XC0bwoJpV1xVTuOx4AEJ8SqlrhPtXfGUtQKNDvYLOV+ggEi/aaqg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000020, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --udftjw4lcp7jj2yb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello. Something like this would come quite handy. On Mon, Feb 12, 2024 at 12:10:38PM +0800, "Jan Kratochvil (Azul)" wrote: > which are useful for userland to easily and performance-wise find out the > effective cgroup limits being applied. And the only way to figure out inside cgroupns. > But for cgroup2 it has been missing so far, this is just a copy-paste of = the > cgroup1 code while changing s/memsw/swap/ as that is what cgroup1 vs. cgr= oup2 > tracks. I have added it to the end of "memory.stat" to prevent possible > compatibility problems with existing code parsing that file. I was thinking of memory.max.effective (and others). - no need to (possibly flush) stats when reading memory.stat - can be generalized also for pids controller (and other "limiting" control= lers)=20 - analogous to precedent of cpuset.cpus.effective Whereas, using v1 approach in v2: - memory.stat mixes true stats and limits, - memmory.stat is hierarchical by default, no need for the prefix. What do you think of the separate .effective file(s)? Thanks Michal --udftjw4lcp7jj2yb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQQpEWyjXuwGT2dDBqAGvrMr/1gcjgUCZcoykQAKCRAGvrMr/1gc jrcRAQCmHQ3zahZOyBX4mYSsgAGeyZnpqwR6DtFU4iC+td8H0gD8CMLymLYdXAGC I89BNel0pL7qDQzxSuSAVFvoyZhlRws= =v9Sh -----END PGP SIGNATURE----- --udftjw4lcp7jj2yb--