From: "Liam R. Howlett" <Liam.Howlett@oracle.com>
To: Brendan Jackman <jackmanb@google.com>
Cc: Ujwal Kundur <ujwal.kundur@gmail.com>,
akpm@linux-foundation.org, peterx@redhat.com, david@redhat.com,
lorenzo.stoakes@oracle.com, vbabka@suse.cz, rppt@kernel.org,
surenb@google.com, mhocko@suse.com, shuah@kernel.org,
linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 1/1] selftests/mm/uffd: Refactor non-composite global vars into struct
Date: Thu, 28 Aug 2025 14:49:37 -0400 [thread overview]
Message-ID: <kd6uteyd4vzlnbdwzjydwd7hoqyxewc5fx24z5sq7svmtoa3oo@n57xyeu3vtyy> (raw)
In-Reply-To: <DCE2EJ3KWX3K.1Y198FHBV8UG7@google.com>
* Brendan Jackman <jackmanb@google.com> [250828 08:37]:
> On Sun Aug 17, 2025 at 6:52 AM UTC, Ujwal Kundur wrote:
> > -static void noop_alias_mapping(__u64 __unused *start, size_t __unused len,
> > - unsigned long __unused offset)
> > +static void noop_alias_mapping(uffd_global_test_opts_t *gopts, __u64 __unused *start,
> > + size_t __unused len, unsigned long __unused offset)
>
> After a rebase this is now falling afoul of the -Wunused-parameter added
> here:
>
> https://lore.kernel.org/all/20250731160132.1795351-5-usama.anjum@collabora.com/T/#m0449dc0d6a5ac3b1f71f7182c13b6829e1b444cf
>
> I really don't think we want that flag, I'll comment on that thread, but
> just as an FYI here too.
I was under the impression that it was decided to drop that flag,
otherwise I would have also spoken up about it.
next prev parent reply other threads:[~2025-08-28 18:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-17 6:52 Ujwal Kundur
2025-08-18 7:56 ` David Hildenbrand
2025-08-21 12:44 ` Brendan Jackman
2025-08-28 12:37 ` Brendan Jackman
2025-08-28 18:49 ` Liam R. Howlett [this message]
2025-08-28 22:54 ` Andrew Morton
2025-08-29 8:07 ` Brendan Jackman
2025-08-29 15:29 ` Ujwal Kundur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=kd6uteyd4vzlnbdwzjydwd7hoqyxewc5fx24z5sq7svmtoa3oo@n57xyeu3vtyy \
--to=liam.howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=jackmanb@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=mhocko@suse.com \
--cc=peterx@redhat.com \
--cc=rppt@kernel.org \
--cc=shuah@kernel.org \
--cc=surenb@google.com \
--cc=ujwal.kundur@gmail.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox