From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13668C2BD09 for ; Tue, 9 Jul 2024 10:35:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 247396B0092; Tue, 9 Jul 2024 06:35:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1F7DF6B0095; Tue, 9 Jul 2024 06:35:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 099706B0098; Tue, 9 Jul 2024 06:35:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id DF50B6B0092 for ; Tue, 9 Jul 2024 06:35:02 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 28471121834 for ; Tue, 9 Jul 2024 10:35:02 +0000 (UTC) X-FDA: 82319856444.10.803F0CD Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.16]) by imf21.hostedemail.com (Postfix) with ESMTP id 692431C001A for ; Tue, 9 Jul 2024 10:34:59 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=jsQu8peU; spf=none (imf21.hostedemail.com: domain of kirill.shutemov@linux.intel.com has no SPF policy when checking 192.198.163.16) smtp.mailfrom=kirill.shutemov@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720521284; a=rsa-sha256; cv=none; b=4kzsl1phvz6mEFHt1pCxEqx6YdhYZw1Cr8/hOr9ESO5j2GUOgNg7ht2BYY49da4GaUNP/g VHqM69HTg3/yTPJJJVCLLXtcfG13zVISls+j/gQYq5+hpZgM2j7zG+MUp0dgxmEMpsvA+G dOC6z0IsDnFGOYPJPXwsTp5ghCJd3pc= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=jsQu8peU; spf=none (imf21.hostedemail.com: domain of kirill.shutemov@linux.intel.com has no SPF policy when checking 192.198.163.16) smtp.mailfrom=kirill.shutemov@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720521284; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9lEVpgC6eR7rand+aTG+g2su3WtTfhLOH7iLnl0dNxo=; b=PqrQ/KCXQMRkgqneusePCNCR2XwMvxcj3myErdO9Sj8BB3KUFKzlHOrgev49SCpsxVP+vJ c45iyfTaGcG+XbP0NcPFur8pPM+UCo3gr7TsibQH79aeMBprQ4eorCso/iuUwJERSDsT1F A/nBUEi4MPUcLPXX2H9mIvmDpGeM/EI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1720521299; x=1752057299; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=3P2DFYn1DBKMPF40DT1RbJd0AgqHL2WhUpStkH84zJI=; b=jsQu8peUcdoJvuTbLF11hJFMNFCzeq0LR7NxSMRXv85Os6pSTN/pPAkt cr1EFuu4qbaS/kZU2J2ThWLrin7vYG7Zwr2/RgI7hWVFSnrd9cJAqsoan 4Usnqw1m6jEIKChdUcP7O1TdormcpaEW1mmpYaOgXDF3u58V0n2qOea8G ZHwK+tGx6NqehKOZzvPmpVBhKbgZmyaGxrsrKVYlh1hxdkiXG3fcWGqxu hBW+nofLgSHm6nDOTtLzxX5akDuRH5GMzHGTr0oNyD6lfD9YehfpXUqDT F28k9QWGCAl1rCwQdW1rZVofkJN61UbGEAmn2rO01S8XbgOfH4msLKdS3 A==; X-CSE-ConnectionGUID: IeIg6tA/R4+oV2o04A8/NQ== X-CSE-MsgGUID: GaowpzpkSY2wcEkq7AjZNw== X-IronPort-AV: E=McAfee;i="6700,10204,11127"; a="12449723" X-IronPort-AV: E=Sophos;i="6.09,194,1716274800"; d="scan'208";a="12449723" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa110.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jul 2024 03:34:58 -0700 X-CSE-ConnectionGUID: pDxVPSVaSYyj7rLcSun4KA== X-CSE-MsgGUID: gR3cPS93So+DFacnnGLSUA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,194,1716274800"; d="scan'208";a="52216252" Received: from black.fi.intel.com ([10.237.72.28]) by fmviesa005.fm.intel.com with ESMTP; 09 Jul 2024 03:34:55 -0700 Received: by black.fi.intel.com (Postfix, from userid 1000) id 9B18215B; Tue, 09 Jul 2024 13:34:53 +0300 (EEST) Date: Tue, 9 Jul 2024 13:34:53 +0300 From: "Kirill A . Shutemov" To: Donet Tom Cc: Andrew Morton , Muchun Song , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Ritesh Harjani , Mike Rapoport , David Hildenbrand , Matthew Wilcox , Tony Battersby , "Aneesh Kumar K . V" , Nicholas Piggin , Alexei Starovoitov , Andy Lutomirski Subject: Re: [PATCH v2] fs/hugetlbfs/inode.c: Ensure generic_hugetlb_get_unmapped_area() returns higher address than mmap_min_addr Message-ID: References: <20240709092122.41232-1-donettom@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240709092122.41232-1-donettom@linux.ibm.com> X-Stat-Signature: 1aynbeyachibpsara5s3kewwq4ax8y1d X-Rspamd-Queue-Id: 692431C001A X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1720521299-416538 X-HE-Meta: U2FsdGVkX1+Fc/AVpkGqjsIcLyo3bVSqRXlb0SvWpwxAp8A6qrpupD4MKDG1Aqazy5J/NMMc/F8vf5dDhGC4EhkotxRbZ3ltz7MMZ7Q+Dtz+57q7MqJKTiyaQnVJWcY9ijqGnK0WK9uDavuNyoD5aTiD2fB3nB9bh1oZD3p6couAn1e5HnQq+it0bCsOywdtQlp5+OLTTkcRINTIiI+5iTD6LDGB+vkpq/ArLTFpzxa5qNjHej8mCY0DYM9I+e9RGRy+OESwefRT3CsOZa5+2RTUoTscu3XtzvsRb+T0qZ8/zujLzJhwrT1RO8gSGANFfAhXZzTL4NPyYBZ6c90M9UWPdjSbJ+QAydeKaa6Kdpk3JrFRKWk15iXmVd+sV3AVTTJlPSbwZTo34Nz6KlH/yQWAl3YkCNtqnAHsz+8eywgzWfUn08sQAkYzAiUr3Zkq+jufC+cX6kpLqZ2oKNEyVhp1hszQ79EwbrYKdeiMKblez2In1aUu2L9O98DLmJN6KNwfrBSOD0H6H4mnSQ/QLrVffUB/a7mqvSQALU/ODLEV6K1X0kNu5LDhhG0LQuIisQcclsJAW/h2VQgqkcvs7yIPR191JJLI0cBi517b8FU5IV2Gcxk0N8aGFmRBWiXaXq7D570OAkZ8rK/v6K0XVK/KWewj7lXK/Dt4BqX7Xn7x+LGhTvtHWSYqD4j7CqOBhZMpwxMTRdlDVBtJ/oiuCg8yuR3i0zpYPq0HLxO8gVs587CUdwSLkTkXf8WCK8Bq64FwHmlHbRQcOMvvamK4CQZJJ3AXsnRyvicapraRF8iCz2BpBWVnpahxP4Uo99XQNVPIDkEdAK/XXRiWy9Tqw5IKRqRr9sovl1Ha1HCrXABmA8lB0O9ueCTxrRKYLfk9a90Rf5i3aDM398FnXheLGY2MsIAfw2SJKbMUxTFO6GXepcGyFEiuJiXrTxmJ2PFJ9u0VAEWQcC6V4/7PNZu XCEpifyw 6tN1sr4mGQBlWoRnITVVo6lCOJugjEM7r/0+S0ZeEx/iDRxmDc7dM7HmKQQ96gii4knwnmfGe+YXeFYX++eZ7XEvX1svV98gsFJhWPUxV0nbWfrYBbY82OpB4eRjYnWxvqRq3YRzdepe+AJLNuOG0vDYsBnWWULnruHg5TnvFOqdMEj0TKmipsD5HfY4DqiDcFdoeCyhi9cMkbO0hxJL+xBPDTrsBTNkmOWMYFrCV08pYrOkkmlAHI/EzeWaCwN7iwsRwEpt5qilouJsGQfvwKCtTgf0B4ijLFtUr34kPf/5CzSeXmZbTV7UiEp7cvcyun2E27mqjlu5WTnxC+day5D1r18aM0nrASPV/dcgKYyyfVYqV5nZsZsnJFb3qzKLA/q0C X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jul 09, 2024 at 04:21:22AM -0500, Donet Tom wrote: > generic_hugetlb_get_unmapped_area() was returning an address less > than mmap_min_addr if the mmap argument addr, after alignment, was > less than mmap_min_addr, causing mmap to fail. > > This is because current generic_hugetlb_get_unmapped_area() code does > not take into account mmap_min_addr. > > This patch ensures that generic_hugetlb_get_unmapped_area() always returns > an address that is greater than mmap_min_addr. Additionally, similar to > generic_get_unmapped_area(), vm_end_gap() checks are included to ensure > that the address is within the limit. checks are included to maintain stack gap. > > How to reproduce > ================ > > #include > #include > #include > #include > > #define HUGEPAGE_SIZE (16 * 1024 * 1024) > > int main() { > > void *addr = mmap((void *)-1, HUGEPAGE_SIZE, > PROT_READ | PROT_WRITE, > MAP_SHARED | MAP_ANONYMOUS | MAP_HUGETLB, -1, 0); > if (addr == MAP_FAILED) { > perror("mmap"); > exit(EXIT_FAILURE); > } > > snprintf((char *)addr, HUGEPAGE_SIZE, "Hello, Huge Pages!"); > > printf("%s\n", (char *)addr); > > if (munmap(addr, HUGEPAGE_SIZE) == -1) { > perror("munmap"); > exit(EXIT_FAILURE); > } > > return 0; > } > > Result without fix > ================== > # cat /proc/meminfo |grep -i HugePages_Free > HugePages_Free: 20 > # ./test > mmap: Permission denied > # > > Result with fix > =============== > # cat /proc/meminfo |grep -i HugePages_Free > HugePages_Free: 20 > # ./test > Hello, Huge Pages! > # > > V2: > Added vm_end_gap() check. > > V1: > https://lore.kernel.org/all/20240705071150.84972-1-donettom@linux.ibm.com/ > > Reported-by Pavithra Prakash > Signed-off-by: Donet Tom Please use "hugetlbfs:" as subject prefix. No need to spell out full path. Otherwise, Acked-by: Kirill A. Shutemov -- Kiryl Shutsemau / Kirill A. Shutemov