From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95382C36002 for ; Wed, 9 Apr 2025 21:57:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9F7CB6B0254; Wed, 9 Apr 2025 17:57:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9A6D8280058; Wed, 9 Apr 2025 17:57:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 896156B0257; Wed, 9 Apr 2025 17:57:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 6D4D86B0254 for ; Wed, 9 Apr 2025 17:57:43 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 27FD2AF892 for ; Wed, 9 Apr 2025 21:57:43 +0000 (UTC) X-FDA: 83315868006.21.42E3A7E Received: from out-188.mta1.migadu.com (out-188.mta1.migadu.com [95.215.58.188]) by imf11.hostedemail.com (Postfix) with ESMTP id 31F8540004 for ; Wed, 9 Apr 2025 21:57:40 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=gKDcMMHF; spf=pass (imf11.hostedemail.com: domain of kent.overstreet@linux.dev designates 95.215.58.188 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744235861; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7wUe9pHBSuC5Oe0ZRJOjDIIZ/Co8LyEOQFuUiVOm0oA=; b=TmJVoAxFVnKBBGk7oSQu5AXIsBh3CJhfhjyVshBWdjAUVru/xU5gvAci+ocvaIR1+XS8j9 qa/yNqZbJIVf5RZHLPB/8gnq5lKkhFM/LdEJKrnpsk2RQkdFdgZfelWuQIHxcJsftIV67h w4qQPAJJFoh7FK4YZA5sw6q+Rp1aX/I= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744235861; a=rsa-sha256; cv=none; b=4Wx+V3zIQdOZsgbAVVYFK65IbtOQ66U82jdSyU5amNYl6imqucy8vqRtqi3jReqmB5IC1J vddMe0FFWtruAR8mBQK4Crhq1ur8Euiraxp+t5GTQHGWHoDRvrTJ/LbHctACvMH2SjuAYe UaDwNexdhEOImIEKqRXCeBBqQUQ/UQ0= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=gKDcMMHF; spf=pass (imf11.hostedemail.com: domain of kent.overstreet@linux.dev designates 95.215.58.188 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev; dmarc=pass (policy=none) header.from=linux.dev Date: Wed, 9 Apr 2025 17:57:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1744235859; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7wUe9pHBSuC5Oe0ZRJOjDIIZ/Co8LyEOQFuUiVOm0oA=; b=gKDcMMHFPwlL2p3jQJDm2SvVZx4WqiDfWZW01X1jUml7YX8R9p2G3ln76sPyQ9iph5tMhg /coZH/07NIWLPJHOP3Vu0mzSbRJzFb5jz6SMHTbmUuEHG5ZmgPHMoULYmRYv4i+wRuiLuQ 8O1E3Q1Nv/0/B4KItY3UmYPmtvZSQSE= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: "T.J. Mercier" Cc: Andrew Morton , Suren Baghdasaryan , Janghyuck Kim , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] alloc_tag: Handle incomplete bulk allocations in vm_module_tags_populate Message-ID: References: <20250409195448.3697351-1-tjmercier@google.com> <20250409140848.da67768ac1f5e79d7296de4d@linux-foundation.org> <20250409141131.bd67f6b19ea7e770dce40ac7@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Stat-Signature: jan8aakfomj7fxtaxrniqe9kret4ax63 X-Rspam-User: X-Rspamd-Queue-Id: 31F8540004 X-Rspamd-Server: rspam08 X-HE-Tag: 1744235860-189462 X-HE-Meta: U2FsdGVkX1/22IPgJhxI8SCIyM9IHnizBmqpLH07G5Gujy14prC+6D+QAFmQfLSBvYsswnj4GhgwaaaU4Ju7tj/9ZydzBP7bI0tpkrJRAyra2VuwQyNxhehi/FMjEDnHNQ/WAUgVTKwNNFvutpB96q+5VcdMcb2fndsmOMMu0gxn5sHA2Cnc4FS8PxejvfIPSyPi4fjdzQBNb9WS8IVPmMveMBX170gcRJH8GyIIZ+ClAhuSUhP30/VCZGqYJK2AmgXU4GVpFLaSjy5+l5pPBNXqpUNxm1wjTDlK8z9ApeMU1fx+eYhkKRiwjUBzdEEo9i4ocQmW4BAaczaTHot9MlKXfyyEmzADpcGOOUJKeARvUl1/OFGzXgcDvMcLbyzMyPOASyr8QqcrRy93KSrjUdjCqGe2755GVc+BXZ2q8t7F3WDgeguODNXXL9i2VlaSlUzPoC5syBfvJJBxCNG8toglMV4CQuXGLdkWu4fmgPTvlIACakQidxTLGcMECNz+uQS2jlCozBlFa3541lthde/9BiNjzPha+7YH55vECq7EY6fZWLR1RYdvdj5d9hFc3cI1kVyvl6BqAOSDJrKI8YP6Ny6etyRloGau5SrH78Mg5HFYXm7auqFIKR5EQXGvQAy6aUG/g8kzDYy1tbyARInNq2XR8SnlRO0PsvGetLrTz59GE8R09ihoag6ZNhiGHGPh1ttC7dPPtXvdISfwMTCYX1Iq0KcSf/sQjTMRv+JB5lcSGQlaKdSna/uXm+oR5+pWXdlSX2he2uv3mNmNun0a/LtITvGZb4d6kZFM5Ji0N3GkhMEmUeAVkrlIAO7ULgblTsfXoCjwbeXiGkmflMIP2hQpI6wxxKZqOrw70np/6m8Vh8g7Jb39gwtj33ZeYnY/nC0s0MSQu2T1uoHnidK8eviKIx0ySrFSYcSfSLriLjQjSgE4mXtxmjZ2DfKkOymqhtx0pWPa2j5rhbK 0bAy/aU6 zMbiUGYp1YuL8giRjb620Y7Pmb8EdoYmuTbaVTrICrZP/wOtYdEHRxhv8QMgJXvTSny+sikfBDvdwT3KneOo7cSPlo8NoRCB9an1zrRtZRY5h8XKycQU8HbMr563Pu4uapO+xIJBnWh4sgpzukwbEMjFvEI6qeQIDtnlVrvgDHkdwAZVzyA2bGR5S0dfAwV8Ag1NyMysyrv9UjaEr5zvZ6sOmhE0Vy+h/gE6KS2DNDDBMYoyqB1YZ9vazMI6Ne8nVvb+Oy+rbjbiszyO0GcLIOVUxUcyNBuBN5hnVkEsESQOZGPNvPlq+VizEOzmkzvNvBSmasOedK2gpy/KvlNzBn8QTkUZUcusvDYAM X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Apr 09, 2025 at 02:51:18PM -0700, T.J. Mercier wrote: > On Wed, Apr 9, 2025 at 2:11 PM Andrew Morton wrote: > > > > On Wed, 9 Apr 2025 14:08:48 -0700 Andrew Morton wrote: > > > > > On Wed, 9 Apr 2025 19:54:47 +0000 "T.J. Mercier" wrote: > > > > > > > alloc_pages_bulk_node may partially succeed and allocate fewer than the > > > > requested nr_pages. There are several conditions under which this can > > > > occur, but we have encountered the case where CONFIG_PAGE_OWNER is > > > > enabled causing all bulk allocations to always fallback to single page > > > > allocations due to commit 187ad460b841 ("mm/page_alloc: avoid page > > > > allocator recursion with pagesets.lock held"). > > > > > > > > Currently vm_module_tags_populate immediately fails when > > > > alloc_pages_bulk_node returns fewer than the requested number of pages. > > > > This patch causes vm_module_tags_populate to retry bulk allocations for > > > > the remaining memory instead. > > > > > > Please describe the userspace-visible runtime effects of this change. In a way > > > which permits a user who is experiencing some problem can recognize that this > > > patch will address that problem. > > > > > > ... > > > > > > Reported-by: Janghyuck Kim > > > > A Closes: link will presumably help with the above info. checkpatch > > now warns about the absence of a Closes: > > Hi Andrew, This was reported on our internal bug tracker so there is > no public link I can provide here. If it's better not to add a > Reported-by in this case, then I will do that in the future. In that case perhaps cut and paste the info from your internal bug tracker? Commit messages can include quite a bit more than just a short description of the commit, when it's relevant - e.g. I try to include the literal log of the oops being fixed when appropriate. It really helps when looking at things weeks or months later and trying to remember "ok, exactly what was that code path I need to watch out for?"