From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF483C7115C for ; Fri, 20 Jun 2025 17:19:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6D24E6B0088; Fri, 20 Jun 2025 13:19:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6A9706B008C; Fri, 20 Jun 2025 13:19:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5C47F6B0092; Fri, 20 Jun 2025 13:19:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 4B86F6B0088 for ; Fri, 20 Jun 2025 13:19:14 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id F042FBE91F for ; Fri, 20 Jun 2025 17:19:13 +0000 (UTC) X-FDA: 83576439786.21.9653BCE Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) by imf15.hostedemail.com (Postfix) with ESMTP id 54FA7A0005 for ; Fri, 20 Jun 2025 17:19:11 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Mj2f2Dth; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf15.hostedemail.com: domain of kirill.shutemov@linux.intel.com has no SPF policy when checking 198.175.65.12) smtp.mailfrom=kirill.shutemov@linux.intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750439952; a=rsa-sha256; cv=none; b=nLZ5gtBhPyuke7FY6IPfu3shdZEGGlvkcsMgI/vIMJdS/bCxmwF3U7k/cKX13riPjPDqP9 IRCVq07aB8xzW7eMd6XJnOJGclUTsYpjxXBtNL7VsmfW34au8m6OpbJLY9IBF9MN8kcydm yVCtYkCG10nEloqSPnT5wpGwwwSFfDs= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Mj2f2Dth; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf15.hostedemail.com: domain of kirill.shutemov@linux.intel.com has no SPF policy when checking 198.175.65.12) smtp.mailfrom=kirill.shutemov@linux.intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750439952; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Rl7aks4Cp0rZupOKcrSB0ZbPzaUsdFf6UPPpaoctdbE=; b=nEEpKyIpsepxp4TnO91OAU4rLD92JqI2KXHC2zFaD3Cuw7JZi7qdzePNbBklSAuaKuTv2y Y/pfYddVgvKI9aV8CIgiBbhuw+o8LpfvbfdnPtfJO2w9Nst0auHTvAImSIB5h0BvtvLal9 4NseRbp5scypyka9uzb+XxIZ9P/VAqA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1750439951; x=1781975951; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=dQDvIe8kEpS/KzWDhduzOi7rUZbsWr72XpJrQFUH1DE=; b=Mj2f2DthhAQdWTaYwhLYOKsQxfKyTKCuDyJCuvNLI0glBAHdMFp2Sege GSd04p+TDxjHLKVujctmtjxoJX7Yi8AhN0bj3G5vQuOcgQj0qqHimc2nO 0zpav09wdcTbfrd1gLHvthhNknMCNhMrud57X/xnUxDbzB1QU3Z6+rRI0 c4hkG0bA/NfcNQFBjlASeqSiz3Mi4GEjp1LV/P7FN4xsXK9AGdrjOSbym F3oWx3wmg12hhP48w0LCZswtb9DrsH2IpsGTH3f7smfM8p5Q9Qt6U6AD5 6HoDWh/cxT4RUPBdmM6NXdguWb6fQXHXiYEJL0XPtz6RnJlFjMamAaQsC Q==; X-CSE-ConnectionGUID: LxlPiwRyQvWqXZgouZwwqg== X-CSE-MsgGUID: wWtkAVnTQ2uQRBFpBuY6sA== X-IronPort-AV: E=McAfee;i="6800,10657,11469"; a="64147004" X-IronPort-AV: E=Sophos;i="6.16,252,1744095600"; d="scan'208";a="64147004" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jun 2025 10:19:09 -0700 X-CSE-ConnectionGUID: PEfm1VHzRRCCMeqjwOiyHg== X-CSE-MsgGUID: bAJr5kusQtOHInOrgsg17A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,252,1744095600"; d="scan'208";a="151179342" Received: from black.fi.intel.com ([10.237.72.28]) by orviesa007.jf.intel.com with ESMTP; 20 Jun 2025 10:18:59 -0700 Received: by black.fi.intel.com (Postfix, from userid 1000) id D0767109; Fri, 20 Jun 2025 20:18:56 +0300 (EEST) Date: Fri, 20 Jun 2025 20:18:56 +0300 From: "Kirill A. Shutemov" To: Dave Hansen Cc: Andy Lutomirski , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Peter Zijlstra , Ard Biesheuvel , "Paul E. McKenney" , Josh Poimboeuf , Xiongwei Song , Xin Li , "Mike Rapoport (IBM)" , Brijesh Singh , Michael Roth , Tony Luck , Alexey Kardashevskiy , Alexander Shishkin , Jonathan Corbet , Sohil Mehta , Ingo Molnar , Pawan Gupta , Daniel Sneddon , Kai Huang , Sandipan Das , Breno Leitao , Rick Edgecombe , Alexei Starovoitov , Hou Tao , Juergen Gross , Vegard Nossum , Kees Cook , Eric Biggers , Jason Gunthorpe , "Masami Hiramatsu (Google)" , Andrew Morton , Luis Chamberlain , Yuntao Wang , Rasmus Villemoes , Christophe Leroy , Tejun Heo , Changbin Du , Huang Shijie , Geert Uytterhoeven , Namhyung Kim , Arnaldo Carvalho de Melo , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCHv6 03/16] x86/alternatives: Disable LASS when patching kernel alternatives Message-ID: References: <20250620135325.3300848-1-kirill.shutemov@linux.intel.com> <20250620135325.3300848-4-kirill.shutemov@linux.intel.com> <15335559-bbb2-4da1-bbb9-878edf05437c@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <15335559-bbb2-4da1-bbb9-878edf05437c@intel.com> X-Rspam-User: X-Stat-Signature: 7gu1wqf64qmh67we7491gs5mjpopgamw X-Rspamd-Queue-Id: 54FA7A0005 X-Rspamd-Server: rspam02 X-HE-Tag: 1750439951-152025 X-HE-Meta: U2FsdGVkX1+5mI4pRnp7fmFoQp8HWMW3Jb1PzsdGGe6cYnCdONDDhBburoXw93VdVoYA7r77kyVsVoNTSgEjKIWsEZYuxYZ1g7fxKJF3EaKZOYHq2y6Z6Lv3s0tkJ2/4AG9QEtSJpCNCpR+Pgd/aHm182Qu8g3BGI+wNYfJ3CjbKf0nHIAVUROvhpsIQzwjJdULNhLrKQlckDFnNkpWPxHHjSabW20WvjYQUTV0S93UP3/naLMhlbLKtfpjiRrK2XxD90Ssa/hoOtA2LHKUNoZAMsDrQOztcaioaJaBmnWSmIyyspZGuefuvqI4v9ERNbuR9ycTag181Dufi0eSMyAO8Xwp/m7FhdJaoHIEBlRznUvrkEHOcrrhcPuHasmXZx3i/wvsiTMmkhdsUnoULytHEQMm7Mgel86IZrHf5uEEQg3Hic8vA4lLnprJaX4vXpEurbop1q36Ih9qkpMgGtRx4YKzBfN0eTG5dRiIz8it7EjBZEADvb8P3bLoPlluqQGjj5zLYgoqEvtb0fAIZFvqes5/u5zaUnFfwTY1sUWPFiwXMdYQaGs7DDDHmmaHdF8l7337DNm1toIlC8ZqRA/u8lEedEFRyzVHuJyyIkz/sFqlE88Qwaa7MxdafF1MltwB7YqFIj+ljzY3DGvItzS8uydE5gxpGMNY2lW6coXP3G+2ov51qAEocc4H1j+6GDip2/U+GXa05EDnC+jtBIxrVnHDc6n+rSWHJTFP9eBIyjmuw5KEXBIpLWEAJrXR6Dt5gxAHJRTBE4/a3TiPtVFS0jC7vX1Am+tSTgWVk0Hzkyq3IUMSVMA+nSbxzhIIDDb37ildE76H4oFckVRh7hB3FzLDjy2qrMFVSQJynBAEZeGd2XjTSzKtZ8bHk/aPwGMEHxtbJq+nnm6En/j0XNB0yWF36dwbd/FVhazw0Z0YdW1q+U7b80J522reexRx2O/1HdawEBJ2MwswoiSl Gk63uuSF rrpGAx2BO37et+Qpy7SXadT3SE69eL7PlObQ7kT8edwY9IBAz5CZXCb9sFKvcmqeO1mgpb6R7ekpqBU8YmjIJs6pr0um2V9Q2s7KtScmqE1OJmCQSpfQUUA2EsRthTAn3ZQTlzV4KqcLe/ak39IR4Vc/z4d3rcTmQCTdm2uIxzbl/EZOqNLqfKIPmtfoNwF3d0ZULvlzqv/EuwUruF8H7E2kmcMYNtCAO3k3hhGwHopgLsy41FaJaipZ/bLGdUGEjbXmcwVRDashVi2A= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jun 20, 2025 at 08:33:57AM -0700, Dave Hansen wrote: > On 6/20/25 06:53, Kirill A. Shutemov wrote: > > +/* > > + * poking_init() initializes the text poking address from the lower half of the > > + * address space. Relax LASS enforcement when accessing the poking address. > > + */ > > This does not read quite right. I think there's some unnecessary > confusiuon about initializing the address versus the contents. But > either way, how about: > > /* > * Text poking creates and uses a mapping in the lower half of the > * address space. Relax LASS enforcement when accessing the poking > * address. > */ Looks good. Will update, thanks! > > > static void text_poke_memset(void *dst, const void *src, size_t len) > > { > > int c = *(const int *)src; > > > > - memset(dst, c, len); > > + lass_stac(); > > + __inline_memset(dst, c, len); > > + lass_clac(); > > } > > Yeah, this patch small enough that lass_{stac,clac}() are definitely > misplaced in this series. Just move them into this patch. Okay, makes sense. -- Kiryl Shutsemau / Kirill A. Shutemov