From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C80EE77188 for ; Mon, 6 Jan 2025 12:14:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CAC896B0088; Mon, 6 Jan 2025 07:14:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C35BE6B0092; Mon, 6 Jan 2025 07:14:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AD61C6B0098; Mon, 6 Jan 2025 07:14:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 8CC956B0088 for ; Mon, 6 Jan 2025 07:14:14 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 3BDF0C0B4E for ; Mon, 6 Jan 2025 12:14:14 +0000 (UTC) X-FDA: 82976919228.13.21CCC72 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf12.hostedemail.com (Postfix) with ESMTP id 95E2640012 for ; Mon, 6 Jan 2025 12:14:12 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=caf2YQnR; spf=pass (imf12.hostedemail.com: domain of joel.granados@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=joel.granados@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736165652; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=byazoc2mDcOF+5em6oXGiEJxteM7A6dKjHPIV0ZIJE4=; b=hBqR8lmcianJqhZIAvUIsiLfLRCsi43WZYN/tJZyC+JKFYIHY5l50sbwGSerHKDBH1X/zj Bh7pFUnD+v49CpQfo80p/rDLSJe8SIkgtoIcXtvWClEPqZmNVkcvdXv95mvnV+NnVnAI15 WuX+Uk/kpT0YaZ9lUv+6WpyIxsYVlsY= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=caf2YQnR; spf=pass (imf12.hostedemail.com: domain of joel.granados@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=joel.granados@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736165652; a=rsa-sha256; cv=none; b=mbZnm+FMHYWg6i1aksePMB9acM4NuQtM0HesPCCg5J09duIo5paS7hcFJQNDgKyp3e05VD f+43DtpLFdSPA8lZXyTDEXwHJMNU9GivHiSLL+thz4UEFcOSQXkSfIWowcq+2JkzoIy6Ik 4kXgcqJeO1gBZ1cFajWBDPuu3aVWnMY= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id C81FBA41624; Mon, 6 Jan 2025 12:12:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D6915C4CED2; Mon, 6 Jan 2025 12:14:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1736165651; bh=pz/4rE/ts3Ms1eBIRCBDyTzHSq2kFw61Al1W77b1+dg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=caf2YQnR17OTGlwFLLjBw9d2kz0nAliuNzLceABBepOxnUXs4Aoplgb7rrbHGpq05 FtnokncqBowzsrN664XaoLyqWXQueddDWrGUQxyN0BuIc1F9rBcc6F/mOdhg/ImuOs pg5xJbkFsiPPlmof1Z6ESp3iZXyDNH9NSre+ShxekLPkfIRtFGM4holrpVO0NI4fJ2 9yewgWtusNUBnEVBkE1yK0fbuw7RGWnA3Id5rtlQJWGrLtVpth+paunYIeP7dCDU6e pZrODwBP58ZPZ89zcxiZkQVW+vfnPCzLGH6tRNLKJpFw6Ehq9sF1Wm4ZZAHvRaZD3s YusupTuuxzjtg== Date: Mon, 6 Jan 2025 13:14:06 +0100 From: Joel Granados To: yukaixiong Cc: Brian Gerst , akpm@linux-foundation.org, mcgrof@kernel.org, ysato@users.sourceforge.jp, dalias@libc.org, glaubitz@physik.fu-berlin.de, luto@kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz, kees@kernel.org, j.granados@samsung.com, willy@infradead.org, Liam.Howlett@oracle.com, vbabka@suse.cz, lorenzo.stoakes@oracle.com, trondmy@kernel.org, anna@kernel.org, chuck.lever@oracle.com, jlayton@kernel.org, neilb@suse.de, okorniev@redhat.com, Dai.Ngo@oracle.com, tom@talpey.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, paul@paul-moore.com, jmorris@namei.org, linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-nfs@vger.kernel.org, netdev@vger.kernel.org, linux-security-module@vger.kernel.org, dhowells@redhat.com, haifeng.xu@shopee.com, baolin.wang@linux.alibaba.com, shikemeng@huaweicloud.com, dchinner@redhat.com, bfoster@redhat.com, souravpanda@google.com, hannes@cmpxchg.org, rientjes@google.com, pasha.tatashin@soleen.com, david@redhat.com, ryan.roberts@arm.com, ying.huang@intel.com, yang@os.amperecomputing.com, zev@bewilderbeest.net, serge@hallyn.com, vegard.nossum@oracle.com, wangkefeng.wang@huawei.com Subject: Re: Re: [PATCH v4 -next 13/15] x86: vdso: move the sysctl to arch/x86/entry/vdso/vdso32-setup.c Message-ID: References: <20241228145746.2783627-1-yukaixiong@huawei.com> <20241228145746.2783627-14-yukaixiong@huawei.com> <3ed73b8d-1080-941b-ce6a-2d742b078193@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <3ed73b8d-1080-941b-ce6a-2d742b078193@huawei.com> X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 95E2640012 X-Rspam-User: X-Stat-Signature: hk6ypqdwbcxrz1shjjw9xqjcwsuroo3b X-HE-Tag: 1736165652-431409 X-HE-Meta: U2FsdGVkX18tLC8kcYvn4Wr0IiP57HRcPv3FWBcgcKzFZY5OqBl/pqCmL2o8CEKAAR+VPqEawHH7Oxbnumft4iIx8zYS5Zks1JZ5MRgbB8gUC5LslgbueJ7bYfl7ubUHkV+BpUT6s48CSqCEHundznCFryxjVR9w9Q+jqBchoEWV/J6niQtq5FkrFT9ph1C2dtimIyCvwXcSHF4sC2R2o639+LIiKBYL2OKlR7icdXUHRRnmSH+ZECrW3ImtlkH8M52I3Pm9aMhtjzVHhI8PKNCd4hXzTVad9VqLxPVbG3rpnIG4SeMVKoqG1P/11IGu/rkokvlBXXcIIqha/FYSRsJOdYr0S0CO5Y+TsNqBwHt/+cB6bntijlNgnuaqofuYBg83Vh2aa7Z3Tx+CbbEpkvO/Uz5BNNY2VqStsxOyVbiONXlpFkPyhikp1TwkEU0AOZOYXjXe3+sETkYu0ibzX84R0gMJm96973tpr+lHiFljLLVmDgwLrhIjz5rTSeoXQkLvXMUJtnLMJArQeIVsBfzi5LTvmbFNlj0jZxqTFxkOHZlHbq23NDfLKl6iC07kG77+cqG5FgjELzCB4AeXzrhfoAdcUIPjvDKxzQAPouMNSZMErrcB1ndGjJfVNLUaiwsnZ/vcvU8wMsldVjXc/q6VdsmlnydD9r0RsxKVuBmY97C9pSszw7iuAlqVzaxONmmUuOoTuL8egRKHI7LDpHkmBpVBeHrxiRd5N1qeHrvu3x4X/vfHWp5VTkAtjK6pl5Q7+9q+w9Gje41Z8t/DqdVFASN0QocuOKWNrSIzmRCuG1YxyfWFkjEsdXYKlGvFChkvmSVDlVhv0C9clPW3hjPdp/4xJUguGONAuBbIok8pRqkgsgmwvkw6j70mCkFKnO+03mo4At1l8vBz4bSSPK5SpF0iS8DwmGVAjxxfZA8NU6QqBSDsTwJj98zuTixceaPST4hNOl26+BU7F82 VpdKf7v1 6GmMem52Ud8JCZnbv24gWWfLj6HUfaIZ9r7ccZ+m37SORN3ttnvQK+Lx8C+hImI1sN3ZbV/idAlaZVUVb0SlkEEq92mp6QPtyEZ2evYeM78Y4/5CMb5lFmdfVjw4jqrAm8/GkOSgYBEvk8D07WfguNzvwqrqk2pG33V509QZpIUo58322LoggMf696d+5HGzyCLmesH2cy4txleQ18xfObNKsyOwKKjLshtvw82sgffmXfc4OcstMpourhxzmGnXsmv3NSiIgT7Qb9Qmo335LstFrAkuVjeoptArI+XQVfCb2aSc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Dec 30, 2024 at 02:43:12PM +0800, yukaixiong wrote: > > > On 2024/12/30 7:05, Brian Gerst wrote: > > On Sat, Dec 28, 2024 at 10:17 AM Kaixiong Yu wrote: ... > >> return 0; > >> } > >> __initcall(ia32_binfmt_init); > >> #endif /* CONFIG_SYSCTL */ > >> > >> -#endif /* CONFIG_X86_64 */ > > > > Brian Gerst > > . > Hello all； > > I want to confirm that I should send a new patch series, such as "PATCH > v5 -next"， or just modify this patch by > "git send-email -in-reply-to xxxxx"，or the maintainer will fix this issue ? There are still some outstanding comments (besides this one) to the series that you must address. This is what I propose: 1. Address the outstanding feedback in the series 2. Wait a couple of more days to see if you get more feedback 3. For your next versions, please include the tags from previous reviews; I see that you have not added Lorenzo's reviewed by for "[PATCH v4 -next 06/15] mm: mmap: move sysctl to mm/mmap.c" and "[PATCH v4 -next 08/15] mm: nommu: move sysctl to mm/nommu.c" 4. Once you have addresses all the issues, Send a V5. If there are still issues with this version, then we can cherry-pick the patches that are already reviewed into upstream and continue working on the ones with issues. Best -- Joel Granados