From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6082AC021B2 for ; Tue, 25 Feb 2025 04:29:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EF0006B0085; Mon, 24 Feb 2025 23:29:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E9FFA280001; Mon, 24 Feb 2025 23:29:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D679D6B0089; Mon, 24 Feb 2025 23:29:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id B74786B0085 for ; Mon, 24 Feb 2025 23:29:58 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 6F88612086C for ; Tue, 25 Feb 2025 04:29:58 +0000 (UTC) X-FDA: 83157189276.09.CEA1F6F Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by imf20.hostedemail.com (Postfix) with ESMTP id 8D3C51C0011 for ; Tue, 25 Feb 2025 04:29:56 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=FkRjxZmD; spf=pass (imf20.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.173 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740457796; a=rsa-sha256; cv=none; b=WtrwFLlSFDIBhJc5EHYvm3RLuv265M1889IIcxw6qlxIRB5bQ9FV08no/eLbesbSzGaXj5 WyXmF7MwXq8TrXBcHX7xmk/+68JbIULKv+gSZ6H8b/IFldJsGGb2+tzWxsEbHoKXrL1idx CU327ZM0F5nuuVs9CMiBNPHsgFFsNSE= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=FkRjxZmD; spf=pass (imf20.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.173 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740457796; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zXXlNPUUBPiKZkubtIkuAxkw7YXjV7aLOsj4Haw9B1U=; b=l2ZJgEdNdYI1992pvqUnTSd1Z5x4+cY68RivOsuz43eHHE/CLnJoTVTh2LLEqiaL/lTBCt y0Thg8TZj5hfhszEkY4dSbReapzmlIAEHdz619SGylwVcS6i33zaGm/HptRifbSvZynwJm dMYKFjtVL3P0usOY6LdowqrkznqlMeE= Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-220e6028214so111646585ad.0 for ; Mon, 24 Feb 2025 20:29:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1740457795; x=1741062595; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=zXXlNPUUBPiKZkubtIkuAxkw7YXjV7aLOsj4Haw9B1U=; b=FkRjxZmDkaSsemFYak3xQxTT851TEKk+n2G3NodrPjnUyxTmZ//tE+xCAszMIZe4h9 4BA76SO0k7B8lIF+t1Jf21EwLr4BRhloa3SK8UPyZa3EMBiZ/qORQxX1oCnTf0kAtahQ HssqlPsuUlgJpq87BqYWh64y17Zbm8M2NPcDQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740457795; x=1741062595; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=zXXlNPUUBPiKZkubtIkuAxkw7YXjV7aLOsj4Haw9B1U=; b=QsMVu9Axm3CYhkwQKonXEiB7KJjdqqAGk1ek/HGIn27gw4w70ExBuKQntWzh8usH5z y3DExv42VRnzAY3iuS8wNi3EH7NoZKfS9+tCKf2fTlMjlHauukYZE3ENDTQbb4nFAxD/ FwGTv2H/TZ2/vCDSM1uPsoWHEN/Le9Dnah5z57fhctZZRsVpQwi7irrh6HBRy1HKEgvs NfeTaCcRa83AW3ELihg5s375ryktIQktujLih/mzRZatZS21EbF/Sofp0jwH2UoaOelc YXbnU00FwzVECYxmAcmH1MOj8l4rCw67tBkrlKjuW6x1DzbrQz7IXzJDA2nyW7WUeq8p qHtg== X-Forwarded-Encrypted: i=1; AJvYcCULODkdmHZ40sokOzdJsg+ic8bh8xIgD8mnUwPfspEn2fkAP1jW27EGjl4uRBuHmkrIqzNarXsv4Q==@kvack.org X-Gm-Message-State: AOJu0YwG92iAPXRtjasu1GSDocSPw155kQpaZRykfinrb+xCRekmv9IA d6/NQDm/AvGNeOs8x8ZjMDGCfmVMj993F6Y9L4QHY744q8X8kVCJtJ/lqOc/JQ== X-Gm-Gg: ASbGncuYhzekI6Q2BRT5+Fc8FCeY0KiymOWqrpZZyH6EgBLDUS+AnBsyPH8PjGniVZE wlUvAxYIs4A8hns6ea3uD9kHvdvYZbMqpR7cpqkdyjkfSi5fjjd1nzGnp+Ea+zQea1Jxc53gJq5 QLdb4QnYV1elGpNYv99w4Ok1DsXTzvobbholgGXwXM751TBkhHvSXMWKN0b9SAQwyk209s2o5ei /Z1OS1gyy5opebBQ6PJh9Qy3kjk36FWWH3Mxu7vwmHktjMUYvO2YROiYPL4ZcPED2bgMD5N7a1y ck8DRBPPno4OfkbbLf8qePQvHNLk+A== X-Google-Smtp-Source: AGHT+IHUMtzZMx8wOAQvNxvT5VlJCxbnuMeKFBQKuzIVUYr4CRGvYpaLooVV7rMLU8mEiyK7DpOnPQ== X-Received: by 2002:a05:6a00:14c1:b0:730:8e97:bd76 with SMTP id d2e1a72fcca58-73426cb143cmr21793645b3a.9.1740457795473; Mon, 24 Feb 2025 20:29:55 -0800 (PST) Received: from google.com ([2401:fa00:8f:203:e27d:842a:e0d1:29c4]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7347a6f761fsm488585b3a.47.2025.02.24.20.29.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Feb 2025 20:29:55 -0800 (PST) Date: Tue, 25 Feb 2025 13:29:49 +0900 From: Sergey Senozhatsky To: Sebastian Andrzej Siewior Cc: Sergey Senozhatsky , Andrew Morton , Yosry Ahmed , Hillf Danton , Kairui Song , Minchan Kim , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v8 12/17] zsmalloc: introduce new object mapping API Message-ID: References: <20250221222958.2225035-1-senozhatsky@chromium.org> <20250221222958.2225035-13-senozhatsky@chromium.org> <20250224090154.7Xlsipmu@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250224090154.7Xlsipmu@linutronix.de> X-Stat-Signature: 346c17hba1oqjiqs7j6ewr8bgh3wdtnq X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 8D3C51C0011 X-Rspam-User: X-HE-Tag: 1740457796-34692 X-HE-Meta: U2FsdGVkX18dWchkY1RRFZUcG8ggJ8LVeVNeoqlOt90pZNDG46kzlVQQJ5/waAJ9hYH4EvcxmiV6UaIdBsf+rcUrg0o4qOqblmjeVqKAhCRrZIJEDiCyQ9tKzVWdVMuKfd+9HwqVogNl45xzmGlGaMPNuxrb0pxizqU0mJVfSHGVI9jUF8O48aH0XJCCARYDWb4WBV1dErdSdKL7Qiq9aSMNIHCg2ELqCWNm5YhZdrfHnObwUyvp+XsL911QZ01ZDM5RSICTkkjiXq1bVZ+fzVkFTyw+VGDSmaDTXmwSn2QNWdm0+posd/1Wskytm+pMVNCDF3okqKAGzaFiYnBap9eLuqNVrhwqgJciaQYIP5G9CtOYdAj8R2gNKHe/eqLkK9N3Bl1HIPv6CQfSi3jXYnyaFJiieRlcoF6X3vBRhH43ugyK+xLDcQbDkmUk8gDLKCSZhGy0R8RXjZc4H2wOaM6dzYTgtYQWgtDE3FtONqnurmyxdxvl1elOW22Vkds8q4X9IB0vCwSCQeZyP+TLHSySNF+b77HTMsPZfXQnY0Yeo5RbV7ZAtg8OQJpDQOK2wN6wNi7qEoABEovUdXP65xO3kDtsV8LGDoYoi+/i7xdNfBt+jlHbqxrVGPTcA08+xxQFISdJlPUtR1SjBhc5JWh6TDN0qfx5Tgs0f1eYJD9szDwd+6kkHstRMVdVE2wTiSdDIHK2HnDOQnosNDiDXUXZzqI0w+RS2kaiAENQ0GQgc7S/MmKOdTXSK8KEyHD9Mm4LHnZUWJqlIYwmQ+yHJJAoZEScOV1iyM469o8Xa4GdJ+jOw05+25ngP8G9EdJiaS/gGvW1bdB9MO6GDrFv/NQmjtCOCkJVvaoO/mElaqOlqaIXmn47UNy6496QoTJnXa9yJiE2Kut38wZfgtMSF0Xwm3d4t2aNapBRQDLCS/X28OeCgaDxJ8bWK4YeGZ2faB6mQLzMVSCWurwDNZZ uETqbinC qze/LX2cjJvX6jVAEMhL8kf4eVk+uwjIfP/TszkjZlyLpNt0VvDT7esex29dE7EKDMLmNomQqDvXipRqEtBn1wdOT+bAbNBOfc2gtTSk1d54K/fVNdDhuyjGtY8o06+BOAZkQUZCiHVwSlgWiRVQ30oUG/KCy0XFy9wLTmF5Olq4cOoQRQKH3KA4TzM9vEDqo58zzn4xKQ0l0GqfvEA+38C11l4DArZjaeayoze3ECTiq97LJHQJGykzrR/iWS6gEdUfmWal9gLC5ldzDGkpjYndj1+dfGX5g8B0/6J2qJriuC28E9girC9QrRH8IWsD2uejxUPRYPgLCY8GyDrn1GdvzY+tUd7/FF+8PyQm8oN4crjWfwy2iPBCaGMHfxyBjjgquGIhviRHRG8U00tNQEW95m5zp7QGdK9hBO4a2hrBFhXAi+DACi1uxzZbo8PeXCMB5mOf9Y+2f8BgwLhDdObhMK7vUYjfHpR57Oe1ARk5zAYlA5JN0Cg4/KcKwyvpUFslBRF6oG9Cug89djR+rFWiNEg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000008, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On (25/02/24 10:01), Sebastian Andrzej Siewior wrote: > Date: Mon, 24 Feb 2025 10:01:54 +0100 > From: Sebastian Andrzej Siewior > To: Sergey Senozhatsky > Cc: Andrew Morton , Yosry Ahmed > , Hillf Danton , Kairui Song > , Minchan Kim , linux-mm@kvack.org, > linux-kernel@vger.kernel.org > Subject: Re: [PATCH v8 12/17] zsmalloc: introduce new object mapping API > Message-ID: <20250224090154.7Xlsipmu@linutronix.de> > > On 2025-02-22 07:25:43 [+0900], Sergey Senozhatsky wrote: > > index 03710d71d022..1288a4120855 100644 > > --- a/mm/zsmalloc.c > > +++ b/mm/zsmalloc.c > > @@ -1377,6 +1377,135 @@ void zs_unmap_object(struct zs_pool *pool, unsigned long handle) > > } > > EXPORT_SYMBOL_GPL(zs_unmap_object); > > > > +void *zs_obj_read_begin(struct zs_pool *pool, unsigned long handle, > > + void *local_copy) > > +{ > > + struct zspage *zspage; > > + struct zpdesc *zpdesc; > > + unsigned long obj, off; > > + unsigned int obj_idx; > > + struct size_class *class; > > + void *addr; > > + > > + WARN_ON(in_interrupt()); > > This macro is deprecated. Could you come up with something else like > !in_task() if needed? This was derived from the current zsmalloc object mapping API BUG_ON(in_interrupt()); but converted from BUG_ON() to WARN_ON(). I guess I can drop entirely tho.