linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Sergey Senozhatsky <senozhatsky@chromium.org>,
	 Andrew Morton <akpm@linux-foundation.org>,
	Yosry Ahmed <yosry.ahmed@linux.dev>,
	 Hillf Danton <hdanton@sina.com>, Kairui Song <ryncsn@gmail.com>,
	Minchan Kim <minchan@kernel.org>,
	 linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v8 12/17] zsmalloc: introduce new object mapping API
Date: Tue, 25 Feb 2025 13:29:49 +0900	[thread overview]
Message-ID: <k3sjohhgao4zlu7nqjrwrbajctz65dtzg2aip42vjygpaiyg7r@hjwsb54qbjm2> (raw)
In-Reply-To: <20250224090154.7Xlsipmu@linutronix.de>

On (25/02/24 10:01), Sebastian Andrzej Siewior wrote:
> Date: Mon, 24 Feb 2025 10:01:54 +0100
> From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> To: Sergey Senozhatsky <senozhatsky@chromium.org>
> Cc: Andrew Morton <akpm@linux-foundation.org>,  Yosry Ahmed
>  <yosry.ahmed@linux.dev>, Hillf Danton <hdanton@sina.com>, Kairui Song
>  <ryncsn@gmail.com>,  Minchan Kim <minchan@kernel.org>, linux-mm@kvack.org,
>  linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v8 12/17] zsmalloc: introduce new object mapping API
> Message-ID: <20250224090154.7Xlsipmu@linutronix.de>
> 
> On 2025-02-22 07:25:43 [+0900], Sergey Senozhatsky wrote:
> > index 03710d71d022..1288a4120855 100644
> > --- a/mm/zsmalloc.c
> > +++ b/mm/zsmalloc.c
> > @@ -1377,6 +1377,135 @@ void zs_unmap_object(struct zs_pool *pool, unsigned long handle)
> >  }
> >  EXPORT_SYMBOL_GPL(zs_unmap_object);
> >  
> > +void *zs_obj_read_begin(struct zs_pool *pool, unsigned long handle,
> > +			void *local_copy)
> > +{
> > +	struct zspage *zspage;
> > +	struct zpdesc *zpdesc;
> > +	unsigned long obj, off;
> > +	unsigned int obj_idx;
> > +	struct size_class *class;
> > +	void *addr;
> > +
> > +	WARN_ON(in_interrupt());
> 
> This macro is deprecated. Could you come up with something else like
> !in_task() if needed?

This was derived from the current zsmalloc object mapping API

	BUG_ON(in_interrupt());

but converted from BUG_ON() to WARN_ON().  I guess I can drop
entirely tho.


  reply	other threads:[~2025-02-25  4:29 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-21 22:25 [PATCH v8 00/17] zsmalloc/zram: there be preemption Sergey Senozhatsky
2025-02-21 22:25 ` [PATCH v8 01/17] zram: sleepable entry locking Sergey Senozhatsky
2025-02-24  8:19   ` Sebastian Andrzej Siewior
2025-02-25  4:51     ` Sergey Senozhatsky
2025-02-27 12:05       ` Sebastian Andrzej Siewior
2025-02-27 12:42         ` Sergey Senozhatsky
2025-02-27 13:04           ` Sergey Senozhatsky
2025-02-27 13:12             ` Sebastian Andrzej Siewior
2025-02-27 13:20               ` Sergey Senozhatsky
2025-02-21 22:25 ` [PATCH v8 02/17] zram: permit preemption with active compression stream Sergey Senozhatsky
2025-02-21 22:25 ` [PATCH v8 03/17] zram: remove unused crypto include Sergey Senozhatsky
2025-02-21 22:25 ` [PATCH v8 04/17] zram: remove max_comp_streams device attr Sergey Senozhatsky
2025-02-21 22:25 ` [PATCH v8 05/17] zram: remove second stage of handle allocation Sergey Senozhatsky
2025-02-21 22:25 ` [PATCH v8 06/17] zram: remove writestall zram_stats member Sergey Senozhatsky
2025-02-21 22:25 ` [PATCH v8 07/17] zram: limit max recompress prio to num_active_comps Sergey Senozhatsky
2025-02-21 22:25 ` [PATCH v8 08/17] zram: filter out recomp targets based on priority Sergey Senozhatsky
2025-02-21 22:25 ` [PATCH v8 09/17] zram: rework recompression loop Sergey Senozhatsky
2025-02-21 22:25 ` [PATCH v8 10/17] zsmalloc: rename pool lock Sergey Senozhatsky
2025-02-21 22:25 ` [PATCH v8 11/17] zsmalloc: make zspage lock preemptible Sergey Senozhatsky
2025-02-24  8:59   ` Sebastian Andrzej Siewior
2025-02-25  4:28     ` Sergey Senozhatsky
2025-02-21 22:25 ` [PATCH v8 12/17] zsmalloc: introduce new object mapping API Sergey Senozhatsky
2025-02-24  9:01   ` Sebastian Andrzej Siewior
2025-02-25  4:29     ` Sergey Senozhatsky [this message]
2025-02-21 22:25 ` [PATCH v8 13/17] zram: switch to new zsmalloc " Sergey Senozhatsky
2025-02-21 22:25 ` [PATCH v8 14/17] zram: permit reclaim in zstd custom allocator Sergey Senozhatsky
2025-02-24  9:10   ` Sebastian Andrzej Siewior
2025-02-25  4:42     ` Sergey Senozhatsky
2025-02-26  3:01       ` Sergey Senozhatsky
2025-02-27 13:19       ` Sebastian Andrzej Siewior
2025-02-21 22:25 ` [PATCH v8 15/17] zram: do not leak page on recompress_store error path Sergey Senozhatsky
2025-02-21 22:25 ` [PATCH v8 16/17] zram: do not leak page on writeback_store " Sergey Senozhatsky
2025-02-21 22:25 ` [PATCH v8 17/17] zram: add might_sleep to zcomp API Sergey Senozhatsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=k3sjohhgao4zlu7nqjrwrbajctz65dtzg2aip42vjygpaiyg7r@hjwsb54qbjm2 \
    --to=senozhatsky@chromium.org \
    --cc=akpm@linux-foundation.org \
    --cc=bigeasy@linutronix.de \
    --cc=hdanton@sina.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=minchan@kernel.org \
    --cc=ryncsn@gmail.com \
    --cc=yosry.ahmed@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox