From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14F83C6FD1F for ; Tue, 26 Mar 2024 15:11:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8C1006B009C; Tue, 26 Mar 2024 11:11:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 871396B00A3; Tue, 26 Mar 2024 11:11:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 760846B00A4; Tue, 26 Mar 2024 11:11:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 65EA66B009C for ; Tue, 26 Mar 2024 11:11:43 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 2E1C2804B5 for ; Tue, 26 Mar 2024 15:11:43 +0000 (UTC) X-FDA: 81939529686.17.C4CE6D6 Received: from mout-p-102.mailbox.org (mout-p-102.mailbox.org [80.241.56.152]) by imf29.hostedemail.com (Postfix) with ESMTP id 28071120027 for ; Tue, 26 Mar 2024 15:11:40 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b=ckx1i64Z; dmarc=pass (policy=quarantine) header.from=pankajraghav.com; spf=pass (imf29.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.152 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711465901; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3Nr5pbxteCfHgzj/i1W+/blhYMSR+J/eweuH6yYi/Aw=; b=OWRnT5BFSGVSVLSOn0rOqcosDPt7VYdRfbstEdsZzwXoDPZwEAOlucwbD48YVieM7G9JYg czSVm6vCInd/NXH/h2APocLcw29wI99WN9kNCKdhh+soWV3UPRequvFQMcGA1GkD+wU300 ALlhbamAGWqUlpEEWzfi8ZRtbw7nxek= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b=ckx1i64Z; dmarc=pass (policy=quarantine) header.from=pankajraghav.com; spf=pass (imf29.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.152 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711465901; a=rsa-sha256; cv=none; b=sb4N8Z6HxGaSwTnOqMPQ/y+Tz3X1bW6ITvuYZeGGIDsQvpMs4p1NdXCuivRqu8h3I1UMD5 vA5dOwDffK8FF09XoSp7mldFZvtQsJeR4TxRnMbSje2D0iizs3VzWXLs6HJWV1oqZBqIiZ sRS1e8ChVzY1/4PkTmfgHMA/kz4Jh7A= Received: from smtp202.mailbox.org (smtp202.mailbox.org [IPv6:2001:67c:2050:b231:465::202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-102.mailbox.org (Postfix) with ESMTPS id 4V3tYj0QYqz9sqM; Tue, 26 Mar 2024 16:11:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pankajraghav.com; s=MBO0001; t=1711465897; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3Nr5pbxteCfHgzj/i1W+/blhYMSR+J/eweuH6yYi/Aw=; b=ckx1i64ZvOdoSlf/gp1LfF6YwXSO3PDpqi2rnltX3PTl7K8dZc83b+H262KO0u8DvboKq3 eM5tH0MilsVxjvMhzhWRTp87YG/yvg7MZuAy2A/2KXBcTHJv9fLjURlfu5WhYzbl/sQZi5 8axc0iDbBul5pMoK0AYCN1DTKc4VDTxvYxQTf3jtFeqtOTWMugNH6btgtA8KZg80nz83kj 2nL5Hawm8YGEwsg9qDH6ITS8VVbSFRofzZvr89iT/Jy+V7TAK9EgioV5IR8V29desK0FXA 4LU6yzkA4OxIkBWQaX68XBpwc9IKaAEiRrHUKkXE8y04TB+bDTg9iy/Ul2/2qA== Date: Tue, 26 Mar 2024 16:11:33 +0100 From: "Pankaj Raghav (Samsung)" To: Matthew Wilcox Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, gost.dev@samsung.com, chandan.babu@oracle.com, hare@suse.de, mcgrof@kernel.org, djwong@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, david@fromorbit.com, akpm@linux-foundation.org, Pankaj Raghav Subject: Re: [PATCH v3 04/11] readahead: rework loop in page_cache_ra_unbounded() Message-ID: References: <20240313170253.2324812-1-kernel@pankajraghav.com> <20240313170253.2324812-5-kernel@pankajraghav.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 28071120027 X-Stat-Signature: tpaiui5zcsrtbbxwi38a1gxk3ok9qrr4 X-HE-Tag: 1711465900-225104 X-HE-Meta: U2FsdGVkX19jwhsBhD2iKgjQFGYlsyveH9BgsFoTi1qLxY370L8KsM8smSIbDsOtM/MiVv8HaJXFyxa9XjGucGx9HzOZmK3zTQOuWI99Hf8M1AYdRZG/Rj2e8K6OByqdAzXEU41G5oj/IzWpCbADZ6xl3CPJcnrqnOPlijWZ5KJ7nHvqJCMi9KjSzBok9UhIRec1WEufP3oq1tcnlf5ZLD0eBIrAoFNFjFrblg/yn4bscD4CREkmLU3nocJn39zIt7O+sODjO12RPsGR0RLMJCeCz62G9uE0PmJ42F9r7EBp63VI8xe5yEnS++zOH4XnFFQ3PdLF/9ngXmD1oz0l1bv1SC1g9iSVnCAzPUfyre6ULSPR5x6ciy+0F5r1fFCGopNHgy1gPOymvIn7ahihNjNFazl01UTUtBiByKymTjvlWWQ8TYV6mnr6S8dVqSCu0NoCB7NNj8iPx/nYkYM5drsYCiiJgFtoLQ21k4fsonKSzWpynfIoYdLGtskRhP0BtkxovXPbrJn+YXYz3wcYm8KkLLaQGTl+btbI5ZZvgk7BvGTwTd4g2TU4mVfM1QKqxAVa50U14TK5fmuFFHBTlG+T6HN/7AYdj7A8ALhUkEif3BCu8YN02yuyfmHGZsKGcJGEGh1CdKTslsQNOHQSYpOnZQf3zui77A+Vg3B65z8IgI3R2VCVCYG/b1bJmCi4biDgYgsZf9kyPCE9SJUriaTE2x0XwlO6WFshphtgTqP27BH/Kxg/0y9kYkez/oXr0okkbgy77VtonGT0GbRVbtZBtb1MZtxLhlY3VBaWUoiZNZfosPoDUqZdCgPwf7JdZw6i4mKaUjuLOlLrt8hq/R6Y3NYMFIyjf7F48ttu2wYM4F39AN0vHC6taI7tmmJzNjFZithRLGf9b7CHgxxAXPk0S2eej4J+q1Psq14V7IIv39E+iEb6A7hqYfYjbHWwoCgRgOyxVpS71f7tkzl lWlcXPn5 TRWFwlEKu65/hOxs0G5D3HYmTu8a7FX5i6pwCKnNJai/Vwe/Umt5kyWhPH0TYuq7CdSqO4vVxGSAMrdccg2+zfZ3n7kG2zMQkutoq0f6j4bJp9pXsWkkQ+SGaoR7Dm0scPsrLwB9vQcgKWaMMyAl5WQ1QvMgolADEmq42WQ+IrVJh29ryK2yniGepAlBnlNZuSPMqW1/ZblE4Bma+gQAxDeA8NsSMTT6M1rlZLHE6baD0XVpvx9OsbZEurw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Mar 25, 2024 at 06:41:01PM +0000, Matthew Wilcox wrote: > On Wed, Mar 13, 2024 at 06:02:46PM +0100, Pankaj Raghav (Samsung) wrote: > > @@ -239,8 +239,8 @@ void page_cache_ra_unbounded(struct readahead_control *ractl, > > * not worth getting one just for that. > > */ > > read_pages(ractl); > > - ractl->_index++; > > - i = ractl->_index + ractl->_nr_pages - index - 1; > > + ractl->_index += folio_nr_pages(folio); > > + i = ractl->_index + ractl->_nr_pages - index; > > continue; > > } > > > > @@ -252,13 +252,14 @@ void page_cache_ra_unbounded(struct readahead_control *ractl, > > folio_put(folio); > > read_pages(ractl); > > ractl->_index++; > > - i = ractl->_index + ractl->_nr_pages - index - 1; > > + i = ractl->_index + ractl->_nr_pages - index; > > continue; > > } > > You changed index++ in the first hunk, but not the second hunk. Is that > intentional? After having some back and forth with Hannes, I see where the confusion is coming from. I intended this to be a non-functional change that helps with adding min_order support later. As this is a non-functional change, I will move this patch to be at the start of the series as preparation patches before we start adding min_order helpers and support. -- Pankaj