From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13CD4D597C4 for ; Wed, 13 Nov 2024 01:44:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6E18C6B0088; Tue, 12 Nov 2024 20:44:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 66B2D6B00B5; Tue, 12 Nov 2024 20:44:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 448116B00B7; Tue, 12 Nov 2024 20:44:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 22E176B0088 for ; Tue, 12 Nov 2024 20:44:49 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 91453160696 for ; Wed, 13 Nov 2024 01:44:48 +0000 (UTC) X-FDA: 82779375714.13.1027082 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf30.hostedemail.com (Postfix) with ESMTP id 356B880003 for ; Wed, 13 Nov 2024 01:43:24 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=D2poVj5a; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=GJWkgu4T; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf30.hostedemail.com: domain of liam.howlett@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=liam.howlett@oracle.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1731462108; a=rsa-sha256; cv=pass; b=yqLWAI74RvWkn7diPKqxoptZGHOT/4YYslQD1Lecayi4crY5yx91r5drf0NY8T9S3K1DdW Yf1h1jGGUj0HA9iX74WKFvKbXRFIC2sD24/VNyXp65M8019fY7v9pUIE5YLP0Y8/5gfNBX 0ZxQn9YYwEsyi6YCmZ2PHM3P5QtdUsY= ARC-Authentication-Results: i=2; imf30.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=D2poVj5a; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=GJWkgu4T; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf30.hostedemail.com: domain of liam.howlett@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=liam.howlett@oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731462108; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2k+GBdS1dNbJs9TK83+cSSX+tCqmXtUAxBxS5IC6XoQ=; b=PGhktxaAx0y4s887LM9o4LsqZ7r/t6V5OZzp676ilEvncAi9A9WRTquUDD0U2ZIjtd8s/h N56NmSPktDDph9KwbSBmtUBMsCjxTg3hy5YSAWsdtEyWJU/og63bW2DsGQFcf1Bttr2W+o YYdmJQGoKCtUskUV04E4r2KY+ZZUdV8= Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4ACN1Wo6026428; Wed, 13 Nov 2024 01:44:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=corp-2023-11-20; bh=2k+GBdS1dNbJs9TK83 +cSSX+tCqmXtUAxBxS5IC6XoQ=; b=D2poVj5aT0OXxAkf1dRilhdK7GHAA2lNAJ jd4Zu0JknMbBibz+zbj5idWH4htMAX2SDq559R2GTDrJDa8pb4PDF9GYDDRvjX+P QCXZ+7Jks0Xp8iPrtwtnNRImvIy2Cr+Yx9yu8bC0/GKuDlrPfxhdhsyeKfnivQti bkmfNCpUBRsL8uEP1b7u2GdgEDJoG0BKmmRgtPj52WaVMwCdUwox+bCFLGahRIlc yBatdnye3flNq5h9oGNYoX5tySkUrpjMHxQGPNd/WgGb5xDx1ybM0pzBdtC9LA/W cVOkc0nwwtAtn6XMvJV9pFoCOySPdUspa8KTDllRd65nHbDbX7YQ== Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 42t0mbdtx0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 13 Nov 2024 01:44:42 +0000 (GMT) Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 4ACNA70I005655; Wed, 13 Nov 2024 01:44:41 GMT Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2170.outbound.protection.outlook.com [104.47.55.170]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 42sx68y9aa-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 13 Nov 2024 01:44:41 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=NDkom72eY2KugvbVwZQSlL8fJZV5wokaz7DpHgrNarogwzQhbXQhos+YxqHjgRMlRth/kQGbDg7dvn7d3H42lW8hlJDTbnMFECiFFIFTnkHjtzAWEl3ym2HoG36qbpX2YOH05D6j7YnFtYGJXbNhXSbNpGFSNUgFldd9TyLWdZsMQscFEWF6M1alFHYmmu4yC+JttwP9Ti6qMW9tUZ8Jcevk9GpbbCFhT1Z1YWihcbg/F3m6DUkq+x2fLAYNXjeSFDMcxX/ANgYgsHAqv5+P2mznAdppQMTxsUKigXBP9x3OHdd3lAQDJU39IBpd8Oz0jr9Sq722GNAtEYas2m57Hg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2k+GBdS1dNbJs9TK83+cSSX+tCqmXtUAxBxS5IC6XoQ=; b=ci5O5gVK2lJk0H0BOSI/pgNQWY1mw93A/u5egDyiNWntpSQ9DHj7fZXY1lrNjhrWm4ADUM7LUmjzfFGuNtyNveZi9n3+ntBCVpXcnJ1blkA1yEnceQymj9iXxB3w/wSLtn32/rWlkFMg3KzxZtJ5McE/fRCJlKO9tlaKp2JtsPXn0nQMAk41hTd6H5EK0T74S00TUwnVq0z20BulVNk6K76vwbriYs4Gj7WkBXn7uarO0LHyqmVLmTeEt6XMaDwgWRA9oJR5wgjh8jIVpKFAaeFjLHTTyRuC5tUI4z6SGqq2JmOsOjEsIyRmKL/Gn83dBKwqf3Fi/74kDevYPONF+A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2k+GBdS1dNbJs9TK83+cSSX+tCqmXtUAxBxS5IC6XoQ=; b=GJWkgu4TS82nLZpXPlGJVYqMvXrR6bIt5+UR1R2jZuWSxiZLYIzaHv2cLg8m9cFSXWBqjXUNPDsAWQ0vv4iGeFCAJiaAQyeE6A+aJ8JRUMm3CoR24g+e3/gJDVdxND3aQGYIVEzqXIf04e3FwGFK2ZMcL4UB2baSNM0IplxJgIg= Received: from PH0PR10MB5777.namprd10.prod.outlook.com (2603:10b6:510:128::16) by CH3PR10MB7576.namprd10.prod.outlook.com (2603:10b6:610:17d::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8137.29; Wed, 13 Nov 2024 01:44:39 +0000 Received: from PH0PR10MB5777.namprd10.prod.outlook.com ([fe80::75a8:21cc:f343:f68c]) by PH0PR10MB5777.namprd10.prod.outlook.com ([fe80::75a8:21cc:f343:f68c%6]) with mapi id 15.20.8137.027; Wed, 13 Nov 2024 01:44:39 +0000 Date: Tue, 12 Nov 2024 20:44:36 -0500 From: "Liam R. Howlett" To: Wei Yang Cc: akpm@linux-foundation.org, maple-tree@lists.infradead.org, linux-mm@kvack.org, Sidhartha Kumar , Lorenzo Stoakes Subject: Re: [PATCH v2 1/2] maple_tree: simplify split calculation Message-ID: Mail-Followup-To: "Liam R. Howlett" , Wei Yang , akpm@linux-foundation.org, maple-tree@lists.infradead.org, linux-mm@kvack.org, Sidhartha Kumar , Lorenzo Stoakes References: <20241109134410.31792-1-richard.weiyang@gmail.com> <20241109134410.31792-2-richard.weiyang@gmail.com> <20241113011542.lw5zzude7oo63rr7@master> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241113011542.lw5zzude7oo63rr7@master> User-Agent: NeoMutt/20240425 X-ClientProxiedBy: YT4PR01CA0469.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:d6::7) To PH0PR10MB5777.namprd10.prod.outlook.com (2603:10b6:510:128::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR10MB5777:EE_|CH3PR10MB7576:EE_ X-MS-Office365-Filtering-Correlation-Id: 58e73d82-1856-4acb-5e80-08dd0384bc93 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?2tTyqZfVDeuR1EI/amdwgZ4r3OpJnE60kuFhBK0tS3VKf++hmCCWOZSxfI1M?= =?us-ascii?Q?+DBc4dzhwXtYyCDTgey+o40Y2RUIGVlLv7oij/bfyxj9aG3FKV2GEZPK+tha?= =?us-ascii?Q?ibfBqWmEz2kbBdSoVlDTUbgyS66ed+RI00oW8/IAKca6zG1lMxum7rnrjqsb?= =?us-ascii?Q?8Zezi+ejuyjSomyxfpXgXDM5kPLZCkNxyNCkXwtOQQigDUzqFUUr+KnE0ouA?= =?us-ascii?Q?Xo8vngdt9qiu7BkkcJ/0aNdzL7Wws2/83ePq885eC9620ZBc2x3wLJ+GDdnG?= =?us-ascii?Q?n7Xs9HyBYQNSAXx7gLEY6hEAkrZZ9gFfgqbEL3YLeuAQHnl+4UUx+e338A/X?= =?us-ascii?Q?s7Y7piigYTnvfEKvGJfl306CqC+I3EkuRBUagGQEO8368DRgK6AOcon3+55A?= =?us-ascii?Q?Bo8ixhMk2lv2bcI6y4DMqvysLmty39yUIv8d+rzn0mSLyeNftZSwRG8i1aOS?= =?us-ascii?Q?F0c+DKgpZCbPVrXBN0P3awQ2eq6iiFo8mLd7StzebdYEBmMsxT8DSyzfDwbL?= =?us-ascii?Q?CCVmXGx5FzOfduvfXTzFzTnwwQnehlo9DPYz9xWSd1cCLlK0YwOQAIyYLCh1?= =?us-ascii?Q?b3SG82MMEYpTZtrQuQV3f9sSZIpLTxSLogDu8tjWus0cawMw8OHbnVREJA/w?= =?us-ascii?Q?5xAVEvSjh4a/D9cXLyIe7k1s6f58vsw3Wmkiz8cQxjuiIzuXRrP3YEprfWIR?= =?us-ascii?Q?vkC0vyMslqxq0r+hIFogDasTBsreF3j1CuNBSL5+mRGFA0j+Z85mwLhia/q6?= =?us-ascii?Q?IcirEMuedopYYLM4GcLC2cqwiIMpLyYcZl5nB2h9VPMkO+uHgEPapEHc6NKG?= =?us-ascii?Q?m/05qwXziwkGXeM1FepATNJKgFzaiZQkepMuEpE0IPfCi1XOEXkDxUoBTU1Q?= =?us-ascii?Q?Hk3b3H6/zdzFGLEGEiBBxisbBfDXA5liEDwXPioCQ9CKIjIqi7iFwwsZGDaJ?= =?us-ascii?Q?oOpumeq6VG/2RBmgsf6ZZnvGTIO9tqen6vc9VfzdYKv9HMTza9bE8/wNsPsw?= =?us-ascii?Q?M4XgPs5E6tefWdcNOb44/1OUR05PBHh+so616F8a0+LXcHUtyw9N2LnNhiqd?= =?us-ascii?Q?FuRLTPsEKMmtWRBG/dnfFHRbA4RMD3On99SjusB/wmWTCD22hZPhSMcu9Fgz?= =?us-ascii?Q?ramFlMbrw96PL0evJGY8UJC28ejxwhcOA04x8p5j1sUg0MOVIPZhP8VuYvU9?= =?us-ascii?Q?KKcrJWUknfNqMKmPCbiSwLpaawvQLXbx6sDJxDf0BUg+MiBcbEhV/juBlrDn?= =?us-ascii?Q?KclvS6TDu58aYmOTWrcdujjiLUzQOihonM/fPv11qYMTuvuHGHXlM5ApznId?= =?us-ascii?Q?diuxUXBMUOKnQQI0z+59DqP3?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR10MB5777.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?VPK3xgG8cVp/mQNJRzk9e4WwQ97RlLD0ehfWE8uaUu8WN405FbgZJk7tius5?= =?us-ascii?Q?XE/glGwbzB1FqFkoxUJC6rDsJ7eYJEaeq0QKCwWFJn43NVj3vR4JDcbOJEXe?= =?us-ascii?Q?7IoS1ub1inlHRozFLawdsfglPfoR+twQo+z7kJJ3sKbLAU05pLueaQBCkruB?= =?us-ascii?Q?cEwjUreeFKd+lJ9H60+uvMisDUzojOm4BmAFn9jprMBEIaxHZRyjHlp09u7q?= =?us-ascii?Q?55PMbbpgA+94lXZ6tFMS2pTAwzhDp943b9lfQRpvg19FSDcIgF6uV9YA8VXe?= =?us-ascii?Q?0H+78Qe4p454vB/o75lF0k8o2o/FBne1X7rRMhzW/Pa1/MsncnKlqvsaXcHV?= =?us-ascii?Q?jO5CbQteRgOdtbrNymAt56GvsR68Rar6c7+Rl8fsxzZGoIvaN8IqjwG0MhXN?= =?us-ascii?Q?SWOpS+aat5stS888z2yD8eVoDx25rxx5oRM0RiMiMDFMCCvfv78hmD4DFIlK?= =?us-ascii?Q?BXT/7Itos9uxaayjZSya4TagkmsHZx0GzXzxBMhr926nj90U/IdMAlKDMdQi?= =?us-ascii?Q?+/+SkrS7aODS/y9sWA5UROrkuEq4rmkyO91VaT7KbU4TPH+jAmj0lD6/+wiH?= =?us-ascii?Q?utNeL2BAKmPjPmOQ8MoT4wNoCH6qrANt2aTYUHlxEeBCFNra6e9m5pMaFJ/w?= =?us-ascii?Q?sG2bWxDIMxjqr0BdB/0Fkk/bqheqvMNP/r/eViDeDxaX8AKD/U7RSj9Oydwx?= =?us-ascii?Q?PRgQpOs3UQG+wlmwdjwd57PD6jHHj0BiJ0qNCQ2nJZiSAFxD4Fd6bY6ULIyY?= =?us-ascii?Q?kp4JJWx672M/FdXwV2tS7ioLOYFhjVZulrs8mLY4ZQnwV7vAevsfZPiX4Iiw?= =?us-ascii?Q?5uDcsLEUS7+iL+PgluhRZHm3N4ZDWOGb40gZwgIYwMR7pkMlzdeW8OWqFwUc?= =?us-ascii?Q?26feV1vpo0INAauksbMW1tdbtJrpRP3ES2xGmvy+sIT9QARZ4wPxI/fcjkuy?= =?us-ascii?Q?xEuWFn57WQ/7O0URc12TfzMlHA4UWaqBVs91EQUVIfI61xVLSDMW5caC6CfE?= =?us-ascii?Q?2NntezBzOk0nRrXJ5TGSp8ankhG8YyLXpLWfm9iFjndLtaDqacpHgwlu9PmO?= =?us-ascii?Q?jyXUo4xuofp4AUvoRcylfateaF4DryhWBpS+xDB0e0SPpkxcoXRTZC1jJ2Fv?= =?us-ascii?Q?dm6XqmkD4lx/HY5Mq90iCnVNUbRrprq4mBkmS/1DItCyn1qRpZtD2U3zGsjq?= =?us-ascii?Q?jdIYEkUtL6mbaOHG3kwAj4OWOoLXHdiLWh0C2KMSBXaFUNynBEgaYXbQaL+O?= =?us-ascii?Q?0XR/PZn1dYYo/PpuKQs8xJJQ8G9GO/fFW5JDtwysQ/b0QbECYvBAlZ3LQzkN?= =?us-ascii?Q?xoHQ6aMv6AM1N5Ok3X7oyHH4hSmIJuMef9rbK77BLj2W17fZmYgWGGErPhFn?= =?us-ascii?Q?o0xkL7p5zQdwEXsFS1ijgDxrzqqygZ9thC/kO7satgU2Zr4uJlr4BMwv+VTi?= =?us-ascii?Q?H8JGkdk22A3kqhCsdyeXQDUUlETqBa9KnQf60rUPzaABW29YWPqemsx/psSw?= =?us-ascii?Q?Crb97xvNB+KJ2oY+LA60+/gVthbp7TGUdFT/xCfLQYIWaWHRmuo21Kf9q9Ll?= =?us-ascii?Q?q3ukIpczBh5awBaDo4AocKBPV5FfjcLbW3R6Xmsf?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: Qg2QC3rcD72KJIOHPHpXj7Wb3tbYP6v8nti+YqycVAaavgBuOOy3ViQ2Ia46xg5tV8HRMRUU13BmGbqOWoMhiVLaU0Zhw9BZVhIyCVLTqedQKKKMPo7FZFvbFr9n0suADQDSSg2DBjfG/4+FHnzEpYuGhonLzuvjFafW74Qo1O/MvWj47/NcD3YCciVRxQ6E+OedPldV3eNMIA1JkxHwgZuzrSZvhMBAFpBtlf7UpSXT03m1u1Kn8dAorNofOjIcqQtxzz4aRANGARdxNOSdpAICV7fyVSbzU0hRicF7TIkTHzsFGZ8ONlSV2pJMRFRmU1fnrhMVWtzzQjqZdya12J5uZ9Ifx2eOTIDy/UU0Ttj2ZUpo8FpkNM7VV0sXoKu5DyxT/WF+aRFSA+E2WR8iWJKStrAhU4otSD2JPiSPEUCC6daGcCWpihGSgu4/ohMqMo59xBJ4Ga5nDiGGkaqhE4XVe6HowaylczY8p6WYYWW5xsVp4e1eVJ2qeAMDbSYZSetLwn2jQP0PeKDFMQHZnKgRcd80DumOdSvUq3Vny+r1JK2CX3YFxRh+ipprQkagDpfwXnCPNk1vMS+0F+R5HURxJcrguQ8bqtxmU+7U0oE= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 58e73d82-1856-4acb-5e80-08dd0384bc93 X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB5777.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Nov 2024 01:44:39.2297 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: lFRL2pFeeeBrh0s3kompEEpoLlP3Wf1o9u2Jw9Yj1dVi0tjItVM+zhN2VfQfEjD8LTFgsy8HT9fEtlpvv2EnUg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR10MB7576 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-11-12_09,2024-11-12_02,2024-09-30_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 spamscore=0 adultscore=0 mlxlogscore=999 mlxscore=0 bulkscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2409260000 definitions=main-2411130013 X-Proofpoint-GUID: MtkIFYIgj7AV1GwdBAmujntGbYFPy7So X-Proofpoint-ORIG-GUID: MtkIFYIgj7AV1GwdBAmujntGbYFPy7So X-Stat-Signature: 1fgaza3gb16h7wrascbpmigpfh39get8 X-Rspamd-Queue-Id: 356B880003 X-Rspamd-Server: rspam08 X-Rspam-User: X-HE-Tag: 1731462204-230978 X-HE-Meta: U2FsdGVkX1+MAkDJ+Bo9CIAgS+QDkkNxcYBCkkDQVPh4U8rXFf+Td1HtnrlCb2PQ2JpsLnHR0AzS73Inf9KgdkzeoFw0ofq1x8diZKfL/N3jwW2cT9ZE0KPy3RYEaWv7p+NP9fWp0t28+oUjsrzm8oMuOg5ePg8BwMV1Ifem6TyRYiTVbMpqxp3DHrsshsX78QWYfqTKRZ598piLGX0CoPVwFpFzQdYrgDqMXvGf+KushD9+YgptLgkmEpFuRskWu+O6R+RnN46H/+YNwzHtvePlGmt4Nmbd2hRgCvs1K7TN/2X7xakDyb+qlKud96BgHGg5gkbD/mv8GlEBWNN5WNJYWFbclZ4t13BsiA2lT4oK2hmAbvhBT3q1ph9gYzJVdn/QlL7lF1THt3CTzad7yBX+VSAPhpKK+N3Be/4hhNoo4f5M4y793KtTjNtYxvthXYWAvWXGj+LG7mCck06vgdJfmR06vD0QAkbYy/bEb0bUx9R8L4hTdtz0ZVNk1S/vIMRekwRnZuTdLgCtFjFDwVP7qhAQju4/eYHNXx7xjSpdKPwgR3aUNRRUON25Hk8YvhJ1BfiAhQPae8jst6Xc0bzdw1o60A5PeQq5mq23iu2TBYbZJad8NzltBu5/CQQzoe7JlSNevvWuCSb2vPwe6oa26B9a25xJyTSS4+zyRuBt1eivQGSdvac7RTWiawx4v+Yi4SIJcPxwOEV47q3kG7d44NZuYv+lVMWKsCXiQnB6si8JHRX+g2sH2fPUyn7AsJqNI0No2pZyT446ZtecGJbdMN9omxzkHihN1CjXg0JhFm9GyoLAzk5izgAZHldNDewmwqCb8OzKZSU0CVcumd2gpYq0WSs0/exBOx0DOYz/ecpFbTrgB5KGH7GNV0gVqK8aB5gQ1KCQp2i5094f+gJKNThl3V4HxCIZKqG7ipcsBSIEwLp5DQGw0LnM645TlmMr4FjDWQdEn1nFpNt Bqeezz4t awrwXKV2z/5EP96a+TrEJJtRi94lKQsOs4fdAqC0hCbITXv0TDdMshQB5JUCUPQnwsn4dxhL1DM7j5BlRL/IHd8aZ2qgPrm+5GTdAXDhF1y3yguwm0K5fDv1UVTLzYhpdGSicve7/zXyf5vaZ/n7Lj0yPO+0C7tvUZjHiQixvgARjH94NRhkLWPMdz3hSgZzICMzg12HTB4Fnn/DcQX4dbbfuFwMPq6xwsNXVSZnv7Pi6WEdMudnnK6/8kIMpbMwHrgr7qD1wFhR9QYVK1PsDciJX+ujqy6/9SORmnQhwWk4Q5amY7EnhrlJGcNGQaYJ+Eq6fPoh7GvbeJQPn+I88V/VbOipWaUZwe8oLenp7Drf2507d+DsYeWCVt46KxbgkmYRv8fsBNi4m8nFM8dtGqi886LDU8QzGd4jVN40oQPL7Lrf7UCdit2vSVTz/rKdz1p/InV0fY2ZLU9sqTu1VNT8hDd1PH3til8Rgto/HSP7JUJoSOcDXHngH20+8WDH51WGRIhyy4xWmK2iAu0X5usX+aSaNcozQCy5T8nV8iawVm9b9X19Hw0YN2vO86wEcKAnhLRpCpaFpS8jlZfH6RXqh1RCN6sl3yKlRMt86j27XnMDqRzWAJd57Ab8jFRB+xWiGoTWn7thil5qt0MXxntOJwVTeKAjbnAQGrFVIIaa/eML/jSvUEbgTF+ntekr6Yosp62AbiFVBRKLhV2tNes9UMcTYB3MuORIM X-Bogosity: Ham, tests=bogofilter, spamicity=0.000950, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: * Wei Yang [241112 20:15]: > On Tue, Nov 12, 2024 at 09:46:20AM -0500, Liam R. Howlett wrote: > >* Wei Yang [241109 08:45]: > >> We have been too smart to calculate split value. > >> > >> The purpose of current calculation is to avoid having a range less than > >> the slot count. But this seems to push too hard to suffer from jitter > >> problem. > >> > >> Considering this only matters if the range is less than the slot count, > >> so the real world implications of the calculation will be negligible. So > >> we decide to simplify the calculation of split. > >> > >> Also current code may lead to deficient node, the condition to check > >> should be (b_end - split - 1 > slot_min). After this change, this one is > >> gone together. > > > >This comment is difficult to understand. > > > >Maybe something like: > >The current calculation for splitting nodes tries to enforce a minimum > >span on the leaf nodes. This code is complex and never worked correctly > >to begin with, due to the min value being passed as 0 for all leaves. > > > >The calculation should just split the data as equally as possible > >between the new nodes. Note that b_end will be one more than the data, > >so the left side is still favoured in the calculation. > > > >The current code may also lead to a deficient node by not leaving enough > >data for the right side of the split. This issue is also addressed with > >the split calculation change. > > > > Thanks, this looks much better :-) > > >> > >> Signed-off-by: Wei Yang > > > >Fixes: ? > >Cc: stable ? > > > > Will add this. > > BTW, as this is a fix, do you think the test case in patch 2 of v1 is still > necessary? Yes, please include it. I keep all test cases from fixed bugs or added features. This way we know that the bug doesn't return in another unrelated change. The testcases continuously grow, but they are always useful. Thanks, Liam