From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E87F4C0218D for ; Wed, 29 Jan 2025 03:33:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 294DD28000C; Tue, 28 Jan 2025 22:33:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2443B28000B; Tue, 28 Jan 2025 22:33:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1166328000C; Tue, 28 Jan 2025 22:33:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id E57D028000B for ; Tue, 28 Jan 2025 22:33:05 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 597C9A0864 for ; Wed, 29 Jan 2025 03:33:05 +0000 (UTC) X-FDA: 83059068330.14.B196D87 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) by imf13.hostedemail.com (Postfix) with ESMTP id 7739720004 for ; Wed, 29 Jan 2025 03:33:03 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=K55U2AeX; spf=pass (imf13.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.216.51 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738121583; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HjBeI92RKi20gaW/Mv8Kj/q0kw6CEdFGym/S5DzBqvU=; b=roWN0mHpbl/mr0PySk8mnva4Gs8z4dMIhGtvaIihIAVMo3XBu3TWjsN9UbsNvQUkrEUD6A u/sAmTuY+SOHciRXVh1eoiZsKifLTEjbkQ25lCXvN7piKu+5cCviiE2Mh9coVGdCQE6mLy /Bz8QrMzeU4PlOb0TYbg6ZsHOSotsIE= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=K55U2AeX; spf=pass (imf13.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.216.51 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738121583; a=rsa-sha256; cv=none; b=Awyrqd5qKka0MlZlF3gWxCmKCUrLir7CzSP+wbZZSUBgIHNmsH/z986RotCeVmCtSPSzr5 lPjcv3Yi2YMVEiOm2198aa2nTooDxSkzs6nEI8XqZ/o52c80h5vXgoxaJtHXnCPfRzJzEY pz3/H+/SVufnsnRqj4qF2qArt3GWCKo= Received: by mail-pj1-f51.google.com with SMTP id 98e67ed59e1d1-2ee76befe58so10890077a91.2 for ; Tue, 28 Jan 2025 19:33:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1738121582; x=1738726382; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=HjBeI92RKi20gaW/Mv8Kj/q0kw6CEdFGym/S5DzBqvU=; b=K55U2AeXLhrnQDy7H/PkQae1d4QpSzWGx41Oex638w0P49w8aZRr8aORUUUO2twg70 fc7xntA77fAZqhxk7LruU4dJUxycP0o68KtuGfkTx4jnwQVT77GI6LyatLA0IrgVLLEN Fb0SdfvuxM6xGe+1e4Cs+ZEyMZDd3FSQieR24= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738121582; x=1738726382; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=HjBeI92RKi20gaW/Mv8Kj/q0kw6CEdFGym/S5DzBqvU=; b=t87pJHG7gKb2SrkdkLM8t93FZv/yLtpFYxY4ViyxhaVjJnobjiGsqkPXHojtg/26dZ hH3Az3A0/emNDfQovdOAZv6Dd/uFpAFIDNo82EVH7YSv5ds8cZmPgYY4MpYhD0mdC2zK ojiCFdiAf4wxRoXQGE3Ij8gMhB0s6HUqGjKjv5ueByuZbndtZKbWi7dh4wlCEmXH4dPK 3WCCSY8a1vgWuk1xKMrnok7JoDSBQ2QNOE7fevWfASzecSRmK8XrAhfLyci9T0dtwU9w LwRiUvHI1qbUjyQBivuQMHijKi9ho27R8veYblH6SarW971tbZUh0CNtV4qJzgYywPwX /NnQ== X-Forwarded-Encrypted: i=1; AJvYcCWXeXEbf3spwVX+hUUJmckwPxudR4MI4yZLUtDGrW3bNnliYND1wbbaN9dkXEt1vCByw5vRPwQq0Q==@kvack.org X-Gm-Message-State: AOJu0YyrjrYjiY3xMWpz4i3L69pw+0gA6CndYNndz/VcTMKXS8BuSiau X/RolIj7KuKmVr4RbT3psvocdhNrg0pX02CHwFR1JSZtd6lHfRois9CDG75CBg== X-Gm-Gg: ASbGncvK96wJVsQegsZrxP3V5m6/rUbf4GLHkdnFA1Lr7OaVNijrqObJ2oe90HdBQhT Pfm6byRyDJbPC1eE9U13l5cyyAK9kDyKgZs+4uhzQOXtu5T1ZT2oSbXWQSVvCfiX3QQkJ2ysB0p X5D68K1fyqinYiVGD0+vn+9bmXEp2HySqT80ABcKQiy2QnoHxp5ixI+g8dnnzKYCBup320GHLAR GL2njXSJMFDUnjbNGxmeHrbafR7p7wlYH7ZrHArubAcNhiyYI8/j7ZgsAYgtS2PqQGNkEY6XPC5 HbDi+nad49/VWdda6vk= X-Google-Smtp-Source: AGHT+IEByU7V0mIfEUfCPYRNvc6zFRC5HTQlvJXQ46fUGIwYC8pG10xxIJD6/l8FY09RxKVGyQtXZA== X-Received: by 2002:a05:6a00:2350:b0:72a:a7a4:b4cd with SMTP id d2e1a72fcca58-72fd0c728ffmr2360855b3a.21.1738121581868; Tue, 28 Jan 2025 19:33:01 -0800 (PST) Received: from google.com ([2401:fa00:8f:203:b323:d70b:a1b8:1683]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72f8a763468sm10255347b3a.106.2025.01.28.19.32.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jan 2025 19:33:01 -0800 (PST) Date: Wed, 29 Jan 2025 12:32:55 +0900 From: Sergey Senozhatsky To: Yosry Ahmed Cc: Sergey Senozhatsky , Andrew Morton , Minchan Kim , Johannes Weiner , Nhat Pham , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 5/6] zsmalloc: introduce handle mapping API Message-ID: References: <20250127080254.1302026-1-senozhatsky@chromium.org> <20250127080254.1302026-6-senozhatsky@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 7739720004 X-Stat-Signature: xa4e4b7akiu8b4p57dpm77ep3ihnmoq4 X-Rspam-User: X-HE-Tag: 1738121583-762806 X-HE-Meta: U2FsdGVkX1+W5XtbZ51CuvespBYRtzzKmGsdO5I9Gx+dKGfQ4lWn+LjW7PHGz+SCMjxdiHXhq+RUULo2dtsjJopdV6ghenmJdvN/Hw92b59q0A+MEuw4LRXZ9VjoH5zNFBimMeBc4yjizsXNEynY/eax7oMH95XlONlecs0qXAiErxYxMGpsO1yb/Fg8IJD88Kt+Uq+df3KNt+buNlTjvA2bqCxPI691p/8eMHCGCdNYfeU6sWuXwmBJGgd2Z9wZMy4zQSy0n4MpUi3I7SGK50e/hQm+LEORy+pZsTt+93NlykFuWzp07v660kie938BJVMs9G2n5pwzzBAeIxueQfq39oTlZFn8Dag1Ic8tvEkY/uvOozJCjkrDt/XDcXowZWQDm4BubwRcNJf/+WJjvDoNuBGok5a2IUNz+IUwkkjj2Wg2Z6RreVirlli4AOHsVhuwfI4ckBzxxhR+px80ELXJAbriautuCpj60XbrAPepooQiRcepGWckS0dbFD7R65iiXSIRFWeS4//cbWTihJ5o8ODFBrSXh106tazH72yTPm5ccssNDQf8RKpl6JF9m1eLXSfNdpSSBmP00otyISZwCe9z6CXszZ5Tm7YTodKAr3gowZ/whsfrT06hDISWhhWGFl5FM8vNgE/oYhs8EM+3UybMNMSRJBZik1anZYFuJpRERUFSA+gnzAFVfyN7gWT1/GIJo+XaNoJ35CqPHXwMcQNUZ5bCPVrnNBBOIB5E9YYC9vFKmLgIQ0F/nX/pMyCUUgIa/00NriJAjZ0xFQnewqRrzjuc9Skril/+UPNB2Ue/6V9b44f9DqY9SJvWV/X6uirbDre7UVQ/20bSMEEoQYsfQHuqCH80ckQT7pjJQv9lEMY/F3MbD3MRFlK5OZLcKQbT+X1uLt5DzhkPZJJobuiXav+3ShUI1rotWonAvnxpIcWOqRIU8t023qCEioXB1adq4kWqchQVN5o LvUz0EVf 0HzZSOEZTf40L2mO3xPs34MHu7orVC2RiEVb5XoNY8DZUD5i8Q8cmbHB6T7jG9G+s5r0yI+J1nn/FKQsE1RBLnLZtn+03/zcxTrvK24EVODPTstr8giDINH9+0dJxeKSgsbTgXFZgpInJseWQ0z/TrCILZxx01VVHvPvVMxh3+DOrFnYNz0V8AJ5Zefj/U9mL9L9C9HhgC/p5lDKOx8jOuacuZpkQB5pq+PELSZemiwCvRD2nJaPlWKGZSkygyT1nrZcr3H4Z+ckAeD83R3xGJhVldyHEWwRAeLlEgxvUJkHUEt00V65T/LkhyOQZ5yfUg4O3DEa/vrFtf66XrBlZpWu3Ko24a7T+7l6KgkJock906So= X-Bogosity: Ham, tests=bogofilter, spamicity=0.001377, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On (25/01/28 17:21), Yosry Ahmed wrote: > On Tue, Jan 28, 2025 at 06:38:35PM +0900, Sergey Senozhatsky wrote: > > On (25/01/28 14:29), Sergey Senozhatsky wrote: > > > Maybe copy-in is just an okay thing to do. Let me try to measure. > > Yeah seems like the optimization is effective, at least on that > workload The workload is just lots of browser tabs (zram is configured as a swap device), so it's quite representative. > unless the memcpy() is cheap and avoiding it is not buying as > much > > ... > > (do you know if that's the case?). We run on arm64 and x86_64 on a variety of models from low-cost ones to high-cost ones. I probably wouldn't expect memcpy() of 6GB of random sized objects (loop unrolling is possible only partially) to be cheap in general.