From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BBF4C5475B for ; Tue, 20 Feb 2024 17:32:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 02BA06B007E; Tue, 20 Feb 2024 12:32:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F1E7E6B0080; Tue, 20 Feb 2024 12:32:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DE6446B0081; Tue, 20 Feb 2024 12:32:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id CE33A6B007E for ; Tue, 20 Feb 2024 12:32:47 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id AD5281A0608 for ; Tue, 20 Feb 2024 17:32:47 +0000 (UTC) X-FDA: 81812877174.17.D4E573D Received: from out-175.mta0.migadu.com (out-175.mta0.migadu.com [91.218.175.175]) by imf04.hostedemail.com (Postfix) with ESMTP id DE98240017 for ; Tue, 20 Feb 2024 17:32:45 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=fxyuYm2K; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf04.hostedemail.com: domain of kent.overstreet@linux.dev designates 91.218.175.175 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708450366; a=rsa-sha256; cv=none; b=2BZwL0w1gsyjEOEQzmLMbuhnd2auSzzCz9KsJpG+5HPKaZxuPgRgc6F3/VoR36S081iKUU SqpfFoRCRjccizR1wHDrLKm8H3vs6d+ZI7TcViLE0G9aXLcKxSFW6IlbDYdxVhLIOAKAfZ RtLg410nNyHRdTxjwm0MlFdGtKendfg= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=fxyuYm2K; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf04.hostedemail.com: domain of kent.overstreet@linux.dev designates 91.218.175.175 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708450366; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OL5xFDTNv2eO4cGs2LE/aYT6r12sFC1afgYu/aCZ6KM=; b=3xSTwG6uqGcNT831muOPd25uy3lcuPCX9LdgCsBGGLBW39qMTzOw3zsaBAtVAAwC7M7nSd 12JmzH8dQdnoPBBTHRvuooTmRnZtRb/kKu5tTJNPwJgKxp5o7N4h64Zxy+dq4hLdGKSUjr HnAvRwzEjA8kHc8svRpd5iv+KHtX8IY= Date: Tue, 20 Feb 2024 12:32:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1708450363; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OL5xFDTNv2eO4cGs2LE/aYT6r12sFC1afgYu/aCZ6KM=; b=fxyuYm2KyZqwOjeFMmi1Let2DbXxCie5EhloySkSitC8BRgYw+g8xhKzEPRyrpwaBbr/TU 0tafzqcQ40XKTEmAPrIZ3Iw4O895GFa3q7oGe4uavWICcPdzTfB8TRB60MOp0jzPbPvQnG iSWlmNcgFKjgbSQNuTfPAxD2k6jceVg= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Michal Hocko Cc: Suren Baghdasaryan , Steven Rostedt , Vlastimil Babka , akpm@linux-foundation.org, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org Subject: Re: [PATCH v3 31/35] lib: add memory allocations report in show_mem() Message-ID: References: <320cd134-b767-4f29-869b-d219793ba8a1@suse.cz> <20240215180742.34470209@gandalf.local.home> <20240215181648.67170ed5@gandalf.local.home> <20240215182729.659f3f1c@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: DE98240017 X-Stat-Signature: 4kzeikax7xzi4bzwsp8hamfhf1kei9x5 X-HE-Tag: 1708450365-998758 X-HE-Meta: U2FsdGVkX1+TQscJTyQSPCAgaLWo9dASsbdO2iuUiQNeI3qTTczV9zrFYp3zyfpPExxKBiG6we/Oi7Xcjsl5sk+tPiInAp0nbU0GLMLcx3jVA4E24ZT38levKQe58RD7N6ExCjzbPwl7eaAVswhLkDKvFL/h/9AfOhcF/G0rMMw0K2CqPRGc4AhWkCUC18QlBzF4n6j8WBpipX80q6WAhQRrEmAMHWfk7VWGplRxv0ta6EfFJ2wciL+mT7pa7v+MvzNdqHqYVCpWrYhgh4fmpmWGKCUr4AqlNbITpBUi+USenQQIA9GSps+cX8//7816eG55cbNya4Z3hraSJoGJ5rKqhucCNrdMr0krI1lwluGRshFyX22HPutSLO02HQfvCXUgzGxWDznJXF2BOuCgF35Zjs82eAme+7XR6hzWyDdUfknVTWX+6rJ/VZ5fXhXFegGhB9vidN2vGa1vxucZQJbdZyDO1zJ93xWRCpvKmgsCXBbw6DtZcQJh/vp8XkMeoOmRH9C6+gTWm9F91zLn3UczHx70RTD1RmGVa6InQQnENEWefiTmhKyl2N5tbOHOulQ3/uT0SK7DhLUgnppyoRIXpXJz3U8uomnCCxBTsnIWg/lAS558XpIoUjNsygH1/+C4YAy6Xw2kqYJfL5u6T++k8MtxWdS8vMbCOump5ax5hrPNXh0mc4iljzKD8NP6t3bWKzwoHskOnFs0awZJgNqCrlsPtZ6cNRoUX7R1ze8rgZiWVutBfGcLtdZXwCqNnfUu84qzjXVXsptrsNPTksXmE1DuqutNkQ2i0GtCaLS9wVgA6BHPYtNeOQ/ql9LxAGBL2PM02uEF7EKC4+S3kodPsxHoDVvUBOm7AamvGGreEdrH9MyDm4FuxPN2W7XyuRsgzwURqacxleYCBu212KHmrLxzDU2KsiDwPXhycYSlH87kMMmRr6weAy/kseRFp69iKsdcomVTPJvpnRl X/GzYrV8 2kabFGlOFllZAfyRaMj51RaLGGB/2jb5qqmow78K37zhKDYVrxQMIXxul8Tmi4rjvvcPSh4p4rQQMz5MVvVFwx1JI3iXdoxDNkM9IGHSxHxeSDC/HOwl7dVocxi60HHGzZEK6d35brSEOv4Xb/QTNTepctsNphzHGTsS/gp9ZcfIJ6SriuEnDJFesjVGs5DOHbHJv88POBDeTjkQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Feb 20, 2024 at 06:24:41PM +0100, Michal Hocko wrote: > On Tue 20-02-24 12:18:49, Kent Overstreet wrote: > > On Tue, Feb 20, 2024 at 05:23:29PM +0100, Michal Hocko wrote: > > > On Mon 19-02-24 09:17:36, Suren Baghdasaryan wrote: > > > [...] > > > > For now I think with Vlastimil's __GFP_NOWARN suggestion the code > > > > becomes safe and the only risk is to lose this report. If we get cases > > > > with reports missing this data, we can easily change to reserved > > > > memory. > > > > > > This is not just about missing part of the oom report. This is annoying > > > but not earth shattering. Eating into very small reserves (that might be > > > the only usable memory while the system is struggling in OOM situation) > > > could cause functional problems that would be non trivial to test for. > > > All that for debugging purposes is just lame. If you want to reuse the code > > > for a different purpose then abstract it and allocate the buffer when you > > > can afford that and use preallocated on when in OOM situation. > > > > > > We have always went extra mile to avoid potentially disruptive > > > operations from the oom handling code and I do not see any good reason > > > to diverge from that principle. > > > > Michal, I gave you the logic between dedicated reserves and system > > reserves. Please stop repeating these vague what-ifs. > > Your argument makes little sense and it seems that it is impossible to > explain that to you. I gave up on discussing this further with you. It was your choice to not engage with the technical discussion. And if you're not going to engage, repeating the same arguments that I already responded to 10 or 20 emails later is a pretty dishonest way to argue. You've been doing this kind of grandstanding throughout the entire discussion across every revision of the patchset. Knock it off.