From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5C87CD4849 for ; Thu, 5 Sep 2024 23:29:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5E2726B0085; Thu, 5 Sep 2024 19:29:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 592156B0088; Thu, 5 Sep 2024 19:29:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 432826B0089; Thu, 5 Sep 2024 19:29:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 24E316B0085 for ; Thu, 5 Sep 2024 19:29:49 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id AB352160544 for ; Thu, 5 Sep 2024 23:29:48 +0000 (UTC) X-FDA: 82532279256.27.B9344CE Received: from crocodile.elm.relay.mailchannels.net (crocodile.elm.relay.mailchannels.net [23.83.212.45]) by imf27.hostedemail.com (Postfix) with ESMTP id 2F2B740009 for ; Thu, 5 Sep 2024 23:29:45 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=stgolabs.net header.s=dreamhost header.b=qqyi3i8B; dmarc=none; arc=pass ("mailchannels.net:s=arc-2022:i=1"); spf=pass (imf27.hostedemail.com: domain of dave@stgolabs.net designates 23.83.212.45 as permitted sender) smtp.mailfrom=dave@stgolabs.net ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1725578914; a=rsa-sha256; cv=pass; b=DxXzki3M/oNcFuLF41KpmamkQT7JqRnpWlg5zpa7oQiXkRispn2lQfPbGhEKB8C2LkTpSn EDR1wpK1ieo+5dMtz4mGQdbhVK8yvA4Q8TPyimkBibbaaXHwP+95QQa3fL6uPNghlvzOtl g8J2U/c2RthxzFsqMffujIUvBOPjb0w= ARC-Authentication-Results: i=2; imf27.hostedemail.com; dkim=pass header.d=stgolabs.net header.s=dreamhost header.b=qqyi3i8B; dmarc=none; arc=pass ("mailchannels.net:s=arc-2022:i=1"); spf=pass (imf27.hostedemail.com: domain of dave@stgolabs.net designates 23.83.212.45 as permitted sender) smtp.mailfrom=dave@stgolabs.net ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725578914; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2S8X0xUANTwU9pJASFvGEzfejQnAoym/qG0XwbO7PsE=; b=YVdfKpZjslGJwqU0pBvRBCO+BH2jIaKPw0sy9tG23EiGAlIf54LX5F4k3fuZyoLa1i/b8X mjxDVZDs96DbZL7HtquezuM0yZcK82aKh7Dbv1upkaOl/KrcyRgdBr1QB/HJsS1BYFm2QJ K3r/Jag003IeDQNpZfu3yibk6D3rD80= X-Sender-Id: dreamhost|x-authsender|dave@stgolabs.net Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id DA81EC5BC9; Thu, 5 Sep 2024 23:29:44 +0000 (UTC) Received: from pdx1-sub0-mail-a235.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 7522CC5440; Thu, 5 Sep 2024 23:29:44 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1725578984; a=rsa-sha256; cv=none; b=TfCeLZsZ94X0XgUgThXmgdirNhq1lNs8KEf5GSLD2z7sGayx6KfW5+2Dx5VU+XUY0Kuk+z eemJls/HsZizIXMRPwpfiNzgOCJ0kmFaqGjG/4SUh9R4HlDpqBnAf8uVKmbLGxrcMMGyjS GZf67iMkXVjfOtxxOF13dE07B2TtVIOeurDU8GKkpLN+g0SUGUZJmXLFib/mUX+LmmWDxD B2c003pb5teZUnn6UTuKfYvGKkS46dmkrm9rYSiaj1Mgt8uwybxQ0oKhQoHjQ3JC4KA1kj ougt/a5kdGjNGO4vBLFEQiOf89xYdVntX97uA97OC+BAEenv/gmhnjKmxuXmBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1725578984; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2S8X0xUANTwU9pJASFvGEzfejQnAoym/qG0XwbO7PsE=; b=8FU7fqd+7U5bjunPkb6jhlB7LPlIN82fK7p9DiZw72/agyRcK0eX7XWdQ2jQdzAomwBp6o U81y3iJIUIqm428GmY7pBAgrI+Ox1cHi6pq7/HOqFudF7FdzJUbdSxkKEq0bB8xORJhyNu TdokuhEa17eCVK7Uq/T5xiQYh4WrRXLRxJXZpLJxCgwgLPKkEUYJ02fH+cXsdHd0BWTW0G KePVGw8EGe82qM0RV+gDMfE9/0INn5o5szT4j3SzfAtENDpJrJgCIBX5zjsbaD7zANCykV Q3RwJVAMaqVUfZTibDdu67EiKro6pEZkFB7+qIJJraWyiKmXAZLsVKVGCS5HyQ== ARC-Authentication-Results: i=1; rspamd-85dcd79db4-h6mk5; auth=pass smtp.auth=dreamhost smtp.mailfrom=dave@stgolabs.net X-Sender-Id: dreamhost|x-authsender|dave@stgolabs.net X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|dave@stgolabs.net X-MailChannels-Auth-Id: dreamhost X-Exultant-Unite: 443828df6cb4a34b_1725578984724_2528316108 X-MC-Loop-Signature: 1725578984724:3890867753 X-MC-Ingress-Time: 1725578984724 Received: from pdx1-sub0-mail-a235.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.112.250.152 (trex/7.0.2); Thu, 05 Sep 2024 23:29:44 +0000 Received: from offworld (unknown [104.36.31.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: dave@stgolabs.net) by pdx1-sub0-mail-a235.dreamhost.com (Postfix) with ESMTPSA id 4X0FvC6dVBz6h; Thu, 5 Sep 2024 16:29:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stgolabs.net; s=dreamhost; t=1725578984; bh=2S8X0xUANTwU9pJASFvGEzfejQnAoym/qG0XwbO7PsE=; h=Date:From:To:Cc:Subject:Content-Type; b=qqyi3i8BBZVmKh0YZ03zuPNZSFxAI+8wfVcEQ6jWGmenQSoYDf/UDUWFlIuogCg6e rfB6Orof8n/NAD8EPE+1C5/+93LMsLNTlS/iki5GHzVKD3nMSmND5sNa5iz4PDyVdm aiNsZLt1pN+rniRZS3QdA+FYfvhwhcs8jkUla0VDeWlRhzDK99PUIa99RWeQk4lx4e aGYlkleZLbeloHwelP3XgQm6HfCgatk+SyojFrJpLD4LWoErSxLjnPJMfji+AKwxK6 J+EnMWVTxQs64u8LmDxFg3up8VGbOYYo0bYitqbFBd1EbtW1wSfvxNo0q1iPo2/GkV Edny2fyeCdMug== Date: Thu, 5 Sep 2024 16:29:41 -0700 From: Davidlohr Bueso To: Hillf Danton Cc: yosryahmed@google.com, mhocko@kernel.org, Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] mm: introduce per-node proactive reclaim interface Message-ID: Mail-Followup-To: Hillf Danton , yosryahmed@google.com, mhocko@kernel.org, Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240904162740.1043168-1-dave@stgolabs.net> <20240905215945.1909-1-hdanton@sina.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20240905215945.1909-1-hdanton@sina.com> User-Agent: NeoMutt/20240425 X-Rspamd-Queue-Id: 2F2B740009 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: wdruybero7hgrjmsybx94cfiomsyb31i X-HE-Tag: 1725578985-513736 X-HE-Meta: U2FsdGVkX1+I30OupGL7oPztPhFi+Xg+sfhPzs/VN36yhiHQXhxVwa9jP7+aWxdHaW7ole0jcij3Tvy+54OGniXG5S2XVA9zVfQA2NQArf3SEgT+bNHSYvegA6WM5ORMxLyMVOc6xRuGjetO2S1Ss7TJdOl8HhsfERHHCqBEFwmjy+ilomcQ/KhusGw6eSMjZHmThLGGYM1xSse2w+Gs9vGxDb/PFsjHfPkHQO4W1KQ6QkOjXoLZ9RjKIF0ZXAAcFraV9YDM8Fe1rJVt0AU7CD6uesafk0f4DrBdQP6ptJnJ0GBzC1s0dwC/2zmiwB5DXnlZheiqaTQoTZ8zIaEkhw6nUPZfroWGAW8CNF2erfmBvPpp7M9pCR+40Fk5s2wgCk9Jh3sehru7UY43rSozlujkJf2W3dY3vr4HWokSuY5uNrKJmurGrJSjepqCHUg4w9NnwxPIoVBgJJYcb/aOBhrJx/hclpADnnnbALfHiLGioIhlGmiDDHFSr+Wa8YI+AfQLD9kUzXV1txjUMbW4NuHzECuRarXS9nfUxGb1I+pIPrk2adWwOfe4izVbE93fqQ/IicvI8oMmjA+N32wdW/S2XtiKE8z3OOGDcJX9HPRyFOndr2XffiRm/CqrPpQxckk7/ll+nD5OSIZAI4TApi9y+hxyoCrq3BzXslGSK+DKQEKNPJZqVZvm5IT/ctXHQVPmLIkl/HY65ixuzSr0dJvw1vi7XhCMcBCtLBhcKwDlvyqlfLotOEiedKlcyEgc2znXOiHDTREgrm0DmHqQHkE3UB6s2SsoJqZoEF3yRrIJq80gVmJ0end6oeYnopqzh/WN6/h8V4oVaFc1KBMBG08trFiR0aJFA7DMo11p2iF5SGBvgURnipcToGIseEo5FwahffiH/iEpf61QHuZqlj2rvFTZ77ZmFpjfrHgwzCmt5NmbRSWeFHnaP9oFmSSeyFGlqNjZsB4mZ4ukiLj 75VZhEwA LY++K8qKVvN6XvcPpu6JAZj9GqaJ9UEJeOOWWEoPgy8Xg70RnOCvOMaPBb8CDWlh+Qu3rlDaRVMYUYtOrb+dyXGXDyDB85dd54M95KIlbKQZNhDCslPp3p7cDmK9RIP+SrLpbJAHao7+5zAhjQ/v6yO6ptG84N3XE6FEKygexhC4yBkqVscnCOmS8svb+y8fvVwULtUONbIpK44a4O/uJk4hHjWXnKAeR/45teXZaaeibdH1jfqE2k9OdzWX9EuNFzL9FyRbaa6b9GszqEZOr5byUB1Hh/TFb1y5i X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 06 Sep 2024, Hillf Danton wrote:\n >The proactive reclaim on the cmdline looks like waste of cpu cycles before >the cases where kswapd fails to work are spotted. It is not correct to add >it because you can type the code. Are you against proactive reclaim altogether (ie: memcg) or this patch in particular, which extends its availability? The benefits of proactive reclaim are well documented, and the community has been overall favorable towards it. This operation is not meant to be generally used, but there are real latency benefits to be had which are completely unrelated to watermarks. Similarly, we have 'compact' as an alternative to kcompactd (which was once upon a time part of kswapd).