From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D738C19F32 for ; Mon, 3 Mar 2025 02:42:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C70746B008C; Sun, 2 Mar 2025 21:42:37 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C1FFD6B0099; Sun, 2 Mar 2025 21:42:37 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AE7646B009A; Sun, 2 Mar 2025 21:42:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 908A66B008C for ; Sun, 2 Mar 2025 21:42:37 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 4D107508B4 for ; Mon, 3 Mar 2025 02:42:37 +0000 (UTC) X-FDA: 83178691554.01.2E16D8A Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by imf01.hostedemail.com (Postfix) with ESMTP id 6A5B640005 for ; Mon, 3 Mar 2025 02:42:35 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=N1VrqPN1; spf=pass (imf01.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.173 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740969755; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2Eq1Jm9nTipKyg498okiimxlJb53FXR4hBqUwQ5lbqc=; b=fnIIP5NZp6UDWNijDUo6Su4wi/jr7ZFIg2I3Oq6IgKu4Y4g/5mW+ydXULo26iCuO7nsfXf X9NkqcVD563GipV3vwanBp3N5UccWmZnNaMCxALLGu+qL630FpkB50mqkkY/CqJ9XjZaWU bZIXnTGQXfXjqXlVzt9L4GUOctoAsMw= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=N1VrqPN1; spf=pass (imf01.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.173 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740969755; a=rsa-sha256; cv=none; b=ph/GQkpQJjnovqxCN9O6YcNWPWSxEYpTbY3lUggGWOKBUhEy+B5zZdZ+l3sNjCCJ2K+zcj J5olIU5YKGEgktnVMJmz77A/psepq/DmhN4Aa0tWdRMGjk0SpPQ/4h2IqBF4NO2BobeU68 uqR5MBv8vdVpphgGqUdLDEj7RRd5Xzw= Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-2239f8646f6so14455485ad.2 for ; Sun, 02 Mar 2025 18:42:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1740969754; x=1741574554; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=2Eq1Jm9nTipKyg498okiimxlJb53FXR4hBqUwQ5lbqc=; b=N1VrqPN13Op2Ut1qYEQ6e1H46RryuftTQaaLBsoijEo26OxmHpjpOGdbp4xjZkPgHR TapoqjDtN+AQuo+aaDGdohnm29BfNcI4kQT6Sl/GzzW/MZkfqqA+6hcuST5Cfo2jn+lr 88NF8j34S4ZrtzlqdR2nTrfb8sZBQVY+GqINM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740969754; x=1741574554; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=2Eq1Jm9nTipKyg498okiimxlJb53FXR4hBqUwQ5lbqc=; b=e5LAEPF8YT78+td+DeNkOX85fJaTeMPAOQLAS/pkVS1hanHUoAioxv6PR5ORbd50e3 fgYFCbsCF6LEBUXnhiJfqO50bRORpYovYfxe0ajAtTiJVmRSsz8x4fGyJnUG65iobBng wwaomyyl4ijC9heeIkWlKSEE7jtMlo4YuAHy9c94VBmjP9TVv6qI3rjt9isCG4EHLVA2 18p3LxR1Slo5VPOlLEJVo4BhL7K8CJq5f7dL0FCH7WZt3jqBji0YHs6xo0GIBtynUfDR +bDk7BN2JJ650p+TxkmDK7PyajZlFlicGJ3oxEHcjQBD5uIiVAOz+cDvKxcsSMoHtvpv QAeQ== X-Forwarded-Encrypted: i=1; AJvYcCWbH514EUtRKQpltkkMV+EM163AC5aE5msz8NsHVlOfpH0xSvAYFT0OE/gOB4wROmq56nvjBSPtmg==@kvack.org X-Gm-Message-State: AOJu0YzNXTJEfDdWmBU6rblUluHRGokBC45t7HiQDJrTKs1TyZtbjwnt CaDSMZXyrRXzRKAHLFs/zSL7cOzGfx7y1vE3dzAIPa8Ovq83pTxXW2UWzWEKEw== X-Gm-Gg: ASbGncsf8cToyx5dV3HEkS3FTlhnHE6nZWIcGQkphuib5VLDsX7jgOryNgVObDv+oN5 ivzEKC9R69K3CMdkHJm7l6a37c8DmTBXzXZkqpUv1/jOkF8H3l6qQRuK6o8DC33GWmLPPcOOsy1 79Coc6xrY5bt4Lh/3hUEnQcR/53WFA8ovzQdy1OzyIkXsEPLfxp1di8hGNqAVbnCVjyCm8wo1MA a4DTyA2Oo6gwwrfCo4WewL/KppxTR2MscfEJemsE6e8xG8+rPQniOX4EfiQkGFrl4Nqd1MQO+hg 4zHgJHd5yE5QzvWIUyu8DvwTcihx2qkYbD1VZ0aCn+mT1OuS X-Google-Smtp-Source: AGHT+IHFCx5QItcKe2emKdnH2UqMC291YHcrn2qE7hpTfsgRWGbkJ+HqoI5r36ycsN1pfGu0e3g0KQ== X-Received: by 2002:a17:903:1988:b0:223:47b4:aaf8 with SMTP id d9443c01a7336-2236921ed16mr153813725ad.52.1740969754329; Sun, 02 Mar 2025 18:42:34 -0800 (PST) Received: from google.com ([2401:fa00:8f:203:1513:4f61:a4d3:b418]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7365478bc85sm871929b3a.160.2025.03.02.18.42.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Mar 2025 18:42:33 -0800 (PST) Date: Mon, 3 Mar 2025 11:42:28 +0900 From: Sergey Senozhatsky To: Andrew Morton Cc: Sergey Senozhatsky , yosry.ahmed@linux.dev, hdanton@sina.com, ryncsn@gmail.com, bigeasy@linutronix.de, minchan@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Herbert Xu Subject: Re: [PATCH v9 14/19] zsmalloc: introduce new object mapping API Message-ID: References: <20250227043618.88380-15-senozhatsky@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: iekge7o5qsexzq5ywjgr3rwopg8ckoxo X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 6A5B640005 X-Rspam-User: X-HE-Tag: 1740969755-281375 X-HE-Meta: U2FsdGVkX1/MgfxfvZHSh609Ft3p4pFCgcYy6qeE6R4ewMdYgvtfMX59C57FhatG6qMUm/Ss1vhGsdT8eCH1GBQdVePDyrxajcflN7d9gH9HBKbWYzbrQnX0RRSxUCHuMYRdYe/ZWn9605zxwZsdwe5VhUkQP6HzPiW8dI8CqbVRDR7jK0w0vNOuz6NVtdm1jxA+M8MDZZ3DsDhzl8jctEmJ9oph4pIeB+dTLOV8e8v3R/y6LLQWQaiZNRw+6tE3zGMDS5bp46CRap2htVkfkFn72e2HriCyXfR86IT2eLZd27LBrLfQ3ltPLqzt2A+5QO+oIKv5fAkX+NKBNYvcSMjeMuxMD0kwjmbWVWu/4JgU3O825zAdX638sD/zmF5uT6vQybPXYWR5Kpxo0HyEsLVoBUrDxdhXqv6IqqHiOIluvwWJLdLQ2piSNbrHH27PptqB8vQ7pfkZzk/xTkgXG36XLMFLBI/xJpfZH1B73GPJ4rCt8Wtrbqr27aQabLssTMUbcQAn+YkCvgkp0N5/45grptGmx0uKFMCevo6+rltY15GeoGahenwjvyWotUA2qZjVYmXyx+g2sH+YAcWj3I0NPxplWpAPuvRhCt6C+v06tvhXCmctDar2r0TC60vDaZX4Fx4zlx16Xk4xEk7dNhLzJxnLKnh+AV044CUYKvo0MFGjSdEZytgvc/5YW31z36weBYYnOhaO61BsD/JiT9L+7DzyxPjAA6Jr8setcDDYLZ1mffWZ+CUKfcNWC/1QqY1YBkkW0fKkobbvWJezfRf6PtAmdjyWUUDkCA6kEQWhM1f0r3X4NqQEqDY7iIHSvyVZcb10w9m6iNIJ9YHgq9WC23vGc3pUCrU+ri+BwcpQIK5daFp/Yz7+Gw39xvhjEhz6t9gubuUW/aDpawb6gmEecMkeSX8qJBURg1YtLmur86LgmgMy9C5rZHQIue3eXwloyeLYKnfS0F+DKc/ tvAauiXm QMhu4BXVAalhsuggny7FsSlFQDT7BmPK505QKPxoDg46oRQiCAeJswTCrcQg192CHv+QQkBSc1tW8Qf4IhBWGK3Y+YApod0L6+3oDb3nLGcKJxBfGSbDjkosqrYJP4ckk5WBwDZmmWhAcppCwgDSI3LqLxwWC5VkJRksSME4G/E/XZKYgVBXKwfGoiNnmMGvaTD9r4274adX/Ze3bq6Kq3BciXTZe4KCO3/ALFFfU5vbWXt4qdq5aHPZmTBrupNj9xVw0O61yGEWhFCd0qZ6rYCRRRsHuC7/CZb+1B7X/WLrrX8Nyg85Pf45qChoYFIj/1xUgG8/pVqtRGvO7m4bvwU7EcarrF7g4+4+C X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On (25/03/01 15:22), Herbert Xu wrote: > Sergey Senozhatsky wrote: > > > > New API splits functions by access mode: > > - zs_obj_read_begin(handle, local_copy) > > Returns a pointer to handle memory. For objects that span two > > physical pages a local_copy buffer is used to store object's > > data before the address is returned to the caller. Otherwise > > the object's page is kmap_local mapped directly. > > I presume this buffer is always given to the compression algorithm > to decompress? In that case there should be no need to linearise > them at all. > > Just return a two-entry SG list, and give it to the Crypto API > to deal with. Both software and hardware algorithms can handle > non-linear input. Yes software decompression is currently > linearising all input with a copy, but that is no different > to the copy that you're making in zsmalloc. > > So please change this API to create an SG list instead of copying. > That way we can then optimise the software decompression to read > non-linear input directly and skip the copying altogether. A heads up: Discussed with Herbert privately, we will look into SG-list API later (future dev cycles).