From: Cong Wang <xiyou.wangcong@gmail.com>
To: linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ipc/mqueue: remove unnecessary rb_init_node calls
Date: Wed, 18 Jul 2012 15:09:08 +0000 (UTC) [thread overview]
Message-ID: <ju6jik$h3p$1@dough.gmane.org> (raw)
In-Reply-To: <20120718110320.GA32698@google.com>
On Wed, 18 Jul 2012 at 11:03 GMT, Michel Lespinasse <walken@google.com> wrote:
> I previously sent out my rbtree patches against v3.4, however in private
> email Andrew notified me that they broke some builds due to some new
> rb_init_node calls that have been introduced after v3.4. No big deal
> and it's an easy fix, but I forgot to CC the usual lists and now some
> people need the fix in order to try out the patches. So here it is :)
>
> ----- Forwarded message from Michel Lespinasse <walken@google.com> -----
>
> Date: Tue, 17 Jul 2012 17:30:35 -0700
> From: Michel Lespinasse <walken@google.com>
> To: Andrew Morton <akpm@linux-foundation.org>
> Cc: Doug Ledford <dledford@redhat.com>
> Subject: [PATCH] ipc/mqueue: remove unnecessary rb_init_node calls
>
> Commits d6629859 and ce2d52cc introduced an rbtree of message
> priorities, and usage of rb_init_node() to initialize the corresponding
> nodes. As it turns out, rb_init_node() is unnecessary here, as the
> nodes are fully initialized on insertion by rb_link_node() and the
> code doesn't access nodes that aren't inserted on the rbtree.
>
> Removing the rb_init_node() calls as I removed that function during
> rbtree API cleanups (the only other use of it was in a place that similarly
> didn't require it).
>
> Signed-off-by: Michel Lespinasse <walken@google.com>
> Acked-by: Doug Ledford <dledford@redhat.com>
Reviewed-by: WANG Cong <xiyou.wangcong@gmail.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2012-07-18 15:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-18 11:03 Michel Lespinasse
2012-07-18 15:09 ` Cong Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='ju6jik$h3p$1@dough.gmane.org' \
--to=xiyou.wangcong@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox