From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0464AC282EC for ; Tue, 11 Mar 2025 13:49:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 48816280004; Tue, 11 Mar 2025 09:49:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 43857280001; Tue, 11 Mar 2025 09:49:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2D8A1280004; Tue, 11 Mar 2025 09:49:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 0F4E3280001 for ; Tue, 11 Mar 2025 09:49:30 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id E1142161FF0 for ; Tue, 11 Mar 2025 13:49:31 +0000 (UTC) X-FDA: 83209402542.12.3BD8C18 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) by imf09.hostedemail.com (Postfix) with ESMTP id AF5A7140008 for ; Tue, 11 Mar 2025 13:49:29 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=T4D9oqzm; spf=pass (imf09.hostedemail.com: domain of mkoutny@suse.com designates 209.85.128.48 as permitted sender) smtp.mailfrom=mkoutny@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741700970; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gqB/iF+dei4y3VWYyAk1QsAKHD9oZbrYePOTdReSlBs=; b=P/EyqSyfsgSchedclSVMjLd+yZhXxaXDHdBCPHbndvqCRkjhXiCaH7TibysKqEWWT9DTLl yV/L7b23BKXWdeXTFl4YobKBTPR6TA5uzPbTeXaswjCcks3uAYb22o5vK10VSeWnM62uzA ZDsAmEheCDhWykr5xGMb6/1Dq+J5juA= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=T4D9oqzm; spf=pass (imf09.hostedemail.com: domain of mkoutny@suse.com designates 209.85.128.48 as permitted sender) smtp.mailfrom=mkoutny@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741700970; a=rsa-sha256; cv=none; b=srlFiwUEP6HinIySs5F35lAdPJVlsGzYUff/Z5I/Grf/2/OIzyt4JgNVSI6kZRtEznwikr j1ujEa1bGANv8f6pW2T0tRs2tJOYEfp7/gXHN7D2947OEw5EMCPSk+hLP+q8Nqg+yjzw7D 3JoqfVm/TbHFVtJLndBGZBVs22dU4ec= Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-43ce71582e9so19819095e9.1 for ; Tue, 11 Mar 2025 06:49:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1741700968; x=1742305768; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=gqB/iF+dei4y3VWYyAk1QsAKHD9oZbrYePOTdReSlBs=; b=T4D9oqzmKmJFOHwnvFEk6Up4tTDZnCjTorXsaRr2jRTcoCqZKlT0VAnLY/yYIu+8nN i+xr4wIalV04srUpumYjM4BAL5ErK6pMnSEgIUIKW0HBq8PcdlUPRtrmv+QmfuaVL8or BfSSqyIcAtZQWXrcv/vccLuZHqVO9ABAJwtHOaezd7TFrOWAQPhmaNfEnz/ncu39luRR DLfbNv82Xs9hfu90ID4dHLzzjCvC9LI18/dK/0VaMrXGElFY8vgowIM59B/gwdgKod90 /oN5RiCfU8CiZuyVGrBeA3s/Mjjw/tBH7ILZ7r1vMLoc4Envx5iWjvOBs2gWHhMSnhPx xF2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741700968; x=1742305768; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=gqB/iF+dei4y3VWYyAk1QsAKHD9oZbrYePOTdReSlBs=; b=d1k5XHqZ7hIid0NrxY8auW6R88qZ+avZe6mSLhSh2Cy6vmF4wR5rpLuLDxnJIGYPt0 MmDU2vgX230Tu4C15GD/2WXm3NxcMVpJdgsoppeV8XH5BdbtLEww5O/1vtFLpDHTvmDU y6v7L/HoYprcSDJ7GcYgQrGzlmtqB12PjzZVQLCp0su18wvQmTXkJCkXjHHUX4vGGMjZ 63YtwoU6NQxIN20XKVL9y3skjyLMBun5ItAWFdO0sjGhabZLrLWmCxFXskDnsRvZoKY4 vmVRKMrkR57QPmnj7rFwI4Tv4zp222u+dZdvrNdLGHg07DMh6shWYjY0B7Yv1i9/rQFZ WlUA== X-Forwarded-Encrypted: i=1; AJvYcCX5a2Vjb6RUOupaDfoAGtlSqYLsltponIulnISRaEtQvzD17OkMYZuHfEL4aWpCZwdVdRDmRezssQ==@kvack.org X-Gm-Message-State: AOJu0YyT7j8JPa66tsi5LkFGExCmK9ijFjH5SQMoYkcFTozymaCM5ulM +P09Gr5TIUCRteKITvUDTI9VAKDMVPaBksjOokJKXZSD+PNocaS1DdrrA8H6m/gWmz4KqZeeF+S 8FX0= X-Gm-Gg: ASbGnctICVa9wGjFTXADiHsmSIPRf/TadJ3c0FIgqbJa+oZ6F3XfF+LR9Q5tKD8lbZD /fdj6HfpWb5VyDXSvMv9YkhxO5XkkIScaqImGnjTXu//jZ+TeDgwf5iZBQgs0WMnFqQ8KhfsgXC QlSsCRNVCttklOyd5XkGcM22Bv3AUlW14XuhcYgGge3Vr9fpJGz5QrqGDg/TgkBy1mkeRVdj+/9 a0zhMaSVRdbwxHPbqk4J+H6iqMkH+Ktd41KipnEtRj4bvCsv5uJCho3Zhd1DgcKj4Hx3jYw7Rss VZxMjt+uMzp7ASkt97aaes0QPf5nGE62bUVfNfkh0ji5jCk= X-Google-Smtp-Source: AGHT+IHb+rSRbvUlQBkhWQdq8ou6WdPqG3+rRdmBEuLAz661CxrAjVqbigcZm8EOTGlYJNTw3Y20yw== X-Received: by 2002:a05:600c:1c1c:b0:43d:54a:221c with SMTP id 5b1f17b1804b1-43d054a2461mr25392025e9.18.1741700968169; Tue, 11 Mar 2025 06:49:28 -0700 (PDT) Received: from blackdock.suse.cz ([193.86.92.181]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43cf7c8249bsm73699775e9.7.2025.03.11.06.49.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Mar 2025 06:49:27 -0700 (PDT) Date: Tue, 11 Mar 2025 14:49:25 +0100 From: Michal =?utf-8?Q?Koutn=C3=BD?= To: JP Kobryn Cc: Yosry Ahmed , tj@kernel.org, shakeel.butt@linux.dev, mhocko@kernel.org, hannes@cmpxchg.org, akpm@linux-foundation.org, linux-mm@kvack.org, cgroups@vger.kernel.org, kernel-team@meta.com Subject: Re: [PATCH 3/4 v2] cgroup: separate rstat locks for subsystems Message-ID: References: <20250227215543.49928-1-inwardvessel@gmail.com> <20250227215543.49928-4-inwardvessel@gmail.com> <6no5upfirmqnmyfz2vdbcuuxgnrfttvieznj6xjamvtpaz5ysv@swb4vfaqdmbh> <9c50b4ac-7c04-45ff-bf42-9630842eec21@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="2iwj5eprdbpucc2n" Content-Disposition: inline In-Reply-To: <9c50b4ac-7c04-45ff-bf42-9630842eec21@gmail.com> X-Stat-Signature: w8upayejf78ktwpsbqpditicbhutozzx X-Rspam-User: X-Rspamd-Queue-Id: AF5A7140008 X-Rspamd-Server: rspam01 X-HE-Tag: 1741700969-829270 X-HE-Meta: U2FsdGVkX18XqJa3TMzfrIuOgd01ZvjA2xD4kKf8WMFDvqkXCXwUpmuy/pN1CyLLOz9GSuL5rXHi/KFrpruHkFXGkqiRb6PGr3eeq9wW+Mm/aXVlRmxsDu+D4mt8Wc2GEs5HFT+DZwnqKUiMItlCF6pBQfbJ2QbaAQq6XcPe8BdyxveOYAbONqUKD/8zgEBkGcCUpb85Yvd972fFxA8UKJo72U8YwSYsrc0QSGzQeCfrtptad+Q0Zuox4A61NIKr+OO++ovyegUTk8sSAYG0H/TRTwIZrlS7C7zh62FW3DeInaO2b26ubuJ/IwRSBXLKzwbzD3Je3Q4YWIADo+5NkcNtjzvdfI4/WJ2wkysuqy3nT/GQkpyC1/nNxRRD1aZ1INXBVTx7pDudgoRkMcZlPYDhu3s0zLLJxvyKfXjsa9VbPJA67fYts8rnieRzwFVRga4fAfH8cnjmtl1dTAFv7iHnz5ABwc+NPLBFGKyno3DPJji9xbMvD1q5v2rgDW85ISHFvG2E6IQhEsFW0XkTxZ63R7BWgjeQdRtrfLe2DnF4OttnqBc75abfGGuh96lLbr9zih7Yb4HxP/ZOOjlXlTM6StLJUGTggnQdSX68FbiclA6ZpeAIsxxLm9ZoZY7i2YpeSAAjs/8M1aiDoN/n18l5DdPRd+15VmCF2k2xKGw6EtTsADcO9DyW0XhYNGJByHwyVPSydEWN3EfvVcIiios9Z49iFzr/oy8M1hhB/WS5pjbZ4nNVaxKsn8SRDZUHH5crQO2AEHssQFok7LQPesSgWpShCQiko40DQFnIrI9xF4SbveiR7n8FkSwJckVqxb9wjln+/Yz7nwL8mwQshpd8CDL0F0G0UZ8OMpkPhOmkiygLsNHehJsITQrymeqscBsiBPHwmaUhEIGW0M9KhuUKZq9hZ+QTtb+UrEu3CYCgOEDQctbgTE4auUI8phHMWOJMEySP5E1tqIz62Lv DJa1BtVr FvhecYi2NIwD5IGT4unXREt2xyU6ufdRE9tzsvmVZ3VaC2Hb9sNEEUEAL75HKWellqhJ/vGlCLcW5iRJvDsDmH2HkU691BFPh6K0fiiEharfPHUN7yN5T0bOydGsUiMzawW0BVbKqaB5GGOO5eAbI/gA+LC/3sJhNH3plxoS7tXVngflbuuUkKUseEZOsuwJMCkueUZIKeTX19EaWT8HXzuEilPPg5cHNYuj/jWJE1uMWzn7/tj36Tg777jo+kduU6ps0UF8kpNR5NTlpgrP/FVb2sqBUPcTinlHGJ5z85RMvdfAh9mufxS+//413/oVSeWiQSUcZGEVTMJhu33H2DWruaszq4cuZm8K7DLRprxk66z0gbe97y8Q694p1hlkUGQ30ncAocQ0gWqTB4IW6xJRpe9CD1gMW1Z52ecA1Aja7xzbofRC4vBHbr8vybfcv8ksPoE2v2yU56tk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --2iwj5eprdbpucc2n Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH 3/4 v2] cgroup: separate rstat locks for subsystems MIME-Version: 1.0 On Mon, Mar 10, 2025 at 10:59:30AM -0700, JP Kobryn wrote: > > DEFINE_PER_CPU(raw_spinlock_t, cgroup_rstat_base_cpu_lock) =3D > > __RAW_SPIN_LOCK_INITIALIZER(cgroup_rstat_base_cpu_lock); > >=20 > > (I see other places in kernel that assign into the per-cpu definition > > but I have no idea whether that does expands and links to what's > > expected. Neglecting the fact that the lock initializer is apparently > > not for external use.) >=20 > I gave this a try. Using lockdep fields to verify, it expanded as > intended: > [ 1.442498] [ss_rstat_init] cpu:0, lock.magic:dead4ead, > lock.owner_cpu:-1, lock.owner:ffffffffffffffff > [ 1.443027] [ss_rstat_init] cpu:1, lock.magic:dead4ead, > lock.owner_cpu:-1, lock.owner:ffffffffffffffff > ... >=20 > Unless anyone has objections on using the double under macro, I will use > this in v3. Actually, I have the objection (to the underscored macro). It may be work today but it may break subtly in the future. Maybe add a separate patch that introduces a proper (non-underscore) initializer (or percpu wrapped initializer) macro and people Cc'd on that may evaluate wiseness of that. Michal --2iwj5eprdbpucc2n Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQTd6mfF2PbEZnpdoAkt3Wney77BSQUCZ9A/YQAKCRAt3Wney77B SZCmAQCrGZJINyrqRI+1swFv3OuIJLzuOa6+2ok8ZfMh1ppsugD9EYFPHrhvMxIa MhkTkgF7mt76n5ysmfBe+t/kdeHEngs= =GYKH -----END PGP SIGNATURE----- --2iwj5eprdbpucc2n--