From: Cong Wang <xiyou.wangcong@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: linux-mm@kvack.org
Subject: Re: [Patch] mm/policy: use int instead of unsigned for nid
Date: Thu, 5 Jul 2012 13:37:31 +0000 (UTC) [thread overview]
Message-ID: <jt45ar$lq0$3@dough.gmane.org> (raw)
In-Reply-To: <alpine.DEB.2.00.1207032342120.32556@chino.kir.corp.google.com>
On Wed, 04 Jul 2012 at 06:43 GMT, David Rientjes <rientjes@google.com> wrote:
> On Wed, 4 Jul 2012, Cong Wang wrote:
>
>> From: WANG Cong <xiyou.wangcong@gmail.com>
>>
>> 'nid' should be 'int', not 'unsigned'.
>>
>
> unsigned is already of type int, so you're saying these occurrences should
> become signed, but that's not true since they never return NUMA_NO_NODE.
> They are all safe returning unsigned.
>
Yeah, I knew, just thought using 'int' is consistent, this is a
trivial patch, not a bugfix.
> And alloc_page_interleave() doesn't exist anymore since the sched/numa
> bits were merged into sched/core, so nobody could apply this patch anyway.
Ah, I made this patch against linus tree...
prev parent reply other threads:[~2012-07-05 13:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-04 3:01 Cong Wang
2012-07-04 6:43 ` David Rientjes
2012-07-05 13:37 ` Cong Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='jt45ar$lq0$3@dough.gmane.org' \
--to=xiyou.wangcong@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox