From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 357CEC369C2 for ; Tue, 22 Apr 2025 09:31:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4B54B6B0008; Tue, 22 Apr 2025 05:31:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 43D976B000A; Tue, 22 Apr 2025 05:31:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2B66E6B000C; Tue, 22 Apr 2025 05:31:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 07B556B0008 for ; Tue, 22 Apr 2025 05:31:28 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id EB170141893 for ; Tue, 22 Apr 2025 09:31:28 +0000 (UTC) X-FDA: 83361161856.27.B340FAC Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) by imf22.hostedemail.com (Postfix) with ESMTP id 1027AC000E for ; Tue, 22 Apr 2025 09:31:26 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=YLIDT+c5; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf22.hostedemail.com: domain of mkoutny@suse.com designates 209.85.218.42 as permitted sender) smtp.mailfrom=mkoutny@suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745314287; a=rsa-sha256; cv=none; b=ra10X8WXY43nUj/meay7DrGSQAif4XdrE1KSl2LiM13Y085dJq3ID3AJ8bZn8wOEV0IcT5 f7CS8ZI8LjCN9sDUXpi7uZ4qywKomcaN99LCbPKiz7BoGPnqLCAHH9sKw2XksvcB6fNmoU zuxHGNbnqUhI3ZGDgNRehplsPs1Hgq4= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=YLIDT+c5; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf22.hostedemail.com: domain of mkoutny@suse.com designates 209.85.218.42 as permitted sender) smtp.mailfrom=mkoutny@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745314287; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=V5iZrie0NfoNEv+CbNmUGa6+0H1z0sLCiVg0dRInIfI=; b=AnB4EHAJn+hWdQwPA2+E3mjnnSIjSAQQAZm9ZC0AHucMmZ29dnvMqNS0P53wNZzLrnxryG u+mE89OQSQge5MEpLryKr47JEQfjSY+ltrWKLl2K9tfod2jEy4O3GQoiunp7xMlEKJh2cx c9bV6bI/gSAiO1/d5Mt94Eqkv/yvMvA= Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-ac3fcf5ab0dso754920666b.3 for ; Tue, 22 Apr 2025 02:31:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1745314285; x=1745919085; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=V5iZrie0NfoNEv+CbNmUGa6+0H1z0sLCiVg0dRInIfI=; b=YLIDT+c5WN68+fJS+rhXYhgEmdU1XW/gJcBQoWoy4/zT0lM4kyseBlhlStdbnviawW HaqdPAbniUIhjU4fCctQHKirwlV1FRnqXEj1sNDJbEqusjyc4S934H2KPXpiNhZbKaBL HUJJNra8evTI/iE37lFTqWJBYm7i0pQZD/UaCwEpxT4v2/UUAdN2hOW3dD7Lkj1ccoqQ YM8ztvWxhdJgX1/L7PXvjTXYVaN34VPJYqqhmfTihaljNEozwH9V0rYJbXa08gi9Itn/ TbgiHN3pxY+TTVQ3KEsii1utjzDIbksrO1GUp3RLJAoboUmewcFK8zAm4LDVzOPadX86 lQ7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745314285; x=1745919085; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=V5iZrie0NfoNEv+CbNmUGa6+0H1z0sLCiVg0dRInIfI=; b=eecSYsR0KVuelVoAQWmXWOTao1QQSV0r/ss8LThg7RLNIVmS9FqXxlm+Gfc1DYRenP fpgN0/Steop86qzVrUCGXdLGSaGKGTSE1QXUyYj5XXSw0/yS2LqsOFA8Nni8N9gU2F3U znut0sCodTw0+AHCaDV2oz+QDTPOsftgRnC5JIu/L53BG0lrCn6HHupa3qkQe5pQAZrd u2aAGIOeBYyQG6a8RSO5rhvSWLGXWQ2z8XXkleAxsMrPMbX607bMrkEKRmh3LqzY/zBu mS5MEOp9v5gNH6d0khobBjzXzB8IVV9vBMNW/vLUdw/R+a3DW0Vd2wAUL41qXUmIOtxT +ERg== X-Forwarded-Encrypted: i=1; AJvYcCWhy23Yi8RaX/swMsmmsdrp2VbBGh55CjG5eArzZYlwdy1E8iUue6ppqFGtGNPCFkSFFg+9dkp0aw==@kvack.org X-Gm-Message-State: AOJu0YxAJkltkKh/npDiBXp8ki+/6nLrjiW+d95zMpg0i0BNBkpZ1a9m CR32mTlWkttA0QKKaiOEyR437OQGaTU8wyeBeJvQG0XWxQ3wHc4l9uTykDINX3Y= X-Gm-Gg: ASbGnctRYa7gALcL9NwbqVCc1UcMUScFqHByFOPnXnenwUIaYMILbzbdEeCrtlLZOEi Zj0y4t0WkkdC+vtAbZp6DH5lfB0MB2fuPjrtjh11caVVZ3EeHlBZjtU5JYc+YT6+GfE6Czsy7Gl IoMuJW5VFFUhTJCVGgrRmUDdKjlcQnET/TRFR39uWXxRWYx9fa1Maf6Rt8CJUd7l8cOmks1tJRM MmmcT0ZehgM8pFfLyMtW1t3uKuSZGSl0yB5BAb0rTV6L2qUI5ig/wpf7rfANHrg1scjyb25X2K7 L0vl2YtLzqu/ckL6TNXGljb2g1nHZLWIerU8Z4ejHMk= X-Google-Smtp-Source: AGHT+IEVRJF5sF7x1XS+lNM+Im1WgkH5x+/F/q2jlZU7fETD+EEwteY/YCeGUBJhZQKnxR2YU7TZDw== X-Received: by 2002:a17:906:5d5:b0:acb:8a2c:fcdb with SMTP id a640c23a62f3a-acb8a2d110cmr880090566b.38.1745314285271; Tue, 22 Apr 2025 02:31:25 -0700 (PDT) Received: from blackdock.suse.cz ([193.86.92.181]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-acb6efa5c5asm627390666b.166.2025.04.22.02.31.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Apr 2025 02:31:24 -0700 (PDT) Date: Tue, 22 Apr 2025 11:31:23 +0200 From: Michal =?utf-8?Q?Koutn=C3=BD?= To: Christian Brauner Cc: Shakeel Butt , Andrew Morton , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Yosry Ahmed , Tejun Heo , Greg Thelen , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Meta kernel team Subject: Re: [PATCH v2] memcg: introduce non-blocking limit setting option Message-ID: References: <20250419183545.1982187-1-shakeel.butt@linux.dev> <20250422-daumen-ozonbelastung-93d90ca81dfa@brauner> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="i2qhcekndg5mr4b5" Content-Disposition: inline In-Reply-To: <20250422-daumen-ozonbelastung-93d90ca81dfa@brauner> X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 1027AC000E X-Stat-Signature: ptb6xbas9k4tz9daozsm9uptafzomcot X-Rspam-User: X-HE-Tag: 1745314286-859759 X-HE-Meta: U2FsdGVkX19mTrTKfg42Vj4EIFdkkco6HJANMpPiwKa4E9L1HWc39HUlf+LiuHhTLlELapoW040+oekUhhgNbk6lr19GKk0FPbmdMKuvk3UyuFHUgOOFoXmLVA7yR/eEyfqon15eSao7QgvbSw0laVCM3/IGZEuh6zABMZECS/DipIUnWILKyzsX/YDNS8c7oEJhx9SodaIHoIdP6G6+rWArUs2pqbo4fPjiAqqz2c+vl5fQobgneHMfAuq6DjXqhOS1+rSv3Y6sFfVx3S9dBcO8uwXQE9ev7kSnkFS0z6xRCUyI+xp7UJvLlEgWwAU+lA3nOwCBRNkFEeL00D7y4c+hvtbkF6SdQBBaXgGl0RIoj8eZhKK0xKuvCXPR4A6W5xkXIKecfw8DE5hKzFuVBsqWogVV5RPTfAn5u+eVBrSvrgPTcNZI2kjxBIhdRJaN+NOBaOGq+CynSDxDeLiHUFB2lZ1BnHs9WMusMfbQOW/ecirXGbRihot9Insy4wzfCmieO+RqTtqzCtSS1HW1rJYB8LxbOCwgTYMsI+Be0I/V/zZZNH3FwkVKfsqYjcnFuoSUCViXdG0g6d/nHjYl68ZSw3Sezt2miCaWm3soOvqFHx2ye4PJprWKQF9NGle/NpWdj6R/DpURCjbSDA0mTQpOauNrAZgwlnd9nBsXa7O2LPQ36y+t+EAVNP2c1XPIPVxLsXvQ7utbI6+oh4jWK0sacvS6hPsxQenjWF0lk6tfsj8ZUvqR+PIzT9QOuyPZL6ReVC7v1YTBmyDTAiJiyeXji86U4SAslfHzUNurLE2BNYyB0XFOwAY6djwtKdPAxbG1gp7Cq4m3BfHfNTUF3nxE94YvmwFP8VryVVXKAcdNXAaDWE6xbC18SMsU7tuDaBwVT+PH3Z5Bp5etoo16gyRiWdxwiNm1jsEnm7L/BpS2gTkN0WEpT2ilCQ5JTrCnPgeX3/I6cV+7j01pOtO OvrlHp3Q pWASWIWzbgfz0Qu+DUmEM2VAOMNCl+ID/OPurMTPmg98kXBir3pDflQ/r4DehnYTrmYfYlOLg09nntVnvzbBjDvthrfpcr1G3qTZV1IzxSVS8bsnedJcBEUiOARXPDc61vrGvgKf5oqes9zmzMwjUf8qf/ifxbS5fkW/XN74E5gWWa4nTI5K+WYQKUhbEWXqR/CJP0uTIOGWjM+DzKY3tECkaroXVZS/zHu9WA1xSsV3gkJKm+uFaOv5N0JycOE2ftJwNmGert7Zh+V2o3jsXuU/6w/yZkKJR/PLf8TUf6bYJq+HUVwg0EgGqS4Sgwx1hFd7us0bWrlZIEziZ11x4D57shgBiifwkioGivrAXImnZbwW7TfE98t+3ssgCd4pTLnzOoy6xAPa1lxmEIRZSWYpNiRTK3U6L3edDqW0xflrEKwhnKGtYux6wcbQlWcrJlbpbxLUipLJF3ig2CCY0FtroS8eMWhNeUF0TPs/rL/1sjXHokn+mWj3Sw8ifQD73qIDd X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --i2qhcekndg5mr4b5 Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v2] memcg: introduce non-blocking limit setting option MIME-Version: 1.0 On Tue, Apr 22, 2025 at 11:23:17AM +0200, Christian Brauner wrote: > As written this isn't restricted to admin processes though, no? So any > unprivileged container can open that file O_NONBLOCK and avoid > synchronous reclaim? >=20 > Which might be fine I have no idea but it's something to explicitly > point out=20 It occurred to me as well but I think this is fine -- changing the limits of a container is (should be) a privileged operation already (ensured by file permissions at opening). IOW, this doesn't allow bypassing the limits to anyone who couldn't have been able to change them already. Michal --i2qhcekndg5mr4b5 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQTd6mfF2PbEZnpdoAkt3Wney77BSQUCaAdh2wAKCRAt3Wney77B SV5jAQDVSm6Ja4jGC2yTv6E/hAxyTENttqmaX3cnbiAR/btTsAD+NHYf2vRtgkRC wioHPKWvbJ4uZJ+rnc/qtRcKN2hyhgo= =b8xl -----END PGP SIGNATURE----- --i2qhcekndg5mr4b5--