From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E622C54E60 for ; Tue, 12 Mar 2024 12:36:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0A4728D0047; Tue, 12 Mar 2024 08:36:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 054068D0036; Tue, 12 Mar 2024 08:36:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E36B48D0047; Tue, 12 Mar 2024 08:36:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id D0F2D8D0036 for ; Tue, 12 Mar 2024 08:36:27 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 9E9C8120598 for ; Tue, 12 Mar 2024 12:36:27 +0000 (UTC) X-FDA: 81888335214.23.395D71C Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) by imf29.hostedemail.com (Postfix) with ESMTP id 7ED36120010 for ; Tue, 12 Mar 2024 12:36:25 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Ww8cvI0F; spf=none (imf29.hostedemail.com: domain of kirill.shutemov@linux.intel.com has no SPF policy when checking 198.175.65.20) smtp.mailfrom=kirill.shutemov@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710246985; a=rsa-sha256; cv=none; b=3PZjuMJWzvwZuMOigv4mqZOEaRMUFDaqPjv9FubIplBlDqlGP/PXGVCRXs2lIL3lTw9ZIN 7ejwzwCd30eW7Hpk7iJ1Kqam0TcQxR/ERh1/dvvWXtJeDrTzSIhlQIZXj+77aLoCTtMGTO ne6XsPkuk4Hag4l9O0x5dmQcyjOLAdg= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Ww8cvI0F; spf=none (imf29.hostedemail.com: domain of kirill.shutemov@linux.intel.com has no SPF policy when checking 198.175.65.20) smtp.mailfrom=kirill.shutemov@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710246985; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hEovke+9JUAscMogDxZgjbZxMwS6JgLRoKVMzDBV0YM=; b=dLymUZoVPyNVLviJioKSEp5AQRdSewwMpp4kl1FSW1S8rUf/KgFqcYqGJpijkaIehz2iTx H7G3iFD8CD5c9p15LMTK2WAMdXHFxexFIkBQOhv8lkmRYGE8wbgJzP7WYNP81nzoycgo3b XzayIbENIND0DbovzyoOQNvLIKo4W0M= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1710246986; x=1741782986; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=Msp8CavuCxkwBzmx3Zc//1lyf8RG9ukhad+UhCA9Vfs=; b=Ww8cvI0FfXTxEDW5ShcjPwcfCxbiNphJJX0ElcmI+PP00BCURZ9PKqT/ gFVC1az96TTdZjZiuPPOkQx2FOxk0PtyIdNsO9caxG0KwMqC1LckpLYUD ObT4I96Q3MEvvt+sDAsG9wz1le/VA8+hB7JLPumoKoWS5UWfb6knHKXlt J3XsnAuOcBlpzcmxheKEi4+CkF9g6nR3xXZTGrDjnsVAEzVRO6detMlUU EVHFhR8NPCQi0TLLzJ939+nkcH9MAaY1pROBYu1sCVL6BubrA65hanyBM jgEKwc3vAYCpRfbbnhq7H53fled2XQRrxEzy945tsW9vXKtWr9k54Gk/z Q==; X-IronPort-AV: E=McAfee;i="6600,9927,11010"; a="4824023" X-IronPort-AV: E=Sophos;i="6.07,119,1708416000"; d="scan'208";a="4824023" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Mar 2024 05:36:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,11010"; a="937051835" X-IronPort-AV: E=Sophos;i="6.07,119,1708416000"; d="scan'208";a="937051835" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga001.fm.intel.com with ESMTP; 12 Mar 2024 05:36:20 -0700 Received: by black.fi.intel.com (Postfix, from userid 1000) id A604C27D; Tue, 12 Mar 2024 14:36:19 +0200 (EET) Date: Tue, 12 Mar 2024 14:36:19 +0200 From: "Kirill A. Shutemov" To: Yosry Ahmed Cc: x86@kernel.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Andy Lutomirski , Peter Zijlstra , Rick Edgecombe , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] x86/mm: Cleanup prctl_enable_tagged_addr() nr_bits error checking Message-ID: References: <20240312035951.3535980-1-yosryahmed@google.com> <20240312035951.3535980-3-yosryahmed@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240312035951.3535980-3-yosryahmed@google.com> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 7ED36120010 X-Stat-Signature: g4a8rr446gnwqhngrta3kf86u1ntewz7 X-Rspam-User: X-HE-Tag: 1710246985-183184 X-HE-Meta: U2FsdGVkX18G9Xuzi4SSn7MJD4/2jbWZOFHb2H4frv6xKKPA6nsQMOEzDknL1DZo3wheduQFpXnRWUMNMPyBiqkVKMAZOncElTMImvqaogox48kbEoALPd0fF4/qdUtLTpUHUSQ2SpI38EYDYl3pYf8EbBvEvqtHWLIC3PP8tf1dKxUBFdIhUPvM+Fgxp/881LPA0/OfT+h6JiNw5t1dquteFj46m1TjHB7PGU9E9v3G9z6M/cDdVkccfqRdXeGgbj6hb+xS8EGlHGCrGd6LMhCICwzq/buIeFbYbLDLMWjhsh3JrAybwJhKPP/ZXUVrNIb/4Lt6Lz/RuttZ4TlDkHKHcP4Tqmn6H3YCqr0Dc9nPX1fLGsaGOsecpHZHukOFrdypY+jEm3RvK42vjee566qhwE2KgwXZHeuL/vCwy4bB9WNWrKI09bOF73nR290xKZ1ouGtR00GOmvMw+ZMwrA1cEbuuUB9VfwtuiMs3pHOaTlpt8mMl6rTdBGWLlSa1QVGMWy7gpVVQQv5hzrR3NDQ95FxH1qECtQTqMqyg1u8pzO00bSxG/Sds1UuSTt8QDslGBZUaMBiTOYFoeabGQFoH5TBNj+vQUDTlgI+nixVbB7wiPXJvBdN8hlpVJATgw6Uso7Wsu2qteEeOifX7wl1cU70vXfPrlnBcSHfPiwG+wEE/s5Y04xxR0bN/kIDQ3s6OHnvwLKbnlqPiFa1/WkuTbSINFmwvUFUDeTNTR+t0zEAtz7OrlOi9bQ4mtyzM7XD3HIL2KT2Qg7JAYVVtgGyybN6zSJ6n3kSwFsCi7WrCPcskxiPT1TlfFTsi+b/U60Y+jV4OGgqi3VlQPpUikaOizur4nNN86tZXhFLlk+1qTm9xAgU1fv9FRTjT+lArwGn+TipDMR+OBZj/PGbGdG4CGW24vBqyTP9MbizpDMFMgHX1UjkZARa/n6lNuXFE62/ukJhsRf7/Yl6XUTI PBGGrrMx If3JfqhbxvbeCRn16Qa52Q6Mo6JgstaeXBiR8Foao5WUK2VrmwPHEFPkpS0H4cTdVsP+OQpqLsSPMrgioRlYlLSvJzaAFDIe6yattXUJnjo/tA5zVR/5xmPyMaTXvisRVIUOAnmhDD+H4icx9cJBxXKaomaAHmkAKiCIwrLaa5DB4hy3JV3CkL+o2mJJRHZL+BE85mP0Bgc+ybD8rViYWEb0VPNOl+m1NIPkv X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Mar 12, 2024 at 03:59:51AM +0000, Yosry Ahmed wrote: > There are two separate checks in prctl_enable_tagged_addr() that nr_bits > is in the correct range. The checks are arranged such the correct case > is sandwiched between both error cases, which do exactly the same thing. > > Simplify the if condition and pull the correct case outside with the > rest of the success code path. > > Signed-off-by: Yosry Ahmed Reviewed-by: Kirill A. Shutemov -- Kiryl Shutsemau / Kirill A. Shutemov