From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
To: Yosry Ahmed <yosryahmed@google.com>
Cc: x86@kernel.org, Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Andy Lutomirski <luto@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Rick Edgecombe <rick.p.edgecombe@intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] x86/mm: Cleanup prctl_enable_tagged_addr() nr_bits error checking
Date: Tue, 12 Mar 2024 14:36:19 +0200 [thread overview]
Message-ID: <jnpv2ijtmiq4ubnimt7ofgq7pjbygyq3ggqsppgqcqvwigdnpr@urnckuntqx2i> (raw)
In-Reply-To: <20240312035951.3535980-3-yosryahmed@google.com>
On Tue, Mar 12, 2024 at 03:59:51AM +0000, Yosry Ahmed wrote:
> There are two separate checks in prctl_enable_tagged_addr() that nr_bits
> is in the correct range. The checks are arranged such the correct case
> is sandwiched between both error cases, which do exactly the same thing.
>
> Simplify the if condition and pull the correct case outside with the
> rest of the success code path.
>
> Signed-off-by: Yosry Ahmed <yosryahmed@google.com>
Reviewed-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
--
Kiryl Shutsemau / Kirill A. Shutemov
next prev parent reply other threads:[~2024-03-12 12:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-12 3:59 [PATCH 1/3] x86/mm: Use IPIs to synchronize LAM enablement Yosry Ahmed
2024-03-12 3:59 ` [PATCH 2/3] x86/mm: Fix LAM inconsistency during context switch Yosry Ahmed
2024-03-12 12:35 ` Kirill A. Shutemov
2024-03-12 15:34 ` Yosry Ahmed
2024-03-12 3:59 ` [PATCH 3/3] x86/mm: Cleanup prctl_enable_tagged_addr() nr_bits error checking Yosry Ahmed
2024-03-12 12:36 ` Kirill A. Shutemov [this message]
2024-03-12 12:24 ` [PATCH 1/3] x86/mm: Use IPIs to synchronize LAM enablement Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jnpv2ijtmiq4ubnimt7ofgq7pjbygyq3ggqsppgqcqvwigdnpr@urnckuntqx2i \
--to=kirill.shutemov@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rick.p.edgecombe@intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox