From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 981E5C83F18 for ; Thu, 10 Jul 2025 07:56:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 18B886B009D; Thu, 10 Jul 2025 03:56:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 13C056B00A0; Thu, 10 Jul 2025 03:56:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0798D6B00A3; Thu, 10 Jul 2025 03:56:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id F0C9E6B009D for ; Thu, 10 Jul 2025 03:56:18 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 6BEDD1D986D for ; Thu, 10 Jul 2025 07:56:18 +0000 (UTC) X-FDA: 83647597236.17.EC1C0A3 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf09.hostedemail.com (Postfix) with ESMTP id 311B7140006 for ; Thu, 10 Jul 2025 07:56:15 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="UlSBw/v2"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=LXJxHKgt; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="UlSBw/v2"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=LXJxHKgt; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf09.hostedemail.com: domain of pfalcato@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=pfalcato@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752134176; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=soczQF42Fe2kavIG+s9yiq1xrLUBCGtgKG1Ot1oYmXE=; b=aREIGVw4Z6wD8VDa19EU6gLLTRSVDVfffwAgwm7HjR7j572RPr5AyDm7CoACShBf0HJ/9v 01Aode89W2MjKaGGbLxL96xQwdAVHj0OXae2XuL3sTKPWIuaiTfy2s8akSSCy/srWlBER+ uy7YhBRb4I5RzamOFS1ax8GoFVHmUeE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752134176; a=rsa-sha256; cv=none; b=RIykf3xGKXXMFisUI5XqCKw+EBMKLuUjSSBT1fWROFOqLR18WHMaATixlwLekGp1YT/HOj QcFns2qTdvxTIhV5wcekZaxiq/U/5sd7acJoNe4qpo+XzU8PGz1Cu7RffzjK1fdrZjYfry /iiEU/r67rdKirYlSU9YSIuLiefLH28= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="UlSBw/v2"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=LXJxHKgt; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="UlSBw/v2"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=LXJxHKgt; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf09.hostedemail.com: domain of pfalcato@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=pfalcato@suse.de Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 80B0E21164; Thu, 10 Jul 2025 07:56:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1752134174; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=soczQF42Fe2kavIG+s9yiq1xrLUBCGtgKG1Ot1oYmXE=; b=UlSBw/v252otnM56csjWgaV9Rj85CdJI2WZ68i2ToakkKNMuuj4BUHyrDqOYBP0Yg9fC2s MPrul+tbasxa/GBbze26CzjqyBGa61uZ7iJD5Stui6rX9EdhWwRIiMVJC+n/k4+IB8eJyX UQeczDm0tSPL/wqjAAudiOT+TDLGTH4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1752134174; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=soczQF42Fe2kavIG+s9yiq1xrLUBCGtgKG1Ot1oYmXE=; b=LXJxHKgt5tzjq1cZEtxb1MWkDYWJupv6wNizye+Kh14CyRRRahsD+gMDBsoFlcdCi64YwO d+HAQju7Wv4ULlAQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1752134174; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=soczQF42Fe2kavIG+s9yiq1xrLUBCGtgKG1Ot1oYmXE=; b=UlSBw/v252otnM56csjWgaV9Rj85CdJI2WZ68i2ToakkKNMuuj4BUHyrDqOYBP0Yg9fC2s MPrul+tbasxa/GBbze26CzjqyBGa61uZ7iJD5Stui6rX9EdhWwRIiMVJC+n/k4+IB8eJyX UQeczDm0tSPL/wqjAAudiOT+TDLGTH4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1752134174; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=soczQF42Fe2kavIG+s9yiq1xrLUBCGtgKG1Ot1oYmXE=; b=LXJxHKgt5tzjq1cZEtxb1MWkDYWJupv6wNizye+Kh14CyRRRahsD+gMDBsoFlcdCi64YwO d+HAQju7Wv4ULlAQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id EAF18136CB; Thu, 10 Jul 2025 07:56:13 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id Fi4lNh1yb2gmLAAAD6G6ig (envelope-from ); Thu, 10 Jul 2025 07:56:13 +0000 Date: Thu, 10 Jul 2025 08:56:11 +0100 From: Pedro Falcato To: Xuanye Liu Cc: Andrew Morton , "Liam R. Howlett" , Lorenzo Stoakes , Vlastimil Babka , Jann Horn , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: simplify min_brk handling in brk() Message-ID: References: <20250710025859.926355-1-liuqiye2025@163.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250710025859.926355-1-liuqiye2025@163.com> X-Rspamd-Action: no action X-Rspamd-Queue-Id: 311B7140006 X-Stat-Signature: it7irthbnoo6bqtcq67pk637eopegxcj X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1752134175-704756 X-HE-Meta: U2FsdGVkX1/k1eyngUUcOSZw+xs/Yrj7s6YDtCt24Y8iGTqhDoPm0xTJtCY7GAilNX0i0tpgfmjZHIoPWPyzNkTTxEstaRNTafWB1tz3jJcUPoF3g+LXWhV06QeOC9So6OKmS0y5NezSjJkWKotNQEK2zu7ck2TJ4ohZTHOpnfY8Lix9FFlACVAAW6XcvblOipEZOwEpIO0U+EQMMzXSN7WLxI26JAr11M5gvvIgmDX4q5PYpDwfcEKr3FpC5R544LvrMeQpUDFAT3h+2IOe4463atC0SzW5ftf41QqPt+pTeCsjffK41FdOlhmlez0TUVkYr4am+g+j7/Li6s9nRtz0Tsq779wvP6g956njOfrxF5R79jywIxOPf8EVfsW3389Ewl78Agm+/fPJtrh4v7LX1EIAAYPisxgKsOFFNfYSoXMwbZBKp/7RvQcdkY1OuVGTQu2XYN1uajAN3n+SMoA0umymueZU6AVGgKla7kYoTpr80NblDMgG/iHqCYXdxvfzMTLkXgIWLtB4LegAvUWg1a9Xw7QCiEmAg7zUq35TAhuCCtKs05czWrb3pov0nI+HX6YYW7R5jEkz2DqNcv5rIkZIg7ETkujy1hib51H13d1yGbCjqpdi8aszwkYKpipNI9PzbAYo5XelIw24WSX68cthLhNBMtUNvni7D45KrinVoW/z8i3eFdzqUX0DprF7+NOqiEZMp0z2K9OxZGLRKUFdkQhp/zqlPcEtxfK7uU7ofVWWRlT4LLJEwBPxma/q+86G7zRqNHy6ir2fHHAAKWfWGbEsGBDGXPlezPDglznDjtwQFe9Z1n8/o8aDdZEhg3+SR98fz5dcXS6yomOHgAQXhSyuSLKc1i6P0755GAvwjNGBfaZPfdQjiuWSeTuJ+HSoNoBq2FW090dS88Zknk/jWH1bxLapl4YE2ae6CUWvU0vbNCqanuk3/jaXSO/dUzVYLHWMsTogbWq Ewf3qTQQ HEjqKwR7XrN0I7YnM97aYDghGHY3Lnb9Ozh2VYXddJhvlJls4Q8bL/Df7KTrYk0eVjvxUkZJcExBSNRI5PuBiijeYKtf8xybowPs9ppVFBEGZGYPGVXJZLqPt55mwUoAK8xGC8L/4SRCbdcJwx9546EQ5DBnLJFR4GwmWdV7gVOuGanS3aZV8IGxa6QLlvyhlLkfONI3ruIBUYImOReMBvQflxTUr7CL8jmPOjoYRdwMq55b091ZwTao4EDQU/czp4sR92bpwdqjpCWU14h5ekhm41oASNUTVPXScjtEA5aAYBFkpl0m+gZF/ExNMVOsVTpKgUo6AsVSwYzpgdhwPQHrGNIbMYAl5nbNyBTQItONjK/SNXh+6z8bkXypT/4FsoNJwHUWT6cEUrqt5qdqLZjGjwhRuQr4HjKQSumAuTMR8ksE6cKLvLwbxzedm+gM1t2alw2IQnaK072U= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jul 10, 2025 at 10:58:58AM +0800, Xuanye Liu wrote: > Set min_brk to mm->start_brk by default, and override it with > mm->end_data only when CONFIG_COMPAT_BRK is enabled and > brk_randomized is false. > > This makes the logic clearer with no functional change. > > Signed-off-by: Xuanye Liu Reviewed-by: Pedro Falcato Small little simplification, looks good, thanks! -- Pedro