From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71F58C25B74 for ; Sat, 18 May 2024 07:33:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DAFD86B008C; Sat, 18 May 2024 03:33:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D610B6B0092; Sat, 18 May 2024 03:33:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C26BC6B0093; Sat, 18 May 2024 03:33:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A694E6B008C for ; Sat, 18 May 2024 03:33:06 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 148B0A1653 for ; Sat, 18 May 2024 07:33:06 +0000 (UTC) X-FDA: 82130700372.01.07A0CCB Received: from out-180.mta0.migadu.com (out-180.mta0.migadu.com [91.218.175.180]) by imf15.hostedemail.com (Postfix) with ESMTP id 8C160A0002 for ; Sat, 18 May 2024 07:33:02 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=ulqVIej+; spf=pass (imf15.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.180 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716017583; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qqPyvdWYTMHcHihrv+EK/h7p68sko7PuO9n/H1g00I0=; b=lXUV90yxDu2g2CkCRvuvfKfzA7lGvig9Kz4Eod6ELXYTOK9bUFjjlipZlsyCQ8TgutfEKg ZTQdxu+9NWk0GX4abVXZbRMulEwdu5AEGQFQX+KE9IwJe1AOpe/iOcZRrAmgq7plJxCQuD YUatF5D2FujALXnr0c5oMOyj/pHO7rQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716017583; a=rsa-sha256; cv=none; b=NkdMbP/oYRPGLbS0J4fgERzSvwiHlfnB98Eq9SjiYBrl+eYwkrqLye/n8WuH8Aw+qkHVXC m667qC+6yhK8mpuf/gHVfmp6l9JdlXQzNReyqSWZ2AxfbM1lyOB5oW1a2UUhCNCJjEumXO e9+Y69vebKplyuVde4uOd+vwhlgzGVo= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=ulqVIej+; spf=pass (imf15.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.180 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev X-Envelope-To: laoar.shao@gmail.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1716017579; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qqPyvdWYTMHcHihrv+EK/h7p68sko7PuO9n/H1g00I0=; b=ulqVIej+JwhAAQkqV7OUeeEqnGOoh4rkXTdANOPQOyyoA+fW23umXjRuhWZ81N2O1RAarh i/7tc2pyx+R/X4runtP5kLsQhBj4+3JeXMJbGK3G3d3MWT8z15HheiFp2DcV1fIWLbRyWX UNRHz7L2KtPtUEd7abcQ7zVAk4XQ8wg= X-Envelope-To: yosryahmed@google.com X-Envelope-To: roman.gushchin@linux.dev X-Envelope-To: akpm@linux-foundation.org X-Envelope-To: muchun.song@linux.dev X-Envelope-To: hannes@cmpxchg.org X-Envelope-To: mhocko@kernel.org X-Envelope-To: willy@infradead.org X-Envelope-To: linux-mm@kvack.org X-Envelope-To: linux-kernel@vger.kernel.org X-Envelope-To: gthelen@google.com X-Envelope-To: rientjes@google.com X-Envelope-To: chrisl@kernel.org X-Envelope-To: ivan@cloudflare.com Date: Sat, 18 May 2024 00:32:53 -0700 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Yafang Shao Cc: Yosry Ahmed , Roman Gushchin , Andrew Morton , Muchun Song , Johannes Weiner , Michal Hocko , Matthew Wilcox , linux-mm@kvack.org, linux-kernel@vger.kernel.org, gthelen@google.com, rientjes@google.com, Chris Li , Ivan Babrou Subject: Re: [PATCH rfc 0/9] mm: memcg: separate legacy cgroup v1 code and put under config option Message-ID: References: <20240509034138.2207186-1-roman.gushchin@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Stat-Signature: c1xuzhnbe1qpp1ztpe6bo3ieswoa7wpu X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 8C160A0002 X-HE-Tag: 1716017582-850112 X-HE-Meta: U2FsdGVkX1/xCIgyhnCvsRMmE9mAOzt1gBajK6Aof52TuSeRrTzj9dFgr/wvM2Qg0tJVCxujvbLSYQh4I0CJaHrbM20WzG7n9WttDCgeuojrewpG4ncDvnh1fnd/1ZaZiCRt9gffjNoCs18QRmjxpdWRpWLz1TSpEmJFrMDobdyt2Jmccyoq2lIgIqTfGaBbpFgVy0Xt37D95NewEvJGyFyDy2cNjy9NkM28jI7C4kCFGVuf1xfDmTuh0eKGiu09+wdu7I/jhRrmPD+4TudX0aGs92VPriNVa36686AFiU8AT0dVk3CR4QLNL8YyAX3hj6IQXGu5y0yQ9B2Br/4q5VC0qNMh6tG2itZ9Vg4iwtS2huYKXIzfo0tpGi3ZbYMFbjMEcb3XGZLT2ZKbKBNzsaTRzZXKv/mYSXlPBQTqwQX1XH3fefnf4TLDoZyJf5xhGBwYcXYcmG64SbYz2r3HQbmZperbbSixejWEsG9vaCi37PlJbV7BsGVNYd+06D7NJEI1Qx/pZA5e5WLtKYw/YlcHKLLQvhjFlh6piXG8E+gBX1XoDhHI4+6BvNz7KNAD2dCeOyKfZzJJdV+KqWaqv33Zc17KUiEWxC4VyWS2UfMlslFk7zo2BF2XjUK54a1KNi70tlWZHMkFZZ0clgOEOLeh8yT0mT5GkHC9dUaIp0HebMF2Tsv7+9ZrRKq9YvEU3VciN+SYz5Yhb+qYKenaVRvSMoc5F9+haFnEloOShqtcmL3AbdcffmT1Xz36CzSTRbQXOBjSd1NEctDUekdwz3hzs33JkUSKO4JG5Kf9850oaw6RalcSluDGfnE8enHhyWNfc5MZa9qaX+9Nay3JWbLskCR2Y+B2otfhX7IkDYPPYfIIjdnffuCiS5BIvB2s2lWHwJfXpKzzxQbYMU1BMH0iForXOFw48DfOxyf2tuCaMK+VH5JujJS/I8xOCz+QKfNlgC+JubCeAsuqsTl P/f4y9pe 9tFJbwjgMTOI9a8eUah43WNCCH68ufe6nWYOaJzCY0ZSjR0plzCxurWL3n2zHwmfYdB/P9gTI9jXL7yY97W5y9ovBzIIpZKxKK4i8Ns71q/dtuhasv7gfKRdm43gJotH/2u7/CubKmxWsBfz+qCsbdHvawT0+f9s/tMVcnNIwPhLQIejhonOLpzbD9jZsBlmrKTiah2m7eAz8wMX2z7w64WJk8ALuD3+l21Q+1oUZYiFnSDo8NF0f+GKI9nutbZ1xPf6fPpfcg1Zh2VQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, May 16, 2024 at 11:35:57AM +0800, Yafang Shao wrote: > On Thu, May 9, 2024 at 2:33 PM Shakeel Butt wrote: > > > [...] > Hi Shakeel, > > Hopefully I'm not too late. We are currently using memcg v1. > > One specific feature we rely on in v1 is skmem accounting. In v1, we > account for TCP memory usage without charging it to memcg v1, which is > useful for monitoring the TCP memory usage generated by tasks running > in a container. However, in memcg v2, monitoring TCP memory requires > charging it to the container, which can easily cause OOM issues. It > would be better if we could monitor skmem usage without charging it in > the memcg v2, allowing us to account for it without the risk of > triggering OOM conditions. > Hi Yafang, No worries. From what I understand, you are not really using skmem charging of v1 but just the network memory usage stats and you are worried that charging network memory to cgroup memory may cause OOMs. Is that correct? Have you tried charging network memory to cgroup memory before and saw OOMs? If yes then I would really like to see OOM reports. I have two examples where the v2's skmem charging is working fine in production namely Google and Meta. Google is still on v1 but for skmem charging, they have moved to v2 semantics. Actually I have another report from Cloudflare [0] where the tcp throttling mechanism for v2's tcp memory accounting is too much conservative for their production traffic. Anyways this just means that we need a more flexible way to provide and enforce semantics for tcp memory pressure with a decent default behavior. I will followup on this separately. [0] https://lore.kernel.org/lkml/CABWYdi0G7cyNFbndM-ELTDAR3x4Ngm0AehEp5aP0tfNkXUE+Uw@mail.gmail.com/ thanks, Shakeel