From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74C91E7717F for ; Tue, 17 Dec 2024 17:48:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EEAED6B0093; Tue, 17 Dec 2024 12:48:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E9AE76B0095; Tue, 17 Dec 2024 12:48:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D62916B0096; Tue, 17 Dec 2024 12:48:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id B39EB6B0093 for ; Tue, 17 Dec 2024 12:48:08 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 6E2E91A088A for ; Tue, 17 Dec 2024 17:48:08 +0000 (UTC) X-FDA: 82905183732.26.AD4696F Received: from out-184.mta1.migadu.com (out-184.mta1.migadu.com [95.215.58.184]) by imf02.hostedemail.com (Postfix) with ESMTP id 17A8E80014 for ; Tue, 17 Dec 2024 17:47:05 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=fH9xRZDk; spf=pass (imf02.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.184 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734457664; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=efnYIenBfJcT4zbjbUdusYKdPVtUJ13mjfZw0f3fRRI=; b=UxFqoQlpmkVv/t6phTVyCMKBZzvjs380CoBik5dCZ0Krz3jngPr/gl0lM2HJtVf9EHWimu vX59TMznWFLMr2Fhu/c+/lyF5Ggjzka2gl9jANyBeO8izLzXBilE4MMi5TAdD5pjofg/Be TWX/7XV0BxjhZuZzFJHxZF/f97wwfJo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734457664; a=rsa-sha256; cv=none; b=uOiUgzgHgSEbsWDZGfoZNe5GykIPzRybF8V/wqcJhMYQqwJe/768/TX+okPajvu0CKNx3w Zhy17NUtsXIeezOLP2W9fqzvUfrrWSWpLj7clXwqYCjfz/IoixMy9/R6Z7eiSmdP6JrvSO zpnfjwhLnQzCqrVkIKPIbmU6z5qgIyg= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=fH9xRZDk; spf=pass (imf02.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.184 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev Date: Tue, 17 Dec 2024 09:47:57 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1734457682; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=efnYIenBfJcT4zbjbUdusYKdPVtUJ13mjfZw0f3fRRI=; b=fH9xRZDkXZ1XJHghzlEPi3AXTRpW+CTSdj+Cj9d1lcBApm4zr6uOMCdQu0fRy72Axz13q8 U9PP4HejLIIfRSdazBr0XfagLapij+ZVhrMVU+zqMkqF6WeD17BfreuAjcGPFx13lSD/XU yzyQ6XFf9LLzRL2tBlrhJEPyoRMlRl0= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Chen Ridong Cc: akpm@linux-foundation.org, mhocko@kernel.org, hannes@cmpxchg.org, yosryahmed@google.com, roman.gushchin@linux.dev, muchun.song@linux.dev, davidf@vimeo.com, vbabka@suse.cz, linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, chenridong@huawei.com, wangweiyang2@huawei.com Subject: Re: [next -v1 2/5] memcg: call the free function when allocation of pn fails Message-ID: References: <20241206013512.2883617-1-chenridong@huaweicloud.com> <20241206013512.2883617-3-chenridong@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241206013512.2883617-3-chenridong@huaweicloud.com> X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 17A8E80014 X-Stat-Signature: qwoxzwtznojwfu3iqmfpnzt6c45mrtxm X-Rspam-User: X-HE-Tag: 1734457625-561288 X-HE-Meta: U2FsdGVkX19GUO/e2wdm9cuj5X4mzsoIHlK8yqKipGWN9CdqTgP93uWkVGZZjHtfUqpkaCrDUFjntwC1Mr6mZ1PXj5W8nlo4q6rMbLcWUMgURuqcLHdxOdyBUEp6LIJlbIFa5mGWJkVMru+zJjynCX+qzp8DI5vlzyCrNBK+s086UO523C+XjDr3pCeQj9dyS8viaMzwgxDq61sZLqG/9XN5aqYiU8k2PipPBQS8qoOogrtgtw1gvB2c0sgjA8qOTWtC0Gc5kSOYvdVT5lA4zTIuNWF8szonq4GqqlpP9vHWkGChoJJjwqJ0gKjPW8JvnNYX87WdjPKtJ9drKbrztq8T7Qt5nj70E+n7f8/P+9KOgTS1s2h/E30KaRnlJW2Gh0oBbB54KGRSPONsaD7VlhTOWDdRYbcKUxHWC0GwSyTTAWCadGvM4foIlEbPeJT87gUdoTGf5UHpkGYgzC5YaBALb8AWooJhZ01FiASYaMWjD/ZFAX555PInQaiWUcqm/HZYbWHG3HRgCh6bTayeY4BmnqqLrdUjC6WMxvta0dQD9gfqprlV8XMOLuvNTERPuNYjLmm+VtNeguvR8iOHAPISbwUGT9MsV9wYAI629+J4xaY0OJWWP7f1tY6YrCx1izhDArLlhye1NV/FZmL0JvptxVX03vZVUuN5XzgUbsjeCfQc5RcriTr4NYsSlnDrzFAHfD2h9q+hadydpLh+bZKrM/rEig7g72WZz9Lq7ymg77t0odiKDk81krDfF064amFFpGhTlcqeYvBODLuc11DDE2HDjbXYMg9o878A23257ecbtPCv0toCePOlUgJqsOygzQycKVD3vngGSSBEA6MKULGOugVoV9KimuUSawUMWVUm7WaRgWmv9lNIcog5fht8s3K5gyQ36pvoFlgmFpein9F4uHDBROBt0ryffSWRVjPEYlJUVYg/SxTxiKP3CSTFw7oiDa4UHVFi6Kp hzW9qZpm 4GV+7afD+X8fpCpYW+BNzHnbYcnfKCbNeVXbSbB2dCboU6HRTiKzMU4TwyzJzjWDeD1L7pc4akz0PpeXlLLmm1GsXGzzZVO4AseUjCaFZOtLmwNsPNa/7by9S3n95lAXYwN8iGDv7s1P/XrAFDau+g/HUYMQD63nnLGNEkCA5P79ICK8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Dec 06, 2024 at 01:35:09AM +0000, Chen Ridong wrote: > From: Chen Ridong > > The 'free_mem_cgroup_per_node_info' function is used to free > the 'mem_cgroup_per_node' struct. Using 'pn' as the input for the > free_mem_cgroup_per_node_info function will be much clearer. > Call 'free_mem_cgroup_per_node_info' when 'alloc_mem_cgroup_per_node_info' > fails, to free 'pn' as a whole, which makes the code more cohesive. > > Signed-off-by: Chen Ridong Acked-by: Shakeel Butt