From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8161EC25B75 for ; Sun, 19 May 2024 17:20:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C81506B0083; Sun, 19 May 2024 13:20:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C31FB6B0085; Sun, 19 May 2024 13:20:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AF9266B0088; Sun, 19 May 2024 13:20:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 8E4626B0083 for ; Sun, 19 May 2024 13:20:39 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 077DE1C0C2F for ; Sun, 19 May 2024 17:20:38 +0000 (UTC) X-FDA: 82135809798.17.1A36D64 Received: from out-186.mta0.migadu.com (out-186.mta0.migadu.com [91.218.175.186]) by imf02.hostedemail.com (Postfix) with ESMTP id 76EBF8000E for ; Sun, 19 May 2024 17:20:36 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="RwJ//AYT"; spf=pass (imf02.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.186 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716139236; a=rsa-sha256; cv=none; b=rQWjHggFQzHEhz0Y9u2ZhIaLBKyIVFPqeREnpcT3Dw+sX81aWVMmzPll/TjasvpPEnKCXX Lk+j5++sNCc+yKEbW9hFoxeQ76Vqhg6wTSwn1p/gVcmuj/wWPX2EEhirR8WkRKCB4evl7l MwgvrDnXLmXSRdwgnP4NmZnZoVmn+8s= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="RwJ//AYT"; spf=pass (imf02.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.186 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716139236; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NvHbKMGIEEBbCjoVkxZXKJCvmBxbvIxeoNE8YxwoCwI=; b=OFc7oVOM80zZZO1O51hlSMQY8skOmvXRUhkHaNXmDrzTW6mSfchPRYNfeIcM8Xu6wbOI+Q 3wUdFywM26neOAVBTL4cTKXGfFsYu6CzI2IultZhMWNIOJpv/aV3qJP8GN5xCEkhkJCfBO Lk21JlMtM7UBMZsfDa4+4msgCZedqv4= X-Envelope-To: oliver.sang@intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1716139234; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NvHbKMGIEEBbCjoVkxZXKJCvmBxbvIxeoNE8YxwoCwI=; b=RwJ//AYTEDyiz2yzSohwa8IO2PtoG8C+lvATn39MWMuKVDRNLGjDpoVgUwhAUiDy5raEBW MyApbcTF4EDOxY43mINP7aSblMpeac/cBmEBZpWBd+wqhcVGbajwpzYfSB2wwWoR1LWadZ vnNlzct3wlmV3ENmtPNIqPqjK8H6YNE= X-Envelope-To: oe-lkp@lists.linux.dev X-Envelope-To: lkp@intel.com X-Envelope-To: linux-mm@kvack.org X-Envelope-To: akpm@linux-foundation.org X-Envelope-To: yosryahmed@google.com X-Envelope-To: tjmercier@google.com X-Envelope-To: roman.gushchin@linux.dev X-Envelope-To: hannes@cmpxchg.org X-Envelope-To: mhocko@kernel.org X-Envelope-To: muchun.song@linux.dev X-Envelope-To: cgroups@vger.kernel.org X-Envelope-To: ying.huang@intel.com X-Envelope-To: feng.tang@intel.com X-Envelope-To: fengwei.yin@intel.com Date: Sun, 19 May 2024 10:20:28 -0700 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Oliver Sang Cc: oe-lkp@lists.linux.dev, lkp@intel.com, Linux Memory Management List , Andrew Morton , Yosry Ahmed , "T.J. Mercier" , Roman Gushchin , Johannes Weiner , Michal Hocko , Muchun Song , cgroups@vger.kernel.org, ying.huang@intel.com, feng.tang@intel.com, fengwei.yin@intel.com Subject: Re: [linux-next:master] [memcg] 70a64b7919: will-it-scale.per_process_ops -11.9% regression Message-ID: References: <202405171353.b56b845-oliver.sang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: 76EBF8000E X-Rspam-User: X-Rspamd-Server: rspam12 X-Stat-Signature: hwwfem5jdkrj5ws38ref1h535fk69ekc X-HE-Tag: 1716139236-785304 X-HE-Meta: U2FsdGVkX1+LzuGhWE1d8/GrqFcrXeAFPLKaZnHGIm4I0ISjD+Y9t3m6QgEJW9NdTiIdCkp6Ok7epWxuIqszGuf2MkoYdUJjsY9MbTyBBhXNmcleL5CM+v+LrGqxSjtigp8yxwWhHos6cXAWGLmN3nhV8pffT14YOEHe4uXgUqjW5WnPMVSuTx9hU1p37v8jtKAZIoNVV/YXdKhWLqSKgGAeKc7J7J/yrsDl5ztAAqImzplRnhf3Ikn7SiDVI1ec7NVHKO09Fm1hJskQEnoutWSRrCysW4BKx55E8IEvXmD5I7r9i7Dfeojiq1D/9pNe4cHXCdKbmDrtDtMrIUQ1yfNJ6jiBg+oXPVlC+BJ0DTI29qKmL164Wqk6lUXrggdP+Frs6B8uwLiledXW3O6ETZpMxe4vElniSA7Wrdcc4862UgXlZS8woRy14QH57IZlFSjVywvKE/aK1ZMDlvLbRxeek68ubxRfyfyZg7x1dUxflWyQOBRMZo6P5LqS4CvR72apIcw6yQEOrQVn0zrJtPjHksykzzdNvkzmzyk0PdGOwHNIVBHzVnEDlnld9npzB4e/56dRIXRObmMU49zyW15PufwI6VpBrvFy9edc5CCHYFFcFtPKMj1mSKDHoZ5b9NyeZM6xJKG83AFNjQ01dLWWRz02tAKMNTQ9VmVGN1vG5XVzqfJhEwqfKMbRZeHaImk1i7VCT0cxeBoSrKuDn11ZijM1ECGiC0ZpaH52ZtdYvpXhJrSuaXh952t0QP6yUkmCoiHCovnaG65zu2q0x7eYuo+IU+qQiIZQl0dIO7W4eCE8TnnhGZnzBs+tIqUrH+ridH6tUFGMqFpYekFH/mYGeD3T1ASpIaIVn/UcGejIlnf8nKjaM9LZI9q4nXtd2SlqYwT3rkH6uyQF0h1OjtB6+H/ZeZoHtQO8K2SJPiETWcXC2hK8C2kPYd8uQsc8AbWXOkQRZvwQS3FoRye sjUcR5Ll TmOvaSdEE1tcU4/JiM1pd/cZy0dkCW1lZNDGVWwjhimIaVwP7XpE96fxsq2RAIpyDKRx5czqruBbyyF2k9/NywknWhDJIi3XcV2WJ/MPKRJbjrjJLp8IKsyMKkmLmdMjOX2eNpXrkOsla750UkHqE9hVU+K0zJ90rloHSlUgMuyP/WI79KFCU110pj0p+nQ13Fc4t X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, May 19, 2024 at 05:14:39PM +0800, Oliver Sang wrote: > hi, Shakeel, > > On Fri, May 17, 2024 at 11:28:10PM -0700, Shakeel Butt wrote: > > On Fri, May 17, 2024 at 01:56:30PM +0800, kernel test robot wrote: > > > > > > > > > Hello, > > > > > > kernel test robot noticed a -11.9% regression of will-it-scale.per_process_ops on: > > > > > > > > > commit: 70a64b7919cbd6c12306051ff2825839a9d65605 ("memcg: dynamically allocate lruvec_stats") > > > https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git master > > > > > > > Thanks for the report. Can you please run the same benchmark but with > > the full series (of 8 patches) or at least include the ff48c71c26aa > > ("memcg: reduce memory for the lruvec and memcg stats"). > > while this bisect, ff48c71c26aa has been checked. it has silimar data as > 70a64b7919 (a little worse actually) > > 59142d87ab03b8ff 70a64b7919cbd6c12306051ff28 ff48c71c26aaefb090c108d8803 > ---------------- --------------------------- --------------------------- > %stddev %change %stddev %change %stddev > \ | \ | \ > 91713 -11.9% 80789 -13.2% 79612 will-it-scale.per_process_ops > > > ok, we will run tests on tip of the series which should be below if I understand > it correctly. > > * a94032b35e5f9 memcg: use proper type for mod_memcg_state > > Thanks a lot Oliver. One question: what is the filesystem mounted at /tmp on your test machine? I just wanted to make sure I run the test with minimal changes from your setup. > > > > thanks, > > Shakeel > >