From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50DA1CD1284 for ; Thu, 4 Apr 2024 22:38:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D3ECD6B008C; Thu, 4 Apr 2024 18:38:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D0C0D6B0092; Thu, 4 Apr 2024 18:38:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BFAE26B009C; Thu, 4 Apr 2024 18:38:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id A3D806B008C for ; Thu, 4 Apr 2024 18:38:49 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 9342140DE4 for ; Thu, 4 Apr 2024 22:38:48 +0000 (UTC) X-FDA: 81973315536.28.003F693 Received: from out-186.mta0.migadu.com (out-186.mta0.migadu.com [91.218.175.186]) by imf07.hostedemail.com (Postfix) with ESMTP id D850340006 for ; Thu, 4 Apr 2024 22:38:46 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=SAUxTGyw; spf=pass (imf07.hostedemail.com: domain of kent.overstreet@linux.dev designates 91.218.175.186 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712270327; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IqILBVwfm/nA4Dp8fGsnDYqiRoHSDvITblhlFgVtQ+U=; b=SuUc25we9YusAr1gkP8uNDXFXUzdeVu3LBuDYnoWN2RiS9nG1yFoyaNAY5MAV8ByUpwG4P QudumwSiteyM+yQ34XpX6C9mYYZqBAgfkMB3/I1boBGieZI8E7kqyJwKhRPCNXh/nXHt/v hN551usDFLMjsPD0L2DgzOcMtSqfGF8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712270327; a=rsa-sha256; cv=none; b=b5DTu1tdzEeoXiGpWHTmEwSCyogWV5B3/3UfIh1aRiS91p4PVMz/teMa2E5g6l6eivpPyH ibuTgV7fMQxlsn+vvSkZbM2F4yTANxUAOebEd+JIRvVrKhJECKUUrRutyyz2IlYmuNKXY2 0Xa6y3oGeBllcNOvzQ46NQx182YKHd0= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=SAUxTGyw; spf=pass (imf07.hostedemail.com: domain of kent.overstreet@linux.dev designates 91.218.175.186 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev; dmarc=pass (policy=none) header.from=linux.dev Date: Thu, 4 Apr 2024 18:38:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1712270325; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IqILBVwfm/nA4Dp8fGsnDYqiRoHSDvITblhlFgVtQ+U=; b=SAUxTGywnGO9lMg36Yb2FwCo9q4MLPvWVKliB8A6cH5w/sjrb/WdTd6Umo4zcLkMSBRK1Q BE0UEDKEnFkNBgE9qd83+0tLNc30wXqJ2yWdjs62ognxJed0Ch4bu2Pl0Pyyj1mKJMqNpR JfY1MW4y033OYjfXMya1y+rxPLYogzs= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Matthew Wilcox Cc: Suren Baghdasaryan , akpm@linux-foundation.org, joro@8bytes.org, will@kernel.org, trond.myklebust@hammerspace.com, anna@kernel.org, arnd@arndb.de, herbert@gondor.apana.org.au, davem@davemloft.net, jikos@kernel.org, benjamin.tissoires@redhat.com, tytso@mit.edu, jack@suse.com, dennis@kernel.org, tj@kernel.org, cl@linux.com, jakub@cloudflare.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, vbabka@suse.cz, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, iommu@lists.linux.dev, linux-kernel@vger.kernel.org, linux-nfs@vger.kernel.org, linux-acpi@vger.kernel.org, acpica-devel@lists.linux.dev, linux-arch@vger.kernel.org, linux-crypto@vger.kernel.org, bpf@vger.kernel.org, linux-input@vger.kernel.org, linux-ext4@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-security-module@vger.kernel.org Subject: Re: [PATCH 1/1] mm: change inlined allocation helpers to account at the call site Message-ID: References: <20240404165404.3805498-1-surenb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: D850340006 X-Rspam-User: X-Stat-Signature: 63j6h3mt7bxuerk83co6ex4n6s9xeizj X-Rspamd-Server: rspam03 X-HE-Tag: 1712270326-359324 X-HE-Meta: U2FsdGVkX19NzNx6r8TmCfYE5v2CDa6LoyKl9//94x8A0nj1BIaJMJxeoANEpvNf73CdbX+SAY7GHnA2aRNGCqkwIm3NVvbdDa3KWm4LvgneeVyMa0v7wsJpBRolwx2qmhMYTT1HZcg6Rpw05gxrpqLnd2OaW0usw1SJ+d9q5pVxJeFrHmu8dqihSZ/r6aDBG8nc7UXYnY+r1N3p79He71+y2fdfQRgkSSuMDZezVC8ABThiNIK1qx56xbC9Kt6yK4+optlOmWKQ8/5HmGQvj1ci1pMHwbCYamCs/0DhxQ2UCmioY683Z7kO44P5ZS7MXeuzte3Btlj2UaK6G5H4gGmZvOaLJ9dte0oB+B7yiFy5+7UB5sgxBv2higL2hnBk4Agd3+SnGYYzwbSpnVXVV6Xj0Hipv44x2W79P7bRLaiKFVsr3YAyq83mszwKcemU6yxUY6Q0UkG8yJJ18ixsN5zn7D20E1fnTGTxP8+GSpNgB0q3429HbAdlfDlW0ocCyvval6OwlmfaNNxmL8BOxGk8EZFPxJ7ivUEqvWUurAyRirOznuI0hTQQavmakF7zbWjcH09AyTSluSetVfgMtnopFRfnchi5Y1bfrO62HZUJ43xH1YWHlDx7KGeh2BDqtmlm62Kl8iRH19EUJfh06qmU/Ha7rK7jqozBJOfiNE9Gup+tVJIaMsBW1JNOxovkbj8G7QIN427hhu3j7eCxjNNKPJ66hEksMbLfLzjaCdA41aQ7UMC51HAUZYUhhiQWbZEeXNbyAw85DEa8OLJiE4EK71LiPKLEWZaX8GvUItcWF77w5I1+ZqGRqFOnHPCWysvlHfL1c9dN4/JpjbucT/kNy890FzfocNl7VWm9jgl5gvGu1syGye/1ObCu7VQg+zXYw/kB68ZyUaUxcYpCSRQSr6nYfAdk5/q+FrJSDobPgIZcV7kMQqljnwA2frz+53TUjbmCuDVcKruo8Rj yMaNHZ2x G2UPHNueHDEM0KGPoSOKhVSKZITU3moYjpCUkl5/fMHWdDhOxNUn4oEGPw5DE3hcMQmEx5GyUrdanNq+vhlq28yq1xx3QXbQkNImC+BPUKLpX0wLUIldHvUaxf9E4p0tbqv9HtIE5COw4Sr1wpHOPoW4h3R4GOgp91FiwO/FvTmS3cVM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Apr 04, 2024 at 11:33:22PM +0100, Matthew Wilcox wrote: > On Thu, Apr 04, 2024 at 03:17:43PM -0700, Suren Baghdasaryan wrote: > > Ironically, checkpatch generates warnings for these type casts: > > > > WARNING: unnecessary cast may hide bugs, see > > http://c-faq.com/malloc/mallocnocast.html > > #425: FILE: include/linux/dma-fence-chain.h:90: > > + ((struct dma_fence_chain *)kmalloc(sizeof(struct dma_fence_chain), > > GFP_KERNEL)) > > > > I guess I can safely ignore them in this case (since we cast to the > > expected type)? > > I find ignoring checkpatch to be a solid move 99% of the time. > > I really don't like the codetags. This is so much churn, and it could > all be avoided by just passing in _RET_IP_ or _THIS_IP_ depending on > whether we wanted to profile this function or its caller. vmalloc > has done it this way since 2008 (OK, using __builtin_return_address()) > and lockdep has used _THIS_IP_ / _RET_IP_ since 2006. Except you can't. We've been over this; using that approach for tracing is one thing, using it for actual accounting isn't workable.