From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4284DC47DD9 for ; Mon, 22 Jan 2024 15:20:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AD0CB6B0078; Mon, 22 Jan 2024 10:20:37 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A7C3C6B0080; Mon, 22 Jan 2024 10:20:37 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 91DD76B0082; Mon, 22 Jan 2024 10:20:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 7CE9F6B0078 for ; Mon, 22 Jan 2024 10:20:37 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 59933C09DD for ; Mon, 22 Jan 2024 15:20:37 +0000 (UTC) X-FDA: 81707308914.30.8113A0E Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf28.hostedemail.com (Postfix) with ESMTP id 5EE7EC0008 for ; Mon, 22 Jan 2024 15:20:34 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=BfN0cFW6; dkim=pass header.d=suse.com header.s=susede1 header.b=BfN0cFW6; spf=pass (imf28.hostedemail.com: domain of mkoutny@suse.com designates 195.135.223.130 as permitted sender) smtp.mailfrom=mkoutny@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705936834; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uI8H29046lEwAQaOE9IkKlCQkju2vmSs/MhQpFiaPtI=; b=YAVlydk4UiXA7UndfM9Qfy8sGe3GZCr4ZeFupFtJFI4vcBI0vpX3xWgKy5fjW+Yu12Gt+n 7QnUaf8exJyLsEdJyZ80OLW+7LBrWyxnRfXKg6O7dY5HElCKlNcX1MFsTSM1TSSB6ndEky i7RtWGm/Nemo9U2rmJ3AP9yUmS5pkmU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705936834; a=rsa-sha256; cv=none; b=BLKMwF8Xzry/9/zg3RE5CN+VXwuwYVBQbHCgh2aMjcaya5+nx+bBrqQKw1+CLazY6zbHEh NESGMQy3F0/a7TJwegNHzwl3fYZ4lOe8rexlPt50cLCR338S/j6Io28vcYTtpsmq3+v/NZ 12cdv3JDt8FEYN/041apr1at43/n31s= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=BfN0cFW6; dkim=pass header.d=suse.com header.s=susede1 header.b=BfN0cFW6; spf=pass (imf28.hostedemail.com: domain of mkoutny@suse.com designates 195.135.223.130 as permitted sender) smtp.mailfrom=mkoutny@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id A497321FD4; Mon, 22 Jan 2024 15:20:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1705936832; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=uI8H29046lEwAQaOE9IkKlCQkju2vmSs/MhQpFiaPtI=; b=BfN0cFW6Ucd4aMQdhtVQZBZPSYYOf8yTXNjWs9Yt1e3RVCU9MYF/u0BQLFDEqbZCCAsSM3 cp+GEseEUKQn/4pro5nCyDA8Z9Vll5zOtxQkatPnUGk6G7CtDPIPRQROyuC342ETucdNsS wRJP1ACqRz+G2k0V5aAuku0KL2oDx1Y= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1705936832; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=uI8H29046lEwAQaOE9IkKlCQkju2vmSs/MhQpFiaPtI=; b=BfN0cFW6Ucd4aMQdhtVQZBZPSYYOf8yTXNjWs9Yt1e3RVCU9MYF/u0BQLFDEqbZCCAsSM3 cp+GEseEUKQn/4pro5nCyDA8Z9Vll5zOtxQkatPnUGk6G7CtDPIPRQROyuC342ETucdNsS wRJP1ACqRz+G2k0V5aAuku0KL2oDx1Y= Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 8808D136A4; Mon, 22 Jan 2024 15:20:32 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap1.dmz-prg2.suse.org with ESMTPSA id mP41IMCHrmU1ZwAAD6G6ig (envelope-from ); Mon, 22 Jan 2024 15:20:32 +0000 Date: Mon, 22 Jan 2024 16:20:31 +0100 From: Michal =?utf-8?Q?Koutn=C3=BD?= To: Shakeel Butt Cc: Andrew Morton , Jens Axboe , Johannes Weiner , Tejun Heo , Jan Kara , Roman Gushchin , Michal Hocko , Muchun Song , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: writeback: ratelimit stat flush from mem_cgroup_wb_stats Message-ID: References: <20240118184235.618164-1-shakeelb@google.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="nypkyt5neisq55gd" Content-Disposition: inline In-Reply-To: <20240118184235.618164-1-shakeelb@google.com> X-Rspamd-Queue-Id: 5EE7EC0008 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: x73xoaztumzya56qguydbjbgtrf3574c X-HE-Tag: 1705936834-553032 X-HE-Meta: U2FsdGVkX19fB1rkrthKL1SQ9CDZ6ASszUhsIvhVCiOWKzINbjYJbdR+ageBvOkWmOw2GI3ToPaG2IfzRDO7QtzEkec+7pNfcdsuHncFrMq8Spezmm4qQehi/nwgpf3gTjX8sPlIr0vpfJw+ab/qJ/IfITFiHi/Qan9LHfftVxODOouqjHsbr3gVysH2MVsQJfll1/7raKT2+RhABdGxkBupeBn/mQ46JFuIZAaJBGWafq8zVT/p1cXXo2WWcy7k8mqfSI7WtZ4YRo9oInuSlolORuhMChe+HSz3rbm0JvLFONs97Q6f5KYjk1bPk3MgIPceElCnnQ3LHVtjwGpy73ijhtbWktWUzoSYM3CwJNbRLqqXdAT9wnBRxRdiWbYXXBY+zlVASYynfkTJCrLK30xz9OrSYznpQUfQM8VpEk4hm3Hm7Xl52AL+2HhVcSQt1YyM1/pHqNBt1xH4gTeeR1i+nu21vuYuci9fqFyOgmzThNJ3SBsAh0jPiPn0XEn10vFlKoTccx/EdfRw45Unb0AEMuMUke7tbFQfRPjZEE2FPtCdQxd/2su5u5h4Id6nQPLXoGG2IK0+Jwyq4OQ3l6DnHsg+t9fksy8UnLnLZdpXu19cnoihhvJaJ8cP0cwOS66bP9aac1LTgl86tEewIYMREztJIlMVNHNCkzGkZS8ILitskVqB/z5OYRycaZA4ix6ipDl5SS9+p8MMSQr3Lvwv6snsa6tNwV1qU3ojJYigdZmowGlGMnErP7jcaRH21BP4hjyEBWA21uPnrXfxWO5p/YG/cBQUIDamoi68CHWrt8BzxRbbtdLsmFt9gsvE4G0VmEooXztBCssbVhAVi/US3UKKwaq9wtcwzrP9lcRshK/Rz49WMxY4Fb2unN3DnFtsAp1ZyejoV4fFGwKoNR9RmSYu8/nCYF0fv/fUbLr1tiihsXDbkR+X1GviXzkube6rF6RfAf3NmdsSGol ZKjAdF0x +BtT6QUYUYp4TahBGTeOBJCWixKyn/PpuF9to X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --nypkyt5neisq55gd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello. On Thu, Jan 18, 2024 at 06:42:35PM +0000, Shakeel Butt wrote: > One of our workloads (Postgres 14) has regressed when migrated from 5.10 > to 6.1 upstream kernel. The regression can be reproduced by sysbench's > oltp_write_only benchmark. > It seems like the always on rstat flush in > mem_cgroup_wb_stats() is causing the regression. Is the affected benchmark running in a non-root cgroup? I'm asking whether this would warrant a=20 Fixes: fd25a9e0e23b ("memcg: unify memcg stat flushing")=20 that introduced the global flush (in v6.1) but it was removed later in=20 7d7ef0a4686a ("mm: memcg: restore subtree stats flushing")=20 (so v6.8 could be possibly unaffected). Thanks, Michal --nypkyt5neisq55gd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQQpEWyjXuwGT2dDBqAGvrMr/1gcjgUCZa6HuQAKCRAGvrMr/1gc jv0KAP49hs1sQx/Itdzma7JXdOKCH4l9eewELaaWxrVCyuoC0AEA3fgaAGcdTEMr hwYxaHAKsxG38pb+QxHQjbOhmP/afgI= =9ZXF -----END PGP SIGNATURE----- --nypkyt5neisq55gd--