From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7778C0219B for ; Mon, 10 Feb 2025 14:51:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 341836B0082; Mon, 10 Feb 2025 09:51:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2F1806B0083; Mon, 10 Feb 2025 09:51:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1446E6B0085; Mon, 10 Feb 2025 09:51:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id EAB736B0082 for ; Mon, 10 Feb 2025 09:51:53 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 96C27160DE0 for ; Mon, 10 Feb 2025 14:51:53 +0000 (UTC) X-FDA: 83104324506.17.D91797D Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf03.hostedemail.com (Postfix) with ESMTP id 369EA20003 for ; Mon, 10 Feb 2025 14:51:50 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=H388DmeR; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b="i8Js/nAt"; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf03.hostedemail.com: domain of liam.howlett@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=liam.howlett@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1739199110; a=rsa-sha256; cv=pass; b=ABXYajq6LO6NqD8XceG5orNwBG//r7nHHkEFJAOaLJdVeY1qK2mHihRxQk54A4i2CxhWNH FH90gM1FDMJPDdx0Dhy46UgA5uc2R9kK+onptvPIeppLxogfbfEba3GPAsKEWua/GNBs42 CM1xjWSnOLFMMyb6F76o2GisHaIw4N8= ARC-Authentication-Results: i=2; imf03.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=H388DmeR; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b="i8Js/nAt"; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf03.hostedemail.com: domain of liam.howlett@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=liam.howlett@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739199110; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/Vk+oypmJbkUWFO3MXcWNlkoG5y2Bt+XwvnA597y7wc=; b=eCcB/M/NqFeF32TIVN5jAEFbnoy5KxHInmo/ITC6FP1wMLuYwqIdIsBLgrdHWK8wLKcuTn m4tX20AlA0uoYiL8E0q0dwWbzAX7xX9MGe4MwbUx+4XWxoqfLB/gDBHAS2fDWsFuPLxdOy ffCvGAWDhOQyYA+zUbXNFWJktlHnJC4= Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 51A7tjAN001762; Mon, 10 Feb 2025 14:51:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=corp-2023-11-20; bh=/Vk+oypmJbkUWFO3MX cWNlkoG5y2Bt+XwvnA597y7wc=; b=H388DmeR4xrvYqMx8odePcgudRgqZcXkTd 7fKMbF+AYQ+GjLD1y1bXmBXPYhGrDRE8ksMeMtpuSrNkbf9DdmkegaQDHUr/cve1 oDlJklEv52MclaIn3pAAAI7ey+KDmUFLVKqNYX8LTFMNWDyp7WYWq2ZOiRXH3qSD QgFrCRXtby1MHrlKyyfR56bHZGe9Un8OLyU1b36YQ3TeF3LVrRJtLFMblleB0194 dC+RK/XF7YYJ3FqNjQ2DWH722ddhUHDRuB4Ki5URIP+ApZsbMxVgXVzV70eH5sPB EgDTZ+Blc5BYkeAXVYqV0A6Smc751CpPMSUv4Row0MjcWyK1JNqA== Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 44p0tn3350-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 10 Feb 2025 14:51:47 +0000 (GMT) Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 51AERd7U009792; Mon, 10 Feb 2025 14:51:47 GMT Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2168.outbound.protection.outlook.com [104.47.55.168]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 44nwqdr6hk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 10 Feb 2025 14:51:47 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ExgSoy5V4vCDUCNNU+NE0XKAnGnoXyABFH9ydMQxBAY8moX2pRV47shTTA7qocy2ex6UilO0LD11aSPzUXW1ZY6fhBMzyAH3XZeHmwT2zTQJLPPjcyytkmeX7aQ2Ry/N//ILBUuNCETFRcc03/4ud4V0W0ZXYerJcuzL5b+Gtc3oqqJM/hRXi4MMaV01y5uSw/FBmqJIdnLKm9mvSzN7eSPRRy16YcfY7R5gW0BLsHr16asLqklOXG+GbK/dWQ0NtoBaytfNYH93zSZof+MvFdTaM8Hz5oL0QKdH+dkMMAgqxZYqPAoVYeBuGVLB96lfoN+Fy2ZqP8eELpy6+kS+mA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/Vk+oypmJbkUWFO3MXcWNlkoG5y2Bt+XwvnA597y7wc=; b=iZUFlPaF0yv2gUSmb9ixOz47aDJuC8eBgSB2GvpOvf0nwugBd3cqCtxGwitMXWxgGLFU65JvBuhhlTtev8kJhlHcwHGilYpHnJ0KtzPK+aa2+TGk2HavF4OHqDoOPeO0zJYI+sMCfwOWHZ0cVWwrtLa+JeS8T8q012j6BGbIThnsRkZLoBmdeqRyHtu3B7uyRs5DwawYGcpKs0NkEU9PpDH4ROGay+3t1MfPiG34l4UFVBzGdkRlkR5Norq/qYkzhURcjOcQpQ48fkuBq8MuLlpBZPa/abus4UatL0mxWRHGG8NpQ3yacIK1gvS02G/A9i1jewbZDfJHIC4KxBXrbQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/Vk+oypmJbkUWFO3MXcWNlkoG5y2Bt+XwvnA597y7wc=; b=i8Js/nAtzNWORczR3Q+RUWHk8VMEMBGlt44913e4amF4SvanX09UIci0IJQJZC1ZlYlOjujHcZP3Td+mMfm8E7KIhOCciWDMnHE+7O7lmygbzOZFYnMDrtt2OBzSEcVh/B2/7xz4dlGu0eSl6OXkMIevI6tmurYlea2PmTGC8jE= Received: from PH0PR10MB5777.namprd10.prod.outlook.com (2603:10b6:510:128::16) by CY8PR10MB6516.namprd10.prod.outlook.com (2603:10b6:930:5c::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8422.17; Mon, 10 Feb 2025 14:51:45 +0000 Received: from PH0PR10MB5777.namprd10.prod.outlook.com ([fe80::75a8:21cc:f343:f68c]) by PH0PR10MB5777.namprd10.prod.outlook.com ([fe80::75a8:21cc:f343:f68c%4]) with mapi id 15.20.8422.015; Mon, 10 Feb 2025 14:51:45 +0000 Date: Mon, 10 Feb 2025 09:51:42 -0500 From: "Liam R. Howlett" To: I Hsin Cheng Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, maple-tree@lists.infradead.org, linux-mm@kvack.org, jserv@ccns.ncku.edu.tw, skhan@linuxfoundation.org Subject: Re: [PATCH] maple_tree: Remove redundant mte_to_node() in mte_dead_node() Message-ID: Mail-Followup-To: "Liam R. Howlett" , I Hsin Cheng , akpm@linux-foundation.org, linux-kernel@vger.kernel.org, maple-tree@lists.infradead.org, linux-mm@kvack.org, jserv@ccns.ncku.edu.tw, skhan@linuxfoundation.org References: <20250210083526.252955-1-richard120310@gmail.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250210083526.252955-1-richard120310@gmail.com> User-Agent: NeoMutt/20240425 X-ClientProxiedBy: YT4P288CA0014.CANP288.PROD.OUTLOOK.COM (2603:10b6:b01:d4::17) To PH0PR10MB5777.namprd10.prod.outlook.com (2603:10b6:510:128::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR10MB5777:EE_|CY8PR10MB6516:EE_ X-MS-Office365-Filtering-Correlation-Id: d300616d-7d59-4aec-5f3f-08dd49e27050 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?mPIGF3hJB9NSZlQy9lrSdZXalkuON649FoaGcryLqUOeZFyn0kIGkPu1ePmt?= =?us-ascii?Q?4LHAqnJOz8Zg54YD+NgilolmGS6UQPLfiSw7GDD0qdBicUTXdnokhi6ghPuL?= =?us-ascii?Q?1g6QDQUk20ozJ4VVd4RdGHtFp2HWjwfW2eAh6AKrft3eVPegrT7XU2lMP/X8?= =?us-ascii?Q?/ZTrnMYWyCDPb6XglUkalK5pvU6GXDUfuqt7IVSmVATJJua7ynV8hdAIzbIr?= =?us-ascii?Q?AEZRdrjPjZl4pzyJ/gVB4kw81jRaX/OkCSvWpj/G+nVWFl2Q71siOl1c6jen?= =?us-ascii?Q?YU5B5bKmHbK3wFM4jhSjoSMRlpeNDAxMpL1YEJYVHe5IusXcY5Ih0+jPJsnW?= =?us-ascii?Q?NgwSffLOEeWOopbRSTUq0BBGdBpD706kwoJ0HCh3O1ARROmo1KnA4jMiAwqn?= =?us-ascii?Q?eCBTAkmIy1qMV32Zq8IubB8RZ7091cbaitEoobkC99Yl4WA0OrOX7nKTH6C4?= =?us-ascii?Q?PkBCYH7qF3kqLOFblByhquDOrWvLNgEFzcAdx9f/dAvqhhOvVtZgFSO5S5fu?= =?us-ascii?Q?cqr7fwgaC0scOvMsM/uD4EqPeRVXTFwBJUHPpkB2YG6av4ROLUlI7zfs0tjs?= =?us-ascii?Q?7AYMZA1rfF4BYYzqLm111dnF+X9HoINj5Yq/iGf5bItworDV+KylApXJIZR4?= =?us-ascii?Q?YftIQt1DT/ZMaqrtMk4WkjjVuubNi1R7vLyjI6DKp6f+JQGqVX57UKH1cBi0?= =?us-ascii?Q?W/u2lK26qmfOgs4SQeHK4jBddmLlZaBHoA8NV4p5Z/GdxigpZBCTXYvduo9q?= =?us-ascii?Q?BVVdQITH7Acz3DrRdPynU5VKOwCwqqza2nbCdAqQspdpTjn77kPgjvfRXr1e?= =?us-ascii?Q?ukiQUzKQ1cMVvnlN0yeyH1nqn+D3sdtEXWXdpj3xONpWhMJxMG9lcCUS96n6?= =?us-ascii?Q?1tL1SBDfsOiODGifBiRqhUGqqQ8PP75SBbhnIeW10bm1CDcBwDDTsKKFCDaz?= =?us-ascii?Q?mKAzqjcdFZvLHjDbTFFtf8W5/Nv0vXNRew9nuWt+mzJQF17anOagjDycBCrP?= =?us-ascii?Q?qi5j/lH8IltwQtYclMUaYFVLdJkE2NwBR+fdem1/sKnG7PJB+Xkz9puPJ4is?= =?us-ascii?Q?NTiQACa/g47TSPFz6yrZizQ/UaA4mQSxZbZ2h/KiAk/5BKHH4RXYdWGBYlRN?= =?us-ascii?Q?dWK9xa0B/myjrnPm3qeAuq4Jqw4rhO5KUrdKuLPBl09fc4u3GSgjD8Kn7sXY?= =?us-ascii?Q?eeeDn0UGLF3sDyw/PYUQJQJwz8Vwzbm7xGCP4JfTPqvAoXkyh/YFo+KvmxjN?= =?us-ascii?Q?cOAImcNXzbQ8ex4eEHssKmdBTocO7uHRuQGkVx0jbqngesS1mKfI6fS58acg?= =?us-ascii?Q?Cah4Yn8vJKzpK+nfwEtKa7XnqGUCKu6AWX6pVOrKfnvpPv7heMUVGOZfkxfU?= =?us-ascii?Q?f7JUtpg=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR10MB5777.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?61TuuA6TGrOW1/2HTvWXGUI5yD2hkPA1H5hKJuvT7WU5BbBC3LKnPosmTabn?= =?us-ascii?Q?RNM9WROJtbLIB0eXGqYRjydRK0+cY6wacUUjE2u2vV0zm6WFggYllb8kMGyj?= =?us-ascii?Q?pawQ/i4jElMMdR4ha5dLsb3dDZ1gRU8JeEI1n2b3MNj7Bl+20Dn7PI02PH5N?= =?us-ascii?Q?rF3/sbDjYKUkGGYtpRdx5Sz3YGdC8pnSy2gJ15hEqI68fMIk3B+bGaUzaGPG?= =?us-ascii?Q?40eurHMXj9dHla06SYWjmxws+vc1JrnvYm+O50w2egYyiTOvhFQsoqk+peQc?= =?us-ascii?Q?1j3klAP27hkOTY5bT8e7bjGWNsTq0Uywkd/jNb9CwwPhM6VHfp0kSmR+w9ns?= =?us-ascii?Q?zjTLbRldb3UCdyX0eT1X+MdMBkYLxoEK/ktnzazhKUPRLZVDINBYX1KCEYqZ?= =?us-ascii?Q?3BOSXD1Lf00x7vQs86uuzQa2INqgzCBrkA2aS7n/aAkV+wa5kgp5JLqJq7/7?= =?us-ascii?Q?0fPC0v4U5dELS4dBeOWJfVvwni4E9NQxiiaglGz80uzFc2mb0sNdHFkN+E2I?= =?us-ascii?Q?95492HBDD6agFJm3e/eecOZ6LhAl3kUGDZVNcbDEYz82ZIBf5DYh3fL5K2Ll?= =?us-ascii?Q?WJxqK2IZJdGa4E7HrC2F2RgmPUwhVeHtrZDI4zvCuvyWjXweJzAs+UezqAi9?= =?us-ascii?Q?94U5deCgiiF2AFEV9l15pHps2gimAR+cyWQ4u8bUYI7R/Rh6YbRsC5lgdctn?= =?us-ascii?Q?o3Esd4BqJIWti4kyEoe1H3E/V+tyJG8lmMzdaqawFCQvMkHA0zerrgzSs5XW?= =?us-ascii?Q?GLhyf0bJjM2xzEeALp9M+7weTs8U/jj3E+aiYDM+Hr2eriCIyMHhGRnA+SkL?= =?us-ascii?Q?El7ZdMF1V3BW6ZdNzGXqgZnavhJmxg5pQvs88FX5HGIiT1ttXUj07s5eDSx8?= =?us-ascii?Q?ocoAurC9wDwrZh6pj3OgzKnqtdWQk6BMTNT8F6rCuGobKVp2zCje9O8xMWpo?= =?us-ascii?Q?jtxmB96mNIbwsJJmjDieihIMrNEQzn2omCz5Qt5ioFm86tPxna2VTxCnbYwt?= =?us-ascii?Q?r7Q5yXHx3gI9PbFwP9OJzk7vtxt1VCda0/UX3mTF2tQ+Jl14NRFVHAERdUwY?= =?us-ascii?Q?hJS3Gf0+2RqigMTZsa3g2m0qWyXPZVez8w79ascF5UHhSgAfYD1Eu92QCqlZ?= =?us-ascii?Q?qXLycdqw7JNrbGSzspA3KFnV71sNONcD9EZse2JyL4fWdT0CTSj9sqhHafsG?= =?us-ascii?Q?n8F6tSZb4v8bgBNQdJ69OmQ9ysAw6WO2tXvUfO39EvSrHn2Ckx0KkpxacebK?= =?us-ascii?Q?ct0frLXzzb97Dh6AKPk96UKUSeg6kf0//Ytsghg7DNR3XxGIyZ7ncc7Ijt9z?= =?us-ascii?Q?Y4lZbpZXwmNSC6bAPOh0pHQXLZHeB2wQCq7JxQZlxzxLspT/uY7zeFe/stvt?= =?us-ascii?Q?5NxbVZ+JX/TPTBUwlnY6be/s8cRjRO+36n95js2VXinszkAbGi0CXgdNtRXy?= =?us-ascii?Q?K6tsa5up4deTSrKblSRWN6pMIkAXlIRh2An1DBSm9gYsWq6T21OmNSfGLK/G?= =?us-ascii?Q?7RaIth04C4fxZpc8R/+IuGFrjAy6T7tylc8iLic/MWduI867TywKEm5lz/nh?= =?us-ascii?Q?nGVaG0ha7M+RJA01Nk7+Mk3oTO97XjvvLSa2oXuz?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: eXolMZFpE1vD7R6yUIJ19VcUI91Y8sSnPhV7yVOIZLp3dwzSGiHdr5AUfoHKXLGOCt8nOXASoF+UPA2ZuyTea3SehyjN8oncoHAtjb+9HGk4wXNKJS53uzvRhwQSHdXyVksnu+UMFgiIgTMhs8jzRc2Dhn8wD2Npu2OEQ36DU4VuQFn4agVHZVrKX+f4GmZUkDU7BPBUVjWyADf92wcdpl72fUJ5eeT2lVC4CJ4CsQOnOBVHSBYC9eVcLJ9bkIZ62E6vSoy7A8caBk/ERUfzwHAHsgi/AciKqOdslpj4ot8keEnSGeGH+wp03Vb1BYZOoJWBID6p1wSauMJBdhDUuJfd370He+93DY4xs49QRbmcNulqJMveIJddoSDbnGrsTr710ba0b5DixtyIEi3lMX/2rEzYKC+IDbhulAuOa1eInXwZi2Yxa+ygAzd+5cghTcxo3PGhi+Sm14jE/3QS+4TQanh27Uex1CyLtJYi/IwBpdBPr489VLtffvhfHGefjfzf8EmrZldd6S1vhb8xgwdPlpMVg+AacquJC1AJvU0FawWzBmwQFnu9LcSeTgX1BUxAESrWACPY4YHCO6g12FJCMVunWNirz1snfQa+Pkg= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: d300616d-7d59-4aec-5f3f-08dd49e27050 X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB5777.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Feb 2025 14:51:45.3661 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: n5pe6VCH9SxiZqpR7yN88v1JlHYfJAz3S3eec5jcnVKefkeJBbhKStSDhA+iH79L3ePIh4gdB7bP5c9Ix4MUmg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR10MB6516 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-02-10_08,2025-02-10_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 spamscore=0 suspectscore=0 malwarescore=0 adultscore=0 bulkscore=0 mlxscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2501170000 definitions=main-2502100123 X-Proofpoint-GUID: GRvdiezajJyQWklXrjX-MOe2NaM05_ZA X-Proofpoint-ORIG-GUID: GRvdiezajJyQWklXrjX-MOe2NaM05_ZA X-Rspamd-Queue-Id: 369EA20003 X-Stat-Signature: 4buzghjcqqkszn1bu6ozm6y5txjjrdj9 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1739199110-75807 X-HE-Meta: U2FsdGVkX1/kpNAJJcZYgB2P+SN4WxuFnMjJB1mdEaYhVINb+NPg0jjLj5PFwDM4TwRw3KhssRSE9M+V9iGZCPRqJG5xDOr1RYCuFcJb+FNzH0nAsk06BKj3w4nkC3cNDdjNRw/fsw7grNm3iULLU2IJ6aL10IsLsQZxpG+Dgu2u2nfP/vNvk8N3m5QVWZI1sEwxDyz5RWCguJj6W/yVCPmQBf5UiDvayt19E6Kh1o32ZGiVuBfT377Fbu+IC3Ko2kM2ERYa6PxMNfVOA5hL0wbXesVistwwngB2B2hpnmYU7qt+MBuY+iIckHoiOaQVX7DOofyOjAGVlqBS34Qw6pO1P6vFs0m+9wjQEgiDhr0NEm7V+aaZZeV/4VqlyPFrIbi0azhSDBuujCb8K4jPk+vMfEOd6klHm8m/7L4uIqRNEwE7qa0vsJ1zjf2MBrNprSQjKVd3cGF+TJD4k1mDob5wnJv7zizKxcBI0mkATTXlfUAFQnDd+muUDB2HGZrMIWMMrQ9eBMRTJ8JPAjQkIAJi+EAxbHHuA4iekj42XsSID/Sx2JumkTd08wMlcywUBCa4LduN5bVBMQ+RT0LQChAmUn3bKSuboS0A6tJerV7IX0KgmWS4WtrCNUjNGnmil8Drmx0skEpSb8fyEY7N8j6ZfcuKxDILLY0hBZZSEP2aKV8+HeY6cTOOB+gA5OTQWjinPK3puhpd2KR8mCElf/Urp6rEztUEEGO86sZCj0pE6kehju6Xzfma3k7RjJ3KSTq1pXLWENZunPD5Aj89I/huwvvH88pUtjY0ifdUwKaLON21JP6cc+Ny6cwNJWPfI/6b3IMU4Jb8mWmsK0RHtDVCky530ShGp94/r5ZKF9nWaOsGWZ5HzGF09ovmiMUzvWxrIagcbUqihQOum40uMoNbgAsNvn1jdLFKFAOgGd8UHixflYM1dU/Y1ZbaV/EuLEO/bKS+4LNgqA+NT3N dDVJGn1Z KCPG2lrMcNqhwNahqLNBtid8F8j9goBIwllQLDR7O+u9CW6u5ySYwvUEO/JS/nMaD+l8HhkClQIijBmEfEyretSJAnx0x3xFt7EX8QN0mUMvCPTmX3Mkh6eGG+BCuhH3eo1nTgce956pzH9GkJ6tZS7RfAwlH3h9Mt1Au+7dDkWkkzVDN8lRO86yP9b8WggJPqXQPqjzU+BOZyNXlusZbe3jiTbweQft/sgnLz0hhs3bzgToQoG5qj0+t93V/TCTYnWQg4D5ZKjbkIeofF3i6uRB55I9p11P85vvY6hHG1OzlFWsZxhBioxFhEcwz2Sow588z448Cic4WePKeQccubc1VgNB6nHpOAZbZjdO3fvJ8m2Np2gXjBjbO2Xkf6MUSu2pmPjiMjVAdvQqdtC3UpxlBZCxaxROb9GnR5hoJ8P59l5I4OHU0OJSyaeWYrDo2r9/a7IsXWzo9xKHSteFOZh6b46lYG92ywNrm1BwlXymjkd6PQDawg4j37fuN0bg2FVa1OYqMwaHQxMtgMsirRB4/lHtT4VgvOmv6mwJrzJNbPx3C2R6k3r5SUbUJCg7hy5lnubpRqiXaGY0rW5fi6qlTZ1TbUwGSDoJdLf2ZhD//puqhbuGxqsgSwQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000010, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: * I Hsin Cheng [250210 03:35]: > In mte_dead_node(), it already assign "node" as "mte_to_node(enode)" in > the first place, calling "mte_parent(enode)" will result in the same > "mte_to_node(enode)" again which is redundant. This is a very confusing way of saying "avoid calling mte_to_node() in the mte_parent() call by using the ma_dead_node() instead." In fact, the subject is wrong as well, since the mte_to_node() was removed from the call path of mte_dead_node(), and not the function itself. > > Refactor mte_dead_node() and utilize ma_dead_node() to perform the > parent check without the redundant "mte_to_node()". > > Signed-off-by: I Hsin Cheng The code looks right, but the subject and change log are not. Please respin the patch, something like this: maple_tree: Use ma_dead_node() in mte_dead_node() Using ma_dead_node() in mte_dead_node() avoids decoding the maple enode for a second time to find the parent. Feel free to change it as you'd like, but I couldn't follow what you meant. > --- > lib/maple_tree.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/lib/maple_tree.c b/lib/maple_tree.c > index f7153ade1be5..362f85c62678 100644 > --- a/lib/maple_tree.c > +++ b/lib/maple_tree.c > @@ -584,13 +584,10 @@ static __always_inline bool ma_dead_node(const struct maple_node *node) > */ > static __always_inline bool mte_dead_node(const struct maple_enode *enode) > { > - struct maple_node *parent, *node; > + struct maple_node *node; > > node = mte_to_node(enode); > - /* Do not reorder reads from the node prior to the parent check */ > - smp_rmb(); > - parent = mte_parent(enode); > - return (parent == node); > + return ma_dead_node(node); > } > > /* > -- > 2.43.0 >