From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38CA5C47DD9 for ; Wed, 28 Feb 2024 11:51:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AD6D16B009E; Wed, 28 Feb 2024 06:51:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A865B6B00A0; Wed, 28 Feb 2024 06:51:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 94E106B00A1; Wed, 28 Feb 2024 06:51:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 821D76B009E for ; Wed, 28 Feb 2024 06:51:54 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 595AB8090C for ; Wed, 28 Feb 2024 11:51:54 +0000 (UTC) X-FDA: 81841048548.02.6764522 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) by imf07.hostedemail.com (Postfix) with ESMTP id E2E644000F for ; Wed, 28 Feb 2024 11:51:51 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=RDBVhHu5; spf=none (imf07.hostedemail.com: domain of kirill.shutemov@linux.intel.com has no SPF policy when checking 198.175.65.14) smtp.mailfrom=kirill.shutemov@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709121112; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kHhwRFRWIBOCPz8SG48lcbEZin2ezBxNtaal4WVHHpA=; b=PjsNW9yMXeNMOt1ULSLZ34Ai5Wi6b7K0HC+caX4fxLAOFXDblzSkbAWkDGGxLEYS1dqL3f FF8H9z7/e1FVp0gNzaZy4YsOk7UV4RwCYTFrJhkiwY53bvSXF/q+hSwO/togU3llTdZf1Y 6HAE7J3CnKh00sP7xZs6i3nNRqsdPuY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709121112; a=rsa-sha256; cv=none; b=KimB+FzeawI1DwSATjkON4qO8/Y04sZbE910cTD3hbPoDsL8V5UXQZqjqBG+nSJ+pCrpDu 3glBpy1jvKgppNuOO4Bb+P8GgW/lZyuxyTdM26l8L6z8Auw1Pb3snu+EFuKxaCeK+izc9d nj62BMatkud75bdulsv2tn9NDyQLc4g= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=RDBVhHu5; spf=none (imf07.hostedemail.com: domain of kirill.shutemov@linux.intel.com has no SPF policy when checking 198.175.65.14) smtp.mailfrom=kirill.shutemov@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1709121112; x=1740657112; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=UOHYABj412OrOe9R32rHntZ5qCSK4fekgltl0v2LzuA=; b=RDBVhHu5kI9HOB61cYAalpnZ0DtwYx+LtAapZMdpmtTti1t1X1gju8nt c1z44b/MnstlsBpEtN+coKHYcUxG8szJs55fjXU147XR/FnOJV/SYvtx8 yStpCZHQMUL+2+mNzijJUbKbYQR4frglhlbWn6aAz0h0GnpSTay4K1KiS IiGNHTgknp78ZyywcGudpjPoepr7mb7nd/n70LtFkTbbMhbgfZVWvX1UA lGV2Ev2plHj8OAZ9T2oYa2HMzAJbZll6mnn+lcU7iL97KTVsl4aQE99Cl dUNihqUkChd2VgIlYe1JlCnAkwnkgD2olR3z51GWrqQCwPsqgsW9sn4np g==; X-IronPort-AV: E=McAfee;i="6600,9927,10996"; a="7337748" X-IronPort-AV: E=Sophos;i="6.06,190,1705392000"; d="scan'208";a="7337748" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Feb 2024 03:51:50 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10996"; a="937034059" X-IronPort-AV: E=Sophos;i="6.06,190,1705392000"; d="scan'208";a="937034059" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga001.fm.intel.com with ESMTP; 28 Feb 2024 03:51:44 -0800 Received: by black.fi.intel.com (Postfix, from userid 1000) id B730928A; Wed, 28 Feb 2024 13:51:42 +0200 (EET) Date: Wed, 28 Feb 2024 13:51:42 +0200 From: "Kirill A. Shutemov" To: Rick Edgecombe Cc: Liam.Howlett@oracle.com, akpm@linux-foundation.org, debug@rivosinc.com, broonie@kernel.org, keescook@chromium.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, luto@kernel.org, peterz@infradead.org, hpa@zytor.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org Subject: Re: [PATCH v2 5/9] mm: Initialize struct vm_unmapped_area_info Message-ID: References: <20240226190951.3240433-1-rick.p.edgecombe@intel.com> <20240226190951.3240433-6-rick.p.edgecombe@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240226190951.3240433-6-rick.p.edgecombe@intel.com> X-Rspamd-Queue-Id: E2E644000F X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: mdi5qkdmfhnyooa5rcnb8cnfizn4y3a6 X-HE-Tag: 1709121111-162656 X-HE-Meta: U2FsdGVkX19LULXC4gq4WvS7nQnUBHH/Ej080z9Z6POqY2HoNZ5eo3JQJtNW57auSYy72bi2UNJlo1KemwCjdj4tmRCvnh/uG80Mxd42qlvZCAMXtIOieTJIrMHpXPR72bWtBs8cjBpMzuR/iYbwNFYAk4qxpsTI3D3WQJ/1MkoL2tSdU1VExY7AePB9Oe36dYSAqwUlY+u7/br36vuYTis3QUvrtokxuZx3Yfd4FDyvpIEPwiTvg3RH/iXRt7PyWRVZTz2OfPkYRsdpGhiTbOiSG+S6ZV6gezeIYkIIgLwLCQPQJv7iq5x4+5LeShnWKT4PLiEyVoaPqc3Khus3H+RVAZ25ZVcs03LuTeisq3ra05akAlOGS4iYKIPYqMi4z+PrLqTa2hQ7zfk6LpTbVqeAShWJ7ZrUQIWXaPx03uxq/Xx7EWnLbDlNWJRsV18mDUmDVD5kYd59+gJMm6YZHyPYQE+sAaYMg2yq4PdrzcOMC8EtuWD0GCWUVZX0/Djk3bW4wnPeP0Vfm1sZYkaE8JIf35SdZliejQczvXXkBh3ooTceuBGzUGHnVgOto7RqzCHUrIY2842oYllG+InScoFI5i1vdFeCtAepnzUV+X4xPm0LrES/anZ5bOrvuOhW0ZByLd3cKFRhqnkYE/0Tzrm9Fqrl1jSNM/0jN9Cc8sehTm6vNwyJgU+JgD7uBhF91UyFjebX2DJ43AA5GdDyAisxq5+nh2H1Yej+WyMCpR8YQtXoYcJCvfDA6Vscsok1x4nqiZ+Xgu9uHqRCzzN5BjEeBqEKuaDvifZmkNSzU2QTMbj07aYKeur+QD4WOtlc2q7W8lV5XKwvRFn5PlAqNCA0C3vt4WyJf22CNBMo6ioe0QzVZWa/hw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 26, 2024 at 11:09:47AM -0800, Rick Edgecombe wrote: > diff --git a/arch/alpha/kernel/osf_sys.c b/arch/alpha/kernel/osf_sys.c > index 5db88b627439..dd6801bb9240 100644 > --- a/arch/alpha/kernel/osf_sys.c > +++ b/arch/alpha/kernel/osf_sys.c > @@ -1218,7 +1218,7 @@ static unsigned long > arch_get_unmapped_area_1(unsigned long addr, unsigned long len, > unsigned long limit) > { > - struct vm_unmapped_area_info info; > + struct vm_unmapped_area_info info = {}; > > info.flags = 0; > info.length = len; Can we make a step forward and actually move initialization inside the initializator? Something like below. I understand that it is substantially more work, but I think it is useful. diff --git a/arch/alpha/kernel/osf_sys.c b/arch/alpha/kernel/osf_sys.c index 5db88b627439..c40ddede3b13 100644 --- a/arch/alpha/kernel/osf_sys.c +++ b/arch/alpha/kernel/osf_sys.c @@ -1218,14 +1218,12 @@ static unsigned long arch_get_unmapped_area_1(unsigned long addr, unsigned long len, unsigned long limit) { - struct vm_unmapped_area_info info; + struct vm_unmapped_area_info info = { + .length = len; + .low_limit = addr, + .high_limit = limit, + }; - info.flags = 0; - info.length = len; - info.low_limit = addr; - info.high_limit = limit; - info.align_mask = 0; - info.align_offset = 0; return vm_unmapped_area(&info); } -- Kiryl Shutsemau / Kirill A. Shutemov