From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE3D6C54E49 for ; Thu, 7 Mar 2024 17:31:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 39BD66B020C; Thu, 7 Mar 2024 12:31:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3233F6B020D; Thu, 7 Mar 2024 12:31:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 19E0E6B020E; Thu, 7 Mar 2024 12:31:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 025CA6B020C for ; Thu, 7 Mar 2024 12:31:53 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id A4598121250 for ; Thu, 7 Mar 2024 17:31:53 +0000 (UTC) X-FDA: 81870935706.01.BD1F053 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) by imf16.hostedemail.com (Postfix) with ESMTP id 74E41180006 for ; Thu, 7 Mar 2024 17:31:51 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=I0YUjJL9; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf16.hostedemail.com: domain of kirill.shutemov@linux.intel.com has no SPF policy when checking 198.175.65.9) smtp.mailfrom=kirill.shutemov@linux.intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709832711; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pulpokqXIwwJXaP2hMiYPOsVLQIW3sjIgjaBXcj8CkI=; b=0JBVvizw9Lmh4AtlsN8peYfniuzBxVQDkcTKSMyfDl7g6qrPbIGP1uBuNIi/tBBQCvinx3 gf8Qd90bHbfEuEyjSB6WNMu8AWGN4wdPZV1lmPcJjOT5XPjarStdsd/ndZPrcfm9B2inby NPiWyLu22B2BLnK4WcG/ImEGd3PedYw= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=I0YUjJL9; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf16.hostedemail.com: domain of kirill.shutemov@linux.intel.com has no SPF policy when checking 198.175.65.9) smtp.mailfrom=kirill.shutemov@linux.intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709832711; a=rsa-sha256; cv=none; b=7HVmxLfCG1Cu7eaSsaCvcMo9fHJGubpixobZRHJ9pZHQIvYjR5b08hw2jLYx+6ZsKOq2Gf T8ErgE02/LsZtJM7lZJag08Xol1CcbUqxzS8AhozMjQr4uYdbmXze39dsaItU9TlZ/RIxM qsQUZAuxJo7+sng8GsOyUcvtKT3QRy0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1709832711; x=1741368711; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=vzADUwGQeVvOM48WKXm4UNqLNwBN9ej4gnBvU/nQcbU=; b=I0YUjJL9q425t3L8LmQFCI9qTawf/Z0swLZzDwA8GtqaoBp/kDSM3MAk +9lRwnwTrgYk/FQmehr6vMggyeg1sXBXCGqgSg1GyYF+RzyWsxJ3YJfax JBixwS8kDEihVpLEEMhDHh7U7ly6ohdHJNUhSvBKrdRycA0A+50goFaxW MoGVak/jehpAzkzclXewbf7IJgXDrJ42FjNou9B5UQ64cb0NNvFy43idS PoFKuOQHx/kaT4dFv0FP0DRfuOqytjT8Q4qEapqbGu2e/xv/DtDHwzdAs xXkoHL9soDl2ddMgpvpKor0NAseDPsBdMf0tatjOr6wtHC3qrGm847QiW w==; X-IronPort-AV: E=McAfee;i="6600,9927,11006"; a="26987282" X-IronPort-AV: E=Sophos;i="6.07,107,1708416000"; d="scan'208";a="26987282" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Mar 2024 09:31:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,11006"; a="937046429" X-IronPort-AV: E=Sophos;i="6.07,107,1708416000"; d="scan'208";a="937046429" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga001.fm.intel.com with ESMTP; 07 Mar 2024 09:31:45 -0800 Received: by black.fi.intel.com (Postfix, from userid 1000) id 8B8BB128; Thu, 7 Mar 2024 19:31:44 +0200 (EET) Date: Thu, 7 Mar 2024 19:31:44 +0200 From: "Kirill A. Shutemov" To: Yosry Ahmed Cc: Andrew Morton , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , Peter Zijlstra , Andy Lutomirski , x86@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 3/3] x86/mm: cleanup prctl_enable_tagged_addr() nr_bits error checking Message-ID: References: <20240307133916.3782068-1-yosryahmed@google.com> <20240307133916.3782068-4-yosryahmed@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240307133916.3782068-4-yosryahmed@google.com> X-Rspamd-Queue-Id: 74E41180006 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: muuefujxth1wrfa45x5mfjxnfrsoshgk X-HE-Tag: 1709832711-335681 X-HE-Meta: U2FsdGVkX19sS8cmduyL35EZaanNJbzk4bOZ1Hbs5U5FidhU99jJgb5SF1HDZtDml/2+yuOKOZG2jtu1TnPpjV2a0NKxOPi5MU0yHm8jS7LOuQiz2vb/Sk3vbhar6acNIrA1OzS9O8z8QrEXPt6OstEQB6vgCj9F+RssOi9CxWOQykMDll8SLWQW4DogvAYEQ5i0Oq6QuJNwS3nfLMa0n0+e2bMYJklhlfqiKAz/nyeEiLOl/NRgmYnpQSpN4lGrbs7cWKDXS3A4gHO8aQpwUx89DaM0GVd1XgLHNdJC0tgBcISYCZDMF40/O+kopZLi3Y9HfJMxtPiexV3Aq7fZomiMhb9lKuyG2K7kFYvoDfZk3TDRJXDdkNG+VxrXAm3UOkp6/HNDSIAYtT2uNa4h93WJREIBrfnCkuZmQaUOeYkr3Yh28iACd5Tl52qu3cTeIyv4MTpKUpAg4SosYgLeLwHmAMOPQZ9NA6y+tiobC330TmaEo5hxYRKjNRp9tLv187RHOaiVPVyCMRvUW17NcyiX/LYMIZRonE5F3BbNGE+GOHXjqGXgz6vdd+wvXyI4zwRExJNq/KYlwt0x3JDvWUGlaOv8d7vQqvVoJk+47jltqLt3yew37XDz5px5WBROeDK/vNEpnEDNQuAgdtEQtt0ADq3NEwPOYGW0A2H70selsWtstb7GQrJS3KzXFtmUdj2qneJdxdI+QgHvLEFDuVtn3ii0c8GaCoGWdl+ZXGLdjcvfbt+/SCmx6Dz7uvaFLQmgBqo24LzPmyGGdQuOiNO5jrWu/FOXb2YE8U7ayxBGCMaQlM8SKQ3rNRmudXt3E8TLGSjNBXiFM5bu0LWDp8ywz8kIarlNg8JdoQrx6L4BKBeiHe1CYg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Mar 07, 2024 at 01:39:16PM +0000, Yosry Ahmed wrote: > In prctl_enable_tagged_addr(), we check that nr_bits is in the correct > range, but we do so in a twisted if/else block where the correct case is > sandwiched between two error cases doing exactly the same thing. > > Simplify the if condition and pull the correct case outside with the > rest of the success code path. I'm okay either way. I structured the code this way as I had separate patch that adds also LAM_U48. But it is unlikely to get upstreamed. -- Kiryl Shutsemau / Kirill A. Shutemov