From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCBF3CA0FE7 for ; Fri, 30 Aug 2024 12:31:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 023666B0132; Fri, 30 Aug 2024 08:31:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EECB06B0133; Fri, 30 Aug 2024 08:31:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D65796B0134; Fri, 30 Aug 2024 08:31:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id B08DA6B0132 for ; Fri, 30 Aug 2024 08:31:50 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id B323B161959 for ; Fri, 30 Aug 2024 12:31:49 +0000 (UTC) X-FDA: 82508848338.01.AB89FF5 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) by imf23.hostedemail.com (Postfix) with ESMTP id DAB19140004 for ; Fri, 30 Aug 2024 12:31:47 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="a/5OAzCE"; spf=pass (imf23.hostedemail.com: domain of pedro.falcato@gmail.com designates 209.85.128.47 as permitted sender) smtp.mailfrom=pedro.falcato@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725021019; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ohDjUIiSvToxlJbMqL5nyB0BrdhKvUaZXF1JCyJv4sY=; b=fMJ2eCwWNMbhC5RmdTH7ctXY4tenWGUlK2tRj74Rd3+De+tbIaOKVOYLz8wZ8uvK3Hroji E7Z49oBu0O8w9S9uDu3mOjMrjgqh0PYZ3/VtN6AAd1c5aLLhKN2DwLrA+WJippzWcppAjM VfEKwu3tBf1kwOnjYz2deJ77h2afU7c= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725021019; a=rsa-sha256; cv=none; b=UKVJ+AhliKSImBCuYB1Bag2PUENQ9EQd/1Q1hOrbldTG51D8YxF8/Ig/8Wxbo/ClMjKP5V B5gr6LlFfy6dCeR5zWQOp+M/mR4UdnTaf58tmarvaMRFv1mEsfj69b6MQAIl1O1e5Uzffa tYfdqWKYCVD8C0pCPgCt0EYscAYn1IU= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="a/5OAzCE"; spf=pass (imf23.hostedemail.com: domain of pedro.falcato@gmail.com designates 209.85.128.47 as permitted sender) smtp.mailfrom=pedro.falcato@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-42bb81e795bso13033325e9.1 for ; Fri, 30 Aug 2024 05:31:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1725021106; x=1725625906; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ohDjUIiSvToxlJbMqL5nyB0BrdhKvUaZXF1JCyJv4sY=; b=a/5OAzCEfBZoJ6n3mR3eE7NnJbT7jHNV+62vj2SwKjwKOOkYtsEOmEq/blABBnCRYn mRCfgGlFLSUcFzsHrcZBFU7BDKBvn6UDIr5rQkiyDkrek1hZEV7S8KKm5I/bcIetNXXl XZaIq0g8TEMPVo9WZGTrTsqqttOwA3jLo0pELdID5b7Gk0rqwOOan8oh+GjGxwPQDES/ 0HN8DP+7r+DZXGshJc3g7XdFuLysn+5n0XIRubJ5evJCi2ogsjDfffo6cCT3kfiC3iKs mmWCi1FTxWivbGit8wKoCax+rRyhhiUMPxfVvVfpwK0Y7998RVRyFO5Gx51i14tK0CAh iM3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725021106; x=1725625906; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ohDjUIiSvToxlJbMqL5nyB0BrdhKvUaZXF1JCyJv4sY=; b=hg+7ndVunyhe8onUJoZJJAzhLn8x8fTxM+7Z1R6/YbYtHyTV6XjA2v86FCREcj5TKD N45yCRrX2Oufq9c7v2cTg1HNK2+kwhKlbj3Q59TausB5+wFPB1/BQL11uAhxWleEe4km DIX5ssnzzXIzI3VWekfeOlZwFPn7N/921zDo+AbG4DCuDEQpr9ADeSuDIoiLja3R8xZL cmIUBDBKfigPKYSMrnXKoClC9GzAxQy8/fcdXyD8Rlsj4kTlMfmcZdpFHLMqO1lwff2t Cj0q1XwsY9HrCFCod7RGT6PUpCGA90SDrtLLjZTntz1Sz5TZBzYyBrsquamX2x7v9bny Fneg== X-Forwarded-Encrypted: i=1; AJvYcCXLgNculL3IkyA2W9XUdl7Ov2elJ9Sut4UmKFPzLd3m4tQV/qdwRjk+MlZFBg6vd9NpYWTn3tH03g==@kvack.org X-Gm-Message-State: AOJu0Yzp4CjO7y8i2K6UnTQynLtlA8WXbPlNOuc+2gtcZaZwJ5Pq59rc AVXZ5oF9AXMO26OS+FTu/MLdfwYKwOOLj+OtQx1l2BAjqA9pVMia X-Google-Smtp-Source: AGHT+IHmGTbedrMJCDroV7oNwxn3M3Ss6No5PIHgV866gcjj3PkKjQVFejaxDgbKL/toPUYO0S1drg== X-Received: by 2002:a05:600c:997:b0:42b:ac3f:f5c with SMTP id 5b1f17b1804b1-42bbb436de5mr14103315e9.26.1725021105330; Fri, 30 Aug 2024 05:31:45 -0700 (PDT) Received: from PC-PEDRO-ARCH ([2001:8a0:7862:ea00:1d36:5f53:3f57:14ad]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3749efbf406sm3842829f8f.115.2024.08.30.05.31.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Aug 2024 05:31:44 -0700 (PDT) Date: Fri, 30 Aug 2024 13:31:42 +0100 From: Pedro Falcato To: jeffxu@chromium.org Cc: akpm@linux-foundation.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org, willy@infradead.org, lorenzo.stoakes@oracle.com, broonie@kernel.org, vbabka@suse.cz, Liam.Howlett@oracle.com, rientjes@google.com, keescook@chromium.org Subject: Re: [PATCH v2 0/4] Increase mseal test coverage Message-ID: References: <20240829214352.963001-1-jeffxu@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240829214352.963001-1-jeffxu@chromium.org> X-Rspamd-Queue-Id: DAB19140004 X-Stat-Signature: p1fd9po4p1u3wx6gz6dxdg9a9mait4go X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1725021107-98768 X-HE-Meta: U2FsdGVkX1/f/qCn54aLTJOl4Y6z/Otz0I0btydGgQ3CbsIxUXst5gMZqhc8Ot8foVHSkX5lnT+EnXzR41MQ+mxVSYaamEZykpWMBaZIEyj0ltR/QJcYlVrze6Xr5vLsGEYLYNXDwCJgXfnGQ0Cg7LFyJCeEaPEtkW10GuEdzGtrCClJ1cxgFtgI3e4wEHolGHj/Oe/DnMpu+/crwphNj8ZOe/rE/yb5rHrkv4aas0IyPYAJYzsJGfkMRscx27hFCJfd642LM56Nztlb+g4Gh99+UHYYRQAR+0r75wwh1mNdeywgfNKDC25ZxiDePoKZVXu8sDWl7BCfsSGIdirT0WycHoBu1JQO6zVgxmrkYLwEOBJ4xMzkjPm91gv56j11I5NNJXrIKC3BvIvFfj6AoAspF/UlY0NnQNf11WVIrjiaePMBysEXkSa+7ERTw5wG46fMdU9Q6CnRc7FHNiLxOdCy781qAvcffl/vEhVrEBqUb7qw51yK5HFoT6zS9cKq8jX1cYR9SHb1X5ePdOC/l2UDe3us5aSFmLdB2//Mou7pxz2HANh5gmGN1YyugROhMClpV8vesdl0p2pJ87SHGNWf3C0ptaDcoWeDBtMVv7bF8BdxjOmmtf9AtCKleiEwNkbNHNuzjXDkm0A7nIYxT/o34m/IbxxFEyYCcq4oK4og46u25Za9LebCNZOPQO/Crt7q13T+sfqHL2SZkY4m5+4n/kag+kvt7sSA0viaj+5mIMMfG5v67l4TgAXISvr3NhxHtaFq//EInw6KAcAoXKqarMRPp8Om1WN9dEzDowyl7sIyNvTfHj3Ulns7hwA33XIsLuPviVegAqJG94P3iQLuosog69FFp+JasyQEApL0f+TrShLoPv5E+j8HGRv41pDBye2qux2aLVjCuJ7pnW90M2sw5fOgL/3tmLLWwxhV31+FGj3R4LKFxx3Q30y7xiQlN4Z1jFqdit+2C6U +P0pu/Iq SEbTx9CqWZfLORHER44LYRmRjG4ZzsF2DSemqw3GNMiweMVYcYFSf5qOG7d+NhOu2SgL0lQN8Xu5T3D+2u8VBTt+50BMUxAWQEyMTb5NL0khbTLdBgI+lhVa2RygFC0L/up5ylNQtyyT71FamIupm83gHIt3tNPE1UOl0VylW6fW7uUUDdezXYynyj/Up5M+GEp2J+q59CCPXWOZwrCSFy6RRoE/7D6QzH9DLbPafCQQN8u8iRqNTP3iJv2Aec8LFySECcLXamQHMlpw70HWUKA5kJCOKIbR1AvnTohvsvLHTBimCgUOdyqYnh9Y7U03raUM83fppaZugco6f4p7xQSGd5YPjIv3BzoHUjjtXK0NlebMw4vaX5VLZWHm8YOo/NBYocYxSzK6bdo3iR/Hk+wxhvCcJwrCY7jndcpSy3LMV4IUuclO4YffV5tfLuqQ5k/tC3Hit3g8AGP1gJvRSEyplSfH64yVhnuXV X-Bogosity: Ham, tests=bogofilter, spamicity=0.008768, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Aug 29, 2024 at 09:43:48PM GMT, jeffxu@chromium.org wrote: > From: Jeff Xu > > This series increase the test coverage of mseal_test by: > > Add check for vma_size, prot, and error code for existing tests. > Add more testcases for madvise, munmap, mmap and mremap to cover > sealing in different scenarios. > > The increase test coverage hopefully help to prevent future regression. > It doesn't change any existing mm api's semantics, i.e. it will pass on > linux main and 6.10 branch. I do want to be clear that we shouldn't confuse "test coverage" with being unequivocally good if it has the possibility to paint ourselves into an API corner where details that should be left unspecified are instead set in stone (e.g do we want to test how mprotect behaves if it finds an msealed vma midway? no, apart from the property that really matters in this case (that sealed vmas remain untouched)). > > Note: in order to pass this test in mm-unstable, mm-unstable must have > Liam's fix on mmap [1] > > [1] https://lore.kernel.org/linux-kselftest/vyllxuh5xbqmaoyl2mselebij5ox7cseekjcvl5gmzoxxwd2he@hxi4mpjanxzt/#t > > History: > V2: > - remove the mmap fix (Liam R. Howlett will fix it separately) > - Add cover letter (Lorenzo Stoakes) > - split the testcase for ease of review (Mark Brown) > > V1: > - https://lore.kernel.org/linux-kselftest/20240828225522.684774-1-jeffxu@chromium.org/ > > Jeff Xu (4): > selftests/mm: mseal_test, add vma size check > selftests/mm: mseal_test add sealed madvise type > selftests/mm: mseal_test add more tests for mmap > selftests/mm: mseal_test add more tests for mremap > nit: Please follow a more standard commit naming scheme like selftests/mm: or selftests/mseal: -- Pedro