From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 388ECD10BE5 for ; Sat, 26 Oct 2024 06:34:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B95E26B0082; Sat, 26 Oct 2024 02:34:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B43D66B0083; Sat, 26 Oct 2024 02:34:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A0B906B0085; Sat, 26 Oct 2024 02:34:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 81A7D6B0082 for ; Sat, 26 Oct 2024 02:34:53 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 141C0A13E6 for ; Sat, 26 Oct 2024 06:34:16 +0000 (UTC) X-FDA: 82714789542.19.6A79376 Received: from out-171.mta0.migadu.com (out-171.mta0.migadu.com [91.218.175.171]) by imf03.hostedemail.com (Postfix) with ESMTP id 8B5D620016 for ; Sat, 26 Oct 2024 06:34:41 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=wczahDW0; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf03.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.171 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729924451; a=rsa-sha256; cv=none; b=hY+bd04IBjyqiprOCzKU/HJ19MwduD99eJKGPh+pWBwS1xGowh6o/jjbz+7KKD9PwTObLb onSCIqkWjO4EbQ52O6Oi2y6pujkybzkxt1M5GIjv4kMCZy2gNMrApscx0UjdQZTx5qyBD0 RtO4RRqDp7u/PgRMnc1bA4rMrPN5qnY= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=wczahDW0; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf03.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.171 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729924451; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TxrrU0C1HHBfUSnsjeyhEXVDIjFovKtPgZ0TUPmLbvU=; b=OliiZkhJFSIhhMLsq9n4+BVr5WnBcFC2wYchAYUzWq/1H9A/HQD5uo9jIEelVEg3p34dU4 FQZnpTsIXabUe3r5DMBrKuSz8ceeS3VT0v77r97+LcQZU3Ogwpjtk+KW5crF9z7U9Z35rc oeQo+D0vW9ueh4XVTQpDiID4Pyvt9HE= Date: Fri, 25 Oct 2024 23:34:34 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1729924489; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TxrrU0C1HHBfUSnsjeyhEXVDIjFovKtPgZ0TUPmLbvU=; b=wczahDW06h7sCwR/14RhOAhWxIUZiK9a9DHkNpFa54ZSDnpRWfSNkjci9DWRCMM39T3yFY JucMbidVMqOQGS8doMn8rAbfDURpjRycJKApjaKvXDDDtGBdV+pAorShsf6DE8hljux/dC Td3IuC1aSRPgC4lmUR0FdWkEr9EwdWo= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Andrew Morton Cc: Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Hugh Dickins , Yosry Ahmed , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-doc@vger.kernel.org, Meta kernel team Subject: Re: [PATCH v1 5/6] memcg-v1: no need for memcg locking for MGLRU Message-ID: References: <20241025012304.2473312-1-shakeel.butt@linux.dev> <20241025012304.2473312-6-shakeel.butt@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241025012304.2473312-6-shakeel.butt@linux.dev> X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Stat-Signature: e6qfip6cw4br4kf7phjnkyrxokjyd15p X-Rspamd-Queue-Id: 8B5D620016 X-Rspamd-Server: rspam02 X-HE-Tag: 1729924481-992854 X-HE-Meta: U2FsdGVkX1811CqFjg/Dzzultedio1yFU33qcRbyGc6Ss7e+wxY3mIdTMXqCoTG5GFPf2aG0zIu3viU4w1WiXoGMDpE/0VAYAaR37jdrRc80LI67Sj7wMjUT6ul1SJR96FLfnhnDLy1oH0BooJzqYnsK+MPmFypItra5LxzzFgycqo3TFct+RZDevVOA3MURdMplhpnC1hkS6Zx+wQTzjPD5260OCGkDsnD6+GnCkjsZLyXpuGhXgX7XA7QkUgKdNeMfRGZcTFjnSaOf2Hq5+vw3ATN262f/9K0cRk++xHR9RNYd9UatgtqijmL+Oe8Ho2zyKLo5ACpFgHpuSyRnKO3oMiXPvjiHpL6DPCsmGl9q02JCbsDsQdt5bSQ6y1ze8T2Wzu84sBunz2fjw1m+UVBGrz6SBHV13vLt5B7ohQZmHwgKBziHUnxiIDqrW/NCYasNdPW2t2mIiF/pzGwspQlnPXojS9YAkH7TMP4UyjxUwe9XUR99T0JCaAoPiG9OOFg1PY+6INLSOAWMe3xN4QQvhbBqRU/Axdx8X9PqyCNN5EqmWU8bDP1LEomAvBcoYxfLlUScdxWbXR2SFIh7E3sXrRfa7QC5qC2mgnt7H6NLdLk9RaZMZzR7mYzaOyVYZWa65xcqf3bI4h1Zxp+BlCXCSeqx0oG4C5NErB/Ui5boXsWo4zazPqqWqJdCMQ9/OmQtkyYedLXGw+Dm9kF0Hpp6nPKwIwlN5ZW8yypkJLZbtREoUgrBSj08Z+X5OVYYjpyUEO/jsjQPFykvqiNnWf5f5tcWm+CvbfDZVYh/PzN6QV2TtuQDhhM7/ilGVYGFbG/xacNKAlHwlBUBBjCaSQoZXWSAz00RJ1KclwjdOuC5NZ3KHsmzau23FKcFWLTmZbCIvGZ/y11A/lvM5yl6GF6ZUaRiUy8e1zLEgrC0/MgEmv9azRtzErlGF+aL0q4yoIb48flvxDDbg61hCqY 44ddNxeg FAkA55sgE5nXhPCA9UOld4nDMA8BGsfcx7XeJHP+lWuS6BZlVcTcijUg/3x6Ws+aHJlUoJFjYvkQzHdTXw7sdCJ+eyPvUCYwBASRtw8flefwM7S4iL9gCafO8DJOe5+GjYQC3yhy3sWOd6kaWWN/epP+JGA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Oct 24, 2024 at 06:23:02PM GMT, Shakeel Butt wrote: > While updating the generation of the folios, MGLRU requires that the > folio's memcg association remains stable. With the charge migration > deprecated, there is no need for MGLRU to acquire locks to keep the > folio and memcg association stable. > > Signed-off-by: Shakeel Butt Andrew, can you please apply the following fix to this patch after your unused fixup? index fd7171658b63..b8b0e8fa1332 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -3353,7 +3353,7 @@ static struct folio *get_pfn_folio(unsigned long pfn, struct mem_cgroup *memcg, if (folio_nid(folio) != pgdat->node_id) return NULL; - if (folio_memcg_rcu(folio) != memcg) + if (folio_memcg(folio) != memcg) return NULL; /* file VMAs can contain anon pages from COW */