From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BF92C5321E for ; Mon, 26 Aug 2024 03:32:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 77F2D8D0040; Sun, 25 Aug 2024 23:32:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 70A078D0029; Sun, 25 Aug 2024 23:32:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5A8248D0040; Sun, 25 Aug 2024 23:32:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 3C0CE8D0029 for ; Sun, 25 Aug 2024 23:32:27 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id CF1691A0AB7 for ; Mon, 26 Aug 2024 03:32:26 +0000 (UTC) X-FDA: 82492973892.21.B5A63A0 Received: from out-171.mta1.migadu.com (out-171.mta1.migadu.com [95.215.58.171]) by imf07.hostedemail.com (Postfix) with ESMTP id ECD7840008 for ; Mon, 26 Aug 2024 03:32:24 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=mqDuUSd6; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf07.hostedemail.com: domain of kent.overstreet@linux.dev designates 95.215.58.171 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724643076; a=rsa-sha256; cv=none; b=OvKMaSw0yUuV3/K80sKEqAzKnpGoO/eaSMEyPIT9D9KChWw713rNH9K41VihLJU4a1pTD/ BIHInHe1/+w8M9IV+vMLAwGl5ImtvYjDr9c4TqOlpKefnz6ln3wmiqY5RxbHdfs+zUZ0IL k4UAYxzgkK3YKFSCsH/ZhUHz73GUtns= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=mqDuUSd6; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf07.hostedemail.com: domain of kent.overstreet@linux.dev designates 95.215.58.171 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724643076; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UvfgadhcslqGk6VVX3LUkkJ/RvCws9F2sKx+6ZBX/ZE=; b=xMPERc3p41jEdVbqkQ6eyNoLKaPtfwQrNjcL+5aq2F+wIrkFkT6ln0RPvuVAc24y+h8u7g gDQE2064CUO96bkbKr/jIzfokkxPGZCjkCug6e8swub1D7jqrmjw4hTlinkNbS8PzOSsH5 FsCdubVrDC70nC3/9ezNf/+WzzbbCNM= Date: Sun, 25 Aug 2024 23:32:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1724643143; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UvfgadhcslqGk6VVX3LUkkJ/RvCws9F2sKx+6ZBX/ZE=; b=mqDuUSd6QjANLuKeawxXs5IynoQvSMMa3kCl24fEaaS9Ldl970LDWO52bCd2Ys3OUYuMaq gHlcgq3i1TkMmqwTOV2mrB/qGbbsaXVb4XUDj48XE5nOmsg9AYeaecqJIPiR8/ICoFYCKg /GNIhI57pfBCT3nQ2REhGVTcbRoIAZQ= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Qi Zheng Cc: david@fromorbit.com, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Roman Gushchin Subject: Re: [PATCH 02/10] mm: shrinker: Add a .to_text() method for shrinkers Message-ID: References: <20240824191020.3170516-1-kent.overstreet@linux.dev> <20240824191020.3170516-3-kent.overstreet@linux.dev> <122be87e-132f-4944-88d9-3d13fd1050ad@bytedance.com> <4733d230-0935-4bff-a17e-8c6735ad16b4@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4733d230-0935-4bff-a17e-8c6735ad16b4@bytedance.com> X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: ECD7840008 X-Stat-Signature: prq9xy5kmmebtiogfrsjtrer163fbu9q X-Rspam-User: X-HE-Tag: 1724643144-277633 X-HE-Meta: U2FsdGVkX18sKuRAQBHgjCkSXpeqlQCqg+rsQFQrYssXOJIjiq7GhqXlwqDbYXnWyBUFPowSTn6Wjhmp4bnVaqqPoyPYWGSKFjWp+NZwan9JwB08JfoV0scrDu1z1qQjtKdCGHXTxApI7PlbA4dil2/4ehUq5qpbii1gRZbsYQsyBcGNyL5FxCqSNUJ3HD4P1ZRVfV+QbhXZRxnrImP+fvORjgqjyjFm4UuKpSsZ65vVqxs+yztx6FbuwbBgwEpVJhWDP8KQgVVJ8tLUfm8O4E/5i8B9iKUlGpS3SakPPeA81qT7lVideXZoi9Q9znbHy3PUn3YavzWrt1hI6yDuJSk5bc2ES/AJ1fcL/mVt1LvxlZWIyihII7yYKPK5tNrfxdnXoml07/q7QzD8cXz9vLIAb82hFVDDA3nto0HjhY/yZjVubJ6siqzVn83hMcXlE4bhgaeVg8vcmYsgN50E/py0gvyQ7/ipD8mB6Fz9J50mlRnq7Ht/B79dt1ghr4t7qJ3GVokrHrQ+AOIHV+pBpCs7WIzKZNW7aLokBEwyuENvtcqc6YptPfLONA/sAM27OETkQWXYNpp5g8eSg2i/B2nzcuzQkuN48ypSnbS/JVEItMBQH/UQKGr4kfn3j2akHQM5m1sR9hT+m3fIxli1fsKHdMkVZtb7uSrIvFgo1/cU+OATC2PgoG5yBoYX8mL5nrb2Uy0e/XHjDH8zNv59I3pkseILyE9uDNNx2mltqBMBBN5msCOkwGSs7Cr0ieHdqgk59nPCUr9PivZstEcoTSQ+C79XaAGyDCOKhw+jpQOboLMWFILY38mjwJE1WuCrWVQUARvV04pvbyz94OBgnjEMc3222DukVStougBWfZxSMd7uGaRAGv0ZAEkAXSiukbhVWEjMvmyyINuW+9V0kpt3E2m1cboQy46uafPKetdp9lkUkDeQ1bxJAK4UIHU6VTC93ENaKsU20Xc2G8X 87h0QHR0 u0vaI7ANbZJ19JmDZDx9NE4duzKmX6HE8Z7RfnY2HijlM8cYF2PIjwMkdqVBv7WC31kCrq5axWMwckrR/BhiJm4a3yz9e+XBJYVJHelLC7770UY6XZIPVNH+5wnouGFclo8esSbXLXMqA13XSCWXS2V3xXsJP79uAc/xP X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Aug 26, 2024 at 11:10:08AM GMT, Qi Zheng wrote: > The shrinker list may be very long, and can you guarantee that shrinkers > other than bcachefs won't do anything blocking? ;) It's not worth making this code more complicated. If you'd written a clean simple iterator for RCU iteration it might have been different.