From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3D50C7EE31 for ; Fri, 27 Jun 2025 07:55:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4CCE28D0013; Fri, 27 Jun 2025 03:55:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 47CAB8D0006; Fri, 27 Jun 2025 03:55:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 344838D0013; Fri, 27 Jun 2025 03:55:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 20DF98D0006 for ; Fri, 27 Jun 2025 03:55:26 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id AC830B6E08 for ; Fri, 27 Jun 2025 07:55:25 +0000 (UTC) X-FDA: 83600420610.01.114FBFC Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf30.hostedemail.com (Postfix) with ESMTP id 66B6480006 for ; Fri, 27 Jun 2025 07:55:23 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="FbbeNE/T"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Kty7AgHZ; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=2fJ8jZ9U; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Hpagzk4S; spf=pass (imf30.hostedemail.com: domain of jack@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751010923; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ptecp9XDD5qXUjm1CHcOI25++V3ZYV625LMiuMqRD10=; b=hsvFZD5sqSHLW52RmnGKlZVDiWDvUXK5nDTfC7cSw8yg5BZk451JQq3xfhoBGn6WBDKaEA utb2XmiDoez+3q+8R9xnilM/yBiieaRYJ5b/VlLsgEC5Vtd2mOyI+i4GniBeKiHnpsuOdw EhiWJfYUEJ7GJp5tneM4ctwJGFEnBHk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751010923; a=rsa-sha256; cv=none; b=KAtMWkXc3Jwbsg1OkMD09a5tKXc9iF0CHuh9Jgzr6VuWeLXP+7YYTJbKMXJd7Uvjeybi+d 1Qlt8qUu1SMt59I4QO3MnCiJ4A8Wd6LerQW+Nn6nnGPREX6LeiCsX7V9ozrp5L/qhL1Euo ZCBpcM/Qk9Jx5cl+ALAXrK597+arvbs= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="FbbeNE/T"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Kty7AgHZ; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=2fJ8jZ9U; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Hpagzk4S; spf=pass (imf30.hostedemail.com: domain of jack@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 6A5C021174; Fri, 27 Jun 2025 07:55:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1751010921; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ptecp9XDD5qXUjm1CHcOI25++V3ZYV625LMiuMqRD10=; b=FbbeNE/TjNlk4A5o+6fTzCVPxDsccqxkglkAUwvwXESso0vOSRA93wslhbMWSdcgx2I9A1 FxsYl8peLk6l5FlB8AleHM4sdaXJe+cEOsXjVgIMGRYviXwc03H/7rf2+6l1NPsoASQO8Z wzfkH8nr4OzuWShSLrvWP5nrRCOcpbg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1751010921; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ptecp9XDD5qXUjm1CHcOI25++V3ZYV625LMiuMqRD10=; b=Kty7AgHZB6YBFhZcKRw2mTyW6CJChk6RVH9k5j8RNgF+vqOqoDBVsN3ynKtce9dk3L4P2Z 9VKCowIUIdiFr1CQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1751010920; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ptecp9XDD5qXUjm1CHcOI25++V3ZYV625LMiuMqRD10=; b=2fJ8jZ9UnZlpBq7wdYctaRSdNpHrqZzHhjN/Plxy+wxWVUpw93g2jWHdviq1K8Z9WZkhjb tL7jzDF3f1yKYcyY69EhbD6WS85W5KiM1KDVbp62R7ZM9CBX94CmJISxLdgPi6korVp0S2 k5TJhnCTONmdTMdl3bJVHLNGlUr3awU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1751010920; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ptecp9XDD5qXUjm1CHcOI25++V3ZYV625LMiuMqRD10=; b=Hpagzk4Sk2vJIqYpZVOghUpIQqL6dR5KUuMdCT2yVko6zVkWWutCvArYyCSpKT1jNDVWP9 c0nvjxBxvkOKNUDA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 5894713786; Fri, 27 Jun 2025 07:55:20 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id IbGcFWhOXmgIUQAAD6G6ig (envelope-from ); Fri, 27 Jun 2025 07:55:20 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id D996FA099D; Fri, 27 Jun 2025 09:55:19 +0200 (CEST) Date: Fri, 27 Jun 2025 09:55:19 +0200 From: Jan Kara To: Florian Fainelli Cc: "Liam R. Howlett" , linux-kernel@vger.kernel.org, Jan Kiszka , Kieran Bingham , Michael Turquette , Stephen Boyd , Dennis Zhou , Tejun Heo , Christoph Lameter , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Petr Mladek , Steven Rostedt , John Ogness , Sergey Senozhatsky , Ulf Hansson , Thomas Gleixner , Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , Andrew Morton , Luis Chamberlain , Petr Pavlu , Sami Tolvanen , Daniel Gomez , Kent Overstreet , Anna-Maria Behnsen , Frederic Weisbecker , Alexander Viro , Christian Brauner , Jan Kara , Uladzislau Rezki , Matthew Wilcox , Kuan-Ying Lee , Ilya Leoshkevich , Etienne Buira , Antonio Quartulli , Illia Ostapyshyn , "open list:COMMON CLK FRAMEWORK" , "open list:PER-CPU MEMORY ALLOCATOR" , "open list:GENERIC PM DOMAINS" , "open list:KASAN" , "open list:MAPLE TREE" , "open list:MODULE SUPPORT" , "open list:PROC FILESYSTEM" Subject: Re: [PATCH 00/16] MAINTAINERS: Include GDB scripts under their relevant subsystems Message-ID: References: <20250625231053.1134589-1-florian.fainelli@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 66B6480006 X-Stat-Signature: r3xzhcqo38ba15mhugbrqmf6o78jw566 X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1751010923-358533 X-HE-Meta: U2FsdGVkX1+FRTM5sExrESfTGGeBDBSVwj9NMTNmvkXd43Clabc5vqtmoDkuBBpSRrfYdZNZPAlAZqAcvYxY1sWK5upCsZaqksNl8KnSvwtEzcxj372FjUNjAPXi3WODFZBRU5qdm7VihrvNqq3jWe0Gpbp7+X7rxjaksViqWQYrrWUAm7vvyNVHw6TutAAyB6YUVrnoMKjOl3Nol1fLYDGzro1uWaq7JHPvYv7EuYbjz1y0pmmtp/DjBsC65Ltmhjt/igb+Ne4y+yOoLcBW/m5mcFrTtEyEzhb1aAypCCTmBXaa6tSG5qTBrOAQH0e+f53RpSZEccnj4n9iVQ1wnnSSZxAAEpkKwSWHJGgHhUpbqUUJP1OWnkRWdksHMh5zEupgjw3r4WPdPpucymiBCJT6WdQhufL1TCp06DCPItE/0Uq76WlbAWY4BFJgTI/tTT9yLh3eXu5qOCMFBPcT2SlcPnjfdEY6vzgQf6ie/SZFGy6EU/eJlJgCIr7YPx+I9YBm3TUruTqQM3mIdX6/XS23YizcnRzRO2V94lBxWuLYlLWxAPJ2fEtheVKtybdvhEd3K6lWU0qphdBMHEr4EYfo8D5b4UCjOFTLhrnw8DA85WuokJoHd/Kep9slPtQ+/TjaNeE1qm4xdUuKpPhvfp2/XYP+bOBFYaKM0gXy5EdArq+WCF3LNChc07PQjO8Bg6kDdRZ/+xgeW23tSMGhdLBOA9Z5HH4X4QeKqUBZmd7rm2YkUn/A0GguoB+visf8HpCFznI49YILqyJ7l/KaWJZyZc11As1yqaMEAUrWMiJoy2w6xUj1l6cxE0dfh+2+tsC37A86/DHlad1LymHgIDjLIwcvUdrQkBXEs/L2MG4CX+uqRmPz9fcPj/aYl3wDNJ47niT3cjwKY47+/U/O5utyZ3rWcOOvKN28d4ZKl23gD76k0UnRJlbV+MxzkuMZjGv3GGtgP6yuunUTSb/ yMpw6jtQ xMCx7wAfGI9BALSN4Ed/A3YdB0u5x3lbZk3fFaaxzZrJRQeoQIwZc07Klo+mB9dyso6uMpq7H2xGf6DmqpijQkSLFT5lDn3ZVmPYc9Qq3b2Z40CoLH2+rgdPS/Pb2aMfwMJrD8AMYszlyXNbGbZndt+EB2HtsKSzw0nN698NI+kW7uciyTxwa+DpOOOe/y0EQT5ttxM26aBpZlGye6RVoVMpJR7vJUCjjjKChYQQl6RzVHkNLaxgZ9GsCVbbPCvTbVezkgSrakv1OdzJilAxKkRonu1kYG5lI/DfAr9OQ3GUnu6xxlvBfXsCtNF1dbwtKgJCRF9HTDss4H4yjzCiSDREnHxw5fCTHdp/qyq2gDbA2xzVYjOa3Kjkj/eenrl7iyhSILbd7QQJpah7BZOrO21FxobMTBUM1GSEsxmquxcm50KMUlIvfoIZV19NvUCrgLu81 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu 26-06-25 09:39:36, Florian Fainelli wrote: > On 6/26/25 09:17, Liam R. Howlett wrote: > > * Florian Fainelli [250625 19:13]: > > > Linux has a number of very useful GDB scripts under scripts/gdb/linux/* > > > that provide OS awareness for debuggers and allows for debugging of a > > > variety of data structures (lists, timers, radix tree, mapletree, etc.) > > > as well as subsystems (clocks, devices, classes, busses, etc.). > > > > > > These scripts are typically maintained in isolation from the subsystem > > > that they parse the data structures and symbols of, which can lead to > > > people playing catch up with fixing bugs or updating the script to work > > > with updates made to the internal APIs/objects etc. Here are some > > > recents examples: > > > > > > https://lore.kernel.org/all/20250601055027.3661480-1-tony.ambardar@gmail.com/ > > > https://lore.kernel.org/all/20250619225105.320729-1-florian.fainelli@broadcom.com/ > > > https://lore.kernel.org/all/20250625021020.1056930-1-florian.fainelli@broadcom.com/ > > > > > > This patch series is intentionally split such that each subsystem > > > maintainer can decide whether to accept the extra > > > review/maintenance/guidance that can be offered when GDB scripts are > > > being updated or added. > > > > I don't see why you think it was okay to propose this in the way you > > have gone about it. Looking at the mailing list, you've been around for > > a while. > > This should probably have been posted as RFC rather than PATCH, but as I > indicate in the cover letter this is broken down to allow maintainers like > yourself to accept/reject > > > > > The file you are telling me about seems to be extremely new and I needed > > to pull akpm/mm-new to discover where it came from.. because you never > > Cc'ed me on the file you are asking me to own. > > Yes, that file is very new indeed, and my bad for not copying you on it. > > I was not planning on burning an entire day worth of work to transition the > GDB scripts dumping the interrupt tree away from a radix tree to a maple > tree. All of which happens with the author of that conversion having > absolutely no idea that broke anything in the tree because very few people > know about the Python GDB scripts that Linux has. It is not pleasant to be > playing catch when it would have take maybe an extra couple hours for > someone intimately familiar with the maple tree to come up with a suitable > implementation replacement for mtree_load(). > > So having done it felt like there is a maintenance void that needs to be > filled, hence this patch set. I can see that it takes a lot of time to do a major update of a gdb debugging script after some refactoring like this. OTOH mandating some gdb scripts update is adding non-trivial amount of work to changes that are already hard enough to do as is. And the obvious question is what is the value? I've personally never used these gdb scripts and never felt a strong need for something like that. People have various debugging aids (like BPF scripts, gdb scripts, there's crash tool and drgn, and many more) lying around. I'm personally of an opinion that it is not a responsibility of the person doing refactoring to make life easier for them or even fixing them and I don't think that the fact that some debug aid is under scripts/gdb/ directory is making it more special. So at least as far as I'm concerned (VFS, fsnotify and other filesystem related stuff) I don't plan on requiring updates to gdb scripts from people doing changes or otherwise actively maintain them. Honza -- Jan Kara SUSE Labs, CR