From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4627EC36000 for ; Fri, 21 Mar 2025 12:30:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1DFD1280002; Fri, 21 Mar 2025 08:30:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1924F280001; Fri, 21 Mar 2025 08:30:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 030FC280002; Fri, 21 Mar 2025 08:30:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D3FB5280001 for ; Fri, 21 Mar 2025 08:30:11 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id CC972ACAC6 for ; Fri, 21 Mar 2025 12:30:11 +0000 (UTC) X-FDA: 83245490622.02.275EE9E Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) by imf01.hostedemail.com (Postfix) with ESMTP id A62954000E for ; Fri, 21 Mar 2025 12:30:09 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=Ecd8lHFX; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf01.hostedemail.com: domain of mkoutny@suse.com designates 209.85.221.43 as permitted sender) smtp.mailfrom=mkoutny@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742560209; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=G65UV4/EPEL+kQ65PV9/uamD/u6L+fEtW/r8PlOFSsA=; b=0k+tlhIO6ftEI7kPkwgAYr2Pl3xoINNUQDZzGLVz/CaX/mtyep2qyC14L9CDYNXUDPFDbe u/NFXv5jSheRRBUYhc5cx7/B7RoK9nyXefh+daDomtVlws8uovXy6uBcHd31VBqmmAl8jB evi5FW9KZUwF2CMJHZnkJDwsDKM+nY0= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=Ecd8lHFX; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf01.hostedemail.com: domain of mkoutny@suse.com designates 209.85.221.43 as permitted sender) smtp.mailfrom=mkoutny@suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742560209; a=rsa-sha256; cv=none; b=BaokN+VEC9+evwgdJJ+iCz+6Uv4/PBk1SROwnK6QP0OVPNE6bREvxnIT1SWRPQmIICbdms 5xElQt7oCf2646ip+mchjojwV7cheuJnTGUSq03g2FfRkB7RAkveCrZSfbHKsarsT4nHsN EOlRQMkHkRYYdrnyqeMxWt8BtIIBzyw= Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-399744f74e9so1224896f8f.1 for ; Fri, 21 Mar 2025 05:30:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1742560208; x=1743165008; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=G65UV4/EPEL+kQ65PV9/uamD/u6L+fEtW/r8PlOFSsA=; b=Ecd8lHFXt5w70jGIS+LAH4rdJV36NPp9rYK0TOOGH+AnZlCRrUkUpVdq/Iot3denmX +Qwxg3hCaom6Aspb13GoicfCk16muuqqoZvAuC06GMZWDsHDgw9CLDpSDgKZutdLCZL0 +Avpkem8pyiEEagVyZi8SbWDfmu5eLhlFpLJfQ165/z+Vi5CXYJX8OwZaY+fkQ5A31mu K2Z+EB/bjmyE4TK4elvc1bGlj27hz0oTG8GJ/SslNqna5VOqGjglBAoDprbL50uUQhcr XohlXOG1vMnIkeJP2d6j0HtJ7ZBksqFOl+ASL6iayQv3ROvdpqLzt3J4DkySIW5y5enH werg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742560208; x=1743165008; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=G65UV4/EPEL+kQ65PV9/uamD/u6L+fEtW/r8PlOFSsA=; b=qCRrFoLHU6o6nOSYAdS1ZclLriRSi3igU2ewYRh+Ch8F4HOmfexssLPp4opxcujcuT ZlhtwmoEvts8w1/p7Ywas2btrJf+xhksQdBmedIJ5+YHdAh7R928krtZIxWqbaJDj9du esGbyRYambikJ7TemsoxLeuVZ18glFDiOLPV1AHApFDfQb91eAi/Uq5JBZb+5pBBdxIK npWHaK8dQRX2C2aDJmCxIXov3UtM1lTNd1dHjII1ly/Hq9meMorde36cfwwH5weZuE3q GWA3G8mZtTjL1v4fFx3FyrEYXokU8H0BbfgpnCjZvdsb5GgynwsxcSu7eIY+jdc8K4QA JvMg== X-Forwarded-Encrypted: i=1; AJvYcCUQmBfXCqeTJVQXfmRCnbOP7hITBZzz+yYB/72yagWtAGmuZQOQ9PLV0dI+s1iWUxs5PexYpmwgYg==@kvack.org X-Gm-Message-State: AOJu0Ywk6uG65p3Q9Clnl++P30AmAAWKj+xbh6XsSQwQ8PbBJTGo88mZ IqIkz79y1vpOmFtaglLhff02acz7WYl7umr53IMSf7GZKnv6Xb2DPvzy/sPFEi4= X-Gm-Gg: ASbGncs0dPEaGWEhiYv5uTD0oGwssvddryd51XOqLzhxvoqyvl1cnnKVsP3rHBRWjiE Ur8oVQcN7ggOy15oq4Xk9hSB5fw4akLis4bwLvJtlpUbgtutTEGlCJM+3wNMkfNVzZz9n1oT0db HzcpYyMAG8IZ2VE4gTeymWrOyxgCBoQnGgPAmDeLIgi2W0VOgTbJjwlNCOfVU7wEfziw89L3Nin jXk6KEnypKRGbWmTXVXPXHkJ70xHSRphIPfZj8rBppZj0xyy594mlrtJzbM5X2CFjLKtlRSM9Ye hITy09WSRm34CLLA3O/837Uom6LnKyKLADieIzR6Fm6IlJM= X-Google-Smtp-Source: AGHT+IExv+tybR5ipnVHMChIozaD9HWg71HI9cTN6Q9laK+gRbql3sVz1wKjQhAcenueVqPKCCAWLw== X-Received: by 2002:a5d:598c:0:b0:391:3aaf:1d5f with SMTP id ffacd0b85a97d-3997f9595f6mr2940009f8f.52.1742560207835; Fri, 21 Mar 2025 05:30:07 -0700 (PDT) Received: from blackdock.suse.cz ([193.86.92.181]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3997f9a3a10sm2231886f8f.28.2025.03.21.05.30.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Mar 2025 05:30:07 -0700 (PDT) Date: Fri, 21 Mar 2025 13:30:05 +0100 From: Michal =?utf-8?Q?Koutn=C3=BD?= To: Johannes Weiner Cc: Hao Jia , Hao Jia , akpm@linux-foundation.org, tj@kernel.org, corbet@lwn.net, mhocko@kernel.org, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [PATCH 1/2] mm: vmscan: Split proactive reclaim statistics from direct reclaim statistics Message-ID: References: <20250318075833.90615-1-jiahao.kernel@gmail.com> <20250318075833.90615-2-jiahao.kernel@gmail.com> <3a7a14fb-2eb7-3580-30f8-9a8f1f62aad4@lixiang.com> <20250319154428.GA1876369@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250319154428.GA1876369@cmpxchg.org> X-Rspamd-Server: rspam01 X-Stat-Signature: 3bp6w3zdqqsf74a99iik3r76ezkj49fi X-Rspam-User: X-Rspamd-Queue-Id: A62954000E X-HE-Tag: 1742560209-91362 X-HE-Meta: U2FsdGVkX1/tbC5tfwSCLoGfCX+VTpKIyuqKjvj/naWE6JqMz43wrkO+FZ9xQeKko8A0J+6vmigrEnSu3/FpEChf/4/+HVKa9aTERPMswSFyziwZrmbi7y5WHab5LO6JMhKQUi2lLrcO50AqEkwkQ+B89AEXmT/TkyxFXafoQQUcf5b/8UIEVSENop50LlfySoIcOr7uQWkLRH+YvVruDenw+S//NhMj7h2PA65WVBeq8mQYFC9x5fB3aHEdRVvqpptJdf1zwJVayo+EQHEDfjsopVvNaAQX+eq02EWXbdB4zMBapx1LhCtuYvUvJNI3gXWsadHpi4ljLonRSY6aT5L4BO7WcwXfAG/vRKqt2XSM5V0Tc1q7db1XPDV22HOa0Bu8fl/qTveAm3ZS5chnQbHrcE3oPdMNMzos7SVar8IwQAGeM3jhi3w7g5qyqfj75Owd7bU2m8zc0nkzB7u84hWorsyFBLcpngPxQNam6CyNAzq/9JaXzEEWOQIXfzBliDO4o5OOpJBRPQUOMcbJzgEsk55BrCuSu2rLwQzmfXF5fUgkyQl25Uv7pCU6+Hwl+sGGXqykQywirI6/AjQumqQhV9Etq+UX8fiYk8rqD2MGFxNQ4NlR9zBQhAsN1j6HhAInvgJT3eBHASRGCJEzYJs8+jwhKn6LcWSoYR1876SZ7s67iflKusoq1OI0/Tc2Gvc7c2Rfc5w9HYNQF6MKCpEyiIrHj5YElpFXRR+GY3LsGQR7Ur6kiJ92qE9zrla4r5n+g1L5jM3Yn8iOAALgPq+g+RhspE5MwxCQ3skaiR2SzdYcWvEToFu7QgTsxpcfUPM1/njgKusjQGwI3EKKs4Wti5cV6NVvshQL7a8QqML/q4XAF8hu2t+/qfGHJasy4U+AbkGmy6raTojRjK6EOApz1HnebLvdyNQCBEpIaUdI4unugn+jkxadHOTZIzSAS863HY4b9KS6AbXAuZT pJi43u2X DsRUntuONVmv47mQ+kskrF/9IoLQ+luR40LKhSM+wINxRLA63zEl48PEMtddyaNB3UbrFhmPK4Vq3/CxkDO+KAizv18UmbMsgVlCDAuOWQ5cpeWoAdR0Mw5HCj/PgWAkHYWZaHZ9exchjHheJvecjb5jk6VHuqCccMX8UE1SmmKdgbjGtQIy5FOf+GyYvtOeBxaYDQ9uXG/KYCfhwtnGKS7UNj/Hp1IHwlLUoUoy1/oUviT+ZC3rpNs6xyoUvUglebu+1sxFRKkgwQt8wKwqwv8g4vijIYIuUDn82UZarrgPy4RpyXgDxbf+b8dY56t3YxEulrmCRAqXpUPRfX+cyosbxgFj4+a2JIhQktclJC3F1huQA1loGMlXtFx+3eNQxwHbZvM5Qolkux2yd+qOJWNe4vPsBF9WkzQScR8RIQTpPsSMZoGtbLZtoOqujNcHtbHc0gAOCl1MLT0ThUfq2qda0hQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Mar 19, 2025 at 11:44:28AM -0400, Johannes Weiner wrote: > Can you clarify if you're proposing this as an addition or instead of > the memory.stat items? 1) more precise info for given reclaim daemon 2) slight saving in the long list of memory stats (sorry, I must question new entries :-) to balance flushing[*]) I was originally motivated by 2) to propose the alternative but it is not strong alone if 1) is unnecessary at the moment (and it seems the blurring via aggregation is acceptable for the users), so let's consider that idea a (potential) addition. Michal [*] You'd be right to argue that per-writer collection may not be more efficient in implementation. > The proactive reclaimer data points provide a nice bit of nuance to > this. They can easily be aggregated over many machines etc. That could be collected from memory.reclaim too. > A usecase for per-fd stats would be interesting to hear about, but I > don't think they would be a suitable replacement for memory.stat data. There could be reclaim daemons running at different levels of hierarchy, the higher one would see effects of its operations only. Or differently parametrized reclaimers (swappiness), each interested in their own impact.