From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8AFF2C3DA59 for ; Fri, 19 Jul 2024 22:48:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8803E6B0083; Fri, 19 Jul 2024 18:48:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8303C6B0085; Fri, 19 Jul 2024 18:48:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6F7906B0088; Fri, 19 Jul 2024 18:48:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 5081E6B0083 for ; Fri, 19 Jul 2024 18:48:03 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id DA8DD80A10 for ; Fri, 19 Jul 2024 22:48:02 +0000 (UTC) X-FDA: 82357991604.11.3A0ECD7 Received: from out-171.mta0.migadu.com (out-171.mta0.migadu.com [91.218.175.171]) by imf03.hostedemail.com (Postfix) with ESMTP id ABC6120018 for ; Fri, 19 Jul 2024 22:48:00 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=hF5PjfvS; spf=pass (imf03.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.171 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721429259; a=rsa-sha256; cv=none; b=d31xha39rTozrayMQW149OkvZIR/uFh7kO+0tLCIII28Fo1tx61TfcleIlksu8tregXXl4 /2RrTq2JY3ANs6+tGzVM90R3FrTeEbmV2kWR8YnsomyNfcIDLbOter6fPiCXR2hztQQ5C2 Xns3t01ESX07OcsILgC2sPVAhx3SHFA= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=hF5PjfvS; spf=pass (imf03.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.171 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721429259; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NitcJj0Pw/pNrSCo9KnhvfnaK2ycH5BWZYgqbEjFt1w=; b=280Cb9JziNxUOTkJajJjXFxT912rdgqlBMBb9H8/5JWUM29Efsjwbkzg+2j/ZmRO9eXIFQ 8IVkbSHePUs9ypH99sXtEb8QL0aKS95lfjd1Eqde3PqldW4NHtbVGDx628giVuoNHuM1Cc wjkyKtU7SmBVhpYOG787i/YDi+bzh2A= X-Envelope-To: hawk@kernel.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1721429278; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NitcJj0Pw/pNrSCo9KnhvfnaK2ycH5BWZYgqbEjFt1w=; b=hF5PjfvSwGfXSRC4xhB598MsbaYWkYhNznmKfJ16HTDAcK41Vuol0KZ9ogP4CtpUtVaXTz DSNzieLFFldV9VvdOtWcrrqYVFAgJL5jDDtBK8mJvm8xrAJ2p/hGb8q02LYmg1iY3qZABU +nlQR7SrrEXz5kkHCSyDtdrNbJMw1oQ= X-Envelope-To: yosryahmed@google.com X-Envelope-To: tj@kernel.org X-Envelope-To: cgroups@vger.kernel.org X-Envelope-To: hannes@cmpxchg.org X-Envelope-To: lizefan.x@bytedance.com X-Envelope-To: longman@redhat.com X-Envelope-To: kernel-team@cloudflare.com X-Envelope-To: linux-mm@kvack.org X-Envelope-To: linux-kernel@vger.kernel.org Date: Fri, 19 Jul 2024 15:47:52 -0700 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Jesper Dangaard Brouer Cc: Yosry Ahmed , tj@kernel.org, cgroups@vger.kernel.org, hannes@cmpxchg.org, lizefan.x@bytedance.com, longman@redhat.com, kernel-team@cloudflare.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V7 1/2] cgroup/rstat: Avoid thundering herd problem by kswapd across NUMA nodes Message-ID: References: <172070450139.2992819.13210624094367257881.stgit@firesoul> <100caebf-c11c-45c9-b864-d8562e2a5ac5@kernel.org> <5ccc693a-2142-489d-b3f1-426758883c1e@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5ccc693a-2142-489d-b3f1-426758883c1e@kernel.org> X-Migadu-Flow: FLOW_OUT X-Stat-Signature: mk81q1e6zwwzi1cmqkkbe73swy365odf X-Rspamd-Queue-Id: ABC6120018 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1721429280-680342 X-HE-Meta: U2FsdGVkX189hjRC+e7el4rpFz1t3mDy/7yC23ll8Y8nZEz9BdwTtZ9b8g3s8odKAR1kpseDc78hUbdMQMZ7wALRd3FWzvkn1qhQx5r3DtZ3BrB3eyzE8n3QFRET7OSmGnC5Y5fODHFhORVVJpAbGw/TpWskzuY8FRAK0Jnq3tnErVa3IMEJFRp+kmJ/wK9mr2IyViTZIzz65hqh5RdznDL5RQKfnXxzZZVWGxC6NfGXd2Tf0SpdwvdD5RUNTjdjeYzDNUWJq2T/keNOHnNOwmF+bDHGgXYsj/nd7NMjPYIPvAndkcVttJSURlGLALmuZY9MlhE7FoBc8UTsxhflXfrAalkRaVcLLg+oODuICP6UB1c9Wvl44/BXqrchZIm8H4ysuMasyJ+JCHjTvzI8kqlVriLFFG/yExQnKJg3KLN+k7twib67X4YOLFvkdQdKo+yNPMuHoiZ7slrADd4tVB874kbXQ/6yzh5rgtrKnYl43drAGKP1Ota5knC62spvc1vUSGNuby3yDWEZXZK9PwAXSR/yhF6RhDblXYeVOSJhzzRqkrEjlM7jxM41ERg+7PeaymmHAx5YO2o59zRCSDzLt+lekD5h5f+snxngPSvC+wS3F+qPf8c5c5q3LM4gxxeVjoCGAY0Sqkp0bO40pTwUEcZgzLxpj6LMz+jeB91ggAqJaWSXSyfv6NDi++14jxKETr3QTSc3eyrs+Jjnnx0eJ8vxZhvVHGndfxyLc+haICvPIBHcQcQaArUQ3SwbpKuYzxzKns1MbnTUtoru9Yzn+S5E49rbVVmU4tEwn/uBopZhrfdNUIYS30XBTyvbogROqCf5mWOvJcbWOKNdzyWxdknBBzKcyjmnjZqcY4FtZHnPYoy3eMovL4wgA35UoETobFs0eIjosh65yUeVx8rbMkcOYRcRcV29rhaNo6lDYvZItF07eD0sNdZJTN7qET9QhkZy6AyVFePYGVe z1UemfgU wPXa8msRMIkkjuAkWAy4zboi5l9DRSEk6sA67+HBofw2Mh6WBru5KEPwxNBW0nEabwMHpCCrAfKNSCXA3iJDMIWbtFIHfKVtZ7roe2BcNaJ2FF7G0hbz8EchMsGwksgoa1R46AzrDZKuVyLSyDyr7ygnfLVRrrIVBMdcxQvTwIrplcxq43dRewGOmaA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.002059, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jul 19, 2024 at 09:54:41AM GMT, Jesper Dangaard Brouer wrote: > > > On 19/07/2024 02.40, Shakeel Butt wrote: > > Hi Jesper, > > > > On Wed, Jul 17, 2024 at 06:36:28PM GMT, Jesper Dangaard Brouer wrote: > > > > > [...] > > > > > > > > > Looking at the production numbers for the time the lock is held for level 0: > > > > > > @locked_time_level[0]: > > > [4M, 8M) 623 |@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@ | > > > [8M, 16M) 860 |@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@| > > > [16M, 32M) 295 |@@@@@@@@@@@@@@@@@ | > > > [32M, 64M) 275 |@@@@@@@@@@@@@@@@ | > > > > > > > Is it possible to get the above histogram for other levels as well? > > Data from other levels available in [1]: > [1] > https://lore.kernel.org/all/8c123882-a5c5-409a-938b-cb5aec9b9ab5@kernel.org/ > > IMHO the data shows we will get most out of skipping level-0 root-cgroup > flushes. > Thanks a lot of the data. Are all or most of these locked_time_level[0] from kswapds? This just motivates me to strongly push the ratelimited flush patch of mine (which would be orthogonal to your patch series). Shakeel