From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail137.messagelabs.com (mail137.messagelabs.com [216.82.249.19]) by kanga.kvack.org (Postfix) with ESMTP id 07F4F8D0069 for ; Thu, 20 Jan 2011 19:27:57 -0500 (EST) Message-id: In-Reply-To: <20110121083930.d803126f.kamezawa.hiroyu@jp.fujitsu.com> References: <20110118113528.fd24928f.kamezawa.hiroyu@jp.fujitsu.com> <20110118114348.9e1dba9b.kamezawa.hiroyu@jp.fujitsu.com> <20110120134108.GO2232@cmpxchg.org> <20110121083930.d803126f.kamezawa.hiroyu@jp.fujitsu.com> Date: Fri, 21 Jan 2011 09:21:18 +0900 From: nishimura@mxp.nes.nec.co.jp Subject: Re: [PATCH 4/4] memcg: fix rmdir, force_empty with THP MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: KAMEZAWA Hiroyuki , Johannes Weiner Cc: "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "akpm@linux-foundation.org" , "nishimura@mxp.nes.nec.co.jp" , "balbir@linux.vnet.ibm.com" List-ID: >> > @@ -2278,17 +2287,23 @@ static int mem_cgroup_move_parent(struct >> > goto out; >> > if (isolate_lru_page(page)) >> > goto put; >> > + /* The page is isolated from LRU and we have no race with splitting */ >> > + charge = PAGE_SIZE << compound_order(page); >> >> Why is LRU isolation preventing the splitting? >> Oops! It seems that this comment made me confuse 'split' and 'collapse'. Yes, it's 'collapse', not 'split', that is prevented by isolation. > I use compound_lock now. I'll post clean up. > I'll wait for your patch. Thanks, Daisuke Nishimura. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/ Don't email: email@kvack.org