linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: "Pankaj Raghav (Samsung)" <kernel@pankajraghav.com>
To: Jan Kara <jack@suse.cz>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	 linux-fsdevel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] readahead: Add trace points
Date: Tue, 9 Sep 2025 14:41:33 +0200	[thread overview]
Message-ID: <iruyokxvyziqzq3qrcorpx6mq2pshs6beyvgsokqlcz7loane2@y4bdrxzzitwa> (raw)
In-Reply-To: <20250908145533.31528-2-jack@suse.cz>

On Mon, Sep 08, 2025 at 04:55:34PM +0200, Jan Kara wrote:
>  
>  /*
> @@ -314,6 +317,7 @@ static void do_page_cache_ra(struct readahead_control *ractl,
>  	loff_t isize = i_size_read(inode);
>  	pgoff_t end_index;	/* The last page we want to read */
>  
> +	trace_do_page_cache_ra(inode, index, nr_to_read, lookahead_size);

Any reason why put a probe here instead of page_cache_ra_unbounded as
that is where the actual readahead happens?

-- 
Pankaj Raghav


  reply	other threads:[~2025-09-09 12:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-08 14:55 Jan Kara
2025-09-09 12:41 ` Pankaj Raghav (Samsung) [this message]
2025-09-09 14:47   ` Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=iruyokxvyziqzq3qrcorpx6mq2pshs6beyvgsokqlcz7loane2@y4bdrxzzitwa \
    --to=kernel@pankajraghav.com \
    --cc=akpm@linux-foundation.org \
    --cc=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox