From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2418EC3ABB6 for ; Mon, 5 May 2025 21:30:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8AEF26B0099; Mon, 5 May 2025 17:30:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 85E216B009A; Mon, 5 May 2025 17:30:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 74CC56B009B; Mon, 5 May 2025 17:30:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 568056B0099 for ; Mon, 5 May 2025 17:30:32 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id D460F120ABA for ; Mon, 5 May 2025 21:30:33 +0000 (UTC) X-FDA: 83410148346.03.593F4C8 Received: from out-173.mta0.migadu.com (out-173.mta0.migadu.com [91.218.175.173]) by imf10.hostedemail.com (Postfix) with ESMTP id 10CF9C0009 for ; Mon, 5 May 2025 21:30:31 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="dbUOX+p/"; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf10.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.173 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746480632; a=rsa-sha256; cv=none; b=5cftlvlZ4DHNkgGekcrM2/vake0cn4wGw4HjarsI5JHBjIMHuxdgYslWFxwgxbW/lxQmhF HZNQi4bXyJPaFFDLOGQV32CijdXODpZYBk4SFkf0VDI6h46BtncRQSt/4UoSuCSvxUVP9S h8+P7qNhTC0WJsvgBBjMfk1NgW+mSA4= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="dbUOX+p/"; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf10.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.173 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746480632; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4siW68oDPSIdvipM3gqfjnaQhK22j3W7xRxbXDcucJ0=; b=ja0s+biaHk2BNjVXTppnPKJoulC5msn3QsykOHKrjgj8Gy5R9Mmf42nvxgd19CXHpQd8Yl mikzuYdCGct2bGiKLEpqygN1js3xP2o8oFav9lliLuH1YiCLr9zUuoAq4vQvpTvtCCHIf6 EEB4SB5yWTw8zW3NbutU/ZWPSJ3Nh70= Date: Mon, 5 May 2025 14:30:25 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1746480629; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4siW68oDPSIdvipM3gqfjnaQhK22j3W7xRxbXDcucJ0=; b=dbUOX+p/WAESDrw8cbIJP2Y64eqW+Hr9gR8/bt/Boxi8WEj/t+D+2V70gZV+YD5owGLCSh zj3jVcQGXp+ShoQPg5ujhWsAGJrKWxnoS+P6Qcn0iPjvxt7jQgoDEHUynudXexBbNXh5vF ytdXmBB/GN+oSTiX9gl/cnTMEPlHZh4= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: xu.xin16@zte.com.cn Cc: akpm@linux-foundation.org, david@redhat.com, linux-kernel@vger.kernel.org, wang.yaxin@zte.com.cn, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, yang.yang29@zte.com.cn Subject: Re: [PATCH v2 0/9] support ksm_stat showing at cgroup level Message-ID: References: <20250501120854885LyBCW0syCGojqnJ8crLVl@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250501120854885LyBCW0syCGojqnJ8crLVl@zte.com.cn> X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Queue-Id: 10CF9C0009 X-Rspamd-Server: rspam04 X-Stat-Signature: fbjtqk7sesyj8bfz53wwa1357gqm8xas X-HE-Tag: 1746480631-61455 X-HE-Meta: U2FsdGVkX1+zh/SEMQgWhpVsElaXX4pIXvWtg07Uzb5FsrCuoAG0b9mzIDFjrc1ACar+MVohHxoRz1cH02pcBFhf9ZjGz93oV+G55FQWannjItHtTRYZ2SaRfV+BsCowsdXGC6kAFmV5kQiYX7APbOcpxSqivjd+5DZXKf5kJyV/VIeXKRsCjsDJ/WZ9kvigWVzVWbW0OaeGmEEQmsqx4wFtxmBNzu41KZcuUlB4z5w0xCLX2bkqadAujIF7vRF/D8IfLUvjaiYNEtrjsNb/eLp/zevQe14jvFH4NiCwbKUqT0B4zewhGqZWS/sB7wcSuWCmsShlBTOvPMGLB0r/5nO1hyjaLGpHVRYhZ8yrYA3XPAUXVHmuLiVKzn4kmKqAwOQJ0NUPLmlJIH8Ss7NrT0PtRpM5ffsrp7Q3nHkTXgX8dBMGOd6glDQcchzKOWJx3UWBz6bCadxR6s9PnuXD/t35O8YdYab84i0GxYg+qiI112BdVa13mDsHbUQjmmZbMcZIYqdPVKprRCzZPJulsdGvgQbDeseZbCV5p3JZ0J/+c7lmjOGZM8SvgkElcJOW5TzFAj5V1j6X7dKn7HiO17vmOCmgGH6vBOgnY7lc4AbXsdLdu8dm2vaFO645cr1zP96UZLZcaFKBUu1OlrqI1y10ArQBaRjjFxyJTgnRLcx8aviP3C/majVknXCW3sXexFptBSaJKV5AMqVpxrqxGBwKiV5rYI7UH/JRMmB5R0qKODaIJQ65j+leGJdNEFtkD8nM7grLtPMZqh/zEDm/C9fmC+8hEObdo3c49U9MLXtEbr3Zfp1p4YeWmVy/I43wixy7xQWVVW8TLKwtaWrHAHr1vyZoTyBTXqpdXM6PNkM7qp5U8euWaTNDv54WObY98nTFad3b+NktpD3mDGNIzxjW86MjjfoWGTht8gr95PTnEG7OsrRju02K4leKhWSRXor0wOWw/I2OGCBosnV XGxAPdwL Eiqg9GFjxeK3w6PP0o76TjvLnz4MlJj+pT3n0AHmElxum0fl8HsOjXo09tHbZHr6TrOdSWCDJDMkekleM1H9Dg1IOhw58bArvvI5HReylJsfaRmQV0bp8WEzjMRyJKlHuhVtrFNHANqYCty8XcmTTsYzRSE2W1zqu6ic5RFM1nD9tJ+jEHH+9kod8zVjMOWzQ/8jaGEU7UGPeexik00Eqz0tqR2ZPi8y3ARXJR/lXRPkfiN+nqDmaXRjpIrfOvWFrbjNv23EUMU6xItgHwcY+mmoMN9gNKYTALus4 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, May 01, 2025 at 12:08:54PM +0800, xu.xin16@zte.com.cn wrote: > From: xu xin > > With the enablement of container-level KSM (e.g., via prctl [1]), there is > a growing demand for container-level observability of KSM behavior. However, > current cgroup implementations lack support for exposing KSM-related > metrics. > > This patch introduces a new interface named ksm_stat > at the cgroup hierarchy level, enabling users to monitor KSM merging > statistics specifically for containers where this feature has been > activated, eliminating the need to manually inspect KSM information for > each individual process within the cgroup. > > Users can obtain the KSM information of a cgroup just by: > > # cat /sys/fs/cgroup/memory.ksm_stat > ksm_rmap_items 76800 > ksm_zero_pages 0 > ksm_merging_pages 76800 > ksm_process_profit 309657600 > > Current implementation supports both cgroup v2 and cgroup v1. > Before adding these stats to memcg, add global stats for them in enum node_stat_item and then you can expose them in memcg through memory.stat instead of a new interface.