From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5976EC25B74 for ; Thu, 30 May 2024 17:58:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8F0006B0099; Thu, 30 May 2024 13:58:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 879D26B009B; Thu, 30 May 2024 13:58:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 719406B009C; Thu, 30 May 2024 13:58:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 51EE76B0099 for ; Thu, 30 May 2024 13:58:24 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id E1BC51608F1 for ; Thu, 30 May 2024 17:58:23 +0000 (UTC) X-FDA: 82175821686.25.4652775 Received: from out-183.mta1.migadu.com (out-183.mta1.migadu.com [95.215.58.183]) by imf11.hostedemail.com (Postfix) with ESMTP id D1C144000E for ; Thu, 30 May 2024 17:58:19 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=GYEiP+1F; spf=pass (imf11.hostedemail.com: domain of kent.overstreet@linux.dev designates 95.215.58.183 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717091901; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=A1Y/pr/6li6bjB2ihduinpoMIcWHGvm1kvQW3uuD19o=; b=TQp/PTZqzeYtIiYTgFGdWuYguA2YO1akd4dfrW758Q8J1AycqQB/lXd3V7SASxXRazGdE/ jOXKOAwf4LFykE8KLoxU8tRrgCT2nCOMO7H1J2WOHHd9ykG06mox1y/tueQkR5qwPBzWl7 8Jno5FDcMWnfYHkwAG2SE/BRlws5+7A= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717091901; a=rsa-sha256; cv=none; b=YoVH9p1nMNreW3yGCDqsYC31zom5/Y2Hlpbl4niWPRB4YGsQZk9B8OgqTAMcWaGMhA5l8+ F4XsSlOI+zouI/AUr2Jux3/DCmO8zOSYa3T4+eO9Z+b2qYAb/A4C5bh6O/OCOZtCgXayjc VfusfJ8ScIBBhcAWE6UCurqWe8IwESM= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=GYEiP+1F; spf=pass (imf11.hostedemail.com: domain of kent.overstreet@linux.dev designates 95.215.58.183 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev; dmarc=pass (policy=none) header.from=linux.dev X-Envelope-To: axboe@kernel.dk DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1717091896; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=A1Y/pr/6li6bjB2ihduinpoMIcWHGvm1kvQW3uuD19o=; b=GYEiP+1FctP5FtgCF6cHt+gAs/crZAlukd1ip8oze1YLxzQnHFZ7dn3/zPeHNtAlEirw8S DWBve9RLxK6BoxrEtDPAKVoe6L6Ji2Qg/LvF7Cq/cv2KYP3q+uauHrzv18s9hH7KbD15ZY iY7CjPfjRzp4LxcenUtiHNAVdFbg4yI= X-Envelope-To: bernd.schubert@fastmail.fm X-Envelope-To: bschubert@ddn.com X-Envelope-To: miklos@szeredi.hu X-Envelope-To: amir73il@gmail.com X-Envelope-To: linux-fsdevel@vger.kernel.org X-Envelope-To: akpm@linux-foundation.org X-Envelope-To: linux-mm@kvack.org X-Envelope-To: mingo@redhat.com X-Envelope-To: peterz@infradead.org X-Envelope-To: avagin@google.com X-Envelope-To: io-uring@vger.kernel.org X-Envelope-To: ming.lei@redhat.com X-Envelope-To: asml.silence@gmail.com X-Envelope-To: josef@toxicpanda.com Date: Thu, 30 May 2024 13:58:12 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Jens Axboe Cc: Bernd Schubert , Bernd Schubert , Miklos Szeredi , Amir Goldstein , linux-fsdevel@vger.kernel.org, Andrew Morton , linux-mm@kvack.org, Ingo Molnar , Peter Zijlstra , Andrei Vagin , io-uring@vger.kernel.org, Ming Lei , Pavel Begunkov , Josef Bacik Subject: Re: [PATCH RFC v2 00/19] fuse: fuse-over-io-uring Message-ID: References: <20240529-fuse-uring-for-6-9-rfc2-out-v1-0-d149476b1d65@ddn.com> <5mimjjxul2sc2g7x6pttnit46pbw3astwj2giqfr4xayp63el2@fb5bgtiavwgv> <8c3548a9-3b15-49c4-9e38-68d81433144a@fastmail.fm> <9db5fc0c-cce5-4d01-af60-f28f55c3aa99@kernel.dk> <360b1a11-252d-48d9-a680-eda879b676a5@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <360b1a11-252d-48d9-a680-eda879b676a5@kernel.dk> X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Stat-Signature: mp6ea6spneg9wr6j65ggquke3qyry4xd X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: D1C144000E X-HE-Tag: 1717091899-840893 X-HE-Meta: U2FsdGVkX1+Radqo/NTfvoKrNTuzKJ3cFs0WLzLmx04HoP8DsKa3pwMaDXFniibmw8gcPloVbXWA3S3Jt9lfX1K1ntPOz8FJqUdDaS8s0tMj3kdwly7Na6wu9Ey+V3XVhSnnYleqelwaPWEJJMlrp/+O0E7krh2mjrtA4FNBrusl0+dxRx0bO4/NpNDM/XY8lrbvtjS7eCLD32FEXQqSSgGj7vWR0C2MxM3gjE0aPjCd00Ep0iqDsVvsPXLp87b7HuWTMHKb+9Q9H5NdjDGjtbBZfQv12+JP0IjVMrqxc7Ceo5DcpaivYBAAoWOLq0kx/+sXFRPZEEbQ/5nopxsPvAOTJzHpWf1LfxaHzXMhQHLEcTWGiw5rC6E/8OGctcz7imOcJ2N73idYY34/9rZ86C6q0AQqwOCsai5uEjhIwfuMz2Dcrvcc39rh8bI3f3NY6c9bb6fKVUS/5C7p/EKtrIBOYOgl1vZIvJc4S2Z8xDedYoFJsMogKl8O74zRQkoG8oTPCQEIl3TfQXMCE5tNKnFkAclUnaRLU9odcMXxax+O5VfvffrkLC+hAJz6WNeP4OUE9V9yUwj6Pag3iyFkWEK4JnUrTzIFO5TcL6DBskqPJAcUAczk4+fQNCLtIdEtU/6iTu9264RukykRGEmN3dwWfMAaA386y9OeQ5rATAIA/CDILu++PnZLlTrYOlAEzi+/unf5srtVcXu0B87UIymXefn9z9Ta6yJE2Si4ZtGo/vvVo5Sp1ZMdyQzS8Sh9y7qzKaNep5kvICho/Rg638BFwfHrxBpJ52DprKCh4MBdqNHpTYuq3oqujhbvJcssfs1XHDKvMjR7/iJVJPBcgcPk09VMpy6/HOnkPWMC+qwDSPpmZrJ4j4mnfBi2m+5g4kwGzU/mrZHbO2BO/TEnskrZxLZbHytdKLFJpTx59XtV6YdzqrTgfu0awmvHpN+SwilFyfNW0QueJQS/8a2 n06jnrZH oyWXRwjgnip2eu4uSfFTPUuVeZ2oYGVdfJ9UXg81N76Sj4Bkjjvz11VZ7QxPT3tt/tn6uDUCYGeR3jN5eVV2qFFXcEd/HMPWCcbAqLM0l3ueahcy/tbNkF905eSfMXhpsCi3Mf+quMAPbm/wABoe9li/D3ZpV5vJhuYwR X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, May 30, 2024 at 11:28:43AM -0600, Jens Axboe wrote: > I have addressed it several times in the past. tldr is that yeah the > initial history of io_uring wasn't great, due to some unfortunate > initial design choices (mostly around async worker setup and > identities). Not to pick on you too much but the initial history looked pretty messy to me - a lot of layering violations - it made aio.c look clean. I know you were in "get shit done" mode, but at some point we have to take a step back and ask "what are the different core concepts being expressed here, and can we start picking them apart?". A generic ringbuffer would be a good place to start. I'd also really like to see some more standardized mechanisms for "I'm a kernel thread doing work on behalf of some other user thread" - this comes up elsewhere, I'm talking with David Howells right now about fsconfig which is another place it is or will be coming up. > Those have since been rectified, and the code base is > stable and solid these days. good tests, code coverage analysis to verify, good syzbot coverage?