From: "Liam R. Howlett" <Liam.Howlett@oracle.com>
To: Wei Yang <richard.weiyang@gmail.com>
Cc: akpm@linux-foundation.org, maple-tree@lists.infradead.org,
linux-mm@kvack.org
Subject: Re: [PATCH v2 1/2] maple_tree: remove maple_big_node.parent
Date: Tue, 10 Sep 2024 20:35:38 -0400 [thread overview]
Message-ID: <ikxrholzdips4f7fdwlscgit7saffz6shmr2cp42pp4f2k5i5g@sarng52ov26e> (raw)
In-Reply-To: <20240908140554.20378-2-richard.weiyang@gmail.com>
* Wei Yang <richard.weiyang@gmail.com> [240908 10:06]:
> The member parent of maple_big_node is never used.
>
> Let's remove it which could reduce the number of space to be cleared on
> memset.
>
> Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
> CC: Liam R. Howlett <Liam.Howlett@Oracle.com>
Reviewed-by: Liam R. Howlett <Liam.Howlett@Oracle.com>
> ---
> lib/maple_tree.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/lib/maple_tree.c b/lib/maple_tree.c
> index 4e08dd5e391b..c3370c7449c2 100644
> --- a/lib/maple_tree.c
> +++ b/lib/maple_tree.c
> @@ -120,7 +120,6 @@ static const unsigned char mt_min_slots[] = {
> #define MAPLE_BIG_NODE_GAPS (MAPLE_ARANGE64_SLOTS * 2 + 1)
>
> struct maple_big_node {
> - struct maple_pnode *parent;
> unsigned long pivot[MAPLE_BIG_NODE_SLOTS - 1];
> union {
> struct maple_enode *slot[MAPLE_BIG_NODE_SLOTS];
> --
> 2.34.1
>
next prev parent reply other threads:[~2024-09-11 0:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-08 14:05 [PATCH v2 0/2] Reduce the space to be cleared for maple_big_node Wei Yang
2024-09-08 14:05 ` [PATCH v2 1/2] maple_tree: remove maple_big_node.parent Wei Yang
2024-09-11 0:35 ` Liam R. Howlett [this message]
2024-09-08 14:05 ` [PATCH v2 2/2] maple_tree: memset maple_big_node as a whole Wei Yang
2024-09-11 0:36 ` Liam R. Howlett
2024-09-25 2:45 ` [PATCH v2 0/2] Reduce the space to be cleared for maple_big_node Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ikxrholzdips4f7fdwlscgit7saffz6shmr2cp42pp4f2k5i5g@sarng52ov26e \
--to=liam.howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=maple-tree@lists.infradead.org \
--cc=richard.weiyang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox