From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57454D3DEA6 for ; Fri, 18 Oct 2024 17:58:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8DF5B6B00A4; Fri, 18 Oct 2024 13:58:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8900E6B00A6; Fri, 18 Oct 2024 13:58:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6E1C46B00A8; Fri, 18 Oct 2024 13:58:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 507926B00A4 for ; Fri, 18 Oct 2024 13:58:12 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id AAEECACF2F for ; Fri, 18 Oct 2024 17:57:47 +0000 (UTC) X-FDA: 82687481772.16.A563D38 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf26.hostedemail.com (Postfix) with ESMTP id 242B4140013 for ; Fri, 18 Oct 2024 17:57:59 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=n03X8LT4; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=RYu8ATSG; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf26.hostedemail.com: domain of liam.howlett@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=liam.howlett@oracle.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1729274180; a=rsa-sha256; cv=pass; b=iwLqn13DfeFr8HpXBkatoDEx/gdD7VyXFl584b7JCSwYQqvPLDlzLlIne+jSbBNX522PC5 v5c3y2qckOyDZERozc0luAImCfbITEP7xeItFXmAAB2NbodVIXQ0mLrUhDmFYf35mWT8GA UgER2QPvvjzTa8tEG2OAfYHRY1+7Fa4= ARC-Authentication-Results: i=2; imf26.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=n03X8LT4; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=RYu8ATSG; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf26.hostedemail.com: domain of liam.howlett@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=liam.howlett@oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729274180; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=koxVeaGumYxx2xr+dejo9q0QDBrjgnEQOZhIeF9+hGI=; b=djj0bYk5+6/0cq/V7eYkHdV6HOJv02OKL7L3vRKIRbutWjxXy0t6LBt/HU7BgJELj2DG+q AEvOb3OdfSLDSDg/pvIDNsvqh1KMxNl/rNqCnqDftLXIlUM1whQ+TPHVr33lQph1pBYNZR mSSZP60GfHzcR7xgCQG7wawXz+mdnIU= Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 49IEBd0u017093; Fri, 18 Oct 2024 17:58:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=corp-2023-11-20; bh=koxVeaGumYxx2xr+de jo9q0QDBrjgnEQOZhIeF9+hGI=; b=n03X8LT42HQ5+QRfJeokwlgIoIo/SwOg55 MoB9q0QhxjIlAU7ppuJLQNkkvShySfvUx5xjFNd0Km5/+B/cCQFRJSa9zHwiwXyO m2IKx7+Nb3DBbc2J3k9Cq2NRLf2N/rw9IorKOJW/Srm7absFIPkt5LhOuUcVF94o ZHpLTeZyS1mAxM7RA9q6AS7ygZFiTA3JmUga9QRjDM1xbdH8LTW2L2oCd1VGlsd/ OvVefoNZkNIbZmmCHv6DxRgABH0qB0jupOc5bcIKOOLdcjwIi9w+4CLmKyFAApa3 n3/7VEV9KyHR6I0svA/ceic3fnsfJ17sRskEUOVFUkrh6uRt6M7g== Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 427hnthd5h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 18 Oct 2024 17:58:06 +0000 (GMT) Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 49IGYtVa038497; Fri, 18 Oct 2024 17:58:04 GMT Received: from nam02-sn1-obe.outbound.protection.outlook.com (mail-sn1nam02lp2047.outbound.protection.outlook.com [104.47.57.47]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 427fjjf86u-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 18 Oct 2024 17:58:04 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=SKjMX6Qv01wk1tZqCKFiBmpjwxnjuOfVZckjMP7ogmaZgLQPrpUw6ArbNU+BYHS1f5t8K3FDrDUA3zMnaDwkqevEfQKLaAYEhBkvF22ydxqjMfQDJ8nolAa5hLGDNhj7xa6CQNcneHWLesIdpE152ag5ip27LNJ+r6bB52NqbSTzE/2y0ArYdo1/rhsHQ0Qc4VAwttPSgFpffu/iKhSSNechw6BzN9Hn57GsiO28AsLBxVUyRKqA1Fhz212xqEqTTnoAaViu6paN9rTUqeHCWCPzoOrcWqpDMgX44xRE2o4kNuloEbmdUBpKz1YY/+fYKmRiGFyGODSyfxXdC7y4Qw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=koxVeaGumYxx2xr+dejo9q0QDBrjgnEQOZhIeF9+hGI=; b=VsfoUM7QfNrfm93MR3uRo/stZukkD2YQHML6NugTw7s0PwgNrNqY/sXGVrWZkfvn93A7uFINN4Q1rJfQR20TjjbPPWbzv2Dt5gic+XGyCLaOlq+FJmJ5WANIhnY/DvfkDeoduyTBZ90afphlfDRKvjGvqu+ZwF/0MhuNWVjFYg4r2ivpLThy/u+9Jpix5CqUB0xeneDrz9gFiBZBawRW3ZoAXQi97eyzsKk4xWm367LLR96gF3VQWAmiQViMFGbgVTcKJlNmt1BNhhfD49k56R8HGGPpcvIY5f6A0T0l0O0EwgrtV/sfKjnHyrBwkvkbJxsqA7QMon9Ao185X+WisQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=koxVeaGumYxx2xr+dejo9q0QDBrjgnEQOZhIeF9+hGI=; b=RYu8ATSGlDvcew8eBkw/4Kco+NlJn0hnpccwmYpkiDMKy6ZfO0Cbl3I0pKGTbVk3qnNZ7HGL/Iq1nC/Wkxu49gHy8aUq6f0vN9ZZAi7AOOm+muP3PyJrAIY/Wb9mW3LL11VgFakfnBcSORppeykThNc2xZ+cEi01vfs8vwnTmzo= Received: from DS0PR10MB7933.namprd10.prod.outlook.com (2603:10b6:8:1b8::15) by DS0PR10MB7296.namprd10.prod.outlook.com (2603:10b6:8:f8::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8069.18; Fri, 18 Oct 2024 17:57:57 +0000 Received: from DS0PR10MB7933.namprd10.prod.outlook.com ([fe80::2561:85b0:ae8f:9490]) by DS0PR10MB7933.namprd10.prod.outlook.com ([fe80::2561:85b0:ae8f:9490%7]) with mapi id 15.20.8069.016; Fri, 18 Oct 2024 17:57:57 +0000 Date: Fri, 18 Oct 2024 13:57:55 -0400 From: "Liam R. Howlett" To: Wei Yang Cc: akpm@linux-foundation.org, maple-tree@lists.infradead.org, linux-mm@kvack.org, Sidhartha Kumar , Lorenzo Stoakes Subject: Re: [PATCH v3 4/5] maple_tree: refine mas_store_root() on storing NULL Message-ID: Mail-Followup-To: "Liam R. Howlett" , Wei Yang , akpm@linux-foundation.org, maple-tree@lists.infradead.org, linux-mm@kvack.org, Sidhartha Kumar , Lorenzo Stoakes References: <20241018023943.13860-1-richard.weiyang@gmail.com> <20241018023943.13860-5-richard.weiyang@gmail.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241018023943.13860-5-richard.weiyang@gmail.com> User-Agent: NeoMutt/20240425 X-ClientProxiedBy: YT4PR01CA0480.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:d6::20) To DS0PR10MB7933.namprd10.prod.outlook.com (2603:10b6:8:1b8::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR10MB7933:EE_|DS0PR10MB7296:EE_ X-MS-Office365-Filtering-Correlation-Id: 689df45b-ac7d-4953-f7d8-08dcef9e65c5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?GMeMOXImHbU6PL83qgKpGqsEBHp2zx51LeEkuOZO7d8Jdovb01gTXVEi+lqL?= =?us-ascii?Q?zmYe2yn3WjWqVG/g6HNxJ22/kO4gviMIb/5Ix6G0fMUyNNXG2yrDddNjm1BA?= =?us-ascii?Q?4b0xo0poxsz/8kGNtooYe/poFC34kL86aoJ3YAG7JsrJI1oo7l+DW9FT1/dA?= =?us-ascii?Q?C39dCTpNbuW2Gh4JhEGGn6SNUc25minHT88UGPuWgf91Y1PLzlM/qd3oZAXk?= =?us-ascii?Q?pHvgg5w+jYoE8KCjxU5o4dd1kf6oZPHilTYsvMeIYZA3VSKz/qrP/pGnC/DJ?= =?us-ascii?Q?l52dY2R+KuxsRTdFCMQ/328MjXGPSSrcr21VC1HOLITctSKW0XzulW7TQc8p?= =?us-ascii?Q?SQjRPys83HUVW9Le4OfZMkvj7hvBiVgvLTBFGDMDvqeT3Fu/WNYTgentz2DB?= =?us-ascii?Q?EafQFE+pslo90sRgG4Dignql3n4Dtbh4PBvXkIrNuUcCH5wbfIn/MnTZEJxK?= =?us-ascii?Q?PEsFxGT+fGVBKJG6/DV6iI7mZ2QR8kCJ3WqQWg4ENCEXAUTxLDTWi+1wVpjk?= =?us-ascii?Q?NyY9aLrU2cZy9XO5erzV4xs9uCc+uC9PLF4R/XIc3CfDwCbmsuWO4ZpqM9Dw?= =?us-ascii?Q?xZqgudEvCfHBTdtEvED1fFj3md6pVI53F22AQQAhBH/f4FfAGhNxtaNWa/sa?= =?us-ascii?Q?a4BkgGg17LcZaJTOT6Cu/v2yG2eQyPYu+hiiPDO9e9tMNJDbqNuCVqgKVnY7?= =?us-ascii?Q?mmJ4VYW2UxdTj3y7HIMm8XR/7LOW3z8w+ulirGSdTbmQZRO496jL6p2dBTiN?= =?us-ascii?Q?WlgRKGRq+GLaPd2HUTK3vEA6//TwJVpT+Yx9HLuBohHbhbD45z5rkiAq6rep?= =?us-ascii?Q?We/v1k3at4xXmITzV7I6YndDZ/JCjrDnJwMfJPvnfaaQn10ccLX6PwD0E0oV?= =?us-ascii?Q?VNo32Qz++IKJ7pbN1HnH2UUPvhKQQ+pOljhC1LURLgrCHfGym9HtB9tOIGd/?= =?us-ascii?Q?rIRxdmtsjhoMDXTfuzRLBxmW8EnSHeACsMERgXQ7wX3gJRncMN6gGSDEAbYx?= =?us-ascii?Q?5bd0MkjqufPHSRH19ACjN4H6ZRAwpbFuFIVlupoxVNvcGdRVreuKt8AJor74?= =?us-ascii?Q?qFURjTNkBZZAZ7asw82ji7zAQYyt0RL3+yg8XgCAD8AendOLtK34PP05cWcg?= =?us-ascii?Q?eHBtcnc1CFNLzzK9zbOTVaxd5KEgo5E4ZalToNFZegOKEtG0Lqyc6UwZyHXr?= =?us-ascii?Q?6vc9JQVs1hi0zzF7BaWV11HqCl1snm34MonaUdpYhqbNUur+J1sVE3v5RVUv?= =?us-ascii?Q?wItYhmuORf6vyNTi3/qTbEL8+HRJDQYqDoJC6ZgejjiDuhWJdL28IvZAJGsc?= =?us-ascii?Q?zGE=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR10MB7933.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(366016)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Hu9zDg/SfI4T5A31gC7XMd7MkrtGX5xX03sILjDwdplcKbZub8/UzRL6VP/w?= =?us-ascii?Q?pxfJKInCt2ewoZaZoizrMNoS8Dm5/WLeKEG5/8ESIKl7ADp0asBe6g/uYZ54?= =?us-ascii?Q?/yDDH8mLfRGFK9QFvuT2pg9F/hnNwZxwENBqxgdCJu2BB1YHDvTLA7KGSlSW?= =?us-ascii?Q?uSopzb670kDnbnH993LVg9dIxZ/6Bf6NDcZN6Q8QTER7zOv6DC4Yz80f0ik5?= =?us-ascii?Q?WyftmISm7N9w46X1FxXYYc1R2Jl/oERA9TE/qVvdc3omo8AFoONFEKHC7Rz8?= =?us-ascii?Q?k5DrnviTB6lpruUWI0nNTulb/Fr1LgNEJM4RrOWXA9mmUN/vr8Zs7N+250e+?= =?us-ascii?Q?a4ZWyT4esEi9qC3qYMaEEA2/hmkRXm1UD2LBnYPXd8HmB1epbB/VmlLUAT1C?= =?us-ascii?Q?IcunzO/q5Sa2JWd5sSgUqcakcH6b/NR6EB3ZafLS3wDLWiY5xWp45Ce0AHB2?= =?us-ascii?Q?qOqt5Z82Q4kkMTz4HqnE51Out53jeoH0oQDsH2XFEHzWQYMcUL5zURv4xGT2?= =?us-ascii?Q?LcHmtXrt4PiDhCyNt4ktbhcjAST4yP9agDi3gSqtLb09CBVGMX20KB/UDXvT?= =?us-ascii?Q?8/z2GI1XDL6eRBOT8/r+m1xsiNQnMfGSriPdsaaKAKA4Z/KgUCcrrGi9td9T?= =?us-ascii?Q?YIqfqgD0n+CQvP0FJfwKhQKNz3MoA6pvuByUMWJUb76Bh0gLSkIenEk5eKJQ?= =?us-ascii?Q?waDyFIt6kSjKrhxPLbA0MWuLLwr+cWTMp94SZb4Yz3kQDnpb2ZBA9YJo4JLr?= =?us-ascii?Q?0/qkDAQ6aCgGzfH4TAjtb23t4/g9CouKkhDReHetEYMaBgVm0pgWWH8dyWex?= =?us-ascii?Q?NkcF5IfU1hzl6TVwZqXEoqisv0zzWBCdCA7Cza2VRyBTwDRRT0R8c0+0xKA7?= =?us-ascii?Q?QmIBBi742jK4Zq6D8k7+1AGaOD5tPzBSluaPHZoPCkLPHBFCqyBgIexXwtHL?= =?us-ascii?Q?Q+sRptlDOxdqJ58StedhM2QpeYRJ/u3U/0sk+RAeiNIRBuec6XA8snT7/Gjt?= =?us-ascii?Q?FgaG/vm8rPxPS7hT4fP7Dx7qgBu89y7AEp/ObBiNs52ieUKvXdjmWxDtn59h?= =?us-ascii?Q?K8Yh6zehW8YGsbAV0oUPo4zFYyhPeI9lhaOp0jWTx1fqEtmmDu5k9VF/K/fD?= =?us-ascii?Q?IJyxzgl+d/V9TQIeor2vzJ69H1/I8EFOPO6WO1fXlX4oz0olawhhvDWadTKE?= =?us-ascii?Q?Ixomk3kROCv7R+t37K0DhNmAZFR7/kUadMlkuoiSqXIfQTDaoYZ6AGXNw14e?= =?us-ascii?Q?xV8+2aUUiyEIdve1YZ03UN7eExqdluS7A16uIPcU6LsiBW3onALbs7wucGjc?= =?us-ascii?Q?oxctmr+segyrwKFIZKI9kb1kPLuxhqaDOMiB6svHa+rCaWvu1TWP7TKVAHrW?= =?us-ascii?Q?X/GEkX+PKGuqwG5VOuQ5rQXCOKfrneeWDPUmNA5whx71ZRo0jx9Ww9G5tW/r?= =?us-ascii?Q?XQPmbHMXYFO8u/BMUtLrs5vZlBeYhcr9johgoJ6kG1bCsajare10A31AZ/7f?= =?us-ascii?Q?a2B+jgz6da0fGrgkLKagoXq2p1+SEReXyV45qZNBPJrCBUAKxuvKkSDPBTYt?= =?us-ascii?Q?O/I1Lf9itYDIK9+5is9g3H5/3NlR0E6bZ5pR200c?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: YwwU05uB9sHgFDHwP7a5Ha9sY0JZrXT4Aq4edZT4ZluHpKZLE+aQ2C4CeIQ9t+D1poJRitdRGYeMapKUqA36//D6ZBmzBmNpz7oN2eFpzPKLIiRxGwuT0G3Gv+d3YMhWCrckpXgukFpR6qsdwDdRh8ly+HpOgi8+D7k+rDiGhSUaaPxE9Tuli3K4B7+uJfHpwyET0H+mk0bAIkXsBlI8ucjhRCqwUlMVNZbHewjzIaNDrIhquOcrdJYW2JmWwYODUV8VpgH8TFelwBvnOcW4YVOdvQiLZfml+DLbSAAbnKzVzU+O12elHsfrLLii6tP3p0/df67T6r+X279wP54wotrjkLdTOGA331dDssfFlTk2TwVUdFGIklaNyhsVCphMW+BE79pZ/HLW2xVhZiFjO6OpfvWu+QkLNsbLC0Zr3Zhu6Zbu08zUgpgcie/JI0cxnYcTobopWP9CERx7w3OFXiPS2c+65TgWcFoJJbTDgxvbbue6IHsPE4tDqr9Y8nsfLHXggIoVhYa5zhbtIKOu9HDRvzpJNwJjUFpHnBGauHYKuX2qEXdz5eZ0WAWHwjlQBEXDCDzqcdP+pBNWZi+HBOud4aeSbRd+junU6dCcgfU= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 689df45b-ac7d-4953-f7d8-08dcef9e65c5 X-MS-Exchange-CrossTenant-AuthSource: DS0PR10MB7933.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2024 17:57:57.3177 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WJt7jzAUst83nzd/3FQ6PN6l5zCxoAIPTpFYDKG0viqksMCeE0UItCBU38RkE8LGbI3F21GVj2DQy8uFYmqocw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR10MB7296 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-18_13,2024-10-17_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxscore=0 bulkscore=0 spamscore=0 phishscore=0 malwarescore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2409260000 definitions=main-2410180114 X-Proofpoint-ORIG-GUID: 7J3cd6KJ-vdq2QkokceElvulDuuMIChe X-Proofpoint-GUID: 7J3cd6KJ-vdq2QkokceElvulDuuMIChe X-Rspamd-Queue-Id: 242B4140013 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: p7x5sd1x4jfbgow3rhj7sae9fts9c16z X-HE-Tag: 1729274279-506247 X-HE-Meta: U2FsdGVkX19rXm55t4dRppywAb5pUbtPE8CJLsmvCkm/60GH4K3N+JtGHxElwGoeQds57DgwmHgvfzkMRGBUkhN1nHBVAislbenJzC7JlySPuNvJABJn4Bi4Oded5oAF/qqE+kdTg0U4Fs3hAB2ohlS9kvQXDdlxheSTBTgsUo4zvNPHbTYZCSSxwDf1aHKXJwEPZ2WgIos1lEu/WVaFmB0T8yw40qeoL3QWCEdnLWHCzopWrJ9s5oZSuCAF6tsQ7U4/xr08hgwFJlR+fnrCZZCFyZZkC0hXBta9puVzcWaEVzeIIbOhDkbCUkPHNA2RiljpxW7vy7JrpIvUIr/OdkSnhugBApYBrhHxTMh7SVUkWs9ZvldgYkGslk48nZ1smWaVEx612ogqmoKubaAIMO5ZQaVc9WtCY9od2GxPgIw1q9hSmFcPeuZzCnRcvYdiAD/xI6x4lfuizGq1ndOT7hvZbfRoSwhyfkrgjCyTEkKv3nGyttgyVH0dA2djuNWoVktTWq/pUlxCZkk1xHdFaToevbXQto54ZcSELbCYb4uhd0FVDM+q1lhMT3GoaKkfKz4honQBj7k+UpSF+YuWSiyVXauJZH3oaDo7CLTbroK4X60XjG8Mjjp/hZE7wtFX+PYHCwG4HGlVoWOXe/b3yrFWZPMNXIVpaX8t9yZ8TmVhx7Rl5NqOKOKIB4ycP14hOSVwCIXPJaucdgCCPSqe6t38N6XcM15xxrLKbR0BS6ogr45ttlcGdwwchsnc8JXmBqkP+QIYBL6t5Li7FHVX1KV/fhK8KZ/KsnAnE+AYFikw3fICcBGaeLCbhEimp6phIZG6q+DA63krNsxG0Vw1OmI0ACYVqwlmxwtmnY4fjts/qEq9InCXSH5UnCif86SJ9Gy/pqU4K4VqgP8hUqZt90IjNmPSC0uVyxXvZ9Ke5V8TSOTWgk0HmyGVpv57aUOsoL4pN9D6BAV/sHfW0mT 4K8bOZnH ZsfcjkBIWnF68W0Wko86kCqHjhhg42E8XFkIM1yh1oJjtEgBoOXfEpucnNlGN2IVp4X5seP8Z+z3talb91iQ1l6k4RCyNBHFS70g1z2cTR0G+DlmOSsCxGDLpywC2c2swQNtxQhs0akdi1WoPbFE/+5253+ZcE7rNM6hpPLxh+vQFLygdYczG0hlNhbPJPCX/P8O9BCGbgzmxRDHdf1CJ0Os3GXYaJP7BJIULjH5o8SOOwvnWE7I+VYH/t44rXZMpMJX44JF1cLBZyu/5Mf8uyQSVLmBJ2Qmbvzv8rak6N15qiyew48mYC+hHo/y30iBkaG8/l64Tqjmr3LLYP3geLiPnGrioUvm5OjLWRhPVR3N3YxYoEaKaAUCRfyEqY6PasGCd96C3M0BKrfXNMDhm/GHa/91X1EfU73eI6uQqGTp3ra24oLpMJ2WQLxDRL3mR0xBnwi1GlBLCcIs/StNDHTnz1DgRUZd0GBv31iyHWBrmvhQ/hZFuLosYoxZssG3opKOgJ1YX3GTWJobc0f1X4OVtJ5tXkPzxLgWCOw5vxhbHH8kMN5iafli63JKZdJyA6ympfSRbGqf4tpmBfU9sJBNPPSMiMnWTPKJfgc1G8DsiL2CJVIkhCsdqnAanyF9rV4lGeVV1RuLQAmbusYZ6cmmaWv1AZEG37LJ53IFsKYsCCWA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: * Wei Yang [241017 22:40]: > Currently, when storing NULL on mas_store_root(), the behavior could be > improved. > > For example possible cases are: > > * store NULL at any range result a new node > * store NULL at range [m, n] where m > 0 to a single entry tree result > a new node with range [m, n] set to NULL > * store NULL at range [m, n] where m > 0 to an empty tree result > consecutive NULL slot > > This patch tries to improve in: > > * memory efficient by setting to empty tree instead of using a node > * remove the possibility of consecutive NULL slot which will prohibit > extended null in later operation I don't understand this. Do we actually store consecutive NULLs now? This is a very odd change log for fixing an optimisation. Maybe start by explaining how we end up with a node with a single value now, then state how this code changes that? > > Signed-off-by: Wei Yang > CC: Liam R. Howlett > CC: Sidhartha Kumar > CC: Lorenzo Stoakes > > --- > v3: move change into mas_store_root() > --- > lib/maple_tree.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/lib/maple_tree.c b/lib/maple_tree.c > index db8b89487c98..03fbee9880eb 100644 > --- a/lib/maple_tree.c > +++ b/lib/maple_tree.c > @@ -3439,7 +3439,11 @@ static inline void mas_root_expand(struct ma_state *mas, void *entry) > > static inline void mas_store_root(struct ma_state *mas, void *entry) > { > - if (likely((mas->last != 0) || (mas->index != 0))) > + if (!entry) { > + void *contents = mas_root_locked(mas); > + > + if (!mas->index && contents) > + rcu_assign_pointer(mas->tree->ma_root, NULL); You are changing what used to handle any range that wasn't 0 to handle storing NULL. This seems really broken. > + } else if (likely((mas->last != 0) || (mas->index != 0))) Isn't this exactly what you have above in the if statement? > mas_root_expand(mas, entry); > else if (((unsigned long) (entry) & 3) == 2) > mas_root_expand(mas, entry); > -- > 2.34.1 >