From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE2A1C3ABBE for ; Thu, 8 May 2025 06:07:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D42BE6B000A; Thu, 8 May 2025 02:07:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D17206B0082; Thu, 8 May 2025 02:07:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BDE7F6B0085; Thu, 8 May 2025 02:07:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 9DC326B000A for ; Thu, 8 May 2025 02:07:42 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 8AB8D80A3C for ; Thu, 8 May 2025 06:07:43 +0000 (UTC) X-FDA: 83418709206.27.4F1351C Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) by imf28.hostedemail.com (Postfix) with ESMTP id C8814C0003 for ; Thu, 8 May 2025 06:07:41 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=bogOMwez; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf28.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.210.171 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746684461; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gD6p3LDYmN4HnSqNAjc/2GGWmyPj6vrCx2RAEa4xFwU=; b=OoA0ssDEH3sd+ReBD2H9ejE/S5gwF4y5vlrNrs6fU2eB0dgbgYPaWiik50aHFj0Ivo5w1Q YODgw33P5EEJiszRE7e+6lFUZGjbRZ3EExRBbCWCOqS0zRw8gcbI6pDumCd96A/O9UMTXh 1PgLJsyC3IneK+0G3YgYcI1zcvOWbNQ= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=bogOMwez; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf28.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.210.171 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746684461; a=rsa-sha256; cv=none; b=2I/dqf9ernjq3n4V6Wj6w3NZrxNCEaKVNNm/pmB6tjbDuR2cKelWopjXO9hSb8YJJZg1x0 45zZIOs6m1gFxoJI4uNrxZnJlp0EiF4nrTPLwIPD44EmJdE4T2cnSgnHJTymYExY1uP6cB FeHjFaiv3at7hzWTnZ610is40DXLeKs= Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-736c3e7b390so648807b3a.2 for ; Wed, 07 May 2025 23:07:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1746684460; x=1747289260; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=gD6p3LDYmN4HnSqNAjc/2GGWmyPj6vrCx2RAEa4xFwU=; b=bogOMwezM5JhStnVpV2tMg6skWG7FNqQGr0HLTBqx8KHWf/qLpP8OeQgKjHJOAeW+r ++0zsQLXvNdqD3jskKDSU/qx1BT0UYM5FBk2W7S3Xlyb5E16MesQ45kBCTZpuf24uGB4 QfOVBG419A85DuvCWZECHWgfVftWodmNX4k18= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746684460; x=1747289260; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=gD6p3LDYmN4HnSqNAjc/2GGWmyPj6vrCx2RAEa4xFwU=; b=sfXwSqiGp9kWqHLua6DRxA1zbQYtLQWMe/dcAsjAvJKN5RcDuWOSXKLU+z4Y7HhyDW P+x+rTszqDrDQAGSZhbcIfgBlfThaow/ACHeenYeQ0I89nfGomKvGUtJ4ukoFSCf8Si8 AEtzl5nnCuClj7cGI+lpWbpWWSJ4OkztQNZ0zuBech/VSgXcFAwo8pQQVYWYSRPHPBSv DvWNDNX1tcC88DyiBdJzrmybNNpX8Oj6acr/WhhHzULG5AqkFc8v1LOlEgXZeNWzfaJF 10PiBLGkRNGRPr9l+eS09D/er990u6pfNu6Znz6/CJM66F6mpZbf92asCr1rJ3lK3e9u 6/Jw== X-Forwarded-Encrypted: i=1; AJvYcCXfQ9NuNpNWztF3+AFWllAkrHETVgLiShWYvGjWwVj7p/EenPKasWuPzqtrJnFAL489C43jMq09gg==@kvack.org X-Gm-Message-State: AOJu0Yzjfl7dadB6ZULm/GczdlTR22qymMgHrfQmJ/b8Szmbtsxi82uo BckXhvuamaCFAeFoKhUnXbJ05pxU34SYWzUgrotQ5yTV7Vv4/+wZTEQI1EK6ZQ== X-Gm-Gg: ASbGncuhU8XtOp2fYURo9GUMt230uExsFgQ+QlZhJAiYadxnp5g5u2v/HE871qWnDfr q6Ghb9A80gUeRyXBXwMuG2BPZC0TqAhMLUCFDnMfQKRNL0IbrGAHTl0fKZJLQp6SlqMpxD3qEmk 2pDl8oZe0uk1UrwV+cE7HHftUz+AKSGZysFQRgKvHP+kpOhe+xL96Ms3rvgoroPfd07H7lOL/bm TM68pNO3k0veYxMc4D3GxTagVHoix7Kb6ev6yOwJBQXpM3eouDcx9B0dmaAJLwRd+fsTe0k/yQJ Ymd3XtX/tGY78YG692GdKpWcqWDMqjsxHTiPyBTU8DKF0+Vni1MzHmQ= X-Google-Smtp-Source: AGHT+IGQV8UCjLjaLkpFFN9jqJEmjl4XPsqvizG2tfcBx2LWo18DpGyLnM0uzIGQx5hGiMTU/EEK6w== X-Received: by 2002:a05:6a20:ce46:b0:1f5:884a:7549 with SMTP id adf61e73a8af0-2159b08aca6mr2899868637.41.1746684460685; Wed, 07 May 2025 23:07:40 -0700 (PDT) Received: from google.com ([2401:fa00:8f:203:c794:38be:3be8:4c26]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-b20010bdec2sm297173a12.52.2025.05.07.23.07.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 May 2025 23:07:40 -0700 (PDT) Date: Thu, 8 May 2025 15:07:32 +0900 From: Sergey Senozhatsky To: Uladzislau Rezki , Yosry Ahmed Cc: Sergey Senozhatsky , Vitaly Wool , linux-mm@kvack.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, Nhat Pham , Shakeel Butt , Johannes Weiner , Minchan Kim , Igor Belousov , Herbert Xu Subject: Re: [PATCH] mm/zblock: use vmalloc for page allocations Message-ID: References: <20250502080156.1672957-1-vitaly.wool@konsulko.se> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: 91babucmkfu8mgi7p4zd6jhzfqkx8cjm X-Rspamd-Queue-Id: C8814C0003 X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1746684461-700944 X-HE-Meta: U2FsdGVkX1/wA5QZA1MgjWyfcRWTEv9tniVeefz85O9N2bKcRZfMjQo6Ukm4dgVXBktxDUjoKsTBaCgRQv83OvY3nD2iapBPUNCWaRPYQYxdi975LfxiqYYP/oZk5t7N/5z+NXopcWcWdnEW7jLwfRST50bHgiqe761fHenPgzJXGNiuwGEV3bHFfAI3/FlxVlvyqhy7UWy8s5oT8RJkC2oEFMQR6W3lZ9UPJcs1AXaIKqqxI7hK9b8/02xWWupq+Weyikehb9iv1kGcXzrweJjzkAIVcSFku2ZgqF2hUKihe4LAdnDAcjYCvofJWibREhNCpupYRzJyvc0TwSNEtSw3nADfEDFA5Jn8VSq2zqhvr43f5eohJwOVsevzViGHLchu9kRByntl5QguuzKVW1mA7EK6BtTfM5JW7cscIFqcLng2OKfcnv5Dw9h04Z2TDtpxwfg9diTr1oCJUDyj/SQ+RVWwuPKklSjXcNgnrG5XdD6A63lA7edlhbAEWeD4YxuhNEn78k/ZBycfLaulNgaLxdnzjoWQCSMFmLZGPgx4LbXJF7tch1PlpHFvmpjGEXZZh7OcKdNIQOvAB9baYEMxBCxyHx1BnHWcRbB2cheeNrblvatD0UwTycE4bTJamA0TxiasBRoVGjJ0KCycFK/9sep8bO4RxTeStDVxsg0lV7Q3gN8E6q/qU2bD4vN9ORgZ6PnzdhvfZ06TwczfHf+2eYActIrouYHtVu3s3Xbk1KJuUEs4N3af2bdyDijJHgdP893nf826zZ+oRaanmDhAqG29Z+yJH6WqCx72sbHpS+29K7AmVHzjw+Tw2fQ3S30jZOabWAcsVb7FxH0hHRNOIlJDmkBdzPLkPhq68NsnyLWrGI1PI02se7uuEmE9aXG+/ZKR5vccuwn5yjdx530aKjO7sp9pcqw5DLBGG2ILWZ/RnRNliqkeB2VQZ+WjD4uSlIcd04SgldT5faE S+5g/WYe MrNi7dXpWqSoyaTqK2pZzx54Lzg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On (25/05/07 10:50), Uladzislau Rezki wrote: > On Wed, May 07, 2025 at 03:08:08PM +0900, Sergey Senozhatsky wrote: > > On (25/05/07 14:57), Sergey Senozhatsky wrote: > > > On (25/05/06 13:13), Yosry Ahmed wrote: > > > > If we can use vmalloc for zblock, then we can probably also use vmalloc > > > > in zsmalloc and get rid of the chaining logic completely. This would > > > > make zsmalloc simpler and closer to zblock in that regard. > > > > > > > > Sergey, WDYT? > > > > > > This sounds interesting. We might get rid of lots of memcpy() > > > in object read/write paths, and so on. I don't know if 0-order > > > chaining was the only option for zsmalloc, or just happened to > > > be the first one. > > > > I assume we might have problems with zspage release path. vfree() > > should break .swap_slot_free_notify, as far as I can see. > > .swap_slot_free_notify is called under swap-cluster spin-lock, > > so if we free the last object in the zspage we cannot immediately > > free that zspage, because vfree() might_sleep(). > > > you can use vfree_atomic(), it can be collected in any atomic but > no in NMI. Indeed, thanks. A bigger problem than zspage release path is loosing GFP_MOVABLE, I suspect.