From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CB2DC021B5 for ; Sat, 22 Feb 2025 00:29:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A20B2280001; Fri, 21 Feb 2025 19:29:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9D04C6B0088; Fri, 21 Feb 2025 19:29:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8BE2F280001; Fri, 21 Feb 2025 19:29:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 6C9156B0085 for ; Fri, 21 Feb 2025 19:29:10 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id EDE6F1C8837 for ; Sat, 22 Feb 2025 00:29:09 +0000 (UTC) X-FDA: 83145696018.17.3E4E6A0 Received: from out-173.mta1.migadu.com (out-173.mta1.migadu.com [95.215.58.173]) by imf04.hostedemail.com (Postfix) with ESMTP id 25C2340002 for ; Sat, 22 Feb 2025 00:29:07 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=l2CxxsBf; spf=pass (imf04.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.173 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740184148; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/Y6iYz6qo6As2WbWhauY4s4USd3SkFNZj9yuf7cHP7k=; b=dYl1YcDQTBFcoVdXhLKH2dlyN6kH+MKwbsCtUQBapAKqSVgfnZNRV0WNnk5BTWGqRqg0UW 1He8Ei6Q7sIFnYpRHVnD3/PEf6le73wA4UcJi/jNVaXYj1GrgONtEmLEojmvBnnsSJzspV mliWO7YieAH7Z5Yh43hDJo6ytzyLFy8= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=l2CxxsBf; spf=pass (imf04.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.173 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740184148; a=rsa-sha256; cv=none; b=o/sAfDsFfNBRQEu4k9OhlhesKsLHocFtgOSIad9I8UPp2xo1DkkN/IJo6nfxKiBJAO3eBV 053idXn6i7pMMrvuS40U6KUlHI0gR1DEJ5xXkmMEtGPXxRwEz6I1zY718bdI+3IK/OrH7X 7Au6FI/4Q2utJbjH5OZblyur3PcopxY= Date: Fri, 21 Feb 2025 16:28:49 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1740184146; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/Y6iYz6qo6As2WbWhauY4s4USd3SkFNZj9yuf7cHP7k=; b=l2CxxsBfAll7US7dJzFobtnrbeFTCupZJvPpCBXGaebPlllXwvuaapqVQbrHhzVms0gKuE S9WwMUAJzy2Vse0L9PO0i2t3rw9NfpUzD3yAAEetJ8NjH0dLkxiIKncczwrefD86s6Ar8v 7vDe3r6fSl7XaISLGekges4mzF42lhs= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: JP Kobryn Cc: tj@kernel.org, mhocko@kernel.org, hannes@cmpxchg.org, yosryahmed@google.com, akpm@linux-foundation.org, linux-mm@kvack.org, cgroups@vger.kernel.org, kernel-team@meta.com Subject: Re: [PATCH 11/11] cgroup: separate rstat list pointers from base stats Message-ID: References: <20250218031448.46951-1-inwardvessel@gmail.com> <20250218031448.46951-12-inwardvessel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250218031448.46951-12-inwardvessel@gmail.com> X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: 25C2340002 X-Stat-Signature: 6n4ysizz7tzsxzuss4i1yucnotegbiot X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1740184147-145297 X-HE-Meta: U2FsdGVkX1/ERKIYrewU7qgi64/o61ootg0UfAlbPQkSrozPFqDMCm8iXiWXxA/PxSxCDYPRIsMaMVxQx5G8cH8gKew4t3MkgyNzAMz8JenVlPKvtKvzMTozIDWffhJm2kDUjZerZgoy109pVjuOWc/rydgC+V0PnIloW+Gq2e4CG188qgj2U0qeeZ2cuYVM5N+REznIgy6pBm8mopnxt5qyEYA1mO1HkbSjTCaf8FGaHAUa47T7IHUt0swOtJJoFsFqAPNdTooOKgNg6E+KsduI/Ed3j4qHlhChgplG8da8CFojVjPD4opltT4NEUncZUPgAhGK9n0/Y80LBL330UJK22g7lmsqKdV6t/zqMJP3Hr9KvBodEFcZ7jkmjWXkhqhsoFWr/cTkE9VJlvd3uix6l6DuKYnlRlFexVUo/3w62yhd9eZJftKEA6bqS8zojcx37GwyLAVFz059P4fTiwxXNvzMtiww+G7GUoL4CSrH0L8aCbQjZaMRJGErBn3VXWsBCsXbXcUpZPDd58FaG0gzheVcq7osnD/QqkvycySRSxxATZI8pAyU1TBhFJ9Bqt/UfH3S1Dt6URhQVXHiGZn3qvmUQOApt5QTix+8OCLMu94DAxr19g/9WrddwBeecJVm1YpWz3TuIdXJp5TWC+xq2AtlZT28JqP0PXKh62wg+qghyoammLjbLQzgkzDhFdw1ViFJ582xeDkb3tMdiJ/GHBoboO88OwvR8pglXtBKK5eCqZY9yUPHPLmy41psX34ms10yKCvcXD8bdCBcqLRzPFpyEGCqX/gQb/nBBwuzc0H9yY+M93KzlJ36Lo1he0htjfBQaA2YW1o07dTi3f/UuQ8qAn4v4gb+5POOPST6H81LJ0e6AaSCsEemXfzMJm6W/gYSma5e2OesbjgbNKNaun4aijbh2NK+AnIQ48kwP2Z4mAzJyUpLrMOL/gitQtAWdYKzsr/amtXNMNH iK15N9OE m3vpf9elNHpgn7pFG27kcK1jQvsw1v02C+yWiIAusu2ddZJ7xYqdKrfo4DVR1Ke9TkDUIlvESCTTnTZ5BXrI/nAr/MRbljLocTsQ7rnEJrMCg2VTbdIaf7wDGATvSrOKRfem+ficM/Xp4ZdDdd7uPLxqagUstvA1GQ3S7OsxDy2M/pXblXsRorcRobqmqKCl7aziHCf7j4AX654mhm8wB85RwOA39R4M0M3Gz X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 17, 2025 at 07:14:48PM -0800, JP Kobryn wrote: > A majority of the cgroup_rstat_cpu struct size is made up of the base stat > entities. Since only the "self" subsystem state makes use of these, move > them into a struct of their own. This allows for a new compact > cgroup_rstat_cpu struct that the formal subsystems can make use of. > Where applicable, decide on whether to allocate the compact or the full > struct including the base stats. > > Signed-off-by: JP Kobryn This looks good. Now there are two major asks and then minor comments on some individual patches. Two main asks are: 1. Experiment requested by Tejun. 2. BPF rstat using the base subsystem as requested by Yosry. I would say send the v2 addressing these requests.