From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32F0AC0219D for ; Thu, 13 Feb 2025 08:49:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8F671280004; Thu, 13 Feb 2025 03:49:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8A642280001; Thu, 13 Feb 2025 03:49:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 746B1280004; Thu, 13 Feb 2025 03:49:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 51D68280001 for ; Thu, 13 Feb 2025 03:49:09 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id A99FBC08F1 for ; Thu, 13 Feb 2025 08:49:08 +0000 (UTC) X-FDA: 83114296776.21.8992C7C Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) by imf03.hostedemail.com (Postfix) with ESMTP id BC3BD20002 for ; Thu, 13 Feb 2025 08:49:06 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=BP0J4GOE; spf=pass (imf03.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.169 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739436546; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=b0+V8t8JAMKSPJxJM8ynvsFzXOsDDoMW6px3qewAf3Q=; b=a3u9rIaQ+UP7yauARY1gKttfxk4JF6nC9HL5wuRMon18SWuu4ofFiNhODir7jwH2cIsZOH P1Ae+XBz2sGTcqtfbbp+7kE6Tlrln8CLOELhIHP/3vpT1128e218mEs6P59DWhHeTIHso/ F/RD2DJlczhJHUptphVGQhOt+TZSOK8= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=BP0J4GOE; spf=pass (imf03.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.169 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739436546; a=rsa-sha256; cv=none; b=e+nbjHrNAbe779ywaGZXhbwhQ5cS6LLswP6RDxrPU2ttrLN6k8yY9q/D1//AAr8erLZXNX HjSDQ5UaASByiVOjhuq0jko+Wjgw3a08YIDfL3UFj8drZn4NzlCWAyV34fj54wXxcr0bJP MVUZ1lnAprJp2nC7XkHoC9Tbg3aIoIc= Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-21f49837d36so7106615ad.3 for ; Thu, 13 Feb 2025 00:49:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1739436545; x=1740041345; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=b0+V8t8JAMKSPJxJM8ynvsFzXOsDDoMW6px3qewAf3Q=; b=BP0J4GOEruZjBplAtUutTM33EvaNSTJWHcZueJEEUTj3ArXaqwja7P+9qYEQm9GNYI 6IA7ybEmWwqsWdfB5vni0rUxwgZzJmquyQxmLfUixNGjp2F5tVhLpJ6Tda3fKwWo1siX KU9anukt3zRTBrU/LPPx316AV5mvvSm63gfI8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739436545; x=1740041345; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=b0+V8t8JAMKSPJxJM8ynvsFzXOsDDoMW6px3qewAf3Q=; b=qyq2mczB4kdwepZBYslyKLMzfvCS8t1e/+502NDcYPVXA/2uUxNKJlfjVSIs194tnW 0VHGXGmCH0gcDP3lIiuQzDfXb6HViz0NtZz2zJSSHCDA3FilOF4MO56UahYl1rVh+OUW syI1WtsSjW51MzkiV964bZCvkiMbMnO0G324Pd7Xe9LOaXgiH6CRGWkK/vlAOUNOwI9N v0AhQI1f7DGPaFUF9IaHilnUyIE5WwsfVIxhvaDCau9jAQ+apiVfbB7721aJlWBy7gAE svkTnxjKXTai5Na+pQlqlVL26BZCWmrVNG562w1iUyqTwfx8Rp0PaIHIqtFY4jf2LVFr tYwQ== X-Forwarded-Encrypted: i=1; AJvYcCWh+usuPdnJuBoCVM9KXpcSsGEOmwoTsP/n5A925plkjd+emJmdxEwpfvcZQUSi9yOR22kASCPURA==@kvack.org X-Gm-Message-State: AOJu0YwyrTSTviWQiaMTwi2rZVMLPIIcjp5nIElX1zgvXnku7G/J9pP6 /EUskaK1vv1nrWDmTcdYremuRGdutHb/JmOPKFRXiEfF9JdqcNHUlX0sjyGhZg== X-Gm-Gg: ASbGncs0mdxY6r3Uak7rRt2vw0MIl4E6qdECvGs3+7UfwRMP6f98Fodi0YVIOIlsBVs /qDHRWqtxfLx61ajnNminBBl8PN97djJt+WuX5EafOqkeggRcjJ2wS94yyrxhpvSzZWAnHnPqc6 WZXboMaEP3iJGd6wCD6W3xc8UcXbqtkD4c43npdvhw4byT7NC1aa5qlLa0qjv1U2rBEr0AyPXFx F2XEXJ8HCSulKnrc1jIDGrSxPwRcNMssuFl+kzUNlWa2ZcIIzg0qDgRT6mHClLQmjXVgVXY4ev0 Hhrow7A/NlClVU+hS1k= X-Google-Smtp-Source: AGHT+IHS/5GdKtXgG2/jmhrz0MJD2ke7RDQ6mckkojx+1Hv5HNvAwf4lX7XwhqVSZkbsoNfX55SgYA== X-Received: by 2002:a17:902:f683:b0:21f:5cd8:c67 with SMTP id d9443c01a7336-220d20e8aa3mr36220065ad.31.1739436545640; Thu, 13 Feb 2025 00:49:05 -0800 (PST) Received: from google.com ([2401:fa00:8f:203:3ed3:97ce:5f5f:1f61]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-220d558591asm7818045ad.224.2025.02.13.00.49.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Feb 2025 00:49:05 -0800 (PST) Date: Thu, 13 Feb 2025 17:49:00 +0900 From: Sergey Senozhatsky To: Andrew Morton Cc: Yosry Ahmed , Kairui Song , Minchan Kim , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Sergey Senozhatsky Subject: Re: [PATCH v5 01/18] zram: sleepable entry locking Message-ID: References: <20250212063153.179231-1-senozhatsky@chromium.org> <20250212063153.179231-2-senozhatsky@chromium.org> <20250212160830.730a199935e907c2498b28d4@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: BC3BD20002 X-Stat-Signature: i76tdr1eweseeekcifexg79zqtta3fmd X-HE-Tag: 1739436546-694961 X-HE-Meta: U2FsdGVkX1+UpCBlLchHwsV3wdkZB8Lcp9QyCC9Jx3ZXSk8jAIWn3PQybsCzo3xwBlq+5Q7tJ0vqm0wHzMveaeC8YHcFBOFnQtqeH6zEdmpY2dP1LMm9satucy1ruMM8ZFHLzL8RcQFL7wPlBPYnFtJN4qFQME00/wFnXI43lArs6brcWxwZlcLnWUlIa5SER8841OiLdsRPIpxsABwsFTFEZhljvzRFDKIC2xKn0AFotALb0YMa8eesq5vimAUcHUj1LV4NOnqXZu6DxD55sN4l4EGdyfl7Ra9YKBPN1tyizhFT6DdeytUVN6B6GBmmhsS5FcRYE+zY77sUBxVtA9t72NRBOGF5SthSmhUtCIM6UhLc5kHL8cA2mBGLAgvo9Ng/AL9rQmu4QWs8HLLotKEVMXxOpdDLtpnCm+5YLmNTeMbCbUXShrXcLJSId5Vg7jkUAuICpGPlZJT2Q/+5jZm4+03IPIN5VNM4h26q5W13i/aIMxqUSc5CGO4dI9R4rdMJt5NfNs3pGDDK/1Jhx92Wc5lE93Utba/fU88q9Lrjjkq+1mwnJ+GiqYAEwsEFYXEMLPfBh0HFVJmnk2NusQh1DGFxFDE8dMj9KcmJDWnowE0s51P8gmlA7gU4K87MPPvgraPqp8HlSafx1akd8zMRwxUyXQhzNDSR/F7rjtb0Vifc1IgjBVpgmEFtLAAmVRnDyFRmsA3BYwcHgkc0p5FwhE3CQ7gobyrcWEA/+OSDcijHgRO31cf+g/eGDiqKzzNigR6Uufv8UCtNBNjCM9RQJdixPOX2hnAAWE6d43JHP0YQDYiTbCfSC1mwLmb9ol54mMADSQMnUbfeBGMeUUzQqK6CwsW4hazaWVu4kUdh8UV0DAA+7YaDcsD1jyqauAUHas97pJcinMlYI2DGP51SW3qiOWIdXvqIujmAyXmTtWVbNwev+UXnY529oPNZEo4B0Pevkzb7OQ7Qoo+ 6XP2nf1z OgL8gChE8A4DUMasB3BaAmZ/OET/w7wEuof0iPDMbQtngTfVtbf2XKf+N834GZ9dzhJc9Q/neWpXTE8IX8mde/3HeKHMmoBT4cNQ526RG3g1a1zjBgR82QuTplRpauuvoNyfksRyWD2cix5RL8ylnlVUOxCO6tlZy8y2G+kHIFLECNpNHMMXOdYN4Tm3eQx5v0r+f8XT+rOmQeJaJlXd1RQnBsKkjJsEAMI3qt69npfzd7hs7l5mltdsJIPYGyl8gKBZx7A+nnnzDKWsib4F9cWrwTbyak2hxgKl5rD7thBX1FnoGZp7DaQYRC3lr4eF6SDumgSdZnnRVc1sHmj2RgYU5Jwy3RyQRM39v1ixBX9RZ6NQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.060362, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On (25/02/13 10:42), Sergey Senozhatsky wrote: > On (25/02/13 09:52), Sergey Senozhatsky wrote: > > > > -static int zram_slot_trylock(struct zram *zram, u32 index) > > > > +static void zram_slot_lock_init(struct zram *zram, u32 index) > > > > { > > > > - return spin_trylock(&zram->table[index].lock); > > > > +#ifdef CONFIG_DEBUG_LOCK_ALLOC > > > > + lockdep_init_map(&zram->table[index].lockdep_map, "zram-entry->lock", > > > > + &zram->table_lockdep_key, 0); > > > > +#endif > > > > +} > > > > + > > > > > > > > ... > > > > > > > > +#ifdef CONFIG_DEBUG_LOCK_ALLOC > > > > + lockdep_register_key(&zram->table_lockdep_key); > > > > +#endif > > > > + > > > > > > Please check whether all the ifdefs are needed - some of these things > > > have CONFIG_LOCKDEP=n stubs. > > The problem is that while functions have LOCKDEP=n stubs, struct members > don't - we still declare table_lockdep_key and lockdep_map only when > DEBUG_LOCK_ALLOC is enabled. I rewrote those bits (in zram and in zsmalloc), given that we also need lock-contended/lock-acquired in various branches, which require even more ifdef-s. So I factored out debug-enabled variants.