From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A5D3D2068F for ; Wed, 16 Oct 2024 02:32:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 528BD6B007B; Tue, 15 Oct 2024 22:32:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4D7A16B0082; Tue, 15 Oct 2024 22:32:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2DC626B0083; Tue, 15 Oct 2024 22:32:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 0FE156B007B for ; Tue, 15 Oct 2024 22:32:52 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 300201C7467 for ; Wed, 16 Oct 2024 02:32:41 +0000 (UTC) X-FDA: 82677892206.07.9F67E55 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf11.hostedemail.com (Postfix) with ESMTP id 004B940004 for ; Wed, 16 Oct 2024 02:32:38 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=fBQ1U7Ec; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=x9b0iQhf; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf11.hostedemail.com: domain of liam.howlett@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=liam.howlett@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729045824; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=l6vmlA2x/k8bd2a57KvHpB3KTO+mk99O7SZwgK3/iEQ=; b=A0r8cP6/ewOcrLesqHj7x33t3IYGNKaGt8qiMgaZFEatjBKG05ilCuEOyPaJsoKqhF5V83 Iq8oloG90QaMtZdY8BREdFEfvbErfNLH0s9krX7MYlRb1M+hbDinDc/Py+YkxeKusU51S6 RBCzFtj74E8233mzjuyzYnvo0aATp8M= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1729045824; a=rsa-sha256; cv=pass; b=uj18hsEThQMZbNYTnQNQezB1yvFMu8Ue3T1/n7ao967L7Ip1Duhi61tYejJHxFf9z24bkG /NFupiZuiWcNS0p106TUCjbAu1hXAzGyaDEH6+F+4khIqPfJjEi0hZaXWZdjwiVfLFII/a g4HzU65gThfB71F2a4sVOlDpePavgX8= ARC-Authentication-Results: i=2; imf11.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=fBQ1U7Ec; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=x9b0iQhf; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf11.hostedemail.com: domain of liam.howlett@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=liam.howlett@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 49G2Mlb6008886; Wed, 16 Oct 2024 02:32:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=corp-2023-11-20; bh=l6vmlA2x/k8bd2a57K vHpB3KTO+mk99O7SZwgK3/iEQ=; b=fBQ1U7Ec0dswwFfPnDXjqyadxrI6uoJjhF 0iqX77MtW1QCBlu9i+UyDs23ms0g/FwfiBiZWQ4g0FwCFty/jLESR4iZqFgQH4sO U5/hWDAz4K6YJ2qj+wQdrbrpkjeRgj2ofPx+RoHyjeUjaW0UJiuL1Al4ELayhHpC Iryl+ZPXbeR7DTP7XddRN+TPCGf7BSLrWvSjcJB3aCAZ74zY+35G3a/oLiPpm17Q aLAygMuRt3SjI6mHEagsvdMdtxGldUY6TMx9KviP/OXUa5UI4ZjPKD8umddukZIB mUINz+QiJ2ZNZYmPSeuIkJAgsjglbdqi5xIZT0r6MA3o4rS2qu4Q== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 427fw2jrqj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 16 Oct 2024 02:32:46 +0000 (GMT) Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 49FNvTHw026284; Wed, 16 Oct 2024 02:32:45 GMT Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2044.outbound.protection.outlook.com [104.47.58.44]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 427fj883yb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 16 Oct 2024 02:32:45 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=htgR35BhGAhzFiq2xwJWu5dPx+BPnVJj9/zwRX7vzqRc00tzHXTbDxs25ozs7ZKlBScJD5Bd2fCOnr9w3WbH/Jb7WJii9KDrvMIjyDkX9zYyhkVtnq8aG10D4bRtx/gv6I3TS897S658qoDAs4vDw/ihCs2HmNl29qCVXJnJx6d7+/VFAtBpppe/FMhSvRjIJlQ/kdKKsZ1owF+u3OBeWMolSl/ICzC0PCRrXA4wfIONgfYlNeeMrCrbBHq5mGHIWKHHsr1WrkPQSBMClxLep8fxQTgYY24tjPpFXcTVFD2LQANkFoyofsRKT0iShAsIyqfUFabtK2FStwQ4qPa63g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=l6vmlA2x/k8bd2a57KvHpB3KTO+mk99O7SZwgK3/iEQ=; b=K28mUQpqQh28CY3ISO24Tbr5LkypQyPi0uS4i0dz3oMDbDx7ukj/4MULkx5jIPZgQvA+sDgxrEa+SQlOLLQ+aNNY0JMgKhOFQ0Ly8XrJ1NtBsNBg+AMxDOoFwhAwr45mBH3Z6zTUIPL4ipJn/3gYl9fwiWW9HpxQOHMAWYWMdr1mtDMm5vl8CIpmIEyGm7vy5Fuq6OydmKCFM68ewMYQcafsLHFqIdItzVaXy00Uz+V6Ab0Fgr6yZd/JWRTK8MKIAjlOJFkLNgcXEApcCh+S+tdv3F/ITTtt25r2FskuzJdVwcAaCum1rXHMHVbgsms5SVy2XtWBLmiYwISJTrW7Pg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=l6vmlA2x/k8bd2a57KvHpB3KTO+mk99O7SZwgK3/iEQ=; b=x9b0iQhfpf6MHFTmhRx9tYM6Yih2msINgN/x6TMo7xceMtfvYW1JNDp33WbNVgn/pMs6PvIAJMXKvKlZ+cGizRmIdDHEbnoVyipMwVyu/KOpreZe3zPvtlGIwri5yO6MygQjHt+iCUj+bzv+BEJYt0VK12bXiZvbz1s2YKqS01E= Received: from DS0PR10MB7933.namprd10.prod.outlook.com (2603:10b6:8:1b8::15) by SJ0PR10MB4623.namprd10.prod.outlook.com (2603:10b6:a03:2dc::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8048.27; Wed, 16 Oct 2024 02:32:43 +0000 Received: from DS0PR10MB7933.namprd10.prod.outlook.com ([fe80::2561:85b0:ae8f:9490]) by DS0PR10MB7933.namprd10.prod.outlook.com ([fe80::2561:85b0:ae8f:9490%7]) with mapi id 15.20.8069.016; Wed, 16 Oct 2024 02:32:42 +0000 Date: Tue, 15 Oct 2024 22:32:41 -0400 From: "Liam R. Howlett" To: Wei Yang Cc: akpm@linux-foundation.org, maple-tree@lists.infradead.org, linux-mm@kvack.org Subject: Re: [PATCH 0/2] fix mas_new_root() Message-ID: Mail-Followup-To: "Liam R. Howlett" , Wei Yang , akpm@linux-foundation.org, maple-tree@lists.infradead.org, linux-mm@kvack.org References: <20241015233909.23592-1-richard.weiyang@gmail.com> <20241016021830.6pfc2z3f62qh4xuf@master> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241016021830.6pfc2z3f62qh4xuf@master> User-Agent: NeoMutt/20240425 X-ClientProxiedBy: YT4PR01CA0144.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:d5::10) To DS0PR10MB7933.namprd10.prod.outlook.com (2603:10b6:8:1b8::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR10MB7933:EE_|SJ0PR10MB4623:EE_ X-MS-Office365-Filtering-Correlation-Id: f42895da-8081-4a3c-4ced-08dced8acfc4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|366016; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?d5DA1KRd0TDVq5QSjkBtJvOWDNeQtxqeGLMbV9B3Q47fCndaVGzYCK8RNB52?= =?us-ascii?Q?88avuap5B3jco7TOAVEg8hVn4/o9YdfJ3XBNyzbOAPeTCVIA15XPStM29bBH?= =?us-ascii?Q?zP8P0ufbZra35YRMlDtOEHq4fUU7PyVOwc4QeVYOwgkcfiNC46HtbbB/NZ2c?= =?us-ascii?Q?nnArWlbfgt4+udgdeERvpEmtkdz8kokO26EiltqkOW5YGvSmZLD8tOQEpwzr?= =?us-ascii?Q?UVLi8uDt8GHljaIY0+x/985FTqeN6SVzTOQjYa3tB6s+zYeDs6weCS9zEPqG?= =?us-ascii?Q?jLaeFZA1TiyKd//kpahPm/wcj0a4WzNPypnzpdZhNssJ09MLhuEBLm5gXa87?= =?us-ascii?Q?ZliXaetgy4uXaqETA9wA46T47RZ6OixhaGqrtOQL5SKqaf67PfzCgqLZsRBP?= =?us-ascii?Q?P/+0JBYIzWawTiPCEJBLxySgkjeiX3YIZQpvJZn9nQzllzrAW0uu4suagTn/?= =?us-ascii?Q?yE6GCh/DanbFT9vShg0eGvW4sxiXILe3kqahu8NF/39hAgnW1RqQKOnOj0yh?= =?us-ascii?Q?3cwz4fXhoKUXtA2gKBcyR+lEyZrX4NueTuSOSry4WH9dWqCjVVjGU48zPO+k?= =?us-ascii?Q?/nlY/DW5GNQJ1gh/DkdSp8Yk0n5++gf5TR8bIgbKFKJZMXsHH2rhomp8z3ha?= =?us-ascii?Q?/Ug3RsSN7aZcKLPCH9J7ZahU55Ml4oC8CCSQ7cA10/tIDt56Y6TPA8N/EtA8?= =?us-ascii?Q?ACh1gSmPqhdGP+JseULVqwo8vHQE0ur2XKPPkx3TPqBZvJItw2p0C5UWEHev?= =?us-ascii?Q?Gop3z15afdRUn7WdluSBMx643yneDgJjpvvt8ui0ySebN+fHCTf/i1O07Zpa?= =?us-ascii?Q?+ZJ61eba5zYEq7amc/9k5jk0CtNC/bL+dI8bFfVoLvAyDi6IN8PU7wDUsGrM?= =?us-ascii?Q?P7w7pWBZDo7/ItlnCZq+n+PfBcTdL3C2ibCc+posgwKj7G25O1IV6evYEZ/A?= =?us-ascii?Q?JR7Dz+wPy3PB7oRFArirmonra1fXg0I/FINf6ZtStbfXcUq6TJT4a/yOdwm9?= =?us-ascii?Q?+05Lw6eF07X4MFvizhQdoHR/ogfXR9pm0Tf0ThhzTM0WApN389yFJdcRrILO?= =?us-ascii?Q?mnPpOEtCWIwtGyB92FVfmi/QuOeFq50Y7GdWxlMuVOID20as/cCsF8uttdAB?= =?us-ascii?Q?L8kZh192JBfo3xdtW+wIEPmXOpMWpB7n5kyg4A9zQ12kEcpFwXmprU3JLqA7?= =?us-ascii?Q?TtXsFu17EGBBdv/NITkCEmi89QNegmD2dRHU374OhBfX85TzmhM1OdWYwIrs?= =?us-ascii?Q?Xhe9lM40pKC9w0f//iSZO0fNeHgm4kNLpN9rX+iYLA=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR10MB7933.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(1800799024)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?xmysVzsj7gSCzF5KOitSWIFkEjE0tPX77cTBqUi4yHZNuzqewe/rnUNtAFrF?= =?us-ascii?Q?WV9Lc+5dgyD1cc08otVGI/if3G/V0+q2DNd7LL8BtO6+DaTzCTm/b857thSl?= =?us-ascii?Q?sz0BVDwtejaAQpAT9tRqFe1Ll0uOIqn+UBWcHjqvQR/steCQoZKYdc4UCIRj?= =?us-ascii?Q?AgXlfTCUAKisyhSy1hq19pa6wtqE6zFzWAG7gjrYIok/gc5hmuH2bymDUbLt?= =?us-ascii?Q?/mCNOetujbrIwNVQ7qQHMK4ZbJQlcGEt+58QPO01bSEaOKZePg2sgQPGd2UU?= =?us-ascii?Q?YDeRUL6JwtMyDvEezUCZyfbULMCzQ4Dcu8JZu7jtnenyHbGxljgV1+zwrmaO?= =?us-ascii?Q?m9zPTq8+tXmrodfBC0rRK79KpzP/1hsAzSxGpw50pCsduv+f9FPRAqH27Tkd?= =?us-ascii?Q?Q/I8pc7+Dal3IVA77EoMcsUWqHd/WWCkelePZ0pEbP3KVd0mN9x3KyojkIE3?= =?us-ascii?Q?AqTNMDSCHc1VtclPVGGuWr3vrQl2F/sZMZxiAxVm/UGb4ohMYQOxi8qfsGlX?= =?us-ascii?Q?1D5aoDMfvSayLgeileIj2i2uyN8xsYWVYNLktPlNC+eZXpMR9zvSkyg4NLTz?= =?us-ascii?Q?v0PrLz3Ll8AGE7J6YqelVFBnRrT8MUYfoLyUzJGSP/qtcgi6iD/Hoj4DlG6A?= =?us-ascii?Q?UNHTORqtM8CLdfpHcPaYTWq8P+DyO7bvzLhB1UkK7r1yHRO36v77FJTAEDt7?= =?us-ascii?Q?ag/MShsPr636BRBIIGWPPQc2BuEuDAQaBccPwlZVoNGTONacg8JcuYmQYx9+?= =?us-ascii?Q?pT3tuqGsmYfkS8z61c/96cT4A506WBlAq9xZvZ9RxepE6MyDGu+BMzrBhjl8?= =?us-ascii?Q?KZCEGAzJhl5gSwzXJKTfEqTXSe32H7u6fr72hxe60vybrMDf/0LWEIoh/4xY?= =?us-ascii?Q?q6mAq7BFt/8TnCNpNwAJ4i7FMaHzp2RC71jozlaL0E+AEGu5q4g1bGOA6Bo4?= =?us-ascii?Q?N34IbGUxec+GFqDKf2BGQD/aHq5Hq6Th3ATlhm4xNWSY4IimXYk8c/g/5rfs?= =?us-ascii?Q?d/oAs0bno3sK8yhHwbM7FJc1sJmU1Md3XUaqZyryk4LgR3l31kxZqmW0moAO?= =?us-ascii?Q?icw45Q1mLeFh8yI+leqm2GdotxbFgyW92U2ED+t49/LEk2BdHFc/Ue9A/Uma?= =?us-ascii?Q?kUh2WpzHXewH3j+mhNhFImdhgU6Xj6waB3HdbGImUHYrclqM10fCB/uh4ED4?= =?us-ascii?Q?8c3AbYuu/f6QAYy+UPVXh/HHx1acSHDK75vgdCXRVnAxtZUvgIo8wKVf2vLV?= =?us-ascii?Q?21wo53VulMN+bAlsqwZO+tjz5SkKBTc2Ui685syCZaa5mkiLKm5gCuTq59h2?= =?us-ascii?Q?BEgi3J2Qv8DoJD7b0D4xGDlVz0GE2WLWqCs+p8ARg3gKsVoyC6uGYr8pnT71?= =?us-ascii?Q?UbvBc0Suop5C3bQ4enUbN5RPebQR+oWYkw6zt4nH9Vyr7IHNxOlJwIzFZ+To?= =?us-ascii?Q?k13TyYgjAh86HTnijFnanBGkFve6GaIcObBv8dERcjRJcKxJ4Qncqjk7HQt7?= =?us-ascii?Q?025gq+wfW7zUD1tsqlcnolmE1LZ6gv9aW0ezGkA3LZpZuOb0ZEdOELFBhD/V?= =?us-ascii?Q?zhMp7o5IfP+wjXDhBbG10OK8foBIoUojrEUeGS5iDhuvtgkKtS7cysP3ZuLB?= =?us-ascii?Q?MQ=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: ELwZvAvkqm9LQvRH4F/WaufDFOfkV6dW0g5L8EXkxpyBvsjTtEa5UB7jnTlsJYuyFvHItV3Y596tI8167B8zu6coG33huxuTP4ymqc6P9+JVP9dGLXwb6xaMIW8czI6XsVH1s/hBUkbTRXoZbmFwd+K90on73RsOaV0HPHMHo/ACNe4xcbTAzyjHuKAMO/l96xxVlkjE3BfD15RP9YwUsqhRSpRPvM1KmPpY3pSms9ozOFbx4eD6NEJ36wrVnhERzzsOzUkLnSRu9QC68hontFufZ4NNe+iY2VhlIfeyrxG+t+dn6dlysEfurKxQkKaA+yjS6YqBsO3sJ7YB6zL8MfsCgYj7xPW8lqMIKwBym2S11+st6deWLFaS/ODuFWd1tbex2OwwNKG8IKvRjO7O00cHz47vExrfvz/RUhkFihu9K7NAOorqOmAWZDmyfxKarn6p4hZNjwiW9Qh87h2il0I9PG0PYmNLSVIjHzTm5SiSBr9jMlm6+CJKtPOJQv9E3Bzta0i8x+Lb+cvybxAfx/B4dsA72NMhblPEngZTshCl6pmni5XaesuDpiv8/fYBAbtGSgzoLDwUz18CuVlBKeoAyZLyavGQoG4tBYhHUmM= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: f42895da-8081-4a3c-4ced-08dced8acfc4 X-MS-Exchange-CrossTenant-AuthSource: DS0PR10MB7933.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2024 02:32:42.8764 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 070s8iNvVCIlWqGvYZclFgLBiQQPwyXQhNLyrSDOieiQYYDuPhu1cYVS+NHxHgRR32RjNukYhwueWqNu5lGAsA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB4623 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-15_21,2024-10-15_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 malwarescore=0 adultscore=0 bulkscore=0 spamscore=0 mlxlogscore=999 phishscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2409260000 definitions=main-2410160015 X-Proofpoint-GUID: _E9uOXKA9335xXm7kK2o1GD7xApUxBFw X-Proofpoint-ORIG-GUID: _E9uOXKA9335xXm7kK2o1GD7xApUxBFw X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 004B940004 X-Stat-Signature: h144briqqhcfgurpxi75qtciaqeb5nnp X-HE-Tag: 1729045958-317512 X-HE-Meta: U2FsdGVkX1+bD185m5rBZnXpNtmlcSxOfm6FVyrj0kZLrRCgky0Fc2t3XOQgz/j11qIMp/oWEI6O69MMJ1PSYJ+zw8iyk/cQv/YF/5AVg7qhSjnZQlZYYdVKvTno/XgGvxUMY+Q8ADmcJN5gtb2BuJtb9etVcu6UVzpyfMe+pfafqsHcWx6eC8tPkeLNpBD+aDvU6Iq0+BOKKm+b4uTCHgKW3aPD1s5ucDoXvB1s8Uq8T440qgfHDbHKXv1ybdvMjJG7VSZmQHNGsOFxRbo9dM9ppNApgxKnPLB4ls+B95lYriuOH8Qri+t5HAWAlETAssNSLgdQtc0sqBth8YPzMwXmf2vzihx55nOSmN1q6OdqqiBkV5n2gmdaBLZ+zN+rO0NTuzfzd6pAJzGEsweeepHPrfcg2JpQQ6WaNa5FDu2PyZaYV9GraXZ0fhDAq3ibhYb1Dz10VWFe+D4cENuzciWU/QNhBhMYR8U6FiylfV3X75lmg6p8oyR2rAO7Nj7MtGzaczHv7VGr5TC8cvHFHluXDsT7JhEJsawsHwRy3QaAhRMsN2gS9lzdJDmhtbw+LkdaZIrRMTJ6BlA/Y0U4WzkIU6uKAMGuM7C4pVpRXTvLRmBg+wCsf0ttoSLil54NmgFlR/ZjokNzOqULDvuSL7FazLRjoYPkWqG6OGuqWM0k/ANk7Q6ATLApNxJuq9jeo/1W1WobPBDSTTaPTloARHXCvN2u4iII8rbYUprzKlqrzeIJhOx/c8pYFRdWdXE+ROIguLZcYDPgx8DBOjbJMxn3PJpYUklgcQ+xSRavRLd20kyMVSe1uGgODHUqSjDrijpS2hOh5/Da5wQ2uqTv1PJGayrL8iPUqYv8CtTpmQuuF+CfTmjaqWBA9M72M50hZxxceMyhouTPbEbps3qppz8J89Rkp5f0OyThLR0658ZyQ9H37UAAxxn7q0xyTcdT9bNbKpFOgqXcc7TDJbn A4YiBR1a asWPKJKluy3q9JG483peVJQHMqApU7Io5ZLanLvWmUW3nHeCn0PcdAKhIfJYW9ylzMiRdLyZFdGn0151sb400PQ4/ENFdTTuK1xLFglWWNqkiORfv+YiPC2l4YVgT34z6eFTkikr+5PkWDLdeEhppiOAIZf0oYLwObms/fttghhkpjgzqY7goyNZL11qnT+s6Kdryv9uG4NBcJHuscLGZMW3dRD2kgENviftjc69jiZzqaEE/v2r5wa4v3atcSFWRQCjm9G8uXPRYNPSh2Je5fJF1Cj3iUeB1Lkgkh0pQfDFqfB1UQ5/a+nCD9N90QlYJ+kMhhmM8jDg4mZRBvQkq5HC1w8oQItmkfXKjlwS4Tp5Fq4V8e1/y8QKVO7emDl7QErI3YtON4iriQNeBTiP5PYFKBQxc2OHPzEeFzmzN5cQY1G31OGr18wqMFy/vyigzSqzpS0bCIwt4Jzj95s1EPxlN032AUZhxSb+hlXn8E1lP7ix6p7/bS3pImB/HaKctRqIhjAclp0FbuWky1pXFIR2XzkSyHLEwNmbLqt3Kpy1Z38aH5qd4H827ntQ7Opnd0oLCQt54zp9sXVxoRgyAqF3jo2DqRUPhV8QbMhRmvGa/5/WCru4t8Y8IdlbEIUNFRTL0K6kN/b6vmfLrFbvQ9A3M5xv/vWq/XXBD X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: * Wei Yang [241015 22:18]: > On Tue, Oct 15, 2024 at 09:25:19PM -0400, Liam R. Howlett wrote: > >* Liam R. Howlett [241015 20:42]: > >> * Wei Yang [241015 19:39]: > >> > When overwriting the whole range with NULL, current behavior is not correct. > >> > > >> > >> This is really strange. You have changed the code to be wrong then > >> removed it.. The second patch removes what you changed in the first. > >> > >> It doesn't look right today but what you have done is also not right. > > > >Looking at this again, the code that you have changed is correct. > > > >I actually think the bug is the other way around. If we are > >represnenting 0 - ULONG_MAX => NULL, then it's an empty tree and we > >don't need a node to store that, and shouldn't. > > > >It's also not really a bug, but a missed optimisation. The ranges are > >stored correctly, we just use too much memory in one case. > > > >The dump isn't clear, but since we merge NULL entries, if there is a 0-0 > >-> NULL and 1-ULONG_MAX => NULL, then they will be one and the same. > >You could change the dump code as part of your fix. > > > >It's like the init of a tree (tree->ma_root = NULL). > > Agree with your above statement, this depends how we want to handle this. The > change here is to make the behavior consistent. > > Want to confirm with you: the fix in this patch is fine with your, right? No, it's not fine. You are removing an optimisation. The issue is the other side of things where a node is used to store a single range from 0 to ULONX_MAX pointing to NULL in a 256B node. And, potentially, the debug dump of the tree should be more clear. > > > > >Please don't submit multiple patches to fix the same thing like this, it > >makes it look like you are trying to pad your patch count. I'm guessing > >you did this to keep them logically separate, but when you completely > >drop the entire block of code that was changed in the second patch it > >becomes a bit much (and hard to follow, I was trying to figure out what > >branch you were working off because it didn't look like the patch would > >apply to my branch). > > Sure, will merge it. Merge changes like this in the future, but the second patch in this series is wrong. > > > > >Please submit a testcase with any suspected bugs. If it is not possible > >to do the fix first, then do them at the same time. I often write the > >fix for a bug, then recreate the bug in a testcase and ensure that it > >fails without my fix. > > > > Since user won't detect the difference, so a case to see whether the root is a > node looks good to you? Write a test to find out if the resulting 0 - ULONG_MAX store of NULL results in a node. If it is in a node, then the test should fail. > > >I am not sure the fixes tag is correct in the patch either, since so > >much has changed around this. You could test the older code to see once > >you write a testcase. But the bug is using a node to store 0-ULONG_MAX > >=> NULL. > > > > So I should drop the fix tag? Yes, it's not a bug/problem - it's just inefficient use of space when someone tries to store 0 - ULONG_MAX, so there really isn't a reason to backport. Thanks, Liam